From: Suanming Mou <suanmingm@nvidia.com>
To: "Xueming(Steven) Li" <xuemingl@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>,
Asaf Penso <asafp@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v1] net/mlx5: fix meter packet missing
Date: Tue, 10 Nov 2020 08:38:01 +0000 [thread overview]
Message-ID: <MWHPR1201MB01891432313BC8BF56309F4BC1E90@MWHPR1201MB0189.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1604401299-14355-1-git-send-email-xuemingl@nvidia.com>
> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Tuesday, November 3, 2020 7:02 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Xueming(Steven) Li <xuemingl@nvidia.com>; Asaf Penso
> <asafp@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH v1] net/mlx5: fix meter packet missing
>
> For transfer flow with meter, packet was passed without applying flow action.
> The group level was multiplied by 10 for group level 65531.
>
> This patch fixes this issue by correcting suffix table group level calculation.
>
> Fixes: 3e8f3e51fd93 ("net/mlx5: fix meter table definitions")
> Cc: suanmingm@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Reviewed-by: Suanming Mou <suanmingm@nvidia.com>
Thanks.
> ---
> drivers/net/mlx5/mlx5.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index
> 63d263384b..a28f30a5ab 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -610,9 +610,9 @@ struct mlx5_flow_tbl_resource { #define
> MLX5_FLOW_MREG_ACT_TABLE_GROUP (MLX5_MAX_TABLES - 1) #define
> MLX5_FLOW_MREG_CP_TABLE_GROUP (MLX5_MAX_TABLES - 2)
> /* Tables for metering splits should be added here. */ -#define
> MLX5_MAX_TABLES_EXTERNAL (MLX5_MAX_TABLES - 3) -#define
> MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4) #define
> MLX5_FLOW_TABLE_LEVEL_SUFFIX (MLX5_MAX_TABLES - 3)
> +#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4) #define
> +MLX5_MAX_TABLES_EXTERNAL MLX5_FLOW_TABLE_LEVEL_METER
> #define MLX5_MAX_TABLES_FDB UINT16_MAX
> #define MLX5_FLOW_TABLE_FACTOR 10
>
> --
> 2.25.1
next prev parent reply other threads:[~2020-11-10 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 8:28 [dpdk-stable] [PATCH] " Xueming Li
2020-11-03 11:01 ` [dpdk-stable] [PATCH v1] " Xueming Li
2020-11-10 8:38 ` Suanming Mou [this message]
2020-11-10 11:41 ` [dpdk-stable] [dpdk-dev] " Raslan Darawsheh
2020-11-10 8:50 ` [dpdk-stable] [PATCH] " Matan Azrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR1201MB01891432313BC8BF56309F4BC1E90@MWHPR1201MB0189.namprd12.prod.outlook.com \
--to=suanmingm@nvidia.com \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).