From: "Loftus, Ciara" <email@example.com>
To: Stephen Hemminger <firstname.lastname@example.org>
Cc: "email@example.com" <firstname.lastname@example.org>,
"Yigit, Ferruh" <email@example.com>,
"Zhang, Qi Z" <firstname.lastname@example.org>,
"Burakov, Anatoly" <email@example.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/af_xdp: fix support of secondary process
Date: Mon, 20 Sep 2021 15:09:36 +0000 [thread overview]
Message-ID: <PH0PR11MB479125538268219C678ECA8B8EA09@PH0PR11MB4791.namprd11.prod.outlook.com> (raw)
> On Mon, 20 Sep 2021 13:23:57 +0000
> "Loftus, Ciara" <firstname.lastname@example.org> wrote:
> > > -----Original Message-----
> > > From: dev <email@example.com> On Behalf Of Stephen Hemminger
> > > Sent: Friday 3 September 2021 17:15
> > > To: firstname.lastname@example.org
> > > Cc: Stephen Hemminger <email@example.com>;
> > > firstname.lastname@example.org; email@example.com
> > > Subject: [dpdk-dev] [PATCH] net/af_xdp: fix support of secondary
> > >
> > > Doing basic operations like info_get or get_stats was broken
> > > in af_xdp PMD. The info_get would crash because dev->device
> > > was NULL in secondary process. Fix this by doing same initialization
> > > as af_packet and tap devices.
> > >
> > > The get_stats would crash because the XDP socket is not open in
> > > primary process. As a workaround don't query kernel for dropped
> > > packets when called from secondary process.
> > >
> > > Note: this does not address the other bug which is that transmitting
> > > in secondary process is broken because the send() in tx_kick
> > > will fail because XDP socket fd is not valid in secondary process.
> > Hi Stephen,
> > Apologies for the delayed reply, I was on vacation.
> > In the Bugzilla report you suggest we:
> > "mark AF_XDP as broken in with primary/secondary
> > and return an error in probe in secondary process".
> > I agree with this suggestion. However with this patch we still permit
> secondary, and just make sure it doesn't crash for get_stats. Did you change
> your mind?
> > Personally, I would prefer to have primary/secondary either working 100%
> or else not allowed at all by throwing an error during probe. What do you
> think? Do you have a reason/use case to permit secondary processes despite
> some features not being available eg. full stats, tx?
> > Thanks,
> > Ciara
> There are two cases where secondary is useful even if send/receive can't
> work from secondary process.
> The pdump and proc-info applications can work with these patches.
> I am using XDP over pdump as an easy way to get packets into the code for
> The flag in the documentation doesn't have a "limited" version.
> If you want, will send another patch to disable secondary support.
Thanks for explaining. Since there are use cases for secondary, even if the functionality is limited, I don't think it should be disabled.
Since we can't flag it as 'limited' in the feature matrix, could you please add a note about the send/receive limitation in the AF_XDP PMD documentation in a v2? There are already a number of limitations listed, which you can add to.
> Supporting secondary, means adding a mechanism to pass the socket
next prev parent reply other threads:[~2021-09-20 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 16:15 [dpdk-stable] " Stephen Hemminger
2021-09-15 8:19 ` Ferruh Yigit
2021-09-20 13:23 ` [dpdk-stable] [dpdk-dev] " Loftus, Ciara
2021-09-20 14:43 ` Stephen Hemminger
2021-09-20 15:09 ` Loftus, Ciara [this message]
2021-09-21 17:45 ` Stephen Hemminger
2021-09-23 12:33 ` Loftus, Ciara
2021-10-05 15:02 ` Ferruh Yigit
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).