RE: [PATCH] net/af_xdp: add missing trailing newline in logs

["Loftus, Ciara" <ciara.loftus@intel.com>]

> Subject: [PATCH] net/af_xdp: add missing trailing newline in logs
> 
> Caught while trying --in-memory mode, some log messages in this driver
> are not terminated with a newline:
> rte_pmd_af_xdp_probe(): net_af_xdp: Failed to register multi-process IPC
> callback: Operation not supportedvdev_probe(): failed to initialize
> net_af_xdp device
> 
> Other locations in this driver had the same issue, fix all at once.
> 
> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
> Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
> Fixes: 9876cf8316b3 ("net/af_xdp: re-enable secondary process support")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Thanks David, LGTM.

Acked-by: Ciara Loftus <ciara.loftus@intel.com>

> ---
>  drivers/net/af_xdp/rte_eth_af_xdp.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
> b/drivers/net/af_xdp/rte_eth_af_xdp.c
> index 6ac710c6bd..8bdc2920cf 100644
> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
> @@ -1071,7 +1071,7 @@ xsk_umem_info *xdp_umem_configure(struct
> pmd_internals *internals,
>  		umem = rte_zmalloc_socket("umem", sizeof(*umem), 0,
>  					  rte_socket_id());
>  		if (umem == NULL) {
> -			AF_XDP_LOG(ERR, "Failed to allocate umem info");
> +			AF_XDP_LOG(ERR, "Failed to allocate umem info\n");
>  			return NULL;
>  		}
> 
> @@ -1084,7 +1084,7 @@ xsk_umem_info *xdp_umem_configure(struct
> pmd_internals *internals,
>  		ret = xsk_umem__create(&umem->umem, base_addr,
> umem_size,
>  				&rxq->fq, &rxq->cq, &usr_config);
>  		if (ret) {
> -			AF_XDP_LOG(ERR, "Failed to create umem");
> +			AF_XDP_LOG(ERR, "Failed to create umem\n");
>  			goto err;
>  		}
>  		umem->buffer = base_addr;
> @@ -1124,7 +1124,7 @@ xsk_umem_info *xdp_umem_configure(struct
> pmd_internals *internals,
> 
>  	umem = rte_zmalloc_socket("umem", sizeof(*umem), 0,
> rte_socket_id());
>  	if (umem == NULL) {
> -		AF_XDP_LOG(ERR, "Failed to allocate umem info");
> +		AF_XDP_LOG(ERR, "Failed to allocate umem info\n");
>  		return NULL;
>  	}
> 
> @@ -1160,7 +1160,7 @@ xsk_umem_info *xdp_umem_configure(struct
> pmd_internals *internals,
>  			       &usr_config);
> 
>  	if (ret) {
> -		AF_XDP_LOG(ERR, "Failed to create umem");
> +		AF_XDP_LOG(ERR, "Failed to create umem\n");
>  		goto err;
>  	}
>  	umem->mz = mz;
> @@ -1847,7 +1847,7 @@ afxdp_mp_request_fds(const char *name, struct
> rte_eth_dev *dev)
>  	AF_XDP_LOG(DEBUG, "Sending multi-process IPC request for %s\n",
> name);
>  	ret = rte_mp_request_sync(&request, &replies, &timeout);
>  	if (ret < 0 || replies.nb_received != 1) {
> -		AF_XDP_LOG(ERR, "Failed to request fds from primary: %d",
> +		AF_XDP_LOG(ERR, "Failed to request fds from primary:
> %d\n",
>  			   rte_errno);
>  		return -1;
>  	}
> @@ -1996,7 +1996,7 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device
> *dev)
>  	if (!afxdp_dev_count) {
>  		ret = rte_mp_action_register(ETH_AF_XDP_MP_KEY,
> afxdp_mp_send_fds);
>  		if (ret < 0) {
> -			AF_XDP_LOG(ERR, "%s: Failed to register multi-
> process IPC callback: %s",
> +			AF_XDP_LOG(ERR, "%s: Failed to register multi-
> process IPC callback: %s\n",
>  				   name, strerror(rte_errno));
>  			return -1;
>  		}
> --
> 2.23.0