From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15F2742D98 for ; Fri, 30 Jun 2023 16:04:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09EA741143; Fri, 30 Jun 2023 16:04:24 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 5B729406B6; Fri, 30 Jun 2023 16:04:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688133861; x=1719669861; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=QhJ5Vq/T8S4tYJYmr6IbUzWaJ0RiWU2K8D7Dez3akAU=; b=SyWSZL27DMKGIQfSSu+qpmlYmIRgcLra5rJc1edZIVtEE+M6RvRUWG/g u6AEXdk+10Au6Be5Y2k882lu9Qb2fSNPAFB0QiBPWED9lA4a1+P4kGr4s bAlZE6fmJxvyM4nNUqZqH42vnSTg5whBOO0VQdUVGnhABBvEDVeL1Z0or gX1nIEyjAas1fPwxxspo/RLMBKh7aZG+5YVHjXEjJl0wDRS+2NTeDul6z +M970mH0Emxy+SKpKLQsgF2wq05EdERWoKfxu+c1ALKhRjBEEGgpit0yI IQxByYkN1iPYgDR/Jw7Lb7IKuCfyI6TTADSdh2GJ2QMMdR0bZHWm0TQJi Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10757"; a="342736369" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="342736369" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2023 07:04:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10757"; a="711825303" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="711825303" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 30 Jun 2023 07:03:59 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 30 Jun 2023 07:03:59 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 30 Jun 2023 07:03:58 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 30 Jun 2023 07:03:58 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 30 Jun 2023 07:03:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZsMR/+p9AAYjPfQit3dsMKErYSL/Gp1/RLLepC/rQkeKPc1KaZNUhH1n05Aq69Uls4dRE4hcTVycvlglOQ2fLjaxwE8ynFh0Y5m9yqq/VmrRnmfJnOd8C3vAkJc4FzutBBYAqLj/nw6q+9+J2Lud9XV5kBR1+tRFcYFNIsrW/QJTFUY6dRRDo5Gw3X90ZpBM3FElMeL2HsWHEG9avZKDnCzAZYCHFuXsQ3+xBCfnYB/86CoKvskAkuvecpP+xrfPxe8p94KJ7GlG/tor6NWX7kzgG86cyy0fslxo4ZfVwd49x7MFsNKPEVMbZYUCdIw8j51qBM8AapwbTbA2mXPaAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sLmnVQgbFAb41+CLlV0cMb2M8iGM+LK2Skhg6IHPJKQ=; b=hAZRKKqLGBa4Jn1f8U8omXDSCw/rqpaK9fYxzpjVeL/0y6EH/itEhlQXkTe4760pzxCZD4gI9cC9Yai6SPvK9AebiyjV3kWJ7oKynl58xAzbd4nPTc6x3MFfODm2rf9/jYlyAmZ5sLHZlHfm43TSnN0S5KLVLbJkJVnROpkBQ1MZEls4l3rm8IIrvQhCQz2qp6Nx/k+m9ajK6MlZbhE3Bqy78UH7M9rkQfd4BWO9DNJ2uqo73fHUm4CdxZNPuqK9wBRc5SjOvhpW6VydK06t37Ny7S6GXkFXEYhqePTNVfpOOLBoYlakHJkTaHHBJi2XvtsBeOc76DGYbgVWzkM9Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) by SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.43; Fri, 30 Jun 2023 14:03:52 +0000 Received: from PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::907b:802b:a19b:512e]) by PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::907b:802b:a19b:512e%7]) with mapi id 15.20.6544.019; Fri, 30 Jun 2023 14:03:51 +0000 From: "Dooley, Brian" To: "Arshad, Samina" , Gowrishankar Muthukrishnan CC: "dev@dpdk.org" , "stable@dpdk.org" , "Kovacevic, Marko" , Akhil Goyal Subject: RE: [PATCH v1] examples/fips_validation: fix digest length in AES GCM Thread-Topic: [PATCH v1] examples/fips_validation: fix digest length in AES GCM Thread-Index: AQHZqc5BWT+u2GT0w0q2Xq5JSP5WRq+jY2EA Date: Fri, 30 Jun 2023 14:03:51 +0000 Message-ID: References: <20230628143836.968549-1-samina.arshad@intel.com> In-Reply-To: <20230628143836.968549-1-samina.arshad@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5047:EE_|SA2PR11MB5210:EE_ x-ms-office365-filtering-correlation-id: 0053b525-b9c6-4dec-88fb-08db7972d528 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uRcfTa+yPLLgge7Zqpevk+Tx+b0tX5jnlQDYoGGCLiNV2a41NWkOqGeIGzLYBWVJrwzK2Kt3ru/zbK2vwXyLy50e0wDHs7Cql8DuSHbq2XwPHvm/cci0n4/YSwS2+XiM9v2xdxzURD0qtD5pLNfrYtKOhJAeTQavJcQ7HsQqPKAZpvPuj8X51JzPjmmpRAQj8Vxognfrcw3Bp9UNuvOMFd0iU4zLi9yWPqWUofckp8UnsJlXaoBPOOUx1wYyS7wge18r2Av3jnePLrwWlNq8R3R4uIdvlcweOb0fJE2d/pmN84elWL9DxKHOv8fRHXPLEbKApggtbyieA8LpGkIt4XPZiIZLyJ4BPqMrlljyGz2dskeNIcyFEPtn79aNlXMm8qPKc+8tRFVJO0WH99y8uX12OFR/Xlumc7knaup6FzpfvEuYj8RNS77L2oLMWYZ5AijdFWS/nTFfvBqrHCc7YIDJbVyIH7jzm6oLrDnfNbYOhbgE40SFWeGSGfCmtxKQcf4F0NOEIp0sXRAjQqniE/Eu/5CysLMX9AHjNHTAlmNjfvoFYwtiB5B/dnFKUM9HWF+ZB7ChK9g5yLa6rbz1oc9a23uEDViWuehHIAQTYhWL+lwH2cpaxw1oBP12zgID x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5047.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(376002)(396003)(346002)(366004)(136003)(451199021)(8936002)(8676002)(5660300002)(64756008)(76116006)(66946007)(66556008)(66476007)(66446008)(55016003)(4326008)(2906002)(316002)(52536014)(41300700001)(54906003)(110136005)(478600001)(71200400001)(7696005)(53546011)(6506007)(83380400001)(33656002)(186003)(26005)(9686003)(82960400001)(38100700002)(122000001)(38070700005)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?URDUCtV7RBfPNZJNIz5p7ZtpeYbxIy+JjbSGsLenTnlIbUKIkLPV5DcfcRAD?= =?us-ascii?Q?1dhIMC91UppQ7EOmhO0OUI6iCnqAHi+jsHN1L55Dg/3ScQoej8X2PmoB5591?= =?us-ascii?Q?jFwg5EZgpbDKuL47VCW8ouLgTVE+DwwvIRtz5MaEdjxWIepODU61M9kM0mN5?= =?us-ascii?Q?Kwbo5VWPMMiTEVYpBTbc53UKF8akv/O6e6hTowWKtv5drldX3VML3OB1R9sQ?= =?us-ascii?Q?Op2XqF42gEOQ8kQmjcups8E9SfQAeTDp9wI1n1Ro2t3cwtWSHLs8Lzd6cnft?= =?us-ascii?Q?hUCVhMauNVoLmNf+FFiWu9lwX0O37hldDx60eV7boKNk8W0oLY7XhZ9jn2cD?= =?us-ascii?Q?CE3x7ui7HGUyH3om4mEAzNTUTeCddSctW8wjUvvoLv+wuxu4W/9SZ7QqQ/Ep?= =?us-ascii?Q?ohYtCPN71MQNegE9p9XMuBXIhN0TDPQUZAzD692jgegcXBcFeJns/bdAlgg6?= =?us-ascii?Q?A4o/p7kWM6pFZsYrPJ+2uHautsoiTOQJUzCAy/BfOvvqUFnWeIkDpkvMwnQP?= =?us-ascii?Q?jtB1X9Dzk++h5a+0e67M6VfhuGQF76kuPhD9WChOnA9RhJ5DRD4YrHZQ+YlH?= =?us-ascii?Q?hTGo1oEDlNPlWNL+NcKjxRv4JHB7qCFsuo7ZetC3gQZX+7g5KYb4Lzpo1rad?= =?us-ascii?Q?P4Peo1Lzf+9mTUs/wKdYTDDNQ1kJGUveaPH9vpkA/7iheIbENNwo75j8wElF?= =?us-ascii?Q?qe5XO/dJ46fzPkvQpav9X6G5UoJ002Zk6RRcKi0QnqCW7luxTf5plw9zErcv?= =?us-ascii?Q?pYYJZPSlcArAv5tjnM/zaIZn7BULTZFIXfH8GrHshCiUZ9Km8hJqByTHxXsP?= =?us-ascii?Q?wIzBDDTpGtrZv472WPowSYPKTpIN5gtprfPw+S9oWJFZAfSI839OxHGXgh7u?= =?us-ascii?Q?OJnkP+skZSUP6cmfJks5GDj+X5IJviSwMZNzSv0n5AwuY2f2jURlHTHXgjbQ?= =?us-ascii?Q?dtzYWch9DOxyAcsEtkuPZbWZFqwWe8qV2Ix0qbJjfJBX4xNvMTXgmNGw9A0c?= =?us-ascii?Q?3wfAa1MOkhyNdGC6iTewPP+4lOPJRZGbWufrlGHRYSOE8kzXQw33VqW9vXSN?= =?us-ascii?Q?n981uNYKM0FFimAr/CZfLXKFyT+NNTeMnJqgsbq8+PG7qib4xPGtOKTRkH4j?= =?us-ascii?Q?HeB5PWsi8txbgaUJhY1pTf70Zs/p62nNijs4jUXGwn/YiIe0R/dPkJu0lKtb?= =?us-ascii?Q?1f2vk/5C29jQmkJguZ0x7tcdVAFNovVLdVFtwm1qGALT/toULdVrPduoBEXB?= =?us-ascii?Q?2LGJhanGUA1F7OPb61C4yuJDNp3zoVLSvf7xmjxOrPrSTfHe5WjOpQsZRkMx?= =?us-ascii?Q?5GlcVCA1bc0Ttv6HPFoPct9uaUvCACn15Mjl6H5bEpQy8Pzn+0RhrsYVkXhM?= =?us-ascii?Q?Co8aYWk6HDJUD/042SRiBNPeo3MXCL7ICNuqqcVmkwbzsEBpAVS4I7rvCkCN?= =?us-ascii?Q?+63O8eS1YTBZrkPoXW/p4xZFSbDvhJDwyohxBUtO9wYUcKgZD3xr9qw2c0ux?= =?us-ascii?Q?v1Ax0DykY/a3ysiaiK7dHritEuDOjwP9zxXC9+LezU3UoGuoW4/pJGBcPHj8?= =?us-ascii?Q?JXSWPb7jhiccVhTVn4u8QRs/ooTrY5a47VRZj1ME?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5047.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0053b525-b9c6-4dec-88fb-08db7972d528 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2023 14:03:51.2145 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8ACgFKmvXQ/l4UtQAo4hoJwKI+w/Fs7tHvNVm29ndda9SXE94MBVv0aUGWEzsqGph/tjmltyIe+A1f1xLRfpWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5210 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hey Samina, > -----Original Message----- > From: Arshad, Samina > Sent: Wednesday, June 28, 2023 3:39 PM > To: Dooley, Brian ; Gowrishankar Muthukrishnan > > Cc: dev@dpdk.org; stable@dpdk.org; Arshad, Samina > ; Kovacevic, Marko > Subject: [PATCH v1] examples/fips_validation: fix digest length in AES GC= M >=20 > For AES GCM non JSON decrypt test cases the digest length is being set > incorrectly.The digest length is not being cleared after test cases, caus= ing an > issue when running tests individually without the --path-is-folder flag. > This fix adds the digest length correctly to the decrypt cases and clears= the > digest length after each test file. >=20 > Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing") > Cc: marko.kovacevic@intel.com >=20 > Signed-off-by: Samina Arshad > --- > examples/fips_validation/main.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/examples/fips_validation/main.c > b/examples/fips_validation/main.c index 4237224d9d..6518c959c4 100644 > --- a/examples/fips_validation/main.c > +++ b/examples/fips_validation/main.c > @@ -834,7 +834,7 @@ prepare_aead_op(void) > RTE_LOG(ERR, USER1, "Not enough memory\n"); > return -ENOMEM; > } > - env.digest_len =3D vec.cipher_auth.digest.len; > + env.digest_len =3D vec.aead.digest.len; >=20 > sym->aead.data.length =3D vec.pt.len; > sym->aead.digest.data =3D env.digest; > @@ -843,7 +843,7 @@ prepare_aead_op(void) > ret =3D prepare_data_mbufs(&vec.ct); > if (ret < 0) > return ret; > - > + env.digest_len =3D vec.aead.digest.len; > sym->aead.data.length =3D vec.ct.len; > sym->aead.digest.data =3D vec.aead.digest.val; > sym->aead.digest.phys_addr =3D rte_malloc_virt2iova( @@ - > 2618,6 +2618,7 @@ fips_test_one_file(void) > if (env.digest) { > rte_free(env.digest); > env.digest =3D NULL; > + env.digest_len =3D 0; > } > rte_pktmbuf_free(env.mbuf); >=20 > -- > 2.25.1 Acked-by: Brian Dooley