From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9152842B8A for ; Wed, 24 May 2023 10:37:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 875B44282D; Wed, 24 May 2023 10:37:32 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 060704067E; Wed, 24 May 2023 10:37:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684917449; x=1716453449; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Wyp9a0gJYwAeaKwINDkvZj6J7TJ6f2RN1n50JxccFQg=; b=jpZZvMV+0ENmcBeecciz1Y8fQYS3Or3KriIQoD9WoN8NULrCFzxHlkJs S6HqJbO5j7b37MDxopCR6aMErtFVRJpPCcEFcebqk62d0Vuh3SYp4O/5e 3B76R9YaFoOkkpmVPvW+aMfAXUnRI9PSX8b7R9CUlEa/gpLt+kKY6WUfY 0vaNYQN3fuNt8BmkDhKU6yNiwM51uWE4Akxn/SyzZlJa+I9WK4APp3jzN khRv+xdVpOcbJae3S0DQKa1dxFldA4Hys9spKEKsIUfy4C1Ur5UMDGQZb SMQr77Hnkp6n+AnL/GL+2ewRjNW/S1qJZIypgnd6R7eqkuvXNM66znwwC w==; X-IronPort-AV: E=McAfee;i="6600,9927,10719"; a="333857987" X-IronPort-AV: E=Sophos;i="6.00,188,1681196400"; d="scan'208";a="333857987" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2023 01:36:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10719"; a="878563562" X-IronPort-AV: E=Sophos;i="6.00,188,1681196400"; d="scan'208";a="878563562" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 24 May 2023 01:36:55 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 01:36:55 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 24 May 2023 01:36:55 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 24 May 2023 01:36:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HtHg7gCwFLVB6Rl3sDOaeNP/yp0XPBGt4NlQBH8TgkKVC3c1tRrx6hT7FTECETpmAghpCJu+G6XXuv2FsrpIRLNROv+0pl0BLLyWVRAYjeswrXyyS9DamI8Vh15cI+CoFIdmHnPqD8iIt/FlpBmd+IOk6m0TU16qS7weG8IwSRaYFRry0RrqFkNjvrK1EMQZ2WfNiMunfj4gpfg7CX+h3p3kmJM23G8JsxEhux0IjnNNgx15D2KJXo7M9gU8YfsUV80OJ1LujVVgUIcEbgN6fs3YNHOIHN9CPBUFKVc+Z390iVXfg9t1zdPHxekfdVCi5HfZhhrgwdMh2PLOWqM/cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LxFqHNBOF818cpscMZJfbKYUZuOGEvRj97o0iQaISxk=; b=jKTgRQWCaON6E9xPRd/J31v1m+R6qZFZDi0KIo/LSJ5jp4N5JfxIsffn7nFVdyWG/+XN3BkYQKVo5GY4nsiIkZiN9yfKJGtGx56pvMkoLbnJFDjd6BOvIUy9v+PaP2AAlabo6MD4abixL79/Gni7Pmays0D3LEyeS5vdUWXCwIn8L66oQST5egylNDkdkrvwSdP8Qev++mM0saU2HL6ERpJoJ26O1cC5xZkvTDfF1Q1RAx61aOyUask7oRlRRkWwt9RJc3aSVIAabD+FwXo+gMfBI9LoTHg6Bmydi/UX3dgvuWzYnOLVuah3ViGsa598e5QPGzOtT6prejD4o2IctA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5877.namprd11.prod.outlook.com (2603:10b6:510:141::12) by PH7PR11MB7606.namprd11.prod.outlook.com (2603:10b6:510:271::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Wed, 24 May 2023 08:36:50 +0000 Received: from PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::da1b:ee87:709:3174]) by PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::da1b:ee87:709:3174%4]) with mapi id 15.20.6411.028; Wed, 24 May 2023 08:36:50 +0000 From: "Liu, Mingxia" To: "Qiao, Wenjing" , "Wu, Jingjing" , "Xing, Beilei" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v4 1/7] common/idpf: fix 64b timestamp roll over issue Thread-Topic: [PATCH v4 1/7] common/idpf: fix 64b timestamp roll over issue Thread-Index: AQHZii0b4lO0PwWonU6GCqkSoyG5b69pHZHw Date: Wed, 24 May 2023 08:36:49 +0000 Message-ID: References: <20230424091707.488045-2-wenjing.qiao@intel.com> <20230519083110.809913-1-wenjing.qiao@intel.com> <20230519083110.809913-2-wenjing.qiao@intel.com> In-Reply-To: <20230519083110.809913-2-wenjing.qiao@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5877:EE_|PH7PR11MB7606:EE_ x-ms-office365-filtering-correlation-id: ff45c9ab-651e-4209-251f-08db5c3204a8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SL30WAseALNmmGRVuQvaJ/xzLsTfsG9l7dxyGCOwSy6uVCbpe7Ja0J3IjNcR6W2O635M+AwbwyPHLy0j+0+9LRHp/w5A2qSbdsy5yGOCsdwg/f49veP7QNEUeXeDUv2IAGSKUDrMS0+AHnLUnZfv2wDcNyTKl3KLQZ5ws9bz21S5qaXYb0GYIPNPEk/wV+MEKpe5ZLNePdWbYDaukPqXBFqx+VYwUSYZkjU12eHroRgBiQxNmjr+1hF8hie74rJ+vuXcr3JGo0jn8FD+cr5l42mtzGxJJIn4UeY5vT3WWzkhAIHb4Q4ZbDVN0cVqcJA7hMOSaKcMn4dK0qQMntVF8PiXj5Yzw1y3R3yLr7CJO4HLLpemwkz5QVHZgpG5yAw3yC9KMmJUUjymBMniHdJ11Q57NqpBkgkZ3GxzTvXG/Idf/VpkarqIaR8+4cpKofGNEKxE+wJbQdrvr5cjcTllFHwJbkMhFhRnimxK8lgalOr13p3TVro0A7X1KXvhRM1D9ggCnvMK60BzLesEXQEwF/gzfqcN2li5SZPLi13C6+00GtUUm3aUzq3+q6rf0Zy2k4ZKoIuBh+34Jj1x2PGVarc4/bi3bIvcIY6o07+XHXLesY4IwJZWPGy49c1gPm8G x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5877.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(366004)(39860400002)(396003)(346002)(376002)(451199021)(2906002)(54906003)(5660300002)(52536014)(8936002)(8676002)(41300700001)(66446008)(110136005)(6636002)(66476007)(450100002)(66556008)(66946007)(64756008)(478600001)(316002)(4326008)(71200400001)(33656002)(7696005)(55016003)(76116006)(6506007)(26005)(53546011)(9686003)(122000001)(38100700002)(86362001)(83380400001)(186003)(38070700005)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iUvLmWV2s4uCNthW+Xe3g0wyCHj023yOGc0ci3KutfUwlr7p2wAcOtDUveIj?= =?us-ascii?Q?TIkuFL/gePJbVq3A4oP5QAJYa8y/80b/XrKk0GtHYcsfGKXOy2zO8BJ9al8L?= =?us-ascii?Q?N2XqTa4CFObpXhNGXzSuE0CWKWJZ7g00R/r9hnE73uC0ODJWYsKyBUudno+I?= =?us-ascii?Q?s+FjSKBOgIJ+19yeWanC17A3yl1lTPLdGcj+LwNx0AsnpHoM9U3tkJyWARmz?= =?us-ascii?Q?ojCEP4mt8e5nn5ZLVmjggJRxWYIqPtfS9ujST5D3IvWAjehMBhMYz2e8G689?= =?us-ascii?Q?AbZ9jCA1P4phoYYmHJEBP+gEMQsKZozPjzv6uovkkPQgC9e4pLI/vZFr1AL6?= =?us-ascii?Q?0EbvJTyveAHC8AvG8I+lbIV6ZOyc69zgGmo7VdSGOPlnohgf3k4xMHwDprQD?= =?us-ascii?Q?OrxjZSLl3CMD8PGjCgi4Ju3SAm43/fTzsuBKwWbsKfiYHDY3POb9uGCGjnaG?= =?us-ascii?Q?3Qbw9tyiQwRMPrtt3IHetbYqjjhRF01de6kcwpPNUNIJ6VYAggY45fGQJDWg?= =?us-ascii?Q?6r/uSgP/efoTurF1yta9grNaihaG5lxHQkzYTDmAPI/SowNyk3HvDv68M8QX?= =?us-ascii?Q?TFz13ok2/W2Hzgz/g0JFjUWEryP/UkEWkKG1xQ/r/+r8rfBmyj6QLY4CPaKD?= =?us-ascii?Q?TcY2kZY7ZzmB1GGA4uE1a7tJD9o8ecuCOEnXYfWYFiN89EFbK6LjUWAyIheH?= =?us-ascii?Q?Y4YLXq60vrWOHdABUG/KBOBt60HCVDTMC2fFAv5RGFvzGwupZszhgvHfgtnq?= =?us-ascii?Q?zozrZAr9vU4dAoSbAw9ibpuFpAMFmOUhAIpS9r9l7aCNg1MGOcqUYJRmwRPe?= =?us-ascii?Q?PxaHzrGPsHk0Wyh/BxnwCrDrbAKgyi3a+2yowarP+f0kWnR8gezQMf4SEL52?= =?us-ascii?Q?wYJf628umhWfaPZfgobBXVMRrqzeZjXTW3eeNMRLLQei+3pqpnz482Bhx6GV?= =?us-ascii?Q?AIAgV3LqQnIDfOycAjzhUJsz399UvbGRuHy0PHHHhNvSg0FMN+PIc7fKVMsg?= =?us-ascii?Q?+RiBK5zz8kXytK9WuOGHlc15HIMcniDRpEl0sJ5fudrLVsJAkqkdfbTfOAXT?= =?us-ascii?Q?k9+/3nJYmjFE3RS940qntghnVE7MvHaMN3OmDkx4Z3zyYBF0mbxGHDB8Cj5N?= =?us-ascii?Q?+QdTijm35FcPa7pZk0OuHdhjpYzTUzAoSG13Fb6sNFVbDg7jD7jpvSPRmpkt?= =?us-ascii?Q?t2+I0gCLRFj5zsGJX6WeJsADrBtOSprF59JM4+KuJIwV9FAHoDncRqp06Kc7?= =?us-ascii?Q?jp+vTCPMm+/EtDz62xdVCmvBhDpqeUPjcu+gfOk59RMq1ZkOHqyMfMhIHMDK?= =?us-ascii?Q?dGztVcVDGKGS8ksbflYi1pnZD0R4C618UWy/qQftY7KC/B7zGu7o7+vmlSHx?= =?us-ascii?Q?7w64wrtxtlF8HFovC70L3l4swNYTif410yL0CxbRrrg2/n87K+do4f9U6eE7?= =?us-ascii?Q?8mxiSSWnHrPn5CU5zAW7QEPHM3sAI+V5aojQocCuXJCm7P5X354jbAKzkkcn?= =?us-ascii?Q?xSh1sOziV3ujc+6qmGGg5kHUvdefFX8SdG7nC9DVoT+KggtuFXBD4Uz5vyFu?= =?us-ascii?Q?hcF0358RSo1zXbQL2VbayYq3qgSUHroSnj0p61SJ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5877.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff45c9ab-651e-4209-251f-08db5c3204a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 08:36:49.8809 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LJ4oKhRBihgQ18TZ9BZJUVs2stISGTVpL0UzrUqiGaYSgUnYbMFjSHsk7SBMOFqGv/oOUNMUMtPbRRdAleclCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7606 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Qiao, Wenjing > Sent: Friday, May 19, 2023 4:31 PM > To: Wu, Jingjing ; Xing, Beilei ; > Zhang, Qi Z > Cc: dev@dpdk.org; Liu, Mingxia ; Qiao, Wenjing > ; stable@dpdk.org > Subject: [PATCH v4 1/7] common/idpf: fix 64b timestamp roll over issue >=20 > Reading MTS register at first packet will cause timestamp roll over issue= . To > support calculating 64b timestamp, need an alarm to save main time from > registers every 1 second. >=20 > Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wenjing Qiao > --- > drivers/common/idpf/idpf_common_rxtx.c | 126 ++++++++++++++----------- > drivers/common/idpf/idpf_common_rxtx.h | 6 +- > drivers/common/idpf/version.map | 2 + > 3 files changed, 77 insertions(+), 57 deletions(-) >=20 > diff --git a/drivers/common/idpf/idpf_common_rxtx.c > b/drivers/common/idpf/idpf_common_rxtx.c > index fc87e3e243..b487c2a8a6 100644 > --- a/drivers/common/idpf/idpf_common_rxtx.c > +++ b/drivers/common/idpf/idpf_common_rxtx.c > @@ -4,6 +4,7 @@ /* re-alarm watchdog */ > + rc =3D rte_eal_alarm_set(1000 * 1000, &idpf_dev_read_time_hw, cb_arg); ... > +int > +idpf_rx_timestamp_start(struct idpf_adapter *base) { > + rte_eal_alarm_set(1000 * 1000, > + &idpf_dev_read_time_hw, > + (void *)base); > + return 0; > +} > + [Liu, Mingxia] 1000*1000us means 1s, better to use macro variables, such as= "US_PER_S", will be more readable.