RE: [PATCH 22.11] net/mlx5: fix async flow create error handling

[Dariusz Sosnowski <dsosnowski@nvidia.com>]

> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Wednesday, April 3, 2024 13:16
> To: Dariusz Sosnowski <dsosnowski@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Suanming
> Mou <suanmingm@nvidia.com>
> Cc: stable@dpdk.org; Ori Kam <orika@nvidia.com>
> Subject: Re: [PATCH 22.11] net/mlx5: fix async flow create error handling
> 
> External email: Use caution opening links or attachments
> 
> 
> On Wed, 2024-04-03 at 10:38 +0200, Dariusz Sosnowski wrote:
> > [ upstream commit 5ecc8df4fad3411a53c20406f99b59dc736a6d1e ]
> >
> > Whenever processing of asynchronous flow rule create operation failed,
> > but after some dynamic flow actions had already been allocated, these
> > actions were not freed during error handling flow.
> > That behavior lead to leaks e.g., RSS/QUEUE action objects were leaked
> > which triggered assertions during device cleanup.
> >
> > This patch adds flow rule cleanup handling in case of an error during
> > async flow rule creation.
> >
> > Fixes: 3a2f674b6aa8 ("net/mlx5: add queue and RSS HW steering action")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> > Acked-by: Ori Kam <orika@nvidia.com>
> >
> 
> This patch does not apply on stable/22.11, how was it tested?

The backports were tested today by applying on 22.11 branch on git@github.com:bluca/dpdk-stable.git

Could you please try applying mlx5 patches sent by me in the following order?

1. "net/mlx5: fix flow configure validation"
2. "net/mlx5: fix rollback on failed flow configure"
3. "net/mlx5: fix async flow create error handling"

There might be some conflicts between these patches, maybe that's the reason for failure. I'm sorry about not mentioning this.
I retested applying them on commit efe1d783f474, in that order and it applied correctly on my side.

Best regards,
Dariusz Sosnowski