From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB143A0093 for ; Fri, 22 Apr 2022 12:54:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B00224067B; Fri, 22 Apr 2022 12:54:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id D03D44067B; Fri, 22 Apr 2022 12:54:30 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23MArYeV000321; Fri, 22 Apr 2022 03:54:30 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3fku0mg026-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Apr 2022 03:54:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BQs4c03toAPwCAKk8simMMo2G84EpyiOyvxKRblN+PTZxZwxvcgAaq3MS5fDImi+JW/yGUNMCQagnvhwuGamk/bUuu5hiH6MZuN8igCj90vbxK+0BDrLf4xawnF58ljILVh2EEYJBB5ZZY3qsCozkkNwBgQyZp+vCd9STyrzaUdlmeI1MBqgExHiD6eulj9wnvV1NNqioHpaz/bD9rMwSPqmD1K3UMs9ZiHyerHt28jUk3GtfHfjgBTNSdfpuEJtNF+G1zrkO/eg56ykikfy5HEtXmWJ9zLhzKxmS/rMgz7baM4/tJzMgUWiuROHFZLqTwezEm7O8MMSxGARJRcAlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4LpLTZLKdroowP0zqubszm8yKNtUbVpcTYwyeAIrabk=; b=F6dhdPjCA4uggiJ1DrlbDSXj1NNSNHB8gCAEtjYoUpuiHShDm6YB1NhLTpKlHZE1S2bjFxfb33YUMXLQ+6Tb2wSZX6WJRLPB9yYURVFKaGVjaxp2bM/nas8z7TlLdLhyyACq/jDlWKxdpdVUfeIw0XPGkxt/J6B9Gi9Jg1sc/9tvHxg1IJWI/EryMGmylSJr7WSWosvoj8B8psxbYWcQEFUN722vtMIoS7TqDQ4sCiJKZFKbc8KeDbjDigOcXdLeWCfxo5sLx2vnnm8AG/4bF8tjdYWWFI+rl6LjnPM/Av9uJux/d5zC+mg2bd3Uh7tIwerkajpPA/RrJhaMxsVoqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4LpLTZLKdroowP0zqubszm8yKNtUbVpcTYwyeAIrabk=; b=LQ1tN2Dz/pIAnAxLI2o4v7krGjxtB9OqK1z3yPuuyAr/+2+GfH/hMe9QtK32qiWvUclhXcWrWrT4A7P99tCXRDgdqQl9guRKm+RlXfBQxP9H3bakp2pE6nLxHRtucv9BHPvaG81r5JHCWWXN8kowLdK26+1As+B0fs3eSSPZjUg= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by MN2PR18MB2464.namprd18.prod.outlook.com (2603:10b6:208:a9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr 2022 10:54:18 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::f1e9:3c10:e19c:5726]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::f1e9:3c10:e19c:5726%6]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022 10:54:18 +0000 From: Pavan Nikhilesh Bhagavatula To: Nithin Kumar Dabilpuram , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , Satha Koteswara Rao Kottidi CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2 28/28] net/cnxk: fix multi-seg extraction in vwqe path Thread-Topic: [PATCH v2 28/28] net/cnxk: fix multi-seg extraction in vwqe path Thread-Index: AQHYVjaG/21t7J1HQkiPbrqQOsHhHqz7wiig Date: Fri, 22 Apr 2022 10:54:18 +0000 Message-ID: References: <20220422104709.20722-1-ndabilpuram@marvell.com> <20220422104709.20722-28-ndabilpuram@marvell.com> In-Reply-To: <20220422104709.20722-28-ndabilpuram@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d71618c3-f06c-483c-d56a-08da244e734a x-ms-traffictypediagnostic: MN2PR18MB2464:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ehRYa28eHAESKfY/jm8cYi7HEFZsFK6rF7ISwnGurlN3OgjafrjO7ZeI7FRN2Ja2MSzit0Z1rvkVumDs/NM45PN/6oQiGWxoa1ZHRegBOfV/b+FBd/GKUWe0MxbaArWFoMRRZy1UU7ShvZUbN/5OTimnUHeeYZxwALSPOj3R+LKfviyW+9oI8OLRfpTg1wam7dN6rvWkVzLV+uxMhprMYmzGr1O/sofuleUm3LC3QVJEUdGMU52GaLFtHKMUYWVEQ1Km1Uzp4+3iuRMiUUti3ceElGScDvGox8d0w6RaGo7afrNrqVBi1bph57tC+MrbBBvew0PwHrt/NyMCdY79zxO/DHtp56GHrB402ku2jDeC16HhqpsxZYGHRIV4yDrD9pRzJIvG2zwHcGX3SvCDEy5zwSY5Nk31GhyX7MBrVS2a45q4wfy6VMEQrvV/SG+L7DVxt0lauDb8IAKVpQWC9R3J1L/XDgAbgvzu7yc8OUN386IQWFeT5xUSikHLQLi54kEOPtkpuhsTzrKrY5N5aCapt0N7v+Hu54+ffk1coWIjKnmMBByNp/QWUfWIoH7OSlJfFdwUK7HdvdSszMI0lhX8NnTkPrd9gvv38l+XjFFfHgYUEWKiuJVFurjw+bHY0qMdKPPQhkmueDBivFiw+1Ou/8FS9Tpz/2cljajxCELUb2am9uUVupUEUsdBkpjuMh+qz9+fspnkRHcjQNwNQw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(55016003)(6506007)(450100002)(4326008)(83380400001)(7696005)(26005)(38100700002)(9686003)(66946007)(38070700005)(71200400001)(86362001)(76116006)(53546011)(66476007)(66556008)(66446008)(64756008)(8676002)(6636002)(110136005)(54906003)(316002)(2906002)(33656002)(122000001)(52536014)(8936002)(186003)(508600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hVL++rUjojQcZe74TLDMmDr+Qvqfn/u7X3VJ3oyR8n2qNRwVeBRMiNty9zON?= =?us-ascii?Q?qCegP2mw3ngvJajkt3enH6mOs2stGPCC25fLj7wemmz04N3P+QBTyS4zkzxP?= =?us-ascii?Q?cfFGKiKtdhSGJC5F4ElRuBM47jhxBkIsGZFjl3OvGW38V40z8Xp7Km+/hsH4?= =?us-ascii?Q?auYpPryBIhpXSIKS5hYvTa2wCcocrLQYIY4z3YaT4OY5D429dzg5BpIbirHW?= =?us-ascii?Q?h+koKR431p3FKZgh5S5MaG6Xkn6b8wFq/XXvOCve2Ix/yvjQuCoAAHmrHNw3?= =?us-ascii?Q?pOX2sKl3a/dTDb8Tpef+ygZ/9J7Kfud7k4Ck4wsYQxE2kDnJDU8SWKEUdt5h?= =?us-ascii?Q?uAH8x7cTBHlM0xKtVzgTYIHQbyUzITTuaO8f+YQg/8vqQmmurWoGOtx8qWJT?= =?us-ascii?Q?bM00nbHBpPzzcpTJfUfnVKoyTdzg7tPH+9uS9y8e21YG9OD7Uq1sSCOskxyn?= =?us-ascii?Q?knJ6CGn/weymVj6oCT8zbYBkD0TiC1wF423qTPweU+YLKp5HfLRhWGO8apMw?= =?us-ascii?Q?RIZfix9i4Hb3dKkA5hjHY540svwIbU3G2niMAKWKyui5Z12svPZMOP+lwSuk?= =?us-ascii?Q?UJJsnEtol6JoyxixtEGp0n4qhngiilLOxIb027Bkfxo7cebo6AfUDu+uhcfm?= =?us-ascii?Q?idqDbKKwOyiSMUXAQeCEZ7R4TmhUPNUSdm65LB3Fy7tB74/XO7wKS383bPIW?= =?us-ascii?Q?NFtTjEGKKsJ+CZ0jho9azAzL/1U9QHkCHFSFAszshjSusy9jQT9mbkTqK6L9?= =?us-ascii?Q?sUXSk0sumaA6XlFBLBoL2Zip9H9YnxSF3rVYuexEZ7kxTDYZZgp6SdXTjXL4?= =?us-ascii?Q?E3ANCFdT2WBXKs1Jo+eDEumUuddpB/+VA7dHXJwgk+EfrvnV2tfOD0LWET4V?= =?us-ascii?Q?2cImQrnyW+hj9S0riVe3dwFXMY7EjwDl3pqfVnbDWAuETncuIWdX0y3ULBJK?= =?us-ascii?Q?c1cyy1Hfx2iN/l+A5D/YnFx+2ANtlBRv2kyy4v9UFgkK1oTAFBQwMpeA3vNA?= =?us-ascii?Q?7Iy4Y39mPbjO7yy8LpgWTJTRf+6xMk7mh9ZJebn6lF9CIMqGjwKXZrN8HG6H?= =?us-ascii?Q?yyKCfYvb2F9yDuxD6oZ1kNYkB81xzNIwmaWL+vTHcQDEOVUMMMw6Hy2vekKK?= =?us-ascii?Q?lf5T/KDglGgekM90lmHLNPdYaat5Q8qedt/PNDiioYkWzLucWIV4qHH0SQah?= =?us-ascii?Q?W4kfrVvm6Gd7Ubo9rjkwi2IR3t84AF6AWM7ZzA3m+GXy38DHcj87TTwPtnY2?= =?us-ascii?Q?/jxgXJXj0ALxHktk4WCl33fOKqle5Huu7freTUzjVE6MNQy9kxTt4DqjL3Vp?= =?us-ascii?Q?dW87chfQcHG3Jrp68Uqr1MJ9Pk3YMHS/HjDQ4xIbmVrcuDFgPCdEI4kAQpUO?= =?us-ascii?Q?DyfwuQD58YbasKr+3nKXySBmq9lGRk17DaEGnvsgERE645CJCgYs9YpM+MnY?= =?us-ascii?Q?MT/uZBCffc9w8NBnvf1YLDaIQnY0bihbIpqojtiWylKh4aERRV6grBFkODSJ?= =?us-ascii?Q?6Wfhd7m0Th6VU/Mzsl7xc6xnLhg8dMyvnbwBvgQn8/Kz314EN3hgwW7OHrlb?= =?us-ascii?Q?aVxCslqhGjyBbrHO3f4rz13ePcJ1EuXvxaFb/qAAJugaDX2oOhmqI3YKkJUr?= =?us-ascii?Q?osoXpk3RhAMCERdc2mUyvbWpq24DxcfY9ucwCJ813MgY1/lCBFafLXLPPsUF?= =?us-ascii?Q?dxrGOGJdnIavbnXsRslr+LXpWwkNiZKbpwC3y120babwAvMu4pz0A/krog+b?= =?us-ascii?Q?jFaJGk/6RyneGg0zvwynZFsvE27YaYI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d71618c3-f06c-483c-d56a-08da244e734a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 10:54:18.6523 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bMXW3mk7Kyz/WTdncGDCPgGq6mPms5rD8cC43JwKWPBeCPrcQX3SEYWaHY5hl+sAEof6jDgv8yoB28yJNHlLIwjL+3PDiDv1C5ErZGUK+nA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2464 X-Proofpoint-GUID: HKwE0K5lBBKZTW5NwEfUvDVwvprFHf8R X-Proofpoint-ORIG-GUID: HKwE0K5lBBKZTW5NwEfUvDVwvprFHf8R X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-22_02,2022-04-22_01,2022-02-23_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Nithin Dabilpuram > Sent: Friday, April 22, 2022 4:17 PM > To: Jerin Jacob Kollanukkaran ; Nithin Kumar > Dabilpuram ; Kiran Kumar Kokkilagadda > ; Sunil Kumar Kori ; Satha > Koteswara Rao Kottidi > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > ; stable@dpdk.org > Subject: [PATCH v2 28/28] net/cnxk: fix multi-seg extraction in vwqe path >=20 > Fix multi-seg extraction in vwqe path to avoid updating mbuf[] > array until it is used via cq0 path. >=20 > Fixes: 7fbbc981d54f ("event/cnxk: support vectorized Rx event fast path") > Cc: pbhagavatula@marvell.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Nithin Dabilpuram Acked-by: Pavan Nikhilesh > --- > drivers/net/cnxk/cn10k_rx.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h > index 00bec01..5ecb20f 100644 > --- a/drivers/net/cnxk/cn10k_rx.h > +++ b/drivers/net/cnxk/cn10k_rx.h > @@ -1673,10 +1673,6 @@ cn10k_nix_recv_pkts_vector(void *args, struct > rte_mbuf **mbufs, uint16_t pkts, > vst1q_u64((uint64_t *)mbuf2->rearm_data, rearm2); > vst1q_u64((uint64_t *)mbuf3->rearm_data, rearm3); >=20 > - /* Store the mbufs to rx_pkts */ > - vst1q_u64((uint64_t *)&mbufs[packets], mbuf01); > - vst1q_u64((uint64_t *)&mbufs[packets + 2], mbuf23); > - > if (flags & NIX_RX_MULTI_SEG_F) { > /* Multi segment is enable build mseg list for > * individual mbufs in scalar mode. > @@ -1695,6 +1691,10 @@ cn10k_nix_recv_pkts_vector(void *args, struct > rte_mbuf **mbufs, uint16_t pkts, > mbuf3, mbuf_initializer, flags); > } >=20 > + /* Store the mbufs to rx_pkts */ > + vst1q_u64((uint64_t *)&mbufs[packets], mbuf01); > + vst1q_u64((uint64_t *)&mbufs[packets + 2], mbuf23); > + > /* Mark mempool obj as "get" as it is alloc'ed by NIX */ > RTE_MEMPOOL_CHECK_COOKIES(mbuf0->pool, (void > **)&mbuf0, 1, 1); > RTE_MEMPOOL_CHECK_COOKIES(mbuf1->pool, (void > **)&mbuf1, 1, 1); > -- > 2.8.4