From: Anoob Joseph <anoobj@marvell.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Vidya Sagar Velumuri <vvelumuri@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Akhil Goyal <gakhil@marvell.com>,
Fan Zhang <fanzhang.oss@gmail.com>
Subject: RE: [EXTERNAL] [PATCH v4 5/9] app/test: fix TLS zero length record
Date: Fri, 22 Nov 2024 07:22:44 +0000 [thread overview]
Message-ID: <PH0PR18MB46726DE8605ECA16100DF697DF232@PH0PR18MB4672.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20241121182443.68025-6-stephen@networkplumber.org>
> The code was duplicating the same condition three times?
> Reading the commit message, the intention was:
>
> Add unit tests to verify the zero len TLS records. Zero len packets are
> allowed when content type is app data while zero packet length with
> other content type (such as handshake) would result in an error.
>
> Link: https://urldefense.proofpoint.com/v2/url?u=https-3A__pvs-2Dstudio.com_en_blog_posts_cpp_1179_&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=jPfB8rwwviRSxyLWs2n6B-
> WYLn1v9SyTMrT5EQqh2TU&m=XameIFsYmmvHMhJycVwGxFucfJNVntjVlTBXIykV7kmsF4i5OLtyrXHT9KSTJnkm&s=JaPpRUXDxqq1KFX_JG2CQI0viz-YZG33I8zoO25Fr6k&e=
>
> Fixes: 79a58624369a ("test/security: verify zero length TLS records")
> Cc: mailto:vvelumuri@marvell.com
> Cc: mailto:stable@dpdk.org
>
> Signed-off-by: Stephen Hemminger <mailto:stephen@networkplumber.org>
Good catch. Looks like remnants after a rename exercise. Originally it was intended as separate for TLS 1.2, DTLS 1.2 & TLS 1.3.
Acked-by: Anoob Joseph <anoobj@marvell.com>
next prev parent reply other threads:[~2024-11-22 8:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241114001403.147609-1-stephen@networkplumber.org>
[not found] ` <20241114192603.41145-1-stephen@networkplumber.org>
2024-11-14 19:24 ` [PATCH v2 01/10] app/test: do not duplicated loop variable Stephen Hemminger
2024-11-15 9:01 ` Bruce Richardson
2024-11-14 19:25 ` [PATCH v2 02/10] app/test: fix typo in address compare Stephen Hemminger
2024-11-14 19:25 ` [PATCH v2 03/10] app/test: fix paren typo Stephen Hemminger
2024-11-15 9:02 ` Bruce Richardson
2024-11-14 19:25 ` [PATCH v2 05/10] app/test: fix TLS zero length record Stephen Hemminger
2024-11-14 19:25 ` [PATCH v2 06/10] app/test: fix operator precedence bug Stephen Hemminger
2024-11-15 9:06 ` Bruce Richardson
2024-11-14 19:25 ` [PATCH v2 07/10] test/eal: fix core check in c flag test Stephen Hemminger
2024-11-15 9:07 ` Bruce Richardson
2024-11-15 19:53 ` Stephen Hemminger
2024-11-14 19:25 ` [PATCH v2 09/10] app/test-pmd: avoid potential outside of array reference Stephen Hemminger
2024-11-15 9:09 ` Bruce Richardson
2024-11-14 19:25 ` [PATCH v2 10/10] app/test-dma-perf: fix parsing of DMA address Stephen Hemminger
2024-11-15 9:13 ` Bruce Richardson
2024-11-15 19:58 ` Stephen Hemminger
[not found] ` <20241115200751.17141-1-stephen@networkplumber.org>
2024-11-15 20:06 ` [PATCH v3 01/10] app/test: do not duplicate loop variable Stephen Hemminger
2024-11-15 20:06 ` [PATCH v3 02/10] app/test: fix typo in address compare Stephen Hemminger
2024-11-15 20:06 ` [PATCH v3 03/10] app/test: fix paren typo Stephen Hemminger
2024-11-15 20:06 ` [PATCH v3 05/10] app/test: fix TLS zero length record Stephen Hemminger
2024-11-15 20:06 ` [PATCH v3 06/10] app/test: fix operator precedence bug Stephen Hemminger
2024-11-15 20:06 ` [PATCH v3 07/10] test/eal: fix core check in c flag test Stephen Hemminger
2024-11-15 20:06 ` [PATCH v3 09/10] app/test-pmd: avoid potential outside of array reference Stephen Hemminger
2024-11-15 20:06 ` [PATCH v3 10/10] app/test-dma-perf: fix parsing of DMA address Stephen Hemminger
2024-11-18 2:44 ` fengchengwen
[not found] ` <20241121182443.68025-1-stephen@networkplumber.org>
2024-11-21 18:23 ` [PATCH v4 1/9] app/test: do not duplicate loop variable Stephen Hemminger
2024-11-22 0:39 ` fengchengwen
2024-11-21 18:23 ` [PATCH v4 2/9] app/test: fix typo in address compare Stephen Hemminger
2024-11-22 0:37 ` fengchengwen
2024-11-22 8:54 ` Bruce Richardson
2024-11-21 18:23 ` [PATCH v4 3/9] app/test: fix paren typo Stephen Hemminger
2024-11-22 0:34 ` fengchengwen
2024-11-21 18:23 ` [PATCH v4 5/9] app/test: fix TLS zero length record Stephen Hemminger
2024-11-22 7:22 ` Anoob Joseph [this message]
2024-11-21 18:23 ` [PATCH v4 6/9] app/test: fix operator precedence bug Stephen Hemminger
2024-11-21 18:23 ` [PATCH v4 7/9] test/eal: fix core check in c flag test Stephen Hemminger
2024-11-21 18:23 ` [PATCH v4 9/9] app/test-pmd: avoid potential outside of array reference Stephen Hemminger
2024-11-22 0:33 ` fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB46726DE8605ECA16100DF697DF232@PH0PR18MB4672.namprd18.prod.outlook.com \
--to=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=vvelumuri@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).