From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A20B45D6E for ; Fri, 22 Nov 2024 09:55:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31F4D40DDC; Fri, 22 Nov 2024 09:55:35 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 2B2DA40DDC; Fri, 22 Nov 2024 09:55:33 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AM5xvMD004967; Thu, 21 Nov 2024 23:22:48 -0800 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2176.outbound.protection.outlook.com [104.47.58.176]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 432ma3r48j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Nov 2024 23:22:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gfbuWLp6gZZqgioOMMqBZIDSDt759paj/bzojTpE4596O2zuNcK0xeTHxZEBTaWxuD0HLZ/cZ7H2m+s9YBa+n7wG8RAKv9DuZBm3ZcjGSafiYSKyNQV2jEKPYW2NRXC4QVyiwXe3PWilV5kB9Vpvj+XfvDeVWRX+xMU2ks45U2PAt5aBe1vCyfDAl9XshdQ4v2VFokXphjBbZ6Lj7bYTNxWDcTMwBBH4HATzXWenTy7aHQiNomOI9vkW73TYogTqsmUHtUtD/UZ42tu25xc8iMpsdZDteJPT1At1QmAaVwad0EEJ6i4Mbu0naafMxRjfzWlwCzYypczU5BTTMg9g4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B40k/EVi5heySwZVpRv0dYqVTT7Mju307ivhoPnVwRE=; b=lLNxnQtpti9D7OTv9nhW3KVojzllmPG4KjeAUFHGB5O5u94wuBdL+spqcEx/ZEh4hhhJHw1a/7ZvFiPLu2Q1b31wVijDnBCbC/xIIPQM5HK953ftksggor87WTzqsVulVJkkxG1ME2/aCjHsgx+8Tae1I1O2BMReSSUaw6F2A4tbOWw5VA/zMKGiXCdVJEpFEflRyII9A4wBLq0vFVVLl4AzV40PsncIjmEUZ9oJ4YDJvsRY/nmxsx9i6zvpHsjL/0aF8qkQz0lIMHsndMvJfoX3F11kwwEnEHjS9yIwWiSRy6Tc7Xu3n4J93U9bMZBnmJ6LTB9NzHXhxTeisrTQ4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B40k/EVi5heySwZVpRv0dYqVTT7Mju307ivhoPnVwRE=; b=rGQbKfJZ53g7HRY+kHrxcQO6LiJpt0FvwphGiKjaay1kdYjfhf30I72kMNMaH0FChJZ5qtBpP4+25YObY7lGfOTD96QiRCz/APWF0kygqA3OqpptmTM0PhN6/Zfu+FsT2dZjJqNOnDDOLnfvlLJP8mFvlWQaNK9Ij0wDprdNfm8= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by SN7PR18MB3949.namprd18.prod.outlook.com (2603:10b6:806:f5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.27; Fri, 22 Nov 2024 07:22:45 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::10cc:503b:935f:f61c]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::10cc:503b:935f:f61c%4]) with mapi id 15.20.8158.024; Fri, 22 Nov 2024 07:22:44 +0000 From: Anoob Joseph To: Stephen Hemminger , "dev@dpdk.org" CC: Vidya Sagar Velumuri , "stable@dpdk.org" , Akhil Goyal , Fan Zhang Subject: RE: [EXTERNAL] [PATCH v4 5/9] app/test: fix TLS zero length record Thread-Topic: [EXTERNAL] [PATCH v4 5/9] app/test: fix TLS zero length record Thread-Index: AQHbPEKv/2ScJF0oAUKT6s25yaVbzrLC5RbQ Date: Fri, 22 Nov 2024 07:22:44 +0000 Message-ID: References: <20241114001403.147609-1-stephen@networkplumber.org> <20241121182443.68025-1-stephen@networkplumber.org> <20241121182443.68025-6-stephen@networkplumber.org> In-Reply-To: <20241121182443.68025-6-stephen@networkplumber.org> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4672:EE_|SN7PR18MB3949:EE_ x-ms-office365-filtering-correlation-id: f591d513-6565-43c4-2229-08dd0ac6759a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?6lWKDuAJlILKaXKTEUn6ehp7DEbS4mP6NExiH2NOnL04g259NEkVXj4uPLsx?= =?us-ascii?Q?6h+AZKTgt7FA7Oob+qGFR6X68oRuqX4XfLNahsOnW+xle548MYgVdWPcdMYf?= =?us-ascii?Q?wDsVGqFo9jkWHPL5O8b/1hqaeFLHZLaec3K0pgKB316FYfp7ha1aDfCz/Cdv?= =?us-ascii?Q?gF1W0mY+hF2INQhAJKeq40ylMjocm4Vzg9CQYx3/qr5ySsusWnIdTz0lLxVi?= =?us-ascii?Q?cSFwZqfwwu23u05t4FbjCqxDXTEdIruLgHNrFr7Fnl/0y3HOf/Q45ec61Yg1?= =?us-ascii?Q?FSZ1kVk0oxZ3jPBE93/i6+knZqBcJuvtn6GK06R1UOXPjBJwqMtPeohkYqZP?= =?us-ascii?Q?SQZgXPZ7CEJNACWdV/YL/BVSmMqLFro88fO5hmDNvXvZBT5ZtbQLW7T0Ryc7?= =?us-ascii?Q?mpMAJvxdRmRjD0cIfQWBF5yGF+CKIAzkoXvt9qdU0Cg5jBsOZ2gZZxv+X7ri?= =?us-ascii?Q?XevtkGDAi4roOBfRJt1zkFDJilxIP1aOHt8pUS76BcSAXv3FdxRglKWKxGEM?= =?us-ascii?Q?x6PTnnbMyOkbEytPBAr7R/1XHPAlXrDTcXHNT6XMT+m97SCMC2bkJUGJf2fc?= =?us-ascii?Q?YKrhEANWq7MdPZV+dZH1oaB64WOKtdrzMHQ7oVUf3I2e8A0SB0JgblvWvFci?= =?us-ascii?Q?UYJyNzfDCJ+TIR+NqE1W1ZwZqgL988Cb5VN9xkr33MEvD7127gY8g/wfFryD?= =?us-ascii?Q?d6w3/a3SiJS1uNZYFcFo/bAh6ZRIN2VgKzOvDYGhK8Lpyc3N9PBONnK4qx9q?= =?us-ascii?Q?SWU9ytLITHwyUOCfl3G3n+dK244FLI10BWwytxz3H4Soa2twr6hZqlmuqSfc?= =?us-ascii?Q?NY5E/lpAFUBvYlFktomrcxLSAn3RHuNAVXfcMdITPerW1ut3bTw7YYZl/BDP?= =?us-ascii?Q?9xN+avRqkUUOVbPc9vDyHDH/xoXxiJN617H5qL3kjadmUyQfurgM1FFYpC4h?= =?us-ascii?Q?Ry3YQFcls4BQczhvFOsCAqkwgSUk/a7ErdWEsVqb9+yR5/16PCPSKccbDEj/?= =?us-ascii?Q?EZ6ANbtf+UC2L3jmTCATdnm6m/8WbLIwRNH5RRB3ss8KQWfDVYKXK5/EwUyS?= =?us-ascii?Q?4t290GSCLTu3UQIrIkvUD0gas44duixglSKd9P/arl5EYyb/tTgtrd5hgQi2?= =?us-ascii?Q?A/iO4Mh4cz1bFTR1mFkDrYVTy/VhFZFZvXQWKUAdC4JfxdzJ1LH0lmqtrlnB?= =?us-ascii?Q?smmMwAgXTaNV/ePr2f2CJtchg33dW6BtdWCi4Y6awUakmezFAzrE4Cu5yhqw?= =?us-ascii?Q?VI2pR2LbqXHiG6Bdfr6R+ZCeJb/sX2Yx9WDA6gqjCcJ0pbL8P2ubSwgCrJs2?= =?us-ascii?Q?ltecAbdg5wupHBl4w+4/p/ni98LCAIammjx+R4HbVRXuLq5NP4HvceoTU9Mr?= =?us-ascii?Q?KvCxsNk=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yWrcdYzt5OYLKlLXno4VKZI3V9PUin08X/bw7ddrxS6XSTqjcHdAZ+tNIx/B?= =?us-ascii?Q?Y59HbOc5l17E4VThOaFjAz1WIiYH3VAsqixq3YQdq3YoioLEs+k1ToM9YLl0?= =?us-ascii?Q?P6116YUniagzxAf6uzWmWldlxQB1et5mSmtUQQePGApmaApu9zTxCUzXIvbe?= =?us-ascii?Q?y2R7WXDT4VdvhK+S64IXFqC/NwRmiGdLKQ/QHYqxY1WSSumBb26/uAt0gmpQ?= =?us-ascii?Q?Bq4zCTNDkmUI+zGLWHXEJwgsSE5BHNcNYabOVYcGMCsNDcSEe5wH9JH7ZY6u?= =?us-ascii?Q?NO/D08cbaCsQtDjp53UBK2CHAc4qij19sdIdnmhfS5WXd6PQXzKsntMEdrDF?= =?us-ascii?Q?Sazm47IoBusod2zfMGPv9jE62qWu50DEEWUxEulAmAy1vlIDKdqQ3tp8q7UV?= =?us-ascii?Q?pazJMhx11VtOmlq1JgIFmhKgUwD+y5pphsrX2Xu+2t3kq35IrF8dZ0+VgB5b?= =?us-ascii?Q?fAbdasxFcYAPO5XCTf2TDHgeC3fNkOxVua60IfevV0RRcTuL9RwuVtqwE0ai?= =?us-ascii?Q?IO6uDYUlNundRuICyP1aapLYndaggSQp0WH/Koc9ImdtehyEyTg98edX1mpk?= =?us-ascii?Q?sKgpJVJRm8exdwLQyaQkf3l5JclQJlKwrIO6b5krdC6IINFwKBVxh5GvJBxC?= =?us-ascii?Q?k5Adid9PjmgvpV2rWrVfLHyiujK2rVf9qkaMZDUJueHYAcaDNmjJAs6epS5O?= =?us-ascii?Q?qADQ17bAK93S6uhS5rAsaZXxqKe/s4ltGwrBOvkwLJSMZHUQs1mrd5Mqs32a?= =?us-ascii?Q?waj7vqHVizaiK2qi8LmCtrf8rs1yOb/+TxEDJq9MtpvbABeomsqLh/+K/1v0?= =?us-ascii?Q?oZBgcNIbwRwCq3MczrQv4qimrgimQpfU1cchr7uGWa74+KKB/iwTI7AF488g?= =?us-ascii?Q?4BKtw59qBmW0Y91wf6jxSsLATWFv9w4aHBEnEPVd98jGqzjLb10MM8ZDicNf?= =?us-ascii?Q?+Zw65e0HCMcM866bY2jIV7nHUnFFTbCUwE+MPWUIYKW4gZjGcbW7gKqzRA+x?= =?us-ascii?Q?wIzTXRR54ETuBeRPrwS9HyDaUV7TUnNGBJSitUA1tDIXxWK4TBwPrteCVV6x?= =?us-ascii?Q?cElPoxvj970sRWAI5xQJWQHX3CPGhcDCs8bQrW/wkcvf2mkptashORmmYfVg?= =?us-ascii?Q?t2ELx03WofLydpFXnjNHGyCfx1TFrWCT7luVOtvwUYGclnb/HAolVXQDWlrH?= =?us-ascii?Q?uqWUNdNw9z1sNDsarIpF6efQTvdnBIzGiwlmbCWSVbXa+BxACOQgnLhM4Pp1?= =?us-ascii?Q?sLqTvX7UQrXV7HmVOzi71YoYp6XmpJwPnU0ahC+jCQA+MSNpyPVWVaLr2tye?= =?us-ascii?Q?nICeN61ecCI1HrcVeTZTzrzEOzz/n+h+9jtU762Npz12HNPfmA5hAf4xZmyz?= =?us-ascii?Q?xEQp8HZgLHr43CKRIr3bxiaA1ssTv3DkVXFmsvNB0T4WFaMQBs2OzTJEGLML?= =?us-ascii?Q?bw4+aY6IHlv0FYHcH2GwkJ36lDDoLUTtKjw+gSDe7Lxfv9wgw9lM7JakjSaj?= =?us-ascii?Q?OGN6U4/ZjisXD67vT0GJUgJtSC4oFgZIMJ97ANPQGbKCr1VP+eErmgYizjcu?= =?us-ascii?Q?9ZnxkMqphDM9TnNcMM+t+xYZzZ2f+ffussLYnXjO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f591d513-6565-43c4-2229-08dd0ac6759a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2024 07:22:44.9018 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jnDREiHCVr/d5F147sL5mfspOCGS0BcA6tjKYORpxZ47N53ai56/jnq5nYcLdSxHN6X+Qk58u/Uv6oq97qA9dA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB3949 X-Proofpoint-GUID: K3TKKxC4NKcCoQ7ceCxrXE35v0-COodS X-Proofpoint-ORIG-GUID: K3TKKxC4NKcCoQ7ceCxrXE35v0-COodS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > The code was duplicating the same condition three times? > Reading the commit message, the intention was: > > Add unit tests to verify the zero len TLS records. Zero len packets ar= e > allowed when content type is app data while zero packet length with > other content type (such as handshake) would result in an error. > > Link: https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__pvs-2Dstudio= .com_en_blog_posts_cpp_1179_&d=3DDwIDAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DjPfB= 8rwwviRSxyLWs2n6B- > WYLn1v9SyTMrT5EQqh2TU&m=3DXameIFsYmmvHMhJycVwGxFucfJNVntjVlTBXIykV7kmsF4i= 5OLtyrXHT9KSTJnkm&s=3DJaPpRUXDxqq1KFX_JG2CQI0viz-YZG33I8zoO25Fr6k&e=3D > > Fixes: 79a58624369a ("test/security: verify zero length TLS records") > Cc: mailto:vvelumuri@marvell.com > Cc: mailto:stable@dpdk.org > > Signed-off-by: Stephen Hemminger Good catch. Looks like remnants after a rename exercise. Originally it was = intended as separate for TLS 1.2, DTLS 1.2 & TLS 1.3.=20 Acked-by: Anoob Joseph