From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AFF6A0505 for ; Wed, 18 May 2022 06:46:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42C2B42825; Wed, 18 May 2022 06:46:03 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 93F7440685; Wed, 18 May 2022 06:46:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652849160; x=1684385160; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=HpiAhJMsCG14JFc+X9phz97P30YEfk4EN6WutHHwcV0=; b=jTSdiTdX6e9OHIW+0DiYxPea9Z74C++3ofgl9K/A5+U1gWvlKFyQdoKf IMjR6ed+NcpA/SPEcteai4xLn7pHctAHnTI0k42pkuTkTTiJiGn7E2ItB Vd/wzLLuLZbCf5FDp/BRfAuU1UnFE3T314Gy3rnEap16gxEdJ1eHKStu2 5zLo/Fn4b69clxhATow47Kev79drwFj6E/4nSeO0Q0mk5b16myXZ9JJBR 7l83wKSUKUk8yutJPmPFg7zbU9O6UZO4l/DvCQqSwo0+CU2GvEkbtEeGV yCAANAFj0sITPPloJzCefOjvqnJNRXun3iTtaawYSWunXKl7oo3XvxOw1 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="332094879" X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="332094879" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 21:45:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="523322199" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 17 May 2022 21:45:59 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 21:45:58 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 21:45:58 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 21:45:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T+anvsQNQokrpB4JVq6GAlskkeliZLHPb2PMAEhmspbuueHgdDCyJjNUt+hMBYaSIJwDXwWv1notVoSeRYtiYpy+STdItPYJul86YZA7Vml389HRkQhGu2rDn5pzEU2/vOJyHKf/GizBBTsPCSyZ5RzuMqKTOEyIzDCRHK6M4kKDaoQH5FOMmKxWBaB1ksIYYGz8Tp7M2y5OLbTo8wMkij18mvX0SjqR2tyI4xKV4uQLGqaImwAArNLjKZiCRdjrDHBp+IUGEYDhNRCMhlbb8Eij136kpD2iWlwToxBZh0aE81+OVO2z20Jd9GjSx1gyoUXhXgqa5m5IUM079A74tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d5W6VSnuojZmR2v+g1j6sYUK8bKX1E9UOE6tRCaY5Vw=; b=A2Ne1M4FAWHNhosqkHwGulUPGciDacdW8n/ZxlDMmyRyAU9HoNRyTFz/jOtEQl94wpNHeBJ8eFL6Vrkcv16MuklkeiDvp5xwfvFnJcNJm3oldlWxTXMBl3Ok9wlSdSCfxHSF5PaSVtZUiL5+fuAXV48u8vFi4BzKBHTwAQxXNcS53ICDDw6uFjvc/vBFCcyG81li0waFl8soWFnk1cB+6NkPq+ukuuBKPiOShO8qsPrtzy+qIHyHAdcMzSUFdCm/uIGOfCA7+4KPW7LntHpqF1df2N9X0V0GTl0a3ino6i9AiHDKPHFTnHTTOCbZMANZXBXdzY8He2R3mHYeeZ1QwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5982.namprd11.prod.outlook.com (2603:10b6:510:1e1::20) by BN6PR11MB1554.namprd11.prod.outlook.com (2603:10b6:405:b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 04:45:54 +0000 Received: from PH7PR11MB5982.namprd11.prod.outlook.com ([fe80::317e:73cc:d3fc:4fac]) by PH7PR11MB5982.namprd11.prod.outlook.com ([fe80::317e:73cc:d3fc:4fac%3]) with mapi id 15.20.5273.014; Wed, 18 May 2022 04:45:54 +0000 From: "Zhang, Qi Z" To: "Yang, Qiming" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH] net/iavf: fix mask not allowed issue Thread-Topic: [PATCH] net/iavf: fix mask not allowed issue Thread-Index: AQHYaMmRCQp14qx6cEOOarbGbJM9ya0kElgQ Date: Wed, 18 May 2022 04:45:54 +0000 Message-ID: References: <20220516020319.2430990-1-qiming.yang@intel.com> In-Reply-To: <20220516020319.2430990-1-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 09cf0e0e-dc39-4777-bbee-08da38894b12 x-ms-traffictypediagnostic: BN6PR11MB1554:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qN+OQvK72QoiZ6slU4ag3jwCXyV7AjCwconCmRKSFVWoS/m50mfiEeD+GH72OFUFeHCodkXIqFSxmYRCNbYaNeBI0oL0LirjgbfWF9ZDv39g2kqJ8vSCGkYc7kHdgOI31rT3XGP7v0u9MklzqTibHs0YST5kP9kW8tMbfoFaegfCjk9+apuws/7G9b9NsJniC0LrTb9DgFvqe/G6gDzqwokXZhAkEhIAYi63WSCb/Ex8LAWsIpebDKXQJWh+B8hjXOScmjRqSeE90F6KhCoF7E66wt6e+H97kQNH2OD7En/kNGxyDPviFStd1+SJYaXlkmunXcbtFF1wrumfb98l7Qd3ZwtCKAvMWxwAehXLwdXsEcnVFvbo8+/s/ywaLgBn9vc9ZEuookOuTxz3K5QWOxwChZXlRqJTpvzmMOscFh24Zxa08klH08Lup8eFZsMWEi9ahwOjz82dXfiWgcsuO/Hqk/U06Ul1YkUceR11PC/Z6hG6r/K2fAq6rDQBD8G2xKQD7cGj66TeHXkmwudtka9TmN2tobvDQpPWyj+WlZRF0lpigUuJ1sCQtUOuEI3V+RCV4QTFqLAVepVgHrAOiFyV6k7jNluUT1gkYDF/RrKtmaBMn304HaU22f/Mfdobe1mbvBoMXhC8x/9f9WFvRSYZJNuois0IvkIAIEVCH2jxdLasH6V+BgmkQANxsLI7YmWni7rNnwlV/sYHCfM+ng== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5982.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(26005)(8676002)(6506007)(38070700005)(4326008)(2906002)(66476007)(9686003)(122000001)(7696005)(5660300002)(450100002)(110136005)(64756008)(186003)(66946007)(66556008)(66446008)(86362001)(53546011)(316002)(38100700002)(52536014)(508600001)(71200400001)(55016003)(83380400001)(76116006)(82960400001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TlgQQXH9iKDoWN3PFRXnbrQQ9Th+Vy3tVwuDekzQI2wsjpEhBcu+54MLXyEL?= =?us-ascii?Q?ZqLKsCASuxWkxK9hSySQiOUtp8wyKuAKpbv8lAzgIc98k5kHA6K9CGxahYA7?= =?us-ascii?Q?fL12No+IimHTpihvqzNxXvd5NJlUG1rvtePAxdoNW3uW7rsnI1TUpwUIysmR?= =?us-ascii?Q?AQxjKEBz9oKZUCWFE6J/bD8I0RJEYJEPfnnAR0Yr/nAH2HrHAyrQm602CkPu?= =?us-ascii?Q?86nlkSmqUy/Jb9qVNUEoa394C8JMbzXLivVUIGjJAXco/fXCk8pjU2dftoUU?= =?us-ascii?Q?GUI+OU1zYfk8KCWhq7Tyl/gFOtvqzlvOIQueLRJNJaHu6TSI95zWB2a2FvQa?= =?us-ascii?Q?0jpMApFTQSWH0AIVruWRWq7YXqXIEVZpVHrz++duLcTr9N4A19i8FESUeuW1?= =?us-ascii?Q?/PSiuRoTNeyiCBhY6Ls0HAnMjQKkl4sy1KQmKoi949Pin4iVUps8hOV2qqtZ?= =?us-ascii?Q?ulvsV2lF3RRZ97ByszJ3Zq3mnNN+ZSuFz7bPH4OkAKXxqTTvDPu4IDhjeFNx?= =?us-ascii?Q?4ciKql6oBpgLOY9S0m0GsgX862dSbR9a/1tN2GYujj8yeAs4rEB0IVpQWQN2?= =?us-ascii?Q?be7zRG+mZRFk8yri0uLpILL5BI8xApcfT2+MzTsJUwajj5GhfKAehftngla9?= =?us-ascii?Q?/YGOekyi2xSrCcYIoPtbT6EnNPLXfrGD0HH+IWmYT1wTiDrohyCvTkFRgox8?= =?us-ascii?Q?ldWkb8nwmmVtOIDkNL0rPUNRZdQLVrHa37xtargjTyDzSWcmaZJzTKEiNm70?= =?us-ascii?Q?9ifIUxgc2VwsR/4zOB/BYgUHq8GZTKB7VYVq8lu306H20HNNrYdon1n/D/Ks?= =?us-ascii?Q?fBp3yxLhe4KDIp3GiceLU9/nEnhA2hnq5dsQOgCq6lGw3aq98wO48IK/hlqR?= =?us-ascii?Q?V/r/TFi21Xbz6TRbxd22z7MnVTvalfQshEIn+j4VeZ7VHAsJwuXcSHdIXygh?= =?us-ascii?Q?F681ffm26/QNwx1xwNVtOkCH8e01T44PFSIABRqj1yox97KxLpgeKa0D8aAG?= =?us-ascii?Q?7x7QE3zXDz2G5pclC6WfX+BebkTg3Zkdx9B/CiSfp0iuBB24GQ8vwOQUqLQr?= =?us-ascii?Q?jP3pJdwiE5O47ClTfA9lMa+xEyVUNEIwcvMDDpBk973CiJBtdZdfOgr4vMQk?= =?us-ascii?Q?x0pOrFgXmUnyOmJ4CWk5LNFMp2eNZucVtRmTJo3CQQ0RVQiXH2o/YYrFVdr6?= =?us-ascii?Q?BIVj/Hc838D3mOVufq21fHjcdwcIpOJ6noAu+rcrj5t2FYuUouET7crNvLdH?= =?us-ascii?Q?LxatUL1p8suuDBEasVWL4Eq9PcJwO5BTszCL6xzuGK3rInQnEUNqpYcm5MJb?= =?us-ascii?Q?YNR4RJy4u1hV9HHLmsOmy2YJnFv8dzAhlboUpsiuf8h+/fEVnMYAnqqpGj+5?= =?us-ascii?Q?dY90hxRMCJpp5K5ZUNJ4yZytlwpqZKy+1oNfjE6+jsQKvQ/EJAE3wLkXt7wg?= =?us-ascii?Q?PZjA8hmo+FoAYlDB1f/P65NFAtPhQo9QlhNg4oDQGYGjrmvvs1OWFMbG3a+s?= =?us-ascii?Q?yLziYbxvdSa+NiGK1NRiCHk6nYvhMM3tAXgHZoEeavxbuxikAHGjJgr0VLar?= =?us-ascii?Q?cDs9V+LUdAQo3HtOKTuNKrDkN29rr5n5AXiHceu6rYQ+0cBaiUoQkZr2JXSs?= =?us-ascii?Q?mBi5wlhrIkZ24dGHO0OSGnVGyvY9D0+7h5XL69mIhsWy1C22Hnb3l453IxXx?= =?us-ascii?Q?hxbomYAk7rPHUIIaOuo7LYL0Rm2eLvqRfUPrYoLQCHVrUkL805KfpozxJRkr?= =?us-ascii?Q?0ck5dAo4og=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5982.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09cf0e0e-dc39-4777-bbee-08da38894b12 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 04:45:54.7384 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aEXAgPXoJKYV9i4bZYpYzwZnuO+W814fFy53j8vSwq2ylBvtYRswqlJdVtMIlUru8GovRjzY1mWthxfS239u2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1554 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Yang, Qiming > Sent: Monday, May 16, 2022 10:03 AM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Yang, Qiming ; stable@dpdk.org > Subject: [PATCH] net/iavf: fix mask not allowed issue >=20 How about "fix invalid flow mask handling" > Only zero-mask and full-mask for IPv4/UDP/TCP/SCTP addr/port are supporte= d > in current code. Otherwise will return failure when parse pattern. >=20 > Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qiming Yang > --- > drivers/net/iavf/iavf_fdir.c | 150 +++++++++++++++++++++-------------- > 1 file changed, 89 insertions(+), 61 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c = index > b63aaca91d..356bca8d41 100644 > --- a/drivers/net/iavf/iavf_fdir.c > +++ b/drivers/net/iavf/iavf_fdir.c > @@ -802,6 +802,14 @@ iavf_fdir_parse_pattern(__rte_unused struct > iavf_adapter *ad, > return -rte_errno; > } >=20 > + /* Mask for IPv4 src/dst addrs not supported */ > + if (ipv4_mask->hdr.src_addr && > + ipv4_mask->hdr.src_addr !=3D UINT32_MAX) > + return -rte_errno; > + if (ipv4_mask->hdr.dst_addr && > + ipv4_mask->hdr.dst_addr !=3D UINT32_MAX) > + return -rte_errno; Do we need to call rte_flow_error_set before return -rte_errno?