RE: [PATCH] app/testpmd: fix compile error

["Zhang, Ke1X" <ke1x.zhang@intel.com>]

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Wednesday, February 8, 2023 6:58 PM
> To: Zhang, Ke1X <ke1x.zhang@intel.com>; stable@dpdk.org; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Luca
> Boccassi <bluca@debian.org>; Xueming(Steven) Li <xuemingl@nvidia.com>
> Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Subject: Re: [PATCH] app/testpmd: fix compile error
> 
> On 08/02/2023 05:23, Ke Zhang wrote:
> > [ upstream commit f99f2e55af7a49a6ee6555a5554847094086017f]
> >
> > variable 'c' is set but not used, it should be cleard.
> >
> 
> This is a partial backport of
> commit 2809981e858f ("app/testpmd: fix build with clang 15 in flow code")
> 
> Commit is already in 22.11 and already backported to 20.11 and 21.11. So this
> patch can be ignored. Guessing it was intended for 19.11 only but forgot tag
> and was resent later with the 19.11 tag.

Thanks for you information.
will this commit 2809981e858f be merged into 19.11 later?

 
> 
> thanks,
> Kevin.
> 
> > Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow
> > API")
> >
> > Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
> > ---
> >   app/test-pmd/config.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> > 9f96e77ba3..a04ce0ec64 100644
> > --- a/app/test-pmd/config.c
> > +++ b/app/test-pmd/config.c
> > @@ -1457,7 +1457,6 @@ port_flow_destroy(portid_t port_id, uint32_t n,
> const uint32_t *rule)
> >   {
> >   	struct rte_port *port;
> >   	struct port_flow **tmp;
> > -	uint32_t c = 0;
> >   	int ret = 0;
> >
> >   	if (port_id_is_invalid(port_id, ENABLED_WARN) || @@ -1490,7
> +1489,6
> > @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule)
> >   		}
> >   		if (i == n)
> >   			tmp = &(*tmp)->next;
> > -		++c;
> >   	}
> >   	return ret;
> >   }