From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C541542D8B for ; Thu, 29 Jun 2023 10:03:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B09E242BAC; Thu, 29 Jun 2023 10:03:54 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 2E6EB406B7; Thu, 29 Jun 2023 10:03:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688025832; x=1719561832; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NR7vHJdFWsi4zXe1uesVKg/V1BrW6p4Rd50L9KJ4JGo=; b=kwyOQX3Twpo/rq6cBArhBH+DmRoXGfVUO2/BxG5HAzh9m4RpeOTNpDky lYqElGtru+ZVw8f0+G1+HIFwxi2bi4WCOjsTsOJQhxUXoXxmhhHs27jV+ r8u+3RoKQTifzYPkWguEQqv5swKzxu6GydpsORwxDT5Z6KNbDgRpRXAy/ dhv3mhnHjIkM8QjqKTGqpJmXjoT13GtjIy8tYDTG9rWvqwU98pFrY3tOp s8HvEhyP1zhNKyqSmFfrfCbJPWwhFrGTG9QiwY9W3Gz13KxTdwf1R2hm4 BshkgMPV21yw36tFk4m6QvQKkYYgqjYUSQEpjdAzsf2WsJQluog9+SW+x A==; X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="425720336" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="425720336" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 01:03:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="752566573" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="752566573" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 29 Jun 2023 01:03:51 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 29 Jun 2023 01:03:50 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 29 Jun 2023 01:03:50 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 29 Jun 2023 01:03:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=awpqBiE9aTXyXOGhfxOGeWm3sfFu754EGCvtOS1IrcYZxMZepSb7mC+gaiKO1/h8w3T4WMzi2Gag3RaRJYiBQlWVFlPAXdXDt+ajsd+AvV5VrXEHqoaG95BSJM+Q+m1rn/GN3NNiXrLQdyXnAnVoIxudRNpPiTrlJJrIbFQwbRwqrxOf/LwqryD93nDBrTnIdeGZ+AsjZcBSWveYEL1aox9EKnfaMSHF2XCyyopaArupZJTWp7WLR7fX9YK0bfEHoUwlVYw6CKcZzmKn6dFhlznUsDEWu3ltSreNMeFywArPCANeIXkhmZNWB0NcMUpC+6yVhqPokytsvYdGrsLdQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IHPX4QXjQlQLZFbht1VonmaSOv9rXthxVYXnuEGw3/8=; b=jCVNo3fSHljxiE85z0u2HTSo8JZ+9s4BjfpL2wNIqlJ2lIkCpgSPlkVMLIOFw9rnQ/0wWURcjv/ZIlpesNtrYmTRcejYFxXAYAvIsSuiPgktNAwTK6wcMld4+bCMTqiqlCAbN52y3VyfjxmHZmUYWAKTNIAr2AQdZvsC3yzJM0oV4hjl3gYCvstbJDNTFraViCeueIii3I89zLAfUPFtUROPYQf1N1aaINMhv5w2hADzIUB7gHJ062Xj2ffjMMPX8zfODq31TBJeyM2sgO9yTVdHFi0s3+JdKmnEXtywlLViNdhfWYXPgRyGCx4OnKtZEpAHx67EjWxUP+GY21N9nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB6006.namprd11.prod.outlook.com (2603:10b6:510:1e1::13) by IA1PR11MB7679.namprd11.prod.outlook.com (2603:10b6:208:3f1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Thu, 29 Jun 2023 08:03:48 +0000 Received: from PH7PR11MB6006.namprd11.prod.outlook.com ([fe80::5668:6366:b2de:1b5e]) by PH7PR11MB6006.namprd11.prod.outlook.com ([fe80::5668:6366:b2de:1b5e%7]) with mapi id 15.20.6521.023; Thu, 29 Jun 2023 08:03:48 +0000 From: "Ling, WeiX" To: "Guo, Junfeng" , "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" , "He, Xingguang" , "Laatz, Kevin" , "Guo, Junfeng" Subject: RE: [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops Thread-Topic: [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops Thread-Index: AQHZqaDUNbGCan56z0Wq6niG/8nCoq+hbRKw Date: Thu, 29 Jun 2023 08:03:48 +0000 Message-ID: References: <20230614051423.176572-1-junfeng.guo@intel.com> <20230628091218.32292-1-junfeng.guo@intel.com> In-Reply-To: <20230628091218.32292-1-junfeng.guo@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6006:EE_|IA1PR11MB7679:EE_ x-ms-office365-filtering-correlation-id: 619d84c6-cb2c-4c6f-5c57-08db78775e96 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TznG77FSW6wLLfgs4rX2WBJEGpmG98uScF89O+yPhre6r0nbl2/x0KW2YI7unQ3LiIh4aKIljjY0LOkkNAxtDQCZSeRPnH1oNNAeEs8z1rz9/IpQ/OwxGyazDg/o/mMaakJACll4BuNCczLtfCumKQ18atKUuZLeTfFYSKOF+SiKW1m/O+80YS4cjUmm1K8EhciWpFy6GpxG8NvVjhyPt+ki0cyuwpwgvQapsUMibUXGvOFgfcWWeDJFB9Gr+5K/RdX8AoSZmXSlqZNSM47FW5jfhKfejzQ1k0n0g5rXAs+f09qvtuT1/QSvVq3ZImUvsuIdQC7vvLqAuZVVa9ZtGB6rvO6vxHcjXs7vivUu7kknwyOupml6nrFJh7ytNaDWMQRxcaq1/Z2Qj0xbAr9XQkynkhmUc37hMTrJUydJHJPw5KV8s0pViYXP7Kt6MFS7xqT+PnoYOZXwxHicKGcE9i3+ob4ebo1nNrX2wEyPzki+rtuifmt73Xr06hpmt62o49p4zweBjN22XTkrVyz82pyXmbHoVDzrT1abcsWj5wSw1bETd+HW4k4+vXxWh87rrwe9qcI2oFzzKIC9hq56Gj97JXyQSU7iVv278kn7lB5nc2pFOPR4gflfTxmvOrqK x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6006.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(396003)(346002)(136003)(376002)(366004)(451199021)(66446008)(38070700005)(66556008)(66476007)(4326008)(66946007)(122000001)(86362001)(33656002)(316002)(41300700001)(8936002)(6636002)(55016003)(450100002)(82960400001)(5660300002)(52536014)(8676002)(64756008)(38100700002)(76116006)(478600001)(6506007)(107886003)(26005)(2906002)(9686003)(186003)(7696005)(71200400001)(54906003)(53546011)(83380400001)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z8Lst5kEszqizLou7r/fIA9C4AGPPMlNN9VpS5jw/Bcnagn51nY+zqZ1PET/?= =?us-ascii?Q?W1jsLS1tdn3ozclLRqTygTHOZiBdSBOoQzqTMUvgiiNAjZiJ7lhMJsUIIWQ3?= =?us-ascii?Q?uAed4Q1UFBoz3sZHbs+klBy/rIsivSWCNf6l9WkMNjuAU/ygZFVq/DdpZ5Gb?= =?us-ascii?Q?o39LdTx/GixgdFiRu3bZVeYeM61ZMPlvdz586ul2I1h1jHXl39IT+t0kZM4r?= =?us-ascii?Q?vZO4axw9Qj6PT0P51C+8urzJsMQSm4oYUaZu6f8hz5X0dVB56+i6c4kypxHH?= =?us-ascii?Q?zpuisV+mF57SLb30aesmJYva6NOWRVlXXibJRJf0gVPCjnbSo2TLo6eCgPwq?= =?us-ascii?Q?lyaCnHSli3aL0G0KXrTqfxUYSoJbXtpNZx+LJXnoDbnfi1mHu3GRPRYp1t1j?= =?us-ascii?Q?B7iklPuRdCWkw9Xp5JBXraYgfo2esNazHVT4NMQmZrIdV8cgLNDbvEPbe6r9?= =?us-ascii?Q?Fn/pVOXaZWxKU7awjTu0BE5hOgdulNkR2bhknJQl+jIWDA8IcqL6wE95qy35?= =?us-ascii?Q?umbnKizRlSUNQKUORwhAGMCI5oABLjF1CZFGx7kQdWZeQWIjRTLUkzvY6U8c?= =?us-ascii?Q?VrlbUXkoDInut5SAUySs06pnZ4Dy3IlK2xBwS4AQLEldVtamBwOe7podzASJ?= =?us-ascii?Q?YCGZOeigT3gEy1gxhbVJBAz2IYnbEOke2fGPG1V2bcRXQ8rs/ifLVjcz9/bh?= =?us-ascii?Q?PbgZkogepOHzXoyljEVCuKEtypk/z4MDDGXVfG/lI3coqfE8HoaFXNUl53bp?= =?us-ascii?Q?1k3jSZrr3hZL80PyV5iUNvIdiKd+AR5u1MJpa5a2DbMM3/5MewMqmSoD0HZA?= =?us-ascii?Q?+P9GE5mY3u0YYPE0ZtvePZMTeWTAOvx6naY4IjSPOkaEQVQdeezDpOsBnLO4?= =?us-ascii?Q?GmUWm1McyodclmXkWmOPahJhE0u6cBZNy25ZxIPNeegkYv+WJM78s4wkTiG/?= =?us-ascii?Q?eOERVC8OZKjRmYXaW+HqFYe+pkTZitPIYzk7FjRiioAWMDLtNiST44ZYyggM?= =?us-ascii?Q?NYvqQAU7+41bdMYEIaM0qjVFT3eEaSeY5E6UmWsjWdcTZWVdJeEHWSk9wc5m?= =?us-ascii?Q?R0BWKCfeZHwhu9Z4MNboswavMo/ADMB3u/A61TZV+Z/1IaasunC1c9AUiL7T?= =?us-ascii?Q?vH0KGnav1TKEaKmux5Jvj4gd8Ojk3R6V92JSh8677pzRNBDoJuxSonRiquRW?= =?us-ascii?Q?Gq9kH27RzJVcCywhXadCNrdsMpcC6UJU737DIDsT4hM9azr+wd0SX3SNvvAe?= =?us-ascii?Q?W3jIdF6G+yD8Bj3g47Wj5yD8fFlkM2LPsoniXfUUZ4MywRBhw2A7fK5AWNpJ?= =?us-ascii?Q?UMDHO8oPowPPjHfik0BVPaKFsF6FpimxWstG6Sdsp0E6j1CYHN9NiqsohDga?= =?us-ascii?Q?+N7RU5a9pPt58ztWCcCF7fsp+Qud+gE316XfQZ0/moMZ+W84FnGBUHGDj1XZ?= =?us-ascii?Q?Y158F3vgw2H+2PD/V5vcd0Pf51hSnr2ze+qaD1h50UnhBqiAENiypXS4bHaw?= =?us-ascii?Q?a8nakJfZxioPcvYO6bZcSKx0a9mzu93TtQhTP2iI3IOJmv3xdXqQ7K4LlBBs?= =?us-ascii?Q?4Vc6/3SdhmOH+6XxDBQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6006.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 619d84c6-cb2c-4c6f-5c57-08db78775e96 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2023 08:03:48.6336 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LRq+gZfbAmFMV4pu17Bpxg12wY9CaCciYDvF6CBjVMc/FprbAaVdBhF2angM5Pl6Mk53yEAeZnz7yids4BDNEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7679 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Junfeng Guo > Sent: Wednesday, June 28, 2023 5:12 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; stable@dpdk.org; He, Xingguang > ; Laatz, Kevin ; Guo, > Junfeng > Subject: [PATCH v2] raw/ntb: add check for disabling interrupt in dev clo= se > ops >=20 > During EAL cleanup stage, all bus devices are cleaned up properly. > In the meantime, the ntb example app will also do the device cleanup > process, which may call the dev ops '*dev->dev_ops->dev_close' twice. >=20 > If this dev ops for ntb was called twice, the interrupt handle for EAL wi= ll be > disabled twice and will lead to error for the seconde time. Like this: "E= AL: > Error disabling MSI-X interrupts for fd xx" >=20 > Thus, this patch added the check process for disabling interrupt in dev_c= lose > ops, to ensure that interrupt only be disabled once. >=20 > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junfeng Guo > --- > drivers/raw/ntb/ntb.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 Tested-by: Wei Ling