From: "Ling, WeiX" <weix.ling@intel.com>
To: "Wang, YuanX" <yuanx.wang@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>,
"He, Xingguang" <xingguang.he@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] examples/vhost: Fix retry logic on Rx
Date: Thu, 26 May 2022 09:30:47 +0000 [thread overview]
Message-ID: <PH7PR11MB600665E88258AAAC18018876EED99@PH7PR11MB6006.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220518162505.1691401-1-yuanx.wang@intel.com>
> -----Original Message-----
> From: Wang, YuanX <yuanx.wang@intel.com>
> Sent: Thursday, May 19, 2022 12:25 AM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
> <xingguang.he@intel.com>; Ling, WeiX <weix.ling@intel.com>; Wang, YuanX
> <yuanx.wang@intel.com>; stable@dpdk.org
> Subject: [PATCH] examples/vhost: Fix retry logic on Rx
>
> drain_eth_rx() uses rte_vhost_avail_entries() to calculate the available
> entries to determine if a retry is required.
> However, this function only works with split rings, and calculating packed
> rings will return the wrong value and cause unnecessary retries resulting in a
> significant performance penalty.
>
> This patch uses the difference between tx burst and rx burst as a retry
> condition, and introduces enqueue_pkts() to reduce code duplication.
>
> Fixes: 4ecf22e356 ("vhost: export device id as the interface to applications")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> ---
Tested-by: Wei Ling <weix.ling@intel.com>
next prev parent reply other threads:[~2022-05-26 9:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 16:25 Yuan Wang
2022-05-26 9:30 ` Ling, WeiX [this message]
2022-06-17 7:01 ` [PATCH v2] examples/vhost: fix retry logic on eth rx path Yuan Wang
2022-06-20 3:20 ` Xia, Chenbo
2022-06-20 7:36 ` David Marchand
2022-06-20 7:49 ` Xia, Chenbo
2022-06-20 8:59 ` Hu, Jiayu
2022-06-20 9:09 ` Xia, Chenbo
2022-06-20 9:19 ` Wang, YuanX
2022-06-20 9:33 ` Xia, Chenbo
2022-06-20 9:42 ` Hu, Jiayu
2022-06-21 13:34 ` Xia, Chenbo
2022-06-22 2:26 ` Wang, YuanX
2022-06-22 6:27 ` [PATCH v3] " Yuan Wang
2022-06-22 7:23 ` Maxime Coquelin
2022-06-22 8:50 ` Wang, YuanX
2022-06-22 9:25 ` [PATCH v4] " Yuan Wang
2022-06-23 2:57 ` Xia, Chenbo
2022-06-23 7:20 ` Ling, WeiX
2022-07-01 13:57 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB600665E88258AAAC18018876EED99@PH7PR11MB6006.namprd11.prod.outlook.com \
--to=weix.ling@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=xingguang.he@intel.com \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).