From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63CD442CC4 for ; Thu, 15 Jun 2023 10:29:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BBDA41104; Thu, 15 Jun 2023 10:29:01 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id F0E8F40A84; Thu, 15 Jun 2023 10:28:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686817738; x=1718353738; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FTdevxO0QQN/y82pORQBxzQfzCevDPz3PB/4QK1VMn0=; b=SGPAjusFxRAi+d6uiuyhj2em9U61iQKo7RmY3Coj3XHwYfqy6cRF6Evh PbffwfsWSTxjVxErndcmImmxiAFY+0ubOlPB1VC6I4zotRN20F74EYuZN 6FQ09QCptLipO9h0odcaOy3g1rgrroK1+B9xmGruRo2BbSsFHtWm1Hsuz xK70SYu1hlEx1wer727vWiW4/ZIO4a9xRvU8GsGL8Zn4+z7lYultWWtYj VYAbHPBI/14oqdC00OCdi7SPVLDKVhHVhE0OLVW+MciwKp7+dkJe5lwN7 +cM494xoBRO/wS1tBGvfi8BtnekFqubzXq0mBn5VCp9RhVM8jg7dMmSgF A==; X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="361331630" X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="361331630" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 01:28:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="836528966" X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="836528966" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 15 Jun 2023 01:28:10 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 01:28:10 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 15 Jun 2023 01:28:10 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 15 Jun 2023 01:28:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KkzMpu36144Oh/csn+VfnXWynySu+aL2ZvRhR27D8BgixuJ5kS7I5+GFy/+mkL9SloUbza5iiqIg1HsLfgbAT4W3RLksptJf+kFDRp6fZwk6JsvJspy0zmzkH12L7ESlooHeOhzAbocibJTsL3Vt6Nb5zRM7AafHbkI2IzPBcAPsg/MkcM7QXM4+CCERZnwdWM2MSiX1zWNMFqNxWpePnEgmAFUcdn3qM9e7l4Rv/Iws4hdvy1nX9sSnnmtURYH5dpXF5pNN6jZIb/NxkJSBJBzv8jMk5mmseD2gYFlhyMr6xSjbbe/qr6yyKli0Ankv8dXbh72sJZEThyHUD+B/Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FTdevxO0QQN/y82pORQBxzQfzCevDPz3PB/4QK1VMn0=; b=bVs146SytQlQKGYkWu6+aAOulnj8hSdtEspB8aAE/JiBUlCt360CFctqruyMiXOGDFmBJy9VMSp/59V5QSYLWN0ZCobdNESZzMus4+rMSgkf6A8lGYniPdBKZrho99bwwUBX96M0E9IUoNHGugmwgXbO20kQu62LMoqBKNQ+P3+W7hSonvETtM0p333F4lfZsxYcJwh86h7SwCgld7sKFwzeD4xli7qgnXrg3EmBpBI9pXDQ96qle5kguzRd+qR/1P+kDFFTyCR4BhkLBkIm0nZMSZ9YQoOIuniohW3RaKCOp47f5egp0A9yUFgKgkmbWBMLq+0XU9FbGpgPAH3dsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB6006.namprd11.prod.outlook.com (2603:10b6:510:1e1::13) by BN9PR11MB5306.namprd11.prod.outlook.com (2603:10b6:408:137::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Thu, 15 Jun 2023 08:28:06 +0000 Received: from PH7PR11MB6006.namprd11.prod.outlook.com ([fe80::5668:6366:b2de:1b5e]) by PH7PR11MB6006.namprd11.prod.outlook.com ([fe80::5668:6366:b2de:1b5e%7]) with mapi id 15.20.6477.037; Thu, 15 Jun 2023 08:28:06 +0000 From: "Ling, WeiX" To: "Guo, Junfeng" , "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" , "He, Xingguang" , "Laatz, Kevin" , "Guo, Junfeng" Subject: RE: [PATCH] examples/ntb: remove redundant logic for dev close Thread-Topic: [PATCH] examples/ntb: remove redundant logic for dev close Thread-Index: AQHZnn8nxdDVaCldUUyb3F8Qkt3TW6+LiPyQ Date: Thu, 15 Jun 2023 08:28:05 +0000 Message-ID: References: <20230614051423.176572-1-junfeng.guo@intel.com> In-Reply-To: <20230614051423.176572-1-junfeng.guo@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6006:EE_|BN9PR11MB5306:EE_ x-ms-office365-filtering-correlation-id: 06558bcd-02b3-4fcf-b4b1-08db6d7a7157 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vp+dGJNbf1RryxAAE/QMEXkJlPMVj5mP7T2qA0p4oHkH4SkfJs1iXiw+2LZXMV0uOJUkYaEeAxQ2l5Ag/1yVFIkIA8firfp8Y1oM3YeCfVE6Nas4UEI9tvebXn7trfrFoTIny0qok49t2Hhfbx34sZIMYn61yCNSh8cqAmC0fboC1Gse5d4sFU1P7VTtIqZd5jNpDgn1OEM+5AI17VHl5tHqHKjNNBgoiTqlI96G/Mh8Qn+vRU60eEU3kThlU2uDOu5ERB9w/cibS3JD8nhgbB+khycKd3HFH2Mmj8/kHGpprTBK5A3w0YLtODjTwIkgDAyXUb76s5E4BxMSiDRtXYIDTvn5AQf5Z2S1Ci7CiZpQgo9NwV033uR1qxWSG+T6y0VCbmxYJLQqZ/xoMFYiuiqB56MQkaOZc5NGovyurad7719yUd2fc8ONTDNWgqf9XrNKKc9O9OhPLojjiqblhB/4h46OmOoqzVZAE8brpFciJGn6TjiJLCcVePHLgSlDUhBL+DArIIHRiSAYyt/Csx55G/DNq2Y3yFoEXpakqUUxfGbKg+6aBXULrtP7wrDJgSPKfPrw/Cc+gmcy5PG8MO8zpCOZwbIqw0aBshbVvR9AXICnBhVuvxspMKsfWhTs x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6006.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(396003)(346002)(136003)(366004)(39860400002)(451199021)(55016003)(26005)(53546011)(9686003)(6506007)(82960400001)(107886003)(38070700005)(122000001)(38100700002)(86362001)(186003)(33656002)(52536014)(5660300002)(4744005)(2906002)(71200400001)(83380400001)(450100002)(110136005)(54906003)(64756008)(41300700001)(8936002)(8676002)(478600001)(66556008)(66946007)(316002)(6636002)(76116006)(66476007)(66446008)(4326008)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UMUf4lpZ5viJ0Uot2ptxk205/i2EUDEvyh5jGEcm0UWyx9uHeCeFqEbiAFBO?= =?us-ascii?Q?f+MNTCwpq9Z2On7LU/jeYQk3lxOa60rjQLnb6Nc7i+78ym/vsYb9oSDaQMVs?= =?us-ascii?Q?HevzLr5dh93SclMw0bo5VJ+wE/Caj26cf+WTO5sKC3sexp/sgoCgRe2yj9eV?= =?us-ascii?Q?X3FN5C16GpNSmCZuNbkxJDT7UcfOzM8tBlmc4UQ2TlzdEJPUQ+f9/u4nZ/B/?= =?us-ascii?Q?OjOC4R/7K+RlvzkJ5t/zPu+qiIJzeGaMve9EO31lqLJndMO+AbRbmvoWzMS5?= =?us-ascii?Q?YuYZdomFdeNkhofJzxZyh8iD64JLqvRr3HtqzkagXm5U/nPnZtoYpn4e7JDg?= =?us-ascii?Q?QPD61MTKGgroHcBqNEXhbsk2KvLBTYjI+dxq3aPagheBx0l97NheY9VHZIsi?= =?us-ascii?Q?r4cLcip42le7gQhvqowOoy+xZYQkQiRlkJMo1TSw22BZUiQnZ15FzkbsWl+S?= =?us-ascii?Q?CZyAR+NLVL1m8lo+zxOlC+AQbIKpF3tTfykL3Frrs3mVdgSghz3SvgCr36U1?= =?us-ascii?Q?0RRRK1jtNCrFTUoz5frqDPiRmJlU1jpnVqOMTBtLbs9JQCwr03jkl08FWh6P?= =?us-ascii?Q?RpPrkWECqzVW6UBkJWV3r9+wEgUa0VTcyjzvyZppaYxhx31ulqhyFKmNzPvK?= =?us-ascii?Q?f6Gca9oAodV7REm7Nemz/sRuRgD7m//ztEm76oPoDi30u1Vqb8werXhMsfJL?= =?us-ascii?Q?+iMw6P6kVBjCihBMs3RfBcnwi3vQ1RmtxMi3ORuXnGWBd37Zf/2OQUqfXt16?= =?us-ascii?Q?MGXdu3UfZuvnb6uWjIeNNZLnLmsytAfaB29pWLgdbBX7SpOkFKtuBfmnhJ0K?= =?us-ascii?Q?XZ2DUKeiJ3Cz9K/fb2CeHgrRWL6pbD7e6c5JTuMEQDPwMtZpiV2hH8qwbxH/?= =?us-ascii?Q?U87CGzU1pBPTIYvuObaHBPMp5KzV9GOcqo17Ae4b2XYfNg3vWGwmPODA3Z5Z?= =?us-ascii?Q?0qZTEzX1MeOkyXOFgWBcSroszLPcCOcpwELtlcPpCiwxIPZQPzDTor8d9blf?= =?us-ascii?Q?/IaUh4U1ErIwuTZsE649+Kv7UYef0etOAwXs3ei0il/gWUQn2VqluFXhTeY+?= =?us-ascii?Q?0qS+wj42gnJMV/+YriiiIMPMK4NoZvzCRAfBeRhpLVuxdig1evariMCfD4lH?= =?us-ascii?Q?d4ozTXLJvbazgsYzGbn4jOeAHMIYAbaeIb6+k7J3sAdwY6ibw6yWlSStPW7U?= =?us-ascii?Q?tcEkz5PahAGo/DZ/N91UjpFmqDHFw9U/cOzXEknTK955bZBFDpPH8GGHRs6H?= =?us-ascii?Q?v+LfPKtWEWW7a1E1EtTSBQjrnxQeYHPu2ECLE6M1K/BzAx8Kgo814gC9Sw2B?= =?us-ascii?Q?ZKs8MaBBzRZB87GMVj9WA0gIpmNp2ZCI6ajgsC8HeEo9mxzHsjSbskyXjz8q?= =?us-ascii?Q?XI78h0t1ODc0YWS2b5icdqIwEWXUC/OYn1lJTq05q/SwK+8PAnM8xtbdUHah?= =?us-ascii?Q?KHVSMABTU7lzQaYsXmgJ76ORqdCCaG/wBfezUK6BnmQznklrIHXTinSjtlah?= =?us-ascii?Q?HuHsOVY1xRgRA0d2okk31+SBhR44k0Ppv42aVR/DrWRVoz8k/QGabxutFEd1?= =?us-ascii?Q?G/Urk6YIvrMzltuTe4Ys9LvQxMVSlh69nLUIk4w4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6006.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06558bcd-02b3-4fcf-b4b1-08db6d7a7157 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2023 08:28:05.7656 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pg4OXjDXq6pm1C7S21X6tmicw2KGJlztzOn/4rSBjln3vmqfrp3bRQCFF8RIudmmKSfx2Rk5j9MvAcUHLNydVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5306 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Junfeng Guo > Sent: Wednesday, June 14, 2023 1:14 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; stable@dpdk.org; He, Xingguang > ; Laatz, Kevin ; Guo, > Junfeng > Subject: [PATCH] examples/ntb: remove redundant logic for dev close >=20 > During EAL cleanup stage, all bus devices are cleaned up properly. > Based on this, there is no need to do extra device close process, which m= ay > call the dev ops '*dev->dev_ops->dev_close' twice. >=20 > If this dev ops for ntb was called twice, the interrupt handle for EAL wi= ll be > disabled twice and will lead to error for the seconde time. Like this: "E= AL: > Error disabling MSI-X interrupts for fd xx" >=20 > Thus, this patch just remove the redundant logic for device close. > Ports will be closed at rte_eal_cleanup() in the main loop. >=20 > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junfeng Guo > --- Tested-by: Wei Ling