From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 602BAA0353 for ; Thu, 24 Feb 2022 03:32:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5947E40696; Thu, 24 Feb 2022 03:32:43 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 2000A40696 for ; Thu, 24 Feb 2022 03:32:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645669961; x=1677205961; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TP/3DoXBbp7LcQomO3ZBiAj38YbzpHE++SiWeWSE1Q4=; b=FLkSqXqy0hox/sDzDumz/nn7nHwqPGRwmH/a4oQSntNs0Oq3GGCZ99q4 09EgXzr+JgKAnZsYmYl23ttpcX35ovrI71I2MdO4fKoT1A9h9R2jrKE6e XuO59xGWogDQ7rUpfRd2aXYpLBcgk4kGi5+6DsG5gRwHSPfz8ohEZd/9d hLENp76IszaXqFzCqadjW1HsvTCFaieCVlPH/G5UL6428po3/hxD7O5lC IeSBdPYSR7HoXgFAgmvhi3tjPrE4BlhxbgY9OSluAG/QjqjnFkeCNysaE x0x4bZosqQNtbTg2fqKcuhVznEs2ffWoZqx6RA+Qn0m2O4DuNNMrSsIBE A==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="252053091" X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="252053091" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 18:32:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="532945896" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 23 Feb 2022 18:32:40 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 18:32:39 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 23 Feb 2022 18:32:39 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 18:32:39 -0800 Received: from PH7PR11MB6006.namprd11.prod.outlook.com (2603:10b6:510:1e1::13) by SN6PR11MB2592.namprd11.prod.outlook.com (2603:10b6:805:57::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Thu, 24 Feb 2022 02:32:37 +0000 Received: from PH7PR11MB6006.namprd11.prod.outlook.com ([fe80::8c39:9e21:9c14:9a28]) by PH7PR11MB6006.namprd11.prod.outlook.com ([fe80::8c39:9e21:9c14:9a28%4]) with mapi id 15.20.4995.027; Thu, 24 Feb 2022 02:32:36 +0000 From: "Ling, WeiX" To: "Liu, KevinX" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Yang, SteveX" , "Liu, KevinX" , "stable@dpdk.org" Subject: RE: [PATCH] net/ice: fix Tx offload path choice Thread-Topic: [PATCH] net/ice: fix Tx offload path choice Thread-Index: AQHYKJO5b5jLVmqP0EuoGhTcQk2uaKyh/BgQ Date: Thu, 24 Feb 2022 02:32:36 +0000 Message-ID: References: <20211224150925.3296471-1-kevinx.liu@intel.com> In-Reply-To: <20211224150925.3296471-1-kevinx.liu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3fda50c8-ecd5-41e2-3d9e-08d9f73debaf x-ms-traffictypediagnostic: SN6PR11MB2592:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aQa/W3wMdWrf/kW5/g4WXdJciCRRZ1fJmc+JnuaNKigTJnjr9RejpeUWbUT6Q2TKGSLl0sIOIceZHUgsGiJT9D8gla+YAlnm8OSfQCdOoY6ZY9eOZWsnMK/Ey7mFBen6dkosQRFQ8It4+Y1TpjpdmL0yqGsBl7ALxVhcE7MmXFLuCir+K0GM/pKYEiQRDixAIrgfAc36hmtX4T4FWhshWiItLZGUWFzMLIB/wpnEXl18O41y04vvWj/tUdHeE19h+PC+rbZWzNSbu1ucDYWqyFyfg43P1rN0V/6u9dKPybL2FJNqcJAkTuB58zH18hK9mssT333qj315hn+Ol95lbeJv4SBvEo9gWi7RVcoybt85BKprA6Tw4P6quCnXuJ0PbTUmp3GS4KNhD0MpxGS9QK56xhHyYPj0h3KjKNLAKSv9x238h6RPVTQZ2WIuVYq4o6gJwF/tFJYEFo7J9qB/WnmRnVI0vjs8xMgry7nSn3nihW+lsYjWrWQYZo/R2dChNZMhXrdB0EBAHDczbiYnM1EfQml7yLC6P3+iBtPh6pLbZXc270f+J2G3XiSLYikMLFlxOIyvMqRteZgMCln9DQWeeDt9iepSSOs5Drna2hsXQO5q+mHkF4TR2uyqVNDNa1m5+Lo6V4Y5BI1ZUONXrLC/3WM1rn8rHbz+CsLjYmOYmb6lBPPd58kh+T7zjCH3R3p4oG8+hhpJijHYUEi2nA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6006.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(38070700005)(186003)(55016003)(52536014)(2906002)(82960400001)(33656002)(8936002)(86362001)(38100700002)(122000001)(8676002)(4326008)(66946007)(66556008)(66476007)(66446008)(64756008)(450100002)(83380400001)(26005)(71200400001)(54906003)(316002)(76116006)(508600001)(7696005)(53546011)(6506007)(110136005)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VrEAACXgw7T+Rn1A9RCaoZfRsfMBOrLAfiSm2ecHliZZ1vp3l7CFzB63+uTO?= =?us-ascii?Q?BrX5+Elu5YiigDy97sZyuQs07OIs5BxMt9Ss2GOELn+M/yANQmWy7C45Xu89?= =?us-ascii?Q?H7dWGHtnaFMvlpRsnDJtejZ3Oho1TAOmdCcZA4KcBN1mwbSv9/fjdRRkPeEj?= =?us-ascii?Q?VsB7AqdFT/Mh5AnveCWRSrQ9cHty97+9Ry21WXQR5t9kvC+FO8MDkomixCnH?= =?us-ascii?Q?qEgnNGVEiE3iiGMrWz8WN5CM9w5oHzD1EacFeXAEcqcMxZRgPKYf/JB0Kr1a?= =?us-ascii?Q?9Nh4Qhb3WOY0UIQ2LqzNIKaZSQeWVLxTUgdqcXU+PO5Axs6287EFZ8G7epHn?= =?us-ascii?Q?XTxmds0K4raPdG25tkCreqpsyk5Z+7CYCIjFMtsGFqDBfd7dcQllqbo4Bf6g?= =?us-ascii?Q?FdKiNaye8iix1eUwBZGFtb84UVyHGm02h/QNZkQl9bENyaZxh7az93pxaHAl?= =?us-ascii?Q?XSV73XU/FkQfUiGrEh0ASVIDUy/eyq3muR+8TL6OZspLp7sQF5X9XUyRGnF6?= =?us-ascii?Q?eS/XIHFSm6d8dfSDNcYHE5kFmbTKaFxGArdJo5XoKN3fzBM48JSJIltBQz9f?= =?us-ascii?Q?MdbcI4S5op42lhcj5Q1Bo1Bl9P4KG/0R5eRSSnlK96yaGTueii93Zjl51ywL?= =?us-ascii?Q?Oov0sDdJ8/Bu2B5N6umbq1CL9IFAttqkIzfjgUludGXRB2jsxfno/uL5vWps?= =?us-ascii?Q?VI06BoKGD4GKuCgY7CsRyMytpwumiIla9YDN4Wygfh0EikVXvEWYlDG6KUDm?= =?us-ascii?Q?B3tedrC5HL72bfO+/fvaHUyd1lJefm6bfzmeqBsU/qdIX+IuClOTKTp1bZ9U?= =?us-ascii?Q?yHQQn8P4aYFQOCjUTH4tKxtCLhugovGbES/80zGJCV/VmAN5nQTrNfLqGKl3?= =?us-ascii?Q?doD74JEQrbwSOBSXrIcdNn4h0T4W8cxTdb3MKLhuGWHxz5UMJoIP4AEw3Unp?= =?us-ascii?Q?79w8UZQE0svM0nPH4G9Iv+gFFnkyK5fV9ZEVC0F7mrOe1PZt5irnqDcFqgqM?= =?us-ascii?Q?lA2VPDEpEAPnqyyKyvJEmGfWx8f/x016D4fLZdT13uUZqMLZLvCHR8NBV2cw?= =?us-ascii?Q?Ia8DQt98rPQpqzbe9d0c26HscxLSNIXpiDEBzDfDBfB+qnahOA3xEl2di3wL?= =?us-ascii?Q?RixBP/JXnd8Yltj0iR3wqvML9dCHH5iin7xzXswmWoQ8dJpKL5eFstDFJUcZ?= =?us-ascii?Q?TJXW8yN0U7NNZHS5ATYFooFXgduHWxFpHLrqHgvJosIW6QjnVg2gqM0pQo/+?= =?us-ascii?Q?FSdiTD0uc00qzyi1EFfiXv/IMgqha4W0xmyJz9gfb59x7Ywx3g6fsOYjtseJ?= =?us-ascii?Q?DtBl7izxx+mGA7dkofo2eV2Q4pkEgB1ah186HJdQtu1Eq4y74t0MZLFh5KUj?= =?us-ascii?Q?4H4RoFINHAn24D28yuzPQ9oDmU9vJ5HkqtGkUNY93FHsItGjr3zxNiTyPAUZ?= =?us-ascii?Q?tFyhjRUNOneTuzpO1Ui0sZkO9qngoHVkROwl2Gofeo7wGfWk91OEBY9nkpj8?= =?us-ascii?Q?QwjBd2UGcUQDTmvbVK6c7kXIU5maJyNhTed8+izUPAiXcMiruRXwGFaFjvyh?= =?us-ascii?Q?kNcTVTacyifq2pX50nZ1N8OHM7EmtpGWScSuO8ToESvb4P5sonNJ9YM+8LJE?= =?us-ascii?Q?Hw=3D=3D?= arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zu/hn4Nk4PHB6Pxyx9vTUOPZzK0aSUZ2NmJZ8i9Am5S0Kow+jgy2wajmd8jZZkECQceJ0mfpd354VKnVEFKBhhsAATu0JdKbzjDHUrkvPN6x4oUbErSKGuCxCaclznuvJ6ugjDPl3K5jABymE0xr8GgZvrIrl7ubJibtdSIyQRL2BVELQpPZpk5ukyZjhc/MKlCkWyC6aF1CtBTYpmP33Av7ubBej/OrflEj3zAP2IR92I1MRkX1ClfiSZs2i7D4mZY7IZC3Fz4r2B8ZHnJI132gyZhaorDapHqSGWCvR8N0wr10U1AXLVCV4n2+ocviRa2ezGx9CVHH8KsuZtv32w== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xH4kb//ZAJ84UN0fD70U9/iwHi6Bxck7EcwNygu4txM=; b=ZqLYvMnHzKm8onpROXDSkobC3+vFOw7/heddh7SGH2M3HTdu5SBdTMTM61bAtSLtVDq9aoKjUfbFNKTW6KWb4mBFEA2fFwQufo+b9JbcG/Zg6LkEm7eex/yLoQ9Cv5o+nZ7JOoGRi0gQdwdBZOtny3K1esk8QeJfzTxHd4oN1vqiVeGOGSRLmVI4QP3el82HJdBlSAKs53bncXyWTKsyWo0k3aVkmaLhCy89mO+FHUDLkOZU6iXioL0cbqlzPRCZDwmCYT9SMNnvpWJw2O515NueLQSz0entq5eStqrZhy/253KidJA2ph7A5KEDK8cJDCITH17o8QcYV2Gvp/78MA== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none x-ms-exchange-crosstenant-authas: Internal x-ms-exchange-crosstenant-authsource: PH7PR11MB6006.namprd11.prod.outlook.com x-ms-exchange-crosstenant-network-message-id: 3fda50c8-ecd5-41e2-3d9e-08d9f73debaf x-ms-exchange-crosstenant-originalarrivaltime: 24 Feb 2022 02:32:36.7741 (UTC) x-ms-exchange-crosstenant-fromentityheader: Hosted x-ms-exchange-crosstenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d x-ms-exchange-crosstenant-mailboxtype: HOSTED x-ms-exchange-crosstenant-userprincipalname: hmUaLlfVDueQm2I6exNCtt5Yx9BkA1LwQRbGtS/1WGp2dvm9eAcZBm9/2LejQAeHHwXe86521ZYzhdPJv63VEg== x-ms-exchange-transport-crosstenantheadersstamped: SN6PR11MB2592 x-originatororg: intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Kevin Liu > Sent: Friday, December 24, 2021 11:09 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, SteveX > ; Liu, KevinX ; > stable@dpdk.org > Subject: [PATCH] net/ice: fix Tx offload path choice > > Testpmd forwards packets in checksum mode that it needs to calculate the > checksum of each layer's protocol. > > When setting the hardware calculates the outer UDP checksum and the > software calculates the outer IP checksum, the dev->tx_pkt_burst in > ice_set_tx_function is set to ice_xmit_pkts_vec_avx2. > The inner and outer UDP checksum of the tunnel packet after forwarding is > wrong.The dev->tx_pkt_burst should be set to ice_xmit_pkts. > > The patch adds RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM to > ICE_TX_NO_VECTOR_FLAGS,set dev->tx_pkt_burst to ice_xmit_pkts.After > the tunnel packet is forwarded, the inner and outer UDP checksum is corre= ct. > > At the same time, the patch of "net/ice: fix Tx Checksum offload" will ca= use > interrupt errors in a special case that only inner IP and inner UDP check= sum > are set for hardware calculation.The patch is updating > ICE_TX_NO_VECTOR_FLAGS, the problem can be solved, so I will restore the > code modification of that patch. > > Fixes: e6b9d6411e91 ("app/testpmd: add SW L4 checksum in multi- > segments") > Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path") > Fixes: 295968d17407 ("ethdev: add namespace") > Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") > Cc: stable@dpdk.org > > Signed-off-by: Kevin Liu > --- Tested-by: Wei Ling