From: "Liao, TingtingX" <tingtingx.liao@intel.com>
To: "Ye, MingjinX" <mingjinx.ye@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Zhou, YidingX" <yidingx.zhou@intel.com>,
"Ye, MingjinX" <mingjinx.ye@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Liao, TingtingX" <tingtingx.liao@intel.com>
Subject: RE: [PATCH v7] net/ice: fix ice dcf control thread crash
Date: Wed, 10 May 2023 09:34:39 +0000 [thread overview]
Message-ID: <PH7PR11MB6859066E0BA05BF4FF2DE1A892779@PH7PR11MB6859.namprd11.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1806 bytes --]
> -----Original Message-----
> From: Mingjin Ye <mingjinx.ye@intel.com<mailto:mingjinx.ye@intel.com>>
> Sent: Tuesday, April 11, 2023 10:09 AM
> To: dev@dpdk.org<mailto:dev@dpdk.org>
> Cc: Yang, Qiming <qiming.yang@intel.com<mailto:qiming.yang@intel.com>>; stable@dpdk.org<mailto:stable@dpdk.org>; Zhou, YidingX <yidingx.zhou@intel.com<mailto:yidingx.zhou@intel.com>>; Ye, MingjinX <mingjinx.ye@intel.com<mailto:mingjinx.ye@intel.com>>; Zhang, Ke1X <ke1x.zhang@intel.com<mailto:ke1x.zhang@intel.com>>; Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>
> Subject: [PATCH v7] net/ice: fix ice dcf control thread crash
>
> The control thread accesses the hardware resources after the resources were released, which results in a segment error.
>
> The 'ice-reset' threads are detached, so thread resources cannot be reclaimed by `pthread_join` calls.
>
> This commit synchronizes the number of "ice-reset" threads by adding a variable ("vsi_update_thread_num") to the "struct ice_dcf_hw" and performing an atomic operation on this variable. When releasing HW resources, we wait for the number of "ice-reset" threads to be reduced to 0 before releasing the resources.
>
> Fixes: c7e1a1a3bfeb ("net/ice: refactor DCF VLAN handling")
> Fixes: 3b3757bda3c3 ("net/ice: get VF hardware index in DCF")
> Fixes: 7564d5509611 ("net/ice: add DCF hardware initialization")
> Fixes: 0b02c9519432 ("net/ice: handle PF initialization by DCF")
> Cc: stable@dpdk.org<mailto:stable@dpdk.org>
>
> Signed-off-by: Ke Zhang <ke1x.zhang@intel.com<mailto:ke1x.zhang@intel.com>>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com<mailto:mingjinx.ye@intel.com>>
Tested-by: Tingting Liao <tingtingx.liao@intel.com<mailto:tingtingx.liao@intel.com>>
[-- Attachment #2: Type: text/html, Size: 6482 bytes --]
next reply other threads:[~2023-05-10 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 9:34 Liao, TingtingX [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-22 5:56 [PATCH v6] " Mingjin Ye
2023-04-11 2:08 ` [PATCH v7] " Mingjin Ye
2023-05-15 6:28 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB6859066E0BA05BF4FF2DE1A892779@PH7PR11MB6859.namprd11.prod.outlook.com \
--to=tingtingx.liao@intel.com \
--cc=dev@dpdk.org \
--cc=mingjinx.ye@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).