RE: [PATCH v2 1/4] crypto/ccp: remove some printf

["Uttarwar, Sunil Prakashrao" <SunilPrakashrao.Uttarwar@amd.com>]

[Public]

Acked-by: Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>

-----Original Message-----
From: David Marchand <david.marchand@redhat.com> 
Sent: Tuesday, October 4, 2022 3:21 PM
To: dev@dpdk.org
Cc: gakhil@marvell.com; Uttarwar, Sunil Prakashrao <SunilPrakashrao.Uttarwar@amd.com>; stable@dpdk.org; Kumar, Ravi1 <Ravi1.Kumar@amd.com>
Subject: [PATCH v2 1/4] crypto/ccp: remove some printf

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


A DPDK application must _not_ use printf.
Use log framework.

Fixes: ef4b04f87fa6 ("crypto/ccp: support device init")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/crypto/ccp/ccp_dev.c     | 4 ++--
 drivers/crypto/ccp/ccp_pci.c     | 3 ++-
 drivers/crypto/ccp/rte_ccp_pmd.c | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/crypto/ccp/ccp_dev.c index 424ead82c3..9c9cb81236 100644
--- a/drivers/crypto/ccp/ccp_dev.c
+++ b/drivers/crypto/ccp/ccp_dev.c
@@ -362,7 +362,7 @@ ccp_find_lsb_regions(struct ccp_queue *cmd_q, uint64_t status)
                if (ccp_get_bit(&cmd_q->lsbmask, j))
                        weight++;

-       printf("Queue %d can access %d LSB regions  of mask  %lu\n",
+       CCP_LOG_DBG("Queue %d can access %d LSB regions  of mask  
+ %lu\n",
               (int)cmd_q->id, weight, cmd_q->lsbmask);

        return weight ? 0 : -EINVAL;
@@ -709,7 +709,7 @@ ccp_probe_devices(struct rte_pci_device *pci_dev,
                snprintf(dirname, sizeof(dirname), "%s/%s",
                             SYSFS_PCI_DEVICES, d->d_name);
                if (is_ccp_device(dirname, ccp_id, &ccp_type)) {
-                       printf("CCP : Detected CCP device with ID = 0x%x\n",
+                       CCP_LOG_DBG("CCP : Detected CCP device with ID = 
+ 0x%x\n",
                               ccp_id[ccp_type].device_id);
                        ret = ccp_probe_device(ccp_type, pci_dev);
                        if (ret == 0)
diff --git a/drivers/crypto/ccp/ccp_pci.c b/drivers/crypto/ccp/ccp_pci.c index 38029a9081..c941e222c7 100644
--- a/drivers/crypto/ccp/ccp_pci.c
+++ b/drivers/crypto/ccp/ccp_pci.c
@@ -11,6 +11,7 @@
 #include <rte_string_fns.h>

 #include "ccp_pci.h"
+#include "ccp_pmd_private.h"

 static const char * const uio_module_names[] = {
        "igb_uio",
@@ -41,7 +42,7 @@ ccp_check_pci_uio_module(void)
                rewind(fp);
        }
        fclose(fp);
-       printf("Insert igb_uio or uio_pci_generic kernel module(s)");
+       CCP_LOG_DBG("Insert igb_uio or uio_pci_generic kernel 
+ module(s)");
        return -1;/* uio not inserted */  }

diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c b/drivers/crypto/ccp/rte_ccp_pmd.c
index 013f3be1e6..7338ef0ae8 100644
--- a/drivers/crypto/ccp/rte_ccp_pmd.c
+++ b/drivers/crypto/ccp/rte_ccp_pmd.c
@@ -250,7 +250,7 @@ cryptodev_ccp_create(const char *name,
                goto init_error;
        }

-       printf("CCP : Crypto device count = %d\n", cryptodev_cnt);
+       CCP_LOG_DBG("CCP : Crypto device count = %d\n", cryptodev_cnt);
        dev->device = &pci_dev->device;
        dev->device->driver = &pci_drv->driver;
        dev->driver_id = ccp_cryptodev_driver_id;
--
2.37.3