patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Bing Zhao <bingz@nvidia.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	Suanming Mou <suanmingm@nvidia.com>
Cc: Dariusz Sosnowski <dsosnowski@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	Ori Kam <orika@nvidia.com>, Matan Azrad <matan@nvidia.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] doc: update match with compare result item limitation
Date: Mon, 11 Nov 2024 08:15:14 +0000	[thread overview]
Message-ID: <PH7PR12MB69054D47C063C7188FFB9B2DD0582@PH7PR12MB6905.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20241106102919.0171a9cc@hermes.local>

@Suanming Mou, could you please reword the description as Stephen suggested and send a new version?
Hi, @Stephen Hemminger, PSB. Rule should be item, that would be more accurate.

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, November 7, 2024 2:29 AM
> To: Suanming Mou <suanmingm@nvidia.com>
> Cc: Dariusz Sosnowski <dsosnowski@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Matan Azrad <matan@nvidia.com>; dev@dpdk.org;
> stable@dpdk.org
> Subject: Re: [PATCH] doc: update match with compare result item limitation
> 
> External email: Use caution opening links or attachments
> 
> 
> On Tue, 5 Nov 2024 09:47:36 +0800
> Suanming Mou <suanmingm@nvidia.com> wrote:
> 
> > +  - In switch mode, when ``repr_matching_en`` flag is enabled in the
> devarg,
> > +    the match with compare result item is not supported to the
> ``ingress``
> > +    rule as an implicit REPRESENTED_PORT need to be added to the
> matcher.
> > +    That REPRESENTED_PORT item conflicts with the single item
> limitation for
> > +    match with compare result item.
> 
> These sentences are hard to read, the wording is very awkward.
> 
> Have no detailed insight into the mlx5 matching but maybe this wording:
> 
> In switch mode, when the ``repr_matching_en`` flag is used then matching
is used (by default)
> with ingress comparison is not supported because an implicit rule is
Implicit rule -> implicit item
> required to match the REPRESENTED_PORT. And that implicit rule would
Match the REPxxxx with the same rule
Rule-> item 
> conflict with the ingress compare rule.
Comparison item.

      reply	other threads:[~2024-11-11  8:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05  1:47 Suanming Mou
2024-11-05  3:48 ` Bing Zhao
2024-11-06  9:01   ` Suanming Mou
2024-11-06  9:34 ` [PATCH v2] " Suanming Mou
2024-11-12  7:13   ` Bing Zhao
2024-11-06 18:29 ` [PATCH] " Stephen Hemminger
2024-11-11  8:15   ` Bing Zhao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR12MB69054D47C063C7188FFB9B2DD0582@PH7PR12MB6905.namprd12.prod.outlook.com \
    --to=bingz@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dsosnowski@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=suanmingm@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).