patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Long Li <longli@microsoft.com>
To: Ferruh Yigit <ferruh.yigit@xilinx.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: "longli@linuxonhyperv.com" <longli@linuxonhyperv.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [Patch v2] net/netvsc: report correct stats values
Date: Tue, 3 May 2022 19:14:44 +0000	[thread overview]
Message-ID: <PH7PR21MB326357EF0A378BA3CED0C0DACEC09@PH7PR21MB3263.namprd21.prod.outlook.com> (raw)
In-Reply-To: <924d7398-6c78-6318-52f3-d671edfc8aad@xilinx.com>

> Subject: Re: [Patch v2] net/netvsc: report correct stats values
> 
> On 5/3/2022 7:18 PM, Long Li wrote:
> >> Subject: Re: [Patch v2] net/netvsc: report correct stats values
> >>
> >> On Tue, 26 Apr 2022 22:56:14 +0100
> >> Ferruh Yigit <ferruh.yigit@xilinx.com> wrote:
> >>
> >>>>    		if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
> >>>> -			stats->q_opackets[i] = txq->stats.packets;
> >>>> -			stats->q_obytes[i] = txq->stats.bytes;
> >>>> +			stats->q_opackets[i] += txq->stats.packets;
> >>>> +			stats->q_obytes[i] += txq->stats.bytes;
> >>>
> >>> This is per queue stats, 'stats->q_opackets[i]', in next iteration
> >>> of the loop, 'i' will be increased and 'txq' will be updated, so as
> >>> far as I can see the above change has no affect.
> >>
> >> Agree, that is why it was just assignment originally.
> >
> > The condition here is a little different. NETVSC is a master device with
> another PMD running as a slave. When reporting stats values, it needs to add
> the values from the slave PMD. The original code just overwrites the values
> from its slave PMD.
> 
> Where the initial values are coming from, 'hn_vf_stats_get()'?
> 
> If 'hn_vf_stats_get()' fills the stats, what are the values kept in 'txq->stats.*'
> in above updated loop?

Yes, hn_vf_stats_get() fills in the stats from the slave PMD. txq->stats values are from the master PMD. Those values are different and accounted separated from the values from the slave PMD.

  reply	other threads:[~2022-05-03 19:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-24 17:45 longli
2022-04-26 21:56 ` Ferruh Yigit
2022-04-26 22:45   ` Stephen Hemminger
2022-05-03 18:18     ` Long Li
2022-05-03 19:03       ` Ferruh Yigit
2022-05-03 19:14         ` Long Li [this message]
2022-05-03 19:55           ` Ferruh Yigit
2022-05-03 20:48             ` Long Li
2022-05-04 12:33               ` Ferruh Yigit
2022-05-04 18:38                 ` Long Li
2022-05-05 16:28                   ` Ferruh Yigit
2022-05-05 16:40                     ` Stephen Hemminger
2022-05-05 16:57                       ` Ferruh Yigit
2022-05-10  5:33                         ` Long Li
2022-05-10 11:29                           ` Ferruh Yigit
2022-05-10 18:03                             ` Long Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR21MB326357EF0A378BA3CED0C0DACEC09@PH7PR21MB3263.namprd21.prod.outlook.com \
    --to=longli@microsoft.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@xilinx.com \
    --cc=longli@linuxonhyperv.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).