patches for DPDK stable branches
 help / color / Atom feed
* Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
@ 2019-11-26  3:28 Dexuan Cui
  2019-11-26  3:32 ` Dexuan Cui
  2019-12-09 21:29 ` [dpdk-stable] " Dexuan Cui
  0 siblings, 2 replies; 9+ messages in thread
From: Dexuan Cui @ 2019-11-26  3:28 UTC (permalink / raw)
  To: Stephen Hemminger, dev, Donald Lee (RD-TW); +Cc: stable

> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, November 25, 2019 9:13 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; stable@dpdk.org;
> Dexuan Cui <decui@microsoft.com>
> 
> In order to change RSS parameters, the host requires that RSS
> is disable first.
> 
> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
> Cc: stable@dpdk.org
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
> index 164e9ad174a7..575780ee5f26 100644
> --- a/drivers/net/netvsc/hn_ethdev.c
> +++ b/drivers/net/netvsc/hn_ethdev.c
> @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
> *dev,
>  			hv->rss_ind[i] = reta_conf[idx].reta[shift];
>  	}
> 
> +	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> +	if (err) {
> +		PMD_DRV_LOG(NOTICE,
> +			"rss disable failed");
> +		return err;
> +	}
> +
>  	err = hn_rndis_conf_rss(hv, 0);
>  	if (err) {
>  		PMD_DRV_LOG(NOTICE,
> @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
> *dev)
>  			return err;
>  		}
> 
> +		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> +		if (err) {
> +			PMD_DRV_LOG(NOTICE,
> +				"rss disable failed");
> +			return err;
> +		}
> +
>  		err = hn_rndis_conf_rss(hv, 0);
>  		if (err) {
>  			PMD_DRV_LOG(NOTICE,
> --
> 2.20.1

Hi, Stephen,
I think the patch originally came from Donald Lee (I added him to "To").

IMO Donald's Signed-off-by should be added.

And, can you please change my Signed-off-by to Tested-by?

Thanks,
-- Dexuan

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
  2019-11-26  3:28 [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters Dexuan Cui
@ 2019-11-26  3:32 ` Dexuan Cui
  2019-11-26 17:02   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
  2019-12-09 21:29 ` [dpdk-stable] " Dexuan Cui
  1 sibling, 1 reply; 9+ messages in thread
From: Dexuan Cui @ 2019-11-26  3:32 UTC (permalink / raw)
  To: Stephen Hemminger, dev, Donald Lee (RD-TW); +Cc: stable, Abhishek Marathe

> From: Dexuan Cui
> Sent: Monday, November 25, 2019 7:29 PM
> To: Stephen Hemminger <stephen@networkplumber.org>; dev@dpdk.org;
> Donald_Lee@trendmicro.com
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters
> 
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Monday, November 25, 2019 9:13 AM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <stephen@networkplumber.org>;
> stable@dpdk.org;
> > Dexuan Cui <decui@microsoft.com>
> >
> > In order to change RSS parameters, the host requires that RSS
> > is disable first.
> >
> > Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
> > Cc: stable@dpdk.org
> > Signed-off-by: Dexuan Cui <decui@microsoft.com>
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/net/netvsc/hn_ethdev.c
> b/drivers/net/netvsc/hn_ethdev.c
> > index 164e9ad174a7..575780ee5f26 100644
> > --- a/drivers/net/netvsc/hn_ethdev.c
> > +++ b/drivers/net/netvsc/hn_ethdev.c
> > @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
> > *dev,
> >  			hv->rss_ind[i] = reta_conf[idx].reta[shift];
> >  	}
> >
> > +	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> > +	if (err) {
> > +		PMD_DRV_LOG(NOTICE,
> > +			"rss disable failed");
> > +		return err;
> > +	}
> > +
> >  	err = hn_rndis_conf_rss(hv, 0);
> >  	if (err) {
> >  		PMD_DRV_LOG(NOTICE,
> > @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
> > *dev)
> >  			return err;
> >  		}
> >
> > +		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> > +		if (err) {
> > +			PMD_DRV_LOG(NOTICE,
> > +				"rss disable failed");
> > +			return err;
> > +		}
> > +
> >  		err = hn_rndis_conf_rss(hv, 0);
> >  		if (err) {
> >  			PMD_DRV_LOG(NOTICE,
> > --
> > 2.20.1
> 
> Hi, Stephen,
> I think the patch originally came from Donald Lee (I added him to "To").
> 
> IMO Donald's Signed-off-by should be added.
> 
> And, can you please change my Signed-off-by to Tested-by?
> 
> -- Dexuan

Also, please add Tested-by for 

Abhishek Marathe <abmarath@microsoft.com> (Cc'd).

Thanks,
-- Dexuan

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters
  2019-11-26  3:32 ` Dexuan Cui
@ 2019-11-26 17:02   ` " Ferruh Yigit
  2019-11-26 17:19     ` Ferruh Yigit
  0 siblings, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2019-11-26 17:02 UTC (permalink / raw)
  To: Dexuan Cui, Stephen Hemminger, dev, Donald Lee (RD-TW)
  Cc: stable, Abhishek Marathe

On 11/26/2019 3:32 AM, Dexuan Cui wrote:
>> From: Dexuan Cui
>> Sent: Monday, November 25, 2019 7:29 PM
>> To: Stephen Hemminger <stephen@networkplumber.org>; dev@dpdk.org;
>> Donald_Lee@trendmicro.com
>> Cc: stable@dpdk.org
>> Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters
>>
>>> From: Stephen Hemminger <stephen@networkplumber.org>
>>> Sent: Monday, November 25, 2019 9:13 AM
>>> To: dev@dpdk.org
>>> Cc: Stephen Hemminger <stephen@networkplumber.org>;
>> stable@dpdk.org;
>>> Dexuan Cui <decui@microsoft.com>
>>>
>>> In order to change RSS parameters, the host requires that RSS
>>> is disable first.
>>>
>>> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
>>> Cc: stable@dpdk.org
>>> Signed-off-by: Dexuan Cui <decui@microsoft.com>
>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>> ---
>>>  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>
>>> diff --git a/drivers/net/netvsc/hn_ethdev.c
>> b/drivers/net/netvsc/hn_ethdev.c
>>> index 164e9ad174a7..575780ee5f26 100644
>>> --- a/drivers/net/netvsc/hn_ethdev.c
>>> +++ b/drivers/net/netvsc/hn_ethdev.c
>>> @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
>>> *dev,
>>>  			hv->rss_ind[i] = reta_conf[idx].reta[shift];
>>>  	}
>>>
>>> +	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
>>> +	if (err) {
>>> +		PMD_DRV_LOG(NOTICE,
>>> +			"rss disable failed");
>>> +		return err;
>>> +	}
>>> +
>>>  	err = hn_rndis_conf_rss(hv, 0);
>>>  	if (err) {
>>>  		PMD_DRV_LOG(NOTICE,
>>> @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
>>> *dev)
>>>  			return err;
>>>  		}
>>>
>>> +		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
>>> +		if (err) {
>>> +			PMD_DRV_LOG(NOTICE,
>>> +				"rss disable failed");
>>> +			return err;
>>> +		}
>>> +
>>>  		err = hn_rndis_conf_rss(hv, 0);
>>>  		if (err) {
>>>  			PMD_DRV_LOG(NOTICE,
>>> --
>>> 2.20.1
>>
>> Hi, Stephen,
>> I think the patch originally came from Donald Lee (I added him to "To").
>>
>> IMO Donald's Signed-off-by should be added.
>>
>> And, can you please change my Signed-off-by to Tested-by?
>>
>> -- Dexuan
> 
> Also, please add Tested-by for 
> 
> Abhishek Marathe <abmarath@microsoft.com> (Cc'd).

Hi Stephen,

I will update this in next-net if you confirm.
And to prevent confusion, can you please reply the tags that needs to be used?

Thanks,
ferruh

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters
  2019-11-26 17:02   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
@ 2019-11-26 17:19     ` Ferruh Yigit
  0 siblings, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2019-11-26 17:19 UTC (permalink / raw)
  To: Dexuan Cui, Stephen Hemminger, dev, Donald Lee (RD-TW)
  Cc: stable, Abhishek Marathe

On 11/26/2019 5:02 PM, Ferruh Yigit wrote:
> On 11/26/2019 3:32 AM, Dexuan Cui wrote:
>>> From: Dexuan Cui
>>> Sent: Monday, November 25, 2019 7:29 PM
>>> To: Stephen Hemminger <stephen@networkplumber.org>; dev@dpdk.org;
>>> Donald_Lee@trendmicro.com
>>> Cc: stable@dpdk.org
>>> Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters
>>>
>>>> From: Stephen Hemminger <stephen@networkplumber.org>
>>>> Sent: Monday, November 25, 2019 9:13 AM
>>>> To: dev@dpdk.org
>>>> Cc: Stephen Hemminger <stephen@networkplumber.org>;
>>> stable@dpdk.org;
>>>> Dexuan Cui <decui@microsoft.com>
>>>>
>>>> In order to change RSS parameters, the host requires that RSS
>>>> is disable first.
>>>>
>>>> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
>>>> Cc: stable@dpdk.org
>>>> Signed-off-by: Dexuan Cui <decui@microsoft.com>
>>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>>> ---
>>>>  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
>>>>  1 file changed, 14 insertions(+)
>>>>
>>>> diff --git a/drivers/net/netvsc/hn_ethdev.c
>>> b/drivers/net/netvsc/hn_ethdev.c
>>>> index 164e9ad174a7..575780ee5f26 100644
>>>> --- a/drivers/net/netvsc/hn_ethdev.c
>>>> +++ b/drivers/net/netvsc/hn_ethdev.c
>>>> @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
>>>> *dev,
>>>>  			hv->rss_ind[i] = reta_conf[idx].reta[shift];
>>>>  	}
>>>>
>>>> +	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
>>>> +	if (err) {
>>>> +		PMD_DRV_LOG(NOTICE,
>>>> +			"rss disable failed");
>>>> +		return err;
>>>> +	}
>>>> +
>>>>  	err = hn_rndis_conf_rss(hv, 0);
>>>>  	if (err) {
>>>>  		PMD_DRV_LOG(NOTICE,
>>>> @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
>>>> *dev)
>>>>  			return err;
>>>>  		}
>>>>
>>>> +		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
>>>> +		if (err) {
>>>> +			PMD_DRV_LOG(NOTICE,
>>>> +				"rss disable failed");
>>>> +			return err;
>>>> +		}
>>>> +
>>>>  		err = hn_rndis_conf_rss(hv, 0);
>>>>  		if (err) {
>>>>  			PMD_DRV_LOG(NOTICE,
>>>> --
>>>> 2.20.1
>>>
>>> Hi, Stephen,
>>> I think the patch originally came from Donald Lee (I added him to "To").
>>>
>>> IMO Donald's Signed-off-by should be added.
>>>
>>> And, can you please change my Signed-off-by to Tested-by?
>>>
>>> -- Dexuan
>>
>> Also, please add Tested-by for 
>>
>> Abhishek Marathe <abmarath@microsoft.com> (Cc'd).
> 
> Hi Stephen,
> 
> I will update this in next-net if you confirm.
> And to prevent confusion, can you please reply the tags that needs to be used?
> 

Dropping from next-net until owner of the work clarified.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
  2019-11-26  3:28 [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters Dexuan Cui
  2019-11-26  3:32 ` Dexuan Cui
@ 2019-12-09 21:29 ` " Dexuan Cui
  2019-12-10  2:31   ` Donald_Lee
  1 sibling, 1 reply; 9+ messages in thread
From: Dexuan Cui @ 2019-12-09 21:29 UTC (permalink / raw)
  To: Stephen Hemminger, dev, Donald Lee (RD-TW), Ferruh Yigit; +Cc: stable

> From: Dexuan Cui
> Sent: Monday, November 25, 2019 7:29 PM
> To: Stephen Hemminger <stephen@networkplumber.org>; dev@dpdk.org;
> Donald_Lee@trendmicro.com
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters
> 
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Monday, November 25, 2019 9:13 AM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <stephen@networkplumber.org>;
> stable@dpdk.org;
> > Dexuan Cui <decui@microsoft.com>
> >
> > In order to change RSS parameters, the host requires that RSS
> > is disable first.
> >
> > Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
> > Cc: stable@dpdk.org
> > Signed-off-by: Dexuan Cui <decui@microsoft.com>
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/net/netvsc/hn_ethdev.c
> b/drivers/net/netvsc/hn_ethdev.c
> > index 164e9ad174a7..575780ee5f26 100644
> > --- a/drivers/net/netvsc/hn_ethdev.c
> > +++ b/drivers/net/netvsc/hn_ethdev.c
> > @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
> > *dev,
> >  			hv->rss_ind[i] = reta_conf[idx].reta[shift];
> >  	}
> >
> > +	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> > +	if (err) {
> > +		PMD_DRV_LOG(NOTICE,
> > +			"rss disable failed");
> > +		return err;
> > +	}
> > +
> >  	err = hn_rndis_conf_rss(hv, 0);
> >  	if (err) {
> >  		PMD_DRV_LOG(NOTICE,
> > @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
> > *dev)
> >  			return err;
> >  		}
> >
> > +		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> > +		if (err) {
> > +			PMD_DRV_LOG(NOTICE,
> > +				"rss disable failed");
> > +			return err;
> > +		}
> > +
> >  		err = hn_rndis_conf_rss(hv, 0);
> >  		if (err) {
> >  			PMD_DRV_LOG(NOTICE,
> > --
> > 2.20.1
> 
> Hi, Stephen,
> I think the patch originally came from Donald Lee (I added him to "To").
> 
> IMO Donald's Signed-off-by should be added.
> 
> And, can you please change my Signed-off-by to Tested-by?
> 
> Thanks,
> -- Dexuan

Hi Donald,
Since you originally made the patch, can you please confirm that your
Signed-off-by 
"Signed-off-by: Donald Lee <Donald_Lee@trendmicro.com>"
can be added into the patch's changelog? 

Thanks,
-- Dexuan

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
  2019-12-09 21:29 ` [dpdk-stable] " Dexuan Cui
@ 2019-12-10  2:31   ` Donald_Lee
  2019-12-10  6:59     ` Stephen Hemminger
  0 siblings, 1 reply; 9+ messages in thread
From: Donald_Lee @ 2019-12-10  2:31 UTC (permalink / raw)
  To: Dexuan Cui, Stephen Hemminger, dev, Ferruh Yigit; +Cc: stable



On 10/12/2019, 5:29 AM, "Dexuan Cui" <decui@microsoft.com> wrote:

    
    This message was sent from outside of Trend Micro. Please do not click links or open attachments unless you recognise the source of this email and know the content is safe.
    
    
    > From: Dexuan Cui
    > Sent: Monday, November 25, 2019 7:29 PM
    > To: Stephen Hemminger <stephen@networkplumber.org>; dev@dpdk.org;
    > Donald_Lee@trendmicro.com
    > Cc: stable@dpdk.org
    > Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters
    >
    > > From: Stephen Hemminger <stephen@networkplumber.org>
    > > Sent: Monday, November 25, 2019 9:13 AM
    > > To: dev@dpdk.org
    > > Cc: Stephen Hemminger <stephen@networkplumber.org>;
    > stable@dpdk.org;
    > > Dexuan Cui <decui@microsoft.com>
    > >
    > > In order to change RSS parameters, the host requires that RSS
    > > is disable first.
    > >
    > > Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
    > > Cc: stable@dpdk.org
    > > Signed-off-by: Dexuan Cui <decui@microsoft.com>
    > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
    > > ---
    > >  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
    > >  1 file changed, 14 insertions(+)
    > >
    > > diff --git a/drivers/net/netvsc/hn_ethdev.c
    > b/drivers/net/netvsc/hn_ethdev.c
    > > index 164e9ad174a7..575780ee5f26 100644
    > > --- a/drivers/net/netvsc/hn_ethdev.c
    > > +++ b/drivers/net/netvsc/hn_ethdev.c
    > > @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
    > > *dev,
    > >                     hv->rss_ind[i] = reta_conf[idx].reta[shift];
    > >     }
    > >
    > > +   err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
    > > +   if (err) {
    > > +           PMD_DRV_LOG(NOTICE,
    > > +                   "rss disable failed");
    > > +           return err;
    > > +   }
    > > +
    > >     err = hn_rndis_conf_rss(hv, 0);
    > >     if (err) {
    > >             PMD_DRV_LOG(NOTICE,
    > > @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
    > > *dev)
    > >                     return err;
    > >             }
    > >
    > > +           err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
    > > +           if (err) {
    > > +                   PMD_DRV_LOG(NOTICE,
    > > +                           "rss disable failed");
    > > +                   return err;
    > > +           }
    > > +
    > >             err = hn_rndis_conf_rss(hv, 0);
    > >             if (err) {
    > >                     PMD_DRV_LOG(NOTICE,
    > > --
    > > 2.20.1
    >
    > Hi, Stephen,
    > I think the patch originally came from Donald Lee (I added him to "To").
    >
    > IMO Donald's Signed-off-by should be added.
    >
    > And, can you please change my Signed-off-by to Tested-by?
    >
    > Thanks,
    > -- Dexuan
    
    Hi Donald,
    Since you originally made the patch, can you please confirm that your
    Signed-off-by
    "Signed-off-by: Donald Lee <Donald_Lee@trendmicro.com>"
    can be added into the patch's changelog?
    
    Thanks,
    -- Dexuan


Hi Dexuan, 

Yes! Can you please add my signed-off on it? Our mailing system will add extra space on the patch last time I did. Thank you.

Regards,
Donald
    


<table class="TM_EMAIL_NOTICE"><tr><td><pre>
TREND MICRO EMAIL NOTICE
The information contained in this email and any attachments is confidential 
and may be subject to copyright or other intellectual property protection. 
If you are not the intended recipient, you are not authorized to use or 
disclose this information, and we request that you notify us by reply mail or
telephone and delete the original message from your mail system.

For details about what personal information we collect and why, please see our Privacy Notice on our website at: [ https://www.trendmicro.com/privacy] 
</pre></td></tr></table>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
  2019-12-10  2:31   ` Donald_Lee
@ 2019-12-10  6:59     ` Stephen Hemminger
  0 siblings, 0 replies; 9+ messages in thread
From: Stephen Hemminger @ 2019-12-10  6:59 UTC (permalink / raw)
  To: Donald_Lee; +Cc: Dexuan Cui, dev, Ferruh Yigit, stable

On Tue, 10 Dec 2019 02:31:31 +0000
"Donald_Lee@trendmicro.com" <Donald_Lee@trendmicro.com> wrote:

> Hi Dexuan, 
> 
> Yes! Can you please add my signed-off on it? Our mailing system will add extra space on the patch last time I did. Thank you.
> 
> Regards,
> Donald
>     

Thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
  2019-11-25 17:13 Stephen Hemminger
@ 2019-11-26 13:52 ` Ferruh Yigit
  0 siblings, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2019-11-26 13:52 UTC (permalink / raw)
  To: Stephen Hemminger, dev; +Cc: stable, Dexuan Cui

On 11/25/2019 5:13 PM, Stephen Hemminger wrote:
> In order to change RSS parameters, the host requires that RSS
> is disable first.
> 
> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
> Cc: stable@dpdk.org
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
@ 2019-11-25 17:13 Stephen Hemminger
  2019-11-26 13:52 ` Ferruh Yigit
  0 siblings, 1 reply; 9+ messages in thread
From: Stephen Hemminger @ 2019-11-25 17:13 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger, stable, Dexuan Cui

In order to change RSS parameters, the host requires that RSS
is disable first.

Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
Cc: stable@dpdk.org
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 164e9ad174a7..575780ee5f26 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
 			hv->rss_ind[i] = reta_conf[idx].reta[shift];
 	}
 
+	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+	if (err) {
+		PMD_DRV_LOG(NOTICE,
+			"rss disable failed");
+		return err;
+	}
+
 	err = hn_rndis_conf_rss(hv, 0);
 	if (err) {
 		PMD_DRV_LOG(NOTICE,
@@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
 			return err;
 		}
 
+		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+		if (err) {
+			PMD_DRV_LOG(NOTICE,
+				"rss disable failed");
+			return err;
+		}
+
 		err = hn_rndis_conf_rss(hv, 0);
 		if (err) {
 			PMD_DRV_LOG(NOTICE,
-- 
2.20.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26  3:28 [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters Dexuan Cui
2019-11-26  3:32 ` Dexuan Cui
2019-11-26 17:02   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-11-26 17:19     ` Ferruh Yigit
2019-12-09 21:29 ` [dpdk-stable] " Dexuan Cui
2019-12-10  2:31   ` Donald_Lee
2019-12-10  6:59     ` Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2019-11-25 17:13 Stephen Hemminger
2019-11-26 13:52 ` Ferruh Yigit

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox