From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF85E42591 for ; Thu, 14 Sep 2023 07:11:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4C9C402DD; Thu, 14 Sep 2023 07:11:14 +0200 (CEST) Received: from HK2P15301CU002.outbound.protection.outlook.com (mail-eastasiaazon11020026.outbound.protection.outlook.com [52.101.128.26]) by mails.dpdk.org (Postfix) with ESMTP id A18B340289; Thu, 14 Sep 2023 07:11:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E0GH3rb7kBVoG7hHn9ZZnBvJPtyJcG7REjoaObQ5lqAPZhanX4vGOrQuey0OoGtMJxgO8X1uzjGYNfAAIu2JyJ68wRyjwcpXr9g2CWZ5DimIC40Fl8s8kMBoTyT0XLF+9Ok84n+BHujSfMhYb777aFP/xaOPO9V4r5fBBbWr8D9Siophbxe1AeUvVZXUmXGrSa2+sAfnkXXMza+4hrarEUM1HVl5b0WoS2ERC6IelYxinYQ/TgWq21UCf9GdJKmaqh32NwvizBTl6/qixSPoL7qoDhhxSrKZZLW8CudQpaLCVX+0wt7/FFbl/r3G8J2bfwIUWF976q8zJMkIc1bCAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TFg+/7OlnrjNNR8757XudsGVUq9lKfWHjz8AMMZ55SQ=; b=Omlu0AL0sRnlgNc/jXsJIwDi2mRRHUlbz7KMDz4EPCHVteSutkHU9Pj/YsRBFeT3vyJrvEechDhSfjFAh0zckj1lROxGhn6gd2OV9mQStL+B0CMO+Jn+2abTFVfUJldJ99TENEqrXNyh7JTVXyYfxFPrPUDXoiE+C5c8YKbleFvzWlmfAni/elWqDysaECL5zhLfh8Q46+hlQ2PF7DTLtM6m07SKNB9cagL2mxEU96y7N+5oLajaDPJbBsTSfUTDfpu/pOWS3yaZReHWCoDtw6OUwmWnCSdQcgMlRuNAmIHoatHn0uys7dG+vVXduVYHh8wdO0eJuTBU0aR3Chqkzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TFg+/7OlnrjNNR8757XudsGVUq9lKfWHjz8AMMZ55SQ=; b=g9ehKcXM3dIBqbvq70OzEtfvAvzU9UTpartsVhh+sYOtxhr9IBrGHBHlmtpjva7oHrTb1tKhTMq9BIe+9YAwxlHTfvi5ykyUMmB3A2fjv0kfMnxjuBvde7VbSl86gjKrDvsrnlbXnb5XWikClOXoImsYJA52Ux+ZsfeOM54tO08= Received: from SI2P153MB0441.APCP153.PROD.OUTLOOK.COM (2603:1096:4:fc::7) by SI2P153MB0428.APCP153.PROD.OUTLOOK.COM (2603:1096:4:f3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.7; Thu, 14 Sep 2023 05:11:06 +0000 Received: from SI2P153MB0441.APCP153.PROD.OUTLOOK.COM ([fe80::7bae:a915:919b:6f83]) by SI2P153MB0441.APCP153.PROD.OUTLOOK.COM ([fe80::7bae:a915:919b:6f83%7]) with mapi id 15.20.6813.007; Thu, 14 Sep 2023 05:11:03 +0000 From: Wei Hu To: Long Li , "dev@dpdk.org" , Ferruh Yigit , Andrew Rybchenko CC: "stable@dpdk.org" Subject: RE: [PATCH 1/1] net/mana: add 32 bit short doorbell Thread-Topic: [PATCH 1/1] net/mana: add 32 bit short doorbell Thread-Index: AQHZ4xiQ9bKvJDFRDkup2UAbNtMUZbAZR26AgAB5qUA= Date: Thu, 14 Sep 2023 05:11:02 +0000 Message-ID: References: <20230909122347.2043969-1-weh@microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=bec1f215-7edf-49c3-93c3-470f9993eedc; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2023-09-13T20:52:00Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SI2P153MB0441:EE_|SI2P153MB0428:EE_ x-ms-office365-filtering-correlation-id: 8e5d3907-54ee-4bdb-e2c0-08dbb4e0fde6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vRimiIuYcskZ93gz9Mpl7DzJOCR+AfThc5ZwvXxEemphQgnfXILFcGxjKqBT0uH2tR1Hc2nfgUZ+CzZb/YR2uEa5e5QYmxo8FjTd52KYzLZ0pK4PfHSNuhhHYvPBqVL0TuYZu2c4hIXB1AuiusOxSjzg6KHm9z+tSaoC8rIfx1RUm6CXNnosn6vjEiFlp+DYFWbQv75bKuG5EMW1Js3mJuVu+o2GfHAKphyvwFlYF2n/46iNUZnyqnJ7dGsRuwHZs2O86XM1XAlHD8hOFnFaKc0+leh35x/vI55sriKritUaAFHr/Grrzo21ZD98ubCZeBzvEf0TY6YrrXHy3I/dRCkZv3MPJT4yNc5+MAaCYHrMbXX0Ep0ryUGG4y7NQjELobFJQ9Q0gxVge3Nmp8vP8MGbcJULvOkNKwdara0WN+A1seZCnOGJZEapzWq5ZAywn8bFiE1CwUmLqaA4dajwxqmQ2uJm+ojURW4p6uaa+O2W+sq8yyK/2MWskyksgQbIOClIsjM1uf2OShkQJMmxlsbqm3p6eLFhNbWY9WGzWoTIT9IA9DfDIwK+wtOxnjxI/HqSFWIuxsIeJ7+vI3PgtJFwGIDMCcQTj29/T4FXzZVnk+0wBqJlJiUcOuHFBckdoWx767pAA03fWzRgeqr7bBaPJ0KVkDQTulw2TemhWIc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SI2P153MB0441.APCP153.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(366004)(39860400002)(136003)(396003)(186009)(1800799009)(451199024)(9686003)(76116006)(71200400001)(53546011)(6506007)(7696005)(55016003)(8990500004)(83380400001)(26005)(52536014)(5660300002)(66556008)(64756008)(66446008)(66476007)(66946007)(33656002)(41300700001)(38100700002)(86362001)(82960400001)(316002)(82950400001)(122000001)(38070700005)(8676002)(4326008)(8936002)(2906002)(478600001)(110136005)(10290500003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ceZmnW/I1o+VV4ABs4AKpYUtRkyNt8W1xHUhM2fpJ0DgB1GhSE/pzsWZ6xC1?= =?us-ascii?Q?pBU+tW6/8Mbj2RlLcjmhKs0vhtjkKD2GBsxfz6Z4cMbIu/Fu8bSwRkHOxmlf?= =?us-ascii?Q?T+UX8JEWezbV4lCWk+XVzDViEZugO4jsWX1DCUVk+RBmBPbrmLN0m2NcjfiV?= =?us-ascii?Q?eAdDlOgVIruZq9Kzr7OKOZ+Xkcx+p5c7ayTIbIdj3D2EnRlcjGhvTFJrkHpn?= =?us-ascii?Q?YqxUZ73p65eXPZmOvmKigJ+kB5Ef82Ok+f7p4kWiFZEOXZwpDIK4f5YptzFK?= =?us-ascii?Q?5F5HHjcalLza7H3TOUtaNUpmf2Ynzh9pFvMfsGzeevC9cvMEG2BPxYmHuzcb?= =?us-ascii?Q?/1hg8cMlHVOH+KNZJnJjCUHhrmA2AHpVEyzwAsxBZIuvsRdQ+s/IBQxERtEm?= =?us-ascii?Q?uBXEarGR5A+uti3tnUP8m4afHT/A4EBR0DyIAOHJifjMLVWx1noakCDlcm+f?= =?us-ascii?Q?94dFTuMVqRY+2Y5g0/9WnQ/nGas1qJ4lNPH/3/usjpTVXHakBwKu0g1WqnG/?= =?us-ascii?Q?OsjmNHdGoXjcxdi65z4InGAMd2uN7/mdEuY6oQ9xzdFvqfS58LkU4i3vrjTV?= =?us-ascii?Q?mALBjPyZE9WLbYW9rPMFu6vRocbX6QnUKIyaTa91WgrlYXtWlLOka9pHwP+W?= =?us-ascii?Q?2U+vf8cs6rI7Ds5IMmD6wJBd7MgcAVUa3pxauVwpiRTW3DYZSV0Zl3NHyfqh?= =?us-ascii?Q?jFfTVccT+xaQMfm2NyhN+mMPQ70AMocFvT1W4DWuo6XaWRSucMiXSLIcdsvm?= =?us-ascii?Q?liaR9B7lRIMxQcEFds8FbrfniXxf7ZMTMR3xT5kea6XRtl6L35GuB/9lwU9w?= =?us-ascii?Q?scWKD2HkpRrGd9/ZkUu964iUpU+M/9GtJUqX8WfByTIASR4mA99QKaA7LfDc?= =?us-ascii?Q?F0mmrIsmT/NvScL3UVi/1C55moNeWL/6Q3K13kMWDO3f4fT1ZlemEudqjtFy?= =?us-ascii?Q?wMYf2qOh3jD8+hKjDisqgB2bv2Jczw0Z37oC/Gor7KSjeGaj1G9NmlK8OxGy?= =?us-ascii?Q?lfyl7gUj9F6cMsHqSxm2ExAvjX3pFq/CXi88BltBb1pclbRIM3XTAZGrOUng?= =?us-ascii?Q?5vQvF/HGrXeyLP3FwPirjc/lSGxJWMSXeXIIZeCMFIVJLli1LD3OQR6+0rNv?= =?us-ascii?Q?fSdTSZrH3cNGwOL7IqYMPOPFkJdT5y82YJ8al9DNyp6LJvR/CTEHhWDfpYuD?= =?us-ascii?Q?AQiJZAdpGRJUjWQ4biioP6iCMQso+B5sBaYa3v8EvPVBh8EV6YIypRQAdUkx?= =?us-ascii?Q?20MbFEw7N07SMwdtCtlqIpp6uPDrBv9hj9N8Ht/HRZSgxbBxfzd4ddRc5/x0?= =?us-ascii?Q?Xmq8bU/IXglF4eehbOf0B5YyZ1YqFb/lAahtAFt2xt/tKj7gaNs+z1BqT2/j?= =?us-ascii?Q?gGVoufrKjEg0lzz3f5cp0ategxKtJmQhNjS3xKDScPGWj67U6trzdJ8JmbVm?= =?us-ascii?Q?rK6if3Kay720Jb6gMc8zvRU+5ZCQ8FPW3KQkRF+1MXYgFM2i139sNnig6GNO?= =?us-ascii?Q?p4PrMhCzbsb+d1X6s0EHE9j9ZwkDg5MQx93M9bvSNY5+rSVY6IIpCbqT/hbp?= =?us-ascii?Q?a7fpmzhuJwjN7BGBEIQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SI2P153MB0441.APCP153.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 8e5d3907-54ee-4bdb-e2c0-08dbb4e0fde6 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2023 05:11:02.8263 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MynHPTis4GH/Xy4JaENNDaD+Le85u5SpBUfone6vk3RsMxDF1Rk+85UaIOaW191p46HxCEnyDYHNy4rGJXZS/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2P153MB0428 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Long Li > Sent: Thursday, September 14, 2023 5:11 AM > To: Wei Hu ; dev@dpdk.org; Ferruh Yigit > ; Andrew Rybchenko > > Cc: stable@dpdk.org > Subject: RE: [PATCH 1/1] net/mana: add 32 bit short doorbell >=20 > > + > > +/* > > + * Write to hardware doorbell to notify new activity. > > + */ > > +int > > +mana_ring_short_doorbell(void *db_page, enum gdma_queue_types > > queue_type, > > + uint32_t queue_id, uint32_t tail_incr, uint8_t arm) { > > + uint8_t *addr =3D db_page; > > + union gdma_short_doorbell_entry e =3D {}; > > + > > + if ((queue_id & ~GDMA_SHORT_DB_QID_MASK) || > > + (tail_incr & ~GDMA_SHORT_DB_INC_MASK)) { > > + DP_LOG(ERR, "%s: queue_id %u or " > > + "tail_incr %u overflowed, queue type %d", > > + __func__, queue_id, tail_incr, queue_type); >=20 > This should never happen. >=20 > What does "overflowed" mean? Is it a hardware error or software error? If= this > is a software error, the calling code needs to make sure it never overflo= ws > when using short doorbells. >=20 This is to guard any hardware and software bugs or weirdness, which could l= ead to silent failures if it doesn't log.=20 The software code has already been made to avoid any intentional behaviors = which could cause tail_incr overflow.=20 Thanks, Wei