patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Dooley, Brian" <brian.dooley@intel.com>
To: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Anoob Joseph <anoobj@marvell.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] examples/fips_validation: fix coverity issues
Date: Thu, 20 Jun 2024 16:33:34 +0000	[thread overview]
Message-ID: <SJ0PR11MB5056E12BA2AEF4B21CD1978083C82@SJ0PR11MB5056.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240615113118.2137-1-gmuthukrishn@marvell.com>

Hey Gowrishankar,

> -----Original Message-----
> From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> Sent: Saturday, June 15, 2024 12:31 PM
> To: dev@dpdk.org; Dooley, Brian <brian.dooley@intel.com>; Gowrishankar
> Muthukrishnan <gmuthukrishn@marvell.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; stable@dpdk.org
> Subject: [PATCH] examples/fips_validation: fix coverity issues
> 
> Fix NULL dereference, out-of-bound, bad bit shift issues reported by coverity
> scan.
> 
> Coverity issue: 384440, 384435, 384433, 384429
> Fixes: 36128a67c27 ("examples/fips_validation: add asymmetric validation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> ---
>  examples/fips_validation/fips_validation_rsa.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/fips_validation/fips_validation_rsa.c
> b/examples/fips_validation/fips_validation_rsa.c
> index f675b51051..55f81860a0 100644
> --- a/examples/fips_validation/fips_validation_rsa.c
> +++ b/examples/fips_validation/fips_validation_rsa.c
> @@ -328,6 +328,9 @@ parse_test_rsa_json_interim_writeback(struct
> fips_val *val)
>  		if (prepare_vec_rsa() < 0)
>  			return -1;
> 
> +		if (!vec.rsa.e.val)
> +			return -1;
> +
>  		writeback_hex_str("", info.one_line_text, &vec.rsa.n);
>  		obj = json_string(info.one_line_text);
>  		json_object_set_new(json_info.json_write_group, "n", obj);
> @@ -474,7 +477,7 @@ fips_test_randomize_message(struct fips_val *msg,
> struct fips_val *rand)
>  	uint16_t rv_len;
> 
>  	if (!msg->val || !rand->val || rand->len > RV_BUF_LEN
> -		|| msg->len > FIPS_TEST_JSON_BUF_LEN)
> +		|| msg->len > (FIPS_TEST_JSON_BUF_LEN - 1))
>  		return -EINVAL;
> 
>  	memset(rv, 0, sizeof(rv));
> @@ -503,7 +506,7 @@ fips_test_randomize_message(struct fips_val *msg,
> struct fips_val *rand)
>  		m[i + j] ^= rv[j];
> 
>  	m[i + j] = ((uint8_t *)&rv_bitlen)[0];
> -	m[i + j + 1] = (((uint8_t *)&rv_bitlen)[1] >> 8) & 0xFF;
> +	m[i + j + 1] = ((uint8_t *)&rv_bitlen)[1];
> 
>  	rte_free(msg->val);
>  	msg->len = (rv_bitlen + m_bitlen + 16) / 8;
> --
> 2.25.1

Acked-by: Brian Dooley <brian.dooley@intel.com>


  parent reply	other threads:[~2024-06-20 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-15 11:31 Gowrishankar Muthukrishnan
2024-06-17 17:49 ` Patrick Robb
2024-06-20 16:33 ` Dooley, Brian [this message]
2024-07-02 15:44   ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR11MB5056E12BA2AEF4B21CD1978083C82@SJ0PR11MB5056.namprd11.prod.outlook.com \
    --to=brian.dooley@intel.com \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=gmuthukrishn@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).