From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id CC74842900
for <public@inbox.dpdk.org>; Thu, 13 Apr 2023 02:56:27 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C6DB24113D;
Thu, 13 Apr 2023 02:56:27 +0200 (CEST)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by mails.dpdk.org (Postfix) with ESMTP id 741314021F;
Thu, 13 Apr 2023 02:56:24 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1681347384; x=1712883384;
h=from:to:cc:subject:date:message-id:references:
in-reply-to:content-transfer-encoding:mime-version;
bh=4emms+XXuJV1dbCdKod6xN99q+NTNHg/Q2TzNzuyu6Q=;
b=bHXPf1nT00ke2D3wAsfvuim+Ig1bt0njIRZmX63cx4/gOHp6bcaEY7AP
bCWgBn4mLQqZsf3klcVQVQM3zfBl7DDvm3R7DQgFL0sV9Vo6/jmIZfxA9
2KqWeHlruyDXhGETaHb55WCWEeerPYHaOXNF/MLchCqqRgxXXa4MY6Zml
DbEEcL2WF3xDaNShmPM9o0qzCxNQDazPmsCSeWhwvKhV7EXQh2Y6lzg2x
fCdj54tCt9gOoqeu9GFYi4PbvLQvecR0wJKeG8TKoi+hsAOa9kBwEzbgX
AkJS2cIadHkPTHqgbGFt/a5F8C9FeYlHoCE5Lg7UxcprkQU3SSVjhHRNt w==;
X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="332760270"
X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="332760270"
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
12 Apr 2023 17:56:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="863520816"
X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="863520816"
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
by orsmga005.jf.intel.com with ESMTP; 12 Apr 2023 17:56:23 -0700
Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by
fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.23; Wed, 12 Apr 2023 17:56:22 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.23 via Frontend Transport; Wed, 12 Apr 2023 17:56:22 -0700
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176)
by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.23; Wed, 12 Apr 2023 17:56:22 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=BXTGILgxD1E3SkwDlnAd/8pqoAW9/afObZWrS1g9vVtGPKWpCyhov9Np4kfOjQ9lo0oPNUhMFbRr7RycNEjwDLSutiefotzwEzBMU5M9ti+73FpIi0slQAJ+DAvjZ8sNJv9Wed/W5OqBF5jLvD/qKDgPuTDwZwy7YfCuQ16opV7HHGe+ACbIIAZRv2cwC2fmb45bOEuYiQZx7QoqbHNA8IkA+Sr+A2v3kQF985Mn4l98gp8t9Efe7lP6cyfMenDkThqT8tknNhmB6rK2+2+KZ0HAqwXHOugsVaDuzXwiV0sRnVOoKLSmSiWdZd1qGVEOBfqsdKPMS8fysXQaiCB4IA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=d0rzFq98HeY4x0N1yfZ9roovVBfuYvsSonLxbgt3fCA=;
b=T8O5rp3FECi1bdLEWyOJElxoBhB+RS5G0PuqH+Hli35cb+7cRI3OrwsnHtsijrwPlIpOXyBvPT1BSUZaO8zzKyne/PNG/ZwhNP1XGdPdrQgfB/skyew9x9rQWTlf/GEKFkOUhyGN293/lD6Zie26uViV9ZEELxtjVAOgqvZWRF3q6xg5JcNDt90UWCzI5Olzv7w89PWMVZfJoRV6ohyo60Z3i4JixdM8wN/tRKHU9VgwzExTo5D8VlVsktiCnM01wBkc2WhqrZ7zT7KNPKaw/KzajhJ0JAshgQxKs4qgeGGSIl+zzQDN5YP8dWMQEMIn5wyuPKJInTP4mJ9lSKgdNw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Received: from SJ0PR11MB6765.namprd11.prod.outlook.com (2603:10b6:a03:47b::10)
by BN0PR11MB5709.namprd11.prod.outlook.com (2603:10b6:408:148::6)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Thu, 13 Apr
2023 00:56:20 +0000
Received: from SJ0PR11MB6765.namprd11.prod.outlook.com
([fe80::d8de:a1e1:f598:6572]) by SJ0PR11MB6765.namprd11.prod.outlook.com
([fe80::d8de:a1e1:f598:6572%4]) with mapi id 15.20.6277.036; Thu, 13 Apr 2023
00:56:19 +0000
From: "You, KaisenX" <kaisenx.you@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Zhou, YidingX" <yidingx.zhou@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>, "Matz, Olivier"
<olivier.matz@6wind.com>, "ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
"zhoumin@loongson.cn" <zhoumin@loongson.cn>, "stable@dpdk.org"
<stable@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>, "Burakov, Anatoly"
<anatoly.burakov@intel.com>
Subject: RE: [PATCH v5] enhance NUMA affinity heuristic
Thread-Topic: [PATCH v5] enhance NUMA affinity heuristic
Thread-Index: AQHZNf9KkwjFirxtKkqXm6ZbKOABl67QJeuAgADH7FCAGFkTAIAInSJQgDb0DOA=
Date: Thu, 13 Apr 2023 00:56:19 +0000
Message-ID: <SJ0PR11MB676546A9A503ED05C5C6A2DCE1989@SJ0PR11MB6765.namprd11.prod.outlook.com>
References: <20221221104858.296530-1-david.marchand@redhat.com>
<6014e44e-5dd5-365f-2a8f-0ec37f562ca8@intel.com>
<SJ0PR11MB67659D4EA0E7569A4C16841DE1A09@SJ0PR11MB6765.namprd11.prod.outlook.com>
<4598779.O6GEm4j1yj@thomas>
<SJ0PR11MB67655B223283E17E3970FDB9E1B59@SJ0PR11MB6765.namprd11.prod.outlook.com>
In-Reply-To: <SJ0PR11MB67655B223283E17E3970FDB9E1B59@SJ0PR11MB6765.namprd11.prod.outlook.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SJ0PR11MB6765:EE_|BN0PR11MB5709:EE_
x-ms-office365-filtering-correlation-id: dea07a9c-b398-46a5-32cc-08db3bb9e4c5
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ZbmL1WrJHWdibe7n0ltV0hjNX5E8Vr/JO87scL/fJ8w7BTGWYeJbjYpjvf6wtE4763dJsOf/8qwSSRdwPaAcxptdS1jbu+hAVla2x7HpSsIjHqy/Gl0QMxx9jmHpFQjiPaNPln35/BZCWbsb/24oilejN/XZKxscP+RBjNJS8ogs4COPNqVU0V9hJ/0HzrJwDFjN6gQ5wq8iBXrSLE4BvJTZZMyN0mgJVFLVptAXRbejpx1dhH56E54E4dkHHuCryrpTdsri3Hf5a/vnjzUAq6ngrl0gx2bpU9lUtW7tlr3NFQZylC06u4/6DPe2xomfmMyFsHPPtRTfOLbKHwVv+YuUVjlVYDDjOyXQMbvy5bR2T+wcl0AAiL5k1CQM5K8yf/bF0nNSS2QfjUlmRDBCXuDLHuhIaJVhV0xb1a0kx16WVzz5oGYVqCBE89gyX3JMFFGN2MMoe/fjM4XyYWOcPP4aYogGsSsNa8PQooDdPePQmU6SEsBfMtsiRMzwfm1vFdhWXR3GNbBwy7omZfPWyHIxxjk9Yki2JK0unQ1nL0dmsQhEVMfEuR2hiCloGj21j5owaqyxb0fYLQ718nEaO3VoZ7LfuhOXzBQD+eGzZuu6FKqYbWCpc9e2erEfJ1Ul
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:SJ0PR11MB6765.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230028)(396003)(346002)(39860400002)(376002)(136003)(366004)(451199021)(83380400001)(76116006)(107886003)(7696005)(71200400001)(186003)(26005)(54906003)(6506007)(478600001)(53546011)(9686003)(38070700005)(2906002)(52536014)(38100700002)(5660300002)(82960400001)(122000001)(66556008)(66446008)(4326008)(66476007)(41300700001)(6916009)(64756008)(33656002)(66946007)(316002)(8676002)(8936002)(86362001)(55016003);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?UVdoMjhOQXB1YlRRY04zTTBsLytlTS9mdmdoMWJ1aUlzdDdhd3R4aW0r?=
=?iso-2022-jp?B?dm5xRjREcEx1S2hqT3BnS3NaQTMxc2V0cmVUUlFjaGRJWFR4VWVoS0Ew?=
=?iso-2022-jp?B?RjZGK3BKb2dBQ3Y3VFZwbTJUaVJBajdrL0tMN2F2TjFaQjIwTHI0SnBz?=
=?iso-2022-jp?B?LzdTN1gwNGFWc09SUjBaMEd3QVVtVnA2cHljbm1ZZndjMzByaFdoR2pY?=
=?iso-2022-jp?B?Nnk4WktlSFpPaFl1NTdTY2FHSlBUaVlIQ2F3QnRHRVc4bjlyajU5emo2?=
=?iso-2022-jp?B?Q2tRdWtMTW5ualpJU2drbytBWnJTeTJqQTB4ZVpJS0xVSWZjcmpGTnZU?=
=?iso-2022-jp?B?Y2hpZitROGwwMU1GbnJYbU9wY3E5TjNENFlsY2pMY3JScE5mZTREYlBN?=
=?iso-2022-jp?B?aWZQWnRFd3AyM3lhM3kxbGNleUNsMHRnTnVkRkgrYnkxVytnamNMZ1Rn?=
=?iso-2022-jp?B?c1c0cENkS2tzbWpnandKZWZpQUdYR1FjZ0lpanVCVkpEY2owbk1tcXRF?=
=?iso-2022-jp?B?YXhjLzdrVytqRmRYbDBXL0RkbGYyWkdiN21WSTNqdzcxWWh5NWlzc2x3?=
=?iso-2022-jp?B?M1B2Q3BjaFpNMnVFOUJkRVFUNTV2SHlEUHJST08xRFJkZURBZnFyRlpB?=
=?iso-2022-jp?B?Uk1vOTZTanU4SVJ3eERQRWtlbFpNdUdiZlB2cVFlT2wxM1MvZTNha3NJ?=
=?iso-2022-jp?B?Yk5WR3k1SjAveis3ZFloVE82SmtjaEpsOWV0RkdzVWpBUGxHYTFTRU9V?=
=?iso-2022-jp?B?UEwrWnY4Qzh6Q25QR2cvRnFWQk43WlZPTVVWZDN2MHVHS0dhMWR0bVdN?=
=?iso-2022-jp?B?NjA0L1hveG1tVE9Ta3kwRERNQnVCdVk1MlNobnNIb2tKd1BYendPWkNw?=
=?iso-2022-jp?B?OGY2TmprZFAxRUFVcDZaQ3hxTUMzcVBlL05OcnZGTjByem5QZlF6dDgy?=
=?iso-2022-jp?B?c0pMQnJtQVlCZWJmSnI4R0hCc1BSODR1NXlkTXlHc3MrWGJmdExPaUFw?=
=?iso-2022-jp?B?M3hJTHpoNUhPd2pqU0RDbjBIUEtXNXI2RXpuQ3VKalpxaGJMbVY2VEdH?=
=?iso-2022-jp?B?dTc2MmhpMG1CZlpJSEM4bUh1QU8ySUozVGpmQStEV2FEdkM0NURxQ0Zx?=
=?iso-2022-jp?B?WXF5SXpoUGwxS0lPOEFlQnBzZ09zVm5xcWErbHlXV2JoRWgwbkFKWVZm?=
=?iso-2022-jp?B?UUh6c1YrQ0M3MjZwMTlPUUxnVk83Q0krYkNEZ3BDalhnUW9sMUQ5dWRV?=
=?iso-2022-jp?B?MmFJTnVIOG82aXJIN2tFQ2NLK0tmZzc5LzAxQUV0dThhNmtyREpIU0l0?=
=?iso-2022-jp?B?WDFSWU1RSU5hVVBhbDJjUDdGb3lacXNCalFWTTJRQVNoRFBuMTN2ZEtN?=
=?iso-2022-jp?B?RTBiN1N0WnllZFMvNHBKV1c3Mi9GdW1MUThENzV2cm9YNDZqQ0o3eUZQ?=
=?iso-2022-jp?B?aHRRYS9pVE5aUHRtRUpMbkQwMndRVnJzUWN5Z3VnSEtGZ29kc0h3cW9M?=
=?iso-2022-jp?B?WVRNaFE2SmJYRFdiN21xSGwzSHlZdjhnNzV5OXRmTFBWSTFmU3A3ZzZY?=
=?iso-2022-jp?B?ZTZVZnhZMnZvMEFtb25walZVcTE1UTczWnNubTB3MnlBUHJPUzZTMXVV?=
=?iso-2022-jp?B?Tm5kY0UzWnJCWGt4cEZoME5oZ1Rwb0tRdGZESVBDV3pwYWJRWmNvWDV5?=
=?iso-2022-jp?B?TVpvWU1ZRTRTTlhYT2o1MEg5aFhDSWZJc0ZPcVRCWG9uWXUxMjdVZ3Zw?=
=?iso-2022-jp?B?NnNMMWFzTWJNU1luME9POGZReVJLZEc2c1JnN3RjT3pFZlAwakZFYTlJ?=
=?iso-2022-jp?B?UlhLbk41OWkxTXFPTnRJaGliRmZXOFdSSkF1MDdPaUd2bHJHc1pMTUM1?=
=?iso-2022-jp?B?TVFwZktEWWVFb3dLZVhyWkk3VjBVd3h4azE5K05TZ2dBWm1Gekh0aFla?=
=?iso-2022-jp?B?Unl6YUM4cy94b0Q0ZGdYWlBkRk9RZkE1Wkk4NnFIYlVCdHEwa2w0eHk5?=
=?iso-2022-jp?B?NC81dkFSSUFtRU9rNEpGSXVLdkdUc2tMbVFpOUs0TS9BM0NwbUNlYXhK?=
=?iso-2022-jp?B?ZjBTQmtBZDBWek00OGFqUVRFK2cvbGtRUkVmbkc3aWxLanJGd21tQy9t?=
=?iso-2022-jp?B?WGRXRTFXa1N3b1VOUW45V2I3OUxJSXhOWU5ISkJWcEE1b1F1VlJqRnEx?=
=?iso-2022-jp?B?QmwxVmhjZnF3cTRpMzdHL1E0WHBZYjRBZFhLcVBOcUxSNzc5Zkt5YVZE?=
=?iso-2022-jp?B?MlgyMGhaREM0MzZZdXdIc3FIUHRUb0d2TXZSQTBwdGduQkttdUhORmQz?=
=?iso-2022-jp?B?Wm1XaA==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB6765.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dea07a9c-b398-46a5-32cc-08db3bb9e4c5
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2023 00:56:19.5659 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z6wd8325UsQIonPu6p6vxQXrn+gz7mdn9Ynq6qJ9cIFMohEghOXTA4S8Rh70SGD8P0DHLRAKcfSpJO2MRuOUIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5709
X-OriginatorOrg: intel.com
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
> -----Original Message-----
> From: You, KaisenX
> Sent: 2023=1B$BG/=1B(B3=1B$B7n=1B(B9=1B$BF|=1B(B 9:58
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>;
> david.marchand@redhat.com; Matz, Olivier <olivier.matz@6wind.com>;
> ferruh.yigit@amd.com; zhoumin@loongson.cn; stable@dpdk.org;
> Richardson, Bruce <bruce.richardson@intel.com>; jerinj@marvell.com;
> Burakov, Anatoly <anatoly.burakov@intel.com>
> Subject: RE: [PATCH v5] enhance NUMA affinity heuristic
>=20
>=20
>=20
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: 2023=1B$BG/=1B(B3=1B$B7n=1B(B3=1B$BF|=1B(B 22:07
> > To: Burakov, Anatoly <anatoly.burakov@intel.com>; You, KaisenX
> > <kaisenx.you@intel.com>
> > Cc: dev@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>;
> > david.marchand@redhat.com; Matz, Olivier <olivier.matz@6wind.com>;
> > ferruh.yigit@amd.com; zhoumin@loongson.cn; stable@dpdk.org;
> > Richardson, Bruce <bruce.richardson@intel.com>; jerinj@marvell.com
> > Subject: Re: [PATCH v5] enhance NUMA affinity heuristic
> >
> > I'm not comfortable with this patch.
> >
> > First, there is no comment in the code which helps to understand the lo=
gic.
> > Second, I'm afraid changing the value of the per-core variable
> > _socket_id may have an impact on some applications.
> >
Hi Thomas, I'm sorry to bother you again, but we can't think of a better so=
lution for now,
would you please give me some suggestion, and then I will modify it accordi=
ngly.
> Thank you for your reply.
> First, about comments, I can submit a new patch to add comments to help
> understand.
> Second, if you do not change the value of the per-core variable_ socket_ =
id,
> /lib/eal/common/malloc_heap.c
> malloc_get_numa_socket(void)
> {
> const struct internal_config *conf =3D eal_get_internal_configura=
tion();
> unsigned int socket_id =3D rte_socket_id(); // The return value=
of
> "rte_socket_id()" is 1
> unsigned int idx;
>=20
> if (socket_id !=3D (unsigned int)SOCKET_ID_ANY)
> return socket_id; //so return here
>=20
> This will cause return here, This function returns the socket_id of unall=
ocated
> memory.
>=20
> If you have a better solution, I can modify it.
> > 16/02/2023 03:50, You, KaisenX:
> > > From: Burakov, Anatoly <anatoly.burakov@intel.com>
> > > > On 2/1/2023 12:20 PM, Kaisen You wrote:
> > > > > Trying to allocate memory on the first detected numa node has
> > > > > less chance to find some memory actually available rather than
> > > > > on the main lcore numa node (especially when the DPDK
> > > > > application is started only on one numa node).
> > > > >
> > > > > Fixes: 705356f0811f ("eal: simplify control thread creation")
> > > > > Fixes: bb0bd346d5c1 ("eal: suggest using --lcores option")
> > > > > Cc: stable@dpdk.org
> > > > >
> > > > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > > > Signed-off-by: Kaisen You <kaisenx.you@intel.com>
> > > > > ---
> > > > > Changes since v4:
> > > > > - mod the patch title,
> > > > >
> > > > > Changes since v3:
> > > > > - add the assignment of socket_id in thread initialization,
> > > > >
> > > > > Changes since v2:
> > > > > - add uncommitted local change and fix compilation,
> > > > >
> > > > > Changes since v1:
> > > > > - accomodate for configurations with main lcore running on multip=
les
> > > > > physical cores belonging to different numa,
> > > > > ---
> > > > > lib/eal/common/eal_common_thread.c | 1 +
> > > > > lib/eal/common/malloc_heap.c | 4 ++++
> > > > > 2 files changed, 5 insertions(+)
> > > > >
> > > > > diff --git a/lib/eal/common/eal_common_thread.c
> > > > > b/lib/eal/common/eal_common_thread.c
> > > > > index 38d83a6885..21bff971f8 100644
> > > > > --- a/lib/eal/common/eal_common_thread.c
> > > > > +++ b/lib/eal/common/eal_common_thread.c
> > > > > @@ -251,6 +251,7 @@ static void *ctrl_thread_init(void *arg)
> > > > > void *routine_arg =3D params->arg;
> > > > >
> > > > > __rte_thread_init(rte_lcore_id(), cpuset);
> > > > > + RTE_PER_LCORE(_socket_id) =3D SOCKET_ID_ANY;
> > > > > params->ret =3D
> > > > > rte_thread_set_affinity_by_id(rte_thread_self(),
> > > > cpuset);
> > > > > if (params->ret !=3D 0) {
> > > > > __atomic_store_n(¶ms->ctrl_thread_status,
> > > > > diff --git a/lib/eal/common/malloc_heap.c
> > > > > b/lib/eal/common/malloc_heap.c index d7c410b786..3ee19aee15
> > 100644
> > > > > --- a/lib/eal/common/malloc_heap.c
> > > > > +++ b/lib/eal/common/malloc_heap.c
> > > > > @@ -717,6 +717,10 @@ malloc_get_numa_socket(void)
> > > > > return socket_id;
> > > > > }
> > > > >
> > > > > + socket_id =3D rte_lcore_to_socket_id(rte_get_main_lcore());
> > > > > + if (socket_id !=3D (unsigned int)SOCKET_ID_ANY)
> > > > > + return socket_id;
> > > > > +
> > > > > return rte_socket_id_by_idx(0);
> > > > > }
> > > > >
> > > >
> > > > I may be lacking context, but I don't quite get the suggested chang=
e.
> > > > From what I understand, the original has to do with assigning
> > > > lcore cpusets in such a way that an lcore ends up having two
> > > > socket ID's (because it's been assigned to CPU's on different
> > > > sockets). Why is this
> > allowed in the first place?
> > > > It seems like a user error to me, as it breaks many of the
> > > > fundamental assumptions DPDK makes.
> > > >
> > > In a dual socket system, if all used cores are in socket 1 and the
> > > NIC is in socket 1, no memory is allocated for socket 0. This is to
> > > optimize
> > memory consumption.
> > >
> > > I agree with you. If the startup parameters can ensure that both
> > > sockets allocate memory, there will be no problem.
> > > However, due to the different CPU topologies of different systems,
> > > It is difficult for users to ensure that the startup parameter
> > > contains two cpu
> > nodes.
> > >
> > > > I'm fine with using main lcore socket for control threads, I just
> > > > don't think the `socket_id !=3D SOCKET_ID_ANY` thing should be
> > > > checked here, because it apparently tries to compensate for a
> > > > problem with cpuset of the main thread, which shouldn't have
> happened to begin with.
> > > >
> > > This issue has been explained in detail in the discussion of the
> > > patch v1
> > version.
> > > I will forward the previous email to you. The content of the email
> > > will also better let you know the purpose of submitting this patch.
> >
> >