From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDA1F433A2 for ; Thu, 23 Nov 2023 02:23:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D74DF42D3F; Thu, 23 Nov 2023 02:23:29 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2092.outbound.protection.outlook.com [40.107.94.92]) by mails.dpdk.org (Postfix) with ESMTP id 821B140041; Thu, 23 Nov 2023 02:23:27 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlwLjO+Sh5wIGxi1IIBNEsMmug2lwbvHt6kzptUgUOP+YPzDrduH8og8VVEwfrHCqzsPFXS70O6n4hWM5BCUng1nojiBBwrvLKnAM20tqQg1k4N5m4F+coEZF5S4oqWSw50KVniFzDyjcIfF0NqfMMA3X1U5O1r2mTwUg3NCmf2ywTj1HxQsv26CtAtqSThJzT5XYiU7UH1K73IfZvxSYXwCm6Y0/RFQVFgQU1MXcUFtXPxlwi8IUFjR2KT4TNn+VhgpKkcePH2pH/YhRAImu4fhww+qu/ZLNjBz6NXcPYVVdXRdgaPP43XPTzRA73J6qALhUJvftWNk4a6RgBZeDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C1tyNjA4hB20SgzZXm2Zb5y7PGDEnerZEvJwK74OYYA=; b=Hc1WhAXyB0o5mDMGhu7h8xa/7gX+W6PfNEO1XCovR0h+fRF+xBvOqRX8qlN/uJ/t0P9dDeTZ9Q55c1RRTRoqsZFB9z6tHZRH3C3mAb/ErZIbZeLT08rvkfg/+ZOiNeQpKBDHM9xtqp0+kI/YwaKQWpfWg8O3F+HPZpQs6m/cmVUMxVKuFHc7+fmW9wPIkL3X7nvF+zNkzPJ0RGBTCH6cRWq1V8m6S0PZVOVNdMJc7hE776X0kTa1qJcUf5bNBDjEcmXwdC6AkdLHBNNYBVD4TdGN7RPLBHzA0z3VXw/F8YMf5m2rMiUuMKQIHsvujnil+WXI6URzC9rchuRpIaDaDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C1tyNjA4hB20SgzZXm2Zb5y7PGDEnerZEvJwK74OYYA=; b=kv4KtfX4aO2WDPcV46QJv/gdir67sNDdGPeinYL1fmzBO1zE7qM1j369WS4N60p4gIGleTWYLUa83vPq9tTMvIjcLZxqUJdLotzuSiSBZwti7LN5lhEeoyTzu1/LujOnKGeCB9bdRfx3H//u6B35pVFs/BNv6hJrYYgbF2KtBY8= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SN4PR13MB5327.namprd13.prod.outlook.com (2603:10b6:806:20a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19; Thu, 23 Nov 2023 01:23:24 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.7025.019; Thu, 23 Nov 2023 01:23:24 +0000 From: Chaoyong He To: Thomas Monjalon CC: "dev@dpdk.org" , "stable@dpdk.org" , oss-drivers , Long Wu , Nole Zhang Subject: RE: [PATCH 3/5] common/nfp: fix integer handling issues Thread-Topic: [PATCH 3/5] common/nfp: fix integer handling issues Thread-Index: AQHaF3MgISsNL1nnQkGRn+8YHHPGsbCGRWaAgADimhA= Date: Thu, 23 Nov 2023 01:23:23 +0000 Message-ID: References: <20231115032310.756221-1-chaoyong.he@corigine.com> <20231115032310.756221-4-chaoyong.he@corigine.com> <9244382.rMLUfLXkoz@thomas> In-Reply-To: <9244382.rMLUfLXkoz@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|SN4PR13MB5327:EE_ x-ms-office365-filtering-correlation-id: a51cb7af-c361-4c93-094d-08dbebc2c980 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: R2jaIaDBPUW0jcUZqOIz0CYSZjRSS7kGkin93R/92LkRrKopJKGVqsfQqbL5kPlyZlr3xU3PqawyzIY5g076tq0PFtajvEmrSG7lc+k0ahdtv9XlWd9xMRO7G1BGJa5NFF1ogOR4tR+IRCtwwhc5GyRY4ByQg6Z+XtI8r8LUdQwGvYbbMnikKa+4ASw46pyG9u1MYPiUXsfqdd4NXyYObLUA890HsRYDuLg/TosRG4wOAFkwkRuMgW4UOR7SgfWz1T2cBzJVYeGZgk3HgwZaRVSb54qOhHgf9raTBq2QsCbblZ9vusUwEtI0lppnquxoeeZJ8Ry6bXGWlZVVodmlB8G2Z1hcItfqvICZSPpL0uB0+q7urAQc8equqbFMT/N8seCzRO/v5w58DYkQWj7ENkjp7FUdxCZ0PD560p49np4FlcWfCrZ8hVyEo4M6DYxtKUBJjx9bPOSXPV3UQZp/qWk551DriyHQY0Licq8APmcCOfN5JA+E9yb35SuO+2WMgPqcIG9NxVXXaKAReA13Uxe7IX1aJsyodFMFQ/xitosDULeFijcfQzen+IEgPGnmPX3qguQ8SeWpaXBQ6jxGySEzshsCDwkiBRr218fzYnwlISXY2lWs+9TesjNpJmPxYhwu0DhZrTJIu/fOJgDPCl1SSqxpFzQZsUH5fHPtGJ0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(366004)(136003)(39830400003)(376002)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(55016003)(38070700009)(76116006)(64756008)(66946007)(66446008)(54906003)(66556008)(122000001)(66476007)(38100700002)(33656002)(86362001)(6506007)(71200400001)(107886003)(9686003)(7696005)(316002)(4744005)(2906002)(6916009)(478600001)(4326008)(5660300002)(8936002)(8676002)(44832011)(52536014)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t1mY7g7rt4B631kLPaP45QmP1mJe0CvLIgEoPQDnkkSOXZEptmpANqCZ0wFU?= =?us-ascii?Q?qGpugcbvredtJ8LvbH0+7dsWMszfYqUG2NK8B8AE6x+bISw7E6BYpHb3mfE+?= =?us-ascii?Q?4eTt3YsKBhgljfmcQ31Rj76NCD5vzddWudMG9WqIbtmPLiCGSfe0DQ9wy8yB?= =?us-ascii?Q?tsXdV4RDqLGWjAcHpQwopsTX6l2A+QB7SdCuc9zkMSMgz3jcAkhkt5nVPjPX?= =?us-ascii?Q?dw/2hlMhn9aiLGbgu0tetuMBpF8IWEC4G51Wzd78cTRO+vSb4EP4V3yADCL2?= =?us-ascii?Q?847m9cA79H84XskD4cUxDSSzDlz3DeWy1qnPIxY56mclUBz45JdGJTq9frkn?= =?us-ascii?Q?Wta8gS7S68/iEfJ+QYfu++/13Ee2MH9+watRaSDM4JBv8cB7sJyDA83Hkz3U?= =?us-ascii?Q?1GEE2wGvNx7RWWCpfS48yvXsyWwdaRUCj4F9MzrqKyX3Tdrm2ue0Pmo1GMeI?= =?us-ascii?Q?mduCIVdhOyHvFhgo6mJNgNJ+LZZsDb+/4c8wBEC2TQ3jT3h8dDduAsSQUd8K?= =?us-ascii?Q?srv01ZBVQPqZhQKcQPgtiSOrbqKpREY20j2SfnvboJs5ytU5Ef0SIUkc8t+G?= =?us-ascii?Q?ekwodf+6pNjKluy6AIkhgV8dyiwptrEEHfBiN5MCBYzOKApVI31rb9RM6sPv?= =?us-ascii?Q?JiJDt50yoDAmRS6ihebLgSI/DIOHnfB2jeZ2/OIZJcSUKCJGeuirnSCcTRmd?= =?us-ascii?Q?PEQu3cldBPfCM6GcR8Yj1uTo0vzFmZ6GHjBp3PezcALkQDiLD8b5q8ocEepE?= =?us-ascii?Q?eFILntkr/L47TzUwvA5Idw7zurQUBgcFrKGoDNpVDvVjLKC9uJDa6NTsLCyR?= =?us-ascii?Q?aofKoO5/4Un2rIknJtRR/N2lO4P27nOxMOBz8YjEExayanQOjOG77kmEkui1?= =?us-ascii?Q?KGxKQCg4qjozotmGrdbZMbiz7sOP2e+X1VHXHDlC7nPSSBH2llL5fhr3Fwcz?= =?us-ascii?Q?qhTvM28QWTwAINOBN0jbLqexrg7eo6NEWFvHHbzNeLTpePimxKJxwsP6Dg4i?= =?us-ascii?Q?vgdToFwWgz3xEiw+oG2IzJa2YMgzEJFJb8qHm3zCWDFVtLziTLvocFcLQzUQ?= =?us-ascii?Q?X4UJFuaE1MkcSOMi2GuiVxdH5UCZ9k8Ipn/cE66gS5b2DhFBAwQBZjVcxrt2?= =?us-ascii?Q?QWcMMuBO40qCgrCPm2KpM9Gdfrx9lmYu7GOoWRhIuz+uaQPY+Ev6nDSX+THL?= =?us-ascii?Q?ZEMywdRtS4ab8AqnjNPiQKCcRg2vcxj7lkCV4QkKVtUojQKCjSiTVg22UkvG?= =?us-ascii?Q?O+huGH4ABizT5ny0e3ecrVZmVIPsWDsTk9y2ZY5wX/0uwC+eq7CruazSP9gD?= =?us-ascii?Q?+B+3u+sHo4JYYWdMiXsXy00OAp9aiMbJHKpddJWSMU52E9/HnxwUjTQLS09L?= =?us-ascii?Q?CB/zWTn3epMpXqjsTw6hAoeP1pn8tkwuBKXCpbGOqv783XmcmvPx8ZpCCF0V?= =?us-ascii?Q?58aqWXAJLaq939tKLwJsRdBaUaimGVURbJLMPLhMbSloTgUWQ4aMZR47Odga?= =?us-ascii?Q?/6mO/v2/6ddMJGBPzjuGA4p4COss/TbTZdJtrfyqLkAW+QYB7fqDZnUBqrz2?= =?us-ascii?Q?M5dMLvo1i8taAU39ZAg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a51cb7af-c361-4c93-094d-08dbebc2c980 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2023 01:23:23.9646 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jq2gW3ZLaGR6G0efvXkB7aEzyBgcgmftS3+ztRPe1wzWEIhhYLxCiCA67BCebzkOylBeGwlWl+BsEsI2vVxkyMdrtMGp3b5bkTHiLyoVjw8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5327 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > 15/11/2023 04:23, Chaoyong He: > > CI found integer handling issues, overflow before widen. > > > > Coverity issue: 405351 > > Fixes: 87f5b35ba4e8 ("common/nfp: move queue logic") > > Cc: stable@dpdk.org > [...] > > - enabled_queues |=3D (1 << i); > > + enabled_queues |=3D (1ULL << i); >=20 > That's a very bad fix. > You should use RTE_BIT64() which is more explicit. >=20 > Please read rte_bitops.h, that's a nice set of macros and functions. >=20 Okay, I got it now. So, what should I do about it? Send out another patch to fix or something e= lse?