RE: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx

[Chaoyong He <chaoyong.he@corigine.com>]

[-- Attachment #1: Type: text/plain, Size: 3620 bytes --]

Hi Xueming,

After checking the logic carefully, we found this patch need not backport, because this bug is imported by another patch series which is not exist in DPDK 23.11 release version.

Really sorry about this.

From: Xueming Li <xuemingl@nvidia.com>
Sent: Wednesday, May 1, 2024 9:51 AM
To: Chaoyong He <chaoyong.he@corigine.com>; stable@dpdk.org
Cc: oss-drivers <oss-drivers@corigine.com>; Long Wu <Long.Wu@nephogine.com>; Nole Zhang <peng.zhang@corigine.com>
Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx

Some people who received this message don't often get email from xuemingl@nvidia.com<mailto:xuemingl@nvidia.com>. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
I got following compilation error:
  ../../auto/swgwork/xuemingl/workspace/dpdk/drivers/net/nfp/nfp_rxtx.c:763:14: error: no member named 'flags' in 'struct nfp_meta_parsed'
Could you please address ASAP? make sure it tested.

Thanks,
________________________________
From: Xueming Li <xuemingl@nvidia.com<mailto:xuemingl@nvidia.com>>
Sent: Wednesday, May 1, 2024 9:19 AM
To: Chaoyong He <chaoyong.he@corigine.com<mailto:chaoyong.he@corigine.com>>; stable@dpdk.org<mailto:stable@dpdk.org> <stable@dpdk.org<mailto:stable@dpdk.org>>
Cc: oss-drivers@corigine.com<mailto:oss-drivers@corigine.com> <oss-drivers@corigine.com<mailto:oss-drivers@corigine.com>>; Long Wu <long.wu@corigine.com<mailto:long.wu@corigine.com>>; Peng Zhang <peng.zhang@corigine.com<mailto:peng.zhang@corigine.com>>
Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx

Hi Chaoyong,

Thanks for your help, patch added into release queue.
________________________________
From: Chaoyong He <chaoyong.he@corigine.com<mailto:chaoyong.he@corigine.com>>
Sent: Monday, April 15, 2024 10:40 AM
To: stable@dpdk.org<mailto:stable@dpdk.org> <stable@dpdk.org<mailto:stable@dpdk.org>>
Cc: oss-drivers@corigine.com<mailto:oss-drivers@corigine.com> <oss-drivers@corigine.com<mailto:oss-drivers@corigine.com>>; Long Wu <long.wu@corigine.com<mailto:long.wu@corigine.com>>; Chaoyong He <chaoyong.he@corigine.com<mailto:chaoyong.he@corigine.com>>; Peng Zhang <peng.zhang@corigine.com<mailto:peng.zhang@corigine.com>>
Subject: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx

From: Long Wu <long.wu@corigine.com<mailto:long.wu@corigine.com>>

[ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ]

Meta data parsing should be controlled by meta data flag. So use
flag to determine if receive function can use 'port_id' meta data.

Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor")

Signed-off-by: Long Wu <long.wu@corigine.com<mailto:long.wu@corigine.com>>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com<mailto:chaoyong.he@corigine.com>>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com<mailto:peng.zhang@corigine.com>>
---
 drivers/net/nfp/nfp_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c
index 8ca651ba55..5033d659d3 100644
--- a/drivers/net/nfp/nfp_rxtx.c
+++ b/drivers/net/nfp/nfp_rxtx.c
@@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue,
                 if (unlikely(rxq->rd_p == rxq->rx_count)) /* Wrapping */
                         rxq->rd_p = 0;

-               if (meta.port_id == 0) {
+               if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) == 0) {
                         rx_pkts[avail++] = mb;
                 } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_id)) {
                         avail_multiplexed++;
--
2.27.0

[-- Attachment #2: Type: text/html, Size: 10342 bytes --]