From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B8A643FAA for ; Tue, 7 May 2024 03:56:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FF8942E3F; Tue, 7 May 2024 03:56:37 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2117.outbound.protection.outlook.com [40.107.100.117]) by mails.dpdk.org (Postfix) with ESMTP id 72C2F4027B for ; Tue, 7 May 2024 03:56:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kP09alNuJfW36q+BOJpONFYCTJQHfhNddyvtkHeHL2SrY/NXQJWasM/aZAHbck52FYFgZ9Tdjl05Anyet9zPRkj72J3rmLf0sowsg4h7fN+nbkY7MnPg1wdpQCN+ZDjYgXMqKNrnJOqT7ZRj8jKLTouVj1weC99gXQGZPg1TDt/oczlQM8exPwh6NQZnfvLcqAa6fK6JsnMnFqyE4cdm5R0nYEee25jpMm1b/1QdgqMHvmhMJsxrEonCONb6dm06lExBE8jysrrpsp7U6TImtCetwl8+7ywa2FlnJA5p3gYV/aHnycKBzux6/QBEdKVM0Vk7CRCj0NKzJBB3ySmSQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IAgZ9CehRosISZxFVtkcTQg6fHIlti2687YpbF8ojR8=; b=GYN5Tad8BWPo6tKkf/W3k6Lp3sSV7AD2+VeY3XzoWjyb5Lp+Y+i5XiunF1ftbDXUHcgWIVlqvLc77qQx/EEBxaaWZ1k6Y5jqv8J7eiFBMTeZ8AYEYS5hkBX3akCS4TT8mfOxZDloW4muNKeGdcHls8EytcN5HEK0HBkEytLDZ/pj2SBkXIrso8FmuN/6rLy6/v6AqLApKYJQyIiq1SfCYXMe/zY06T/zzT4ud9QxJ7eCYdcG/4tAmcRi1fagwhoJJXyGQ4pPfh9v8nAY9Pnn8szP/Z+iWeoKg7A0aVTGgCLhl3/O7DUTLBlNZ1lCpfh9qRKt/I7JSvhLwAeejNYUZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IAgZ9CehRosISZxFVtkcTQg6fHIlti2687YpbF8ojR8=; b=okM4QEPBTkLb4PN1Zn6Xn2hMgRVBkDdfBaivlca8a2f3GGjRykNDtP36QlLQPbU9RPYzq/7a/Zif8eOoMGuPTxFniq/GJ87PC3x16mDhB0285rQ9WdDZDkuXiJKEW5EzY4+h+ylvyK+BQtMkK0pv5ewA5dgkaEyfO1Kn+d4oaHk= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DS7PR13MB4592.namprd13.prod.outlook.com (2603:10b6:5:38d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Tue, 7 May 2024 01:56:32 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7544.041; Tue, 7 May 2024 01:56:31 +0000 From: Chaoyong He To: Xueming Li , "stable@dpdk.org" CC: oss-drivers , Long Wu , Nole Zhang Subject: RE: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Thread-Topic: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Thread-Index: AQHajt5GwTxMi64t+UGyuxvQU1Tac7GBrXiAgAAI0ICACW7FcA== Date: Tue, 7 May 2024 01:56:31 +0000 Message-ID: References: <20240415024008.1000358-1-chaoyong.he@corigine.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|DS7PR13MB4592:EE_ x-ms-office365-filtering-correlation-id: d28e9cf3-ad00-4077-9638-08dc6e38eae5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|366007|1800799015|376005|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?Xkn0x3VTYS5a0eqcpq8CHjS+Dsxsl5rlLeMKMACdJOn4XQzeRk9RLUQbH0xj?= =?us-ascii?Q?8J2JFWoEZ7cJ78Dtid4D5/DwGvvgd/pgWYLwZJvaxnLgUfhz1qJjDpRfLihW?= =?us-ascii?Q?Q/ToZgGtWyqmNxNneyW6Yocp5TyJ+1321tmqudLW57cwF8YINwd+3xbndpZM?= =?us-ascii?Q?+WAFbgaUaFrj9Gtu/lnPXTs77f+hpGbNLnaZO6Wq8xh8LhsGVDQY7sNWhWSm?= =?us-ascii?Q?RFzX6XVeIaAntSOEG12Fd6r4UNfcY95p7exkk1wnrMioZ0+CgS7W/3VjL3r8?= =?us-ascii?Q?F4lbzVPCygH8N4OGI1jPj/K1d1snoSf9k5BsHR8TdIdSs7i6pwQ1uDd9DHHY?= =?us-ascii?Q?rGc8tPobK6Hn1ddNDJMaIHlToH4qFeDUtI9QkWd39fCw5SYlVyeDoAk6OJOp?= =?us-ascii?Q?KgGExJKpLjX+aQzQptWxNQ4F4BrTCKiUyw6J2krQ7vIKgKHu2WZcu7P3N2/G?= =?us-ascii?Q?eDIPGV8qOipSoLGblyuohGx22LBwkNS6OMGKrM75VT6v+0IFDovF94+sutx8?= =?us-ascii?Q?evJxX9mOn2MEgxcMDE2c/ww5VD8qZFOcF5+v5gaYTW1lWX6uWxJ8vMQWuKX2?= =?us-ascii?Q?diSeCvAI5y9hMN+l7jq2mCbM3PGV+/FPfBoYAJip+iGfT/g0jJh+WRZc0yyT?= =?us-ascii?Q?YTB5BPy/lDp1R+glpNfW3xzUK9pkmEzQsGAMUXQ6nbPwZBWQ+LuldL9hpl/d?= =?us-ascii?Q?MRrw/uDvEBt5WwMVgBVl88ZW6ExLxlkaRZ0j/s1P7HjulubdwMdfsUafTAeQ?= =?us-ascii?Q?PsI2tDcd/15B+HGEMvPBUxUiO2yNaPYUABqRGtYT9yFsSgK4INv3ieVZyYa4?= =?us-ascii?Q?Cs/LywW2/EYsYV8DDVbOFbisU16nManRmi8i8G7wEdaYBNblbjsQhEhfzTQo?= =?us-ascii?Q?DhhyzhdlqqHx4ASCN0Nw6LdAJqEqHsNSZuZ/S361JOsL35e3D10sr2FCTib7?= =?us-ascii?Q?5UzOwiEXpQWZM+KCCJP4Oqda72vapESd1Ct5Sc61K/+W7pleU9bdiO/de0I1?= =?us-ascii?Q?cWmkwe086NPyqtBS2O1Zum3Hpz09eDKjBhJVjkz1TotUtGzqs491Jy8evNxz?= =?us-ascii?Q?RnC832wcH38NH6OX/XtExzwFoU88BBdd0nBhFW8mJeTCTSnpE9lK7DLD99sq?= =?us-ascii?Q?wj5FeikJ8boqoq2WOaQ4hwLPiO1NLr41Xvip0A1j8aZCDsEUtC+VIYjUyGEB?= =?us-ascii?Q?p2HUJmPxC5x34QH+UnwEof8wnYZm03dpB8uE/GvOc0awvPEkpjOfm1eHA/mW?= =?us-ascii?Q?MaBAW6U7EusaUxQxpUCYs5RQYaNVxRvvWigL8AU5CcJlgLkstdArwIXOob/z?= =?us-ascii?Q?XfGpulmT/jEMldlilUdaVg4itlQCNBBojz/xgCG5qLuzsQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/TKCB150+Eazkdc6NJZJSr/iTjXrpVH0G3qEOw96K4H/wPBaQJvHyIuRjPgW?= =?us-ascii?Q?nV6/97yDbbhlfhsoNpAEf9K9UcdIPV0C0PpjSsUN1pMSmUC1HaI1eVqgYgrx?= =?us-ascii?Q?Xgh2nhAVZQPbMxnxOf2W2AP5/xkprb/ROae+aoA+dOK6iqTLwDuIJ9+Xko3E?= =?us-ascii?Q?Fez+bUakZLnJsv0jIJS+CuYcaa2s8BseVnJhGYOiQbNJaabcazLLkrIY3zNZ?= =?us-ascii?Q?tbzM0+KW39Cbqie9Gn3OXEWbim4uIOS2Akbt8GY7VB2dot1k4occR0DRaskF?= =?us-ascii?Q?VBiTK9mw/CaqbKOtAKOxspOigkH4geHFkhXmfHHtP5EJgIdkukG+IkoJ4hP1?= =?us-ascii?Q?Ms3o1x2tCgMq+FMkhE5I1O+vdsysoawO2RbNP28mEoQQt72GHdE+LtUSdZq0?= =?us-ascii?Q?xQ8VLBocsQSGOV19WaOFictUXi3NRKxthvrtcO3w0TeDi3TxjYiGrgcDU35k?= =?us-ascii?Q?a3dvsQSvTa5KCwiB57T5CvNBcprTxQltg7ZzBBhCkd/lvEQKMaDS8vCXF/gO?= =?us-ascii?Q?gvnSzAVcxSv2s3y7md6Y65Cjs5XqxUkWdkHe2N7wZD0e+YYFM4nNVEYmNdjK?= =?us-ascii?Q?7Nqn725Vc64dCon5AvRhCN62xUPxXDhGiDEHoktW15USYWPV5pzraRLdubGF?= =?us-ascii?Q?0rKtxGE2gaKEzxIOMmlOl0lQSfEYltfPixzPCmkYLG2LIeGOBN5AUpL1gPTX?= =?us-ascii?Q?G3WkcImpAUmcCfkbbe770XmMOv8S4jBag3PznuuxI0Bdz3jV+4mNWqn+2Tys?= =?us-ascii?Q?sDJExo9WJxWyHUHXpJqmrGKTDZfqdI1xsRNJIpS/NqEz79/2ts7B7YZYaGK3?= =?us-ascii?Q?zvHXK9P4+PK9GAh5e+V3OOdFFrLRxxcXDkFdXEgYGaBUcFLPIVJctfAsNBnS?= =?us-ascii?Q?0IkoVAHD3hDjDwku/izqMVUW4oxwrCRkFJ1OfkuZPL8IylKWR+qqMkiBWap7?= =?us-ascii?Q?EaJmDTfGaL9GNH0G71oPF9J/gJ8gkBAGEaEY8wg9/lQkDZiyUa419lfOPDG8?= =?us-ascii?Q?sfBB7QnHxJaWMM3lCX7kEE/UZPYsL0XOHe5Dy8R2BUCe90sd6HivSdaRvGht?= =?us-ascii?Q?nP8cWlz+bEjx9nC3LSw5VEcxlz5as3tNfvddBjkWE9hj08vlfJKJjSBSfSlf?= =?us-ascii?Q?clVCx4YUA1w7YzLElAnTOMBgOW+KftNvK0lmimT3RFmc5Ngj2xrj3O5ARwR1?= =?us-ascii?Q?bitSbs2mpaO3YOqXRlvH/CIGHNYks+OhPPDwtuiEZEKefNOHVItyivkLYJX7?= =?us-ascii?Q?aJdnBls5rWZh1OqWX2ktJL8WaJvn6vYaEbog85KLCN+02KxAtEvk9oB7vRuT?= =?us-ascii?Q?0ZiJDZyjFjizuvVm+b3pX2d78VxLSqJJMHrNCDISfCvWT9nz4bWTAPEHL8Sq?= =?us-ascii?Q?DPP0CvGNwZDnW2/JwXOiy94hOZR/LaVVGzVXulNJ5oHt0hKKErep/aq79ya3?= =?us-ascii?Q?wM2ig+/6Jfl/dO+wT6qdTflgLCXOrFztzIXbWie9OYktJYEPpIDlUEby4ypi?= =?us-ascii?Q?YdytTbQ9mh+DKHB8moZjL1qIJXhDWNTs4LN07WXyUo7VU3bWAq4GHFctHoog?= =?us-ascii?Q?C4FDS2mELgQQQxhCtXZk1dZ1z1Fp5g+7MyEs3QGJ?= Content-Type: multipart/alternative; boundary="_000_SJ0PR13MB5545F8C1FCD33ECF3F2436AA9EE42SJ0PR13MB5545namp_" MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d28e9cf3-ad00-4077-9638-08dc6e38eae5 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2024 01:56:31.7363 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lw727Tb4sBXzY85osynM4EoPxgTVDWpFwuzC0giN1/ao+cUHkb3uyhlCzX/miI+HFs81H3HFXIKBrD9C5YXd2+4theebpPQqH5ivwYKixCk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR13MB4592 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --_000_SJ0PR13MB5545F8C1FCD33ECF3F2436AA9EE42SJ0PR13MB5545namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Xueming, After checking the logic carefully, we found this patch need not backport, = because this bug is imported by another patch series which is not exist in = DPDK 23.11 release version. Really sorry about this. From: Xueming Li Sent: Wednesday, May 1, 2024 9:51 AM To: Chaoyong He ; stable@dpdk.org Cc: oss-drivers ; Long Wu = ; Nole Zhang Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Some people who received this message don't often get email from xuemingl@n= vidia.com. Learn why this is important I got following compilation error: ../../auto/swgwork/xuemingl/workspace/dpdk/drivers/net/nfp/nfp_rxtx.c:763= :14: error: no member named 'flags' in 'struct nfp_meta_parsed' Could you please address ASAP? make sure it tested. Thanks, ________________________________ From: Xueming Li > Sent: Wednesday, May 1, 2024 9:19 AM To: Chaoyong He >= ; stable@dpdk.org > Cc: oss-drivers@corigine.com >; Long Wu >; Peng Zhang > Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Hi Chaoyong, Thanks for your help, patch added into release queue. ________________________________ From: Chaoyong He > Sent: Monday, April 15, 2024 10:40 AM To: stable@dpdk.org > Cc: oss-drivers@corigine.com >; Long Wu >; Chaoyong He >; Peng Zhang > Subject: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx From: Long Wu > [ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ] Meta data parsing should be controlled by meta data flag. So use flag to determine if receive function can use 'port_id' meta data. Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor") Signed-off-by: Long Wu > Reviewed-by: Chaoyong He > Reviewed-by: Peng Zhang > --- drivers/net/nfp/nfp_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 8ca651ba55..5033d659d3 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue, if (unlikely(rxq->rd_p =3D=3D rxq->rx_count)) /* Wrapping = */ rxq->rd_p =3D 0; - if (meta.port_id =3D=3D 0) { + if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) =3D=3D 0) { rx_pkts[avail++] =3D mb; } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_i= d)) { avail_multiplexed++; -- 2.27.0 --_000_SJ0PR13MB5545F8C1FCD33ECF3F2436AA9EE42SJ0PR13MB5545namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Xueming,

 

After checking the = logic carefully, we found this patch need not backport, because this bug is= imported by another patch series which is not exist in DPDK 23.11 release = version.

 

Really sorry about = this.

 

From: Xueming Li <xuemingl@nvidia= .com>
Sent: Wednesday, May 1, 2024 9:51 AM
To: Chaoyong He <chaoyong.he@corigine.com>; stable@dpdk.org Cc: oss-drivers <oss-drivers@corigine.com>; Long Wu <Long.W= u@nephogine.com>; Nole Zhang <peng.zhang@corigine.com>
Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx<= o:p>

 

Some people who received this message don't often get email = from xuemingl@nvidia.com. Learn why this is important

I got following compilation error:

  ../../auto/swgwork/xuemingl/workspace/dpdk/drivers/net/nfp/nf= p_rxtx.c:763:14: error: no member named 'flags' in 'struct nfp_meta_parsed'=

Could you please address= ASAP? make sure it tested.

 =

Thanks,

From: Xuemin= g Li <xuemingl@nvidia.com>=
Sent: Wednesday, May 1, 2024 9:19 AM
To: Chaoyong He <chao= yong.he@corigine.com>; stable@dpdk.org <stable@dpdk.org>
Cc: oss-drivers@corigine= .com <oss-drivers@corigi= ne.com>; Long Wu <long.wu= @corigine.com>; Peng Zhang <peng.zhang@corigine.com>
Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx<= /span>

 

Hi Chaoyong,<= /span>

 =

Thanks for your help, pa= tch added into release queue.

From: Chaoyo= ng He <chaoyong.he@corigine.= com>
Sent: Monday, April 15, 2024 10:40 AM
To: stable@dpdk.org <stable@dpdk.org>
Cc: oss-drivers@corigine= .com <oss-drivers@corigi= ne.com>; Long Wu <long.wu= @corigine.com>; Chaoyong He <chaoyong.he@corigine.com>; Peng Zhang <peng.zhang@corig= ine.com>
Subject: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx

 

From: Long Wu <long.= wu@corigine.com>

[ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ]

Meta data parsing should be controlled by meta data flag. So use
flag to determine if receive function can use 'port_id' meta data.

Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor")

Signed-off-by: Long Wu <long.wu@= corigine.com>
Reviewed-by: Chaoyong He <ch= aoyong.he@corigine.com>
Reviewed-by: Peng Zhang <peng= .zhang@corigine.com>
---
 drivers/net/nfp/nfp_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c
index 8ca651ba55..5033d659d3 100644
--- a/drivers/net/nfp/nfp_rxtx.c
+++ b/drivers/net/nfp/nfp_rxtx.c
@@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue,
            &nb= sp;    if (unlikely(rxq->rd_p =3D=3D rxq->rx_count)) /= * Wrapping */
            &nb= sp;            rxq-&= gt;rd_p =3D 0;
 
-            &n= bsp;  if (meta.port_id =3D=3D 0) {
+            &n= bsp;  if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) =3D=3D= 0) {
            &nb= sp;            rx_pk= ts[avail++] =3D mb;
            &nb= sp;    } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.p= ort_id)) {
            &nb= sp;            avail= _multiplexed++;
--
2.27.0

--_000_SJ0PR13MB5545F8C1FCD33ECF3F2436AA9EE42SJ0PR13MB5545namp_--