* [PATCH 23.11] net/nfp: fix port ID meta data use in Rx
@ 2024-04-15 2:40 Chaoyong He
2024-05-01 1:19 ` Xueming Li
0 siblings, 1 reply; 5+ messages in thread
From: Chaoyong He @ 2024-04-15 2:40 UTC (permalink / raw)
To: stable; +Cc: oss-drivers, Long Wu, Chaoyong He, Peng Zhang
From: Long Wu <long.wu@corigine.com>
[ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ]
Meta data parsing should be controlled by meta data flag. So use
flag to determine if receive function can use 'port_id' meta data.
Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor")
Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
drivers/net/nfp/nfp_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c
index 8ca651ba55..5033d659d3 100644
--- a/drivers/net/nfp/nfp_rxtx.c
+++ b/drivers/net/nfp/nfp_rxtx.c
@@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue,
if (unlikely(rxq->rd_p == rxq->rx_count)) /* Wrapping */
rxq->rd_p = 0;
- if (meta.port_id == 0) {
+ if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) == 0) {
rx_pkts[avail++] = mb;
} else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_id)) {
avail_multiplexed++;
--
2.27.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx 2024-04-15 2:40 [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Chaoyong He @ 2024-05-01 1:19 ` Xueming Li 2024-05-01 1:50 ` Xueming Li 0 siblings, 1 reply; 5+ messages in thread From: Xueming Li @ 2024-05-01 1:19 UTC (permalink / raw) To: Chaoyong He, stable; +Cc: oss-drivers, Long Wu, Peng Zhang [-- Attachment #1: Type: text/plain, Size: 1654 bytes --] Hi Chaoyong, Thanks for your help, patch added into release queue. ________________________________ From: Chaoyong He <chaoyong.he@corigine.com> Sent: Monday, April 15, 2024 10:40 AM To: stable@dpdk.org <stable@dpdk.org> Cc: oss-drivers@corigine.com <oss-drivers@corigine.com>; Long Wu <long.wu@corigine.com>; Chaoyong He <chaoyong.he@corigine.com>; Peng Zhang <peng.zhang@corigine.com> Subject: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx From: Long Wu <long.wu@corigine.com> [ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ] Meta data parsing should be controlled by meta data flag. So use flag to determine if receive function can use 'port_id' meta data. Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor") Signed-off-by: Long Wu <long.wu@corigine.com> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com> Reviewed-by: Peng Zhang <peng.zhang@corigine.com> --- drivers/net/nfp/nfp_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 8ca651ba55..5033d659d3 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue, if (unlikely(rxq->rd_p == rxq->rx_count)) /* Wrapping */ rxq->rd_p = 0; - if (meta.port_id == 0) { + if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) == 0) { rx_pkts[avail++] = mb; } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_id)) { avail_multiplexed++; -- 2.27.0 [-- Attachment #2: Type: text/html, Size: 3673 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx 2024-05-01 1:19 ` Xueming Li @ 2024-05-01 1:50 ` Xueming Li 2024-05-07 1:56 ` Chaoyong He 0 siblings, 1 reply; 5+ messages in thread From: Xueming Li @ 2024-05-01 1:50 UTC (permalink / raw) To: Chaoyong He, stable; +Cc: oss-drivers, Long Wu, Peng Zhang [-- Attachment #1: Type: text/plain, Size: 2287 bytes --] I got following compilation error: ../../auto/swgwork/xuemingl/workspace/dpdk/drivers/net/nfp/nfp_rxtx.c:763:14: error: no member named 'flags' in 'struct nfp_meta_parsed' Could you please address ASAP? make sure it tested. Thanks, ________________________________ From: Xueming Li <xuemingl@nvidia.com> Sent: Wednesday, May 1, 2024 9:19 AM To: Chaoyong He <chaoyong.he@corigine.com>; stable@dpdk.org <stable@dpdk.org> Cc: oss-drivers@corigine.com <oss-drivers@corigine.com>; Long Wu <long.wu@corigine.com>; Peng Zhang <peng.zhang@corigine.com> Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Hi Chaoyong, Thanks for your help, patch added into release queue. ________________________________ From: Chaoyong He <chaoyong.he@corigine.com> Sent: Monday, April 15, 2024 10:40 AM To: stable@dpdk.org <stable@dpdk.org> Cc: oss-drivers@corigine.com <oss-drivers@corigine.com>; Long Wu <long.wu@corigine.com>; Chaoyong He <chaoyong.he@corigine.com>; Peng Zhang <peng.zhang@corigine.com> Subject: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx From: Long Wu <long.wu@corigine.com> [ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ] Meta data parsing should be controlled by meta data flag. So use flag to determine if receive function can use 'port_id' meta data. Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor") Signed-off-by: Long Wu <long.wu@corigine.com> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com> Reviewed-by: Peng Zhang <peng.zhang@corigine.com> --- drivers/net/nfp/nfp_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 8ca651ba55..5033d659d3 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue, if (unlikely(rxq->rd_p == rxq->rx_count)) /* Wrapping */ rxq->rd_p = 0; - if (meta.port_id == 0) { + if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) == 0) { rx_pkts[avail++] = mb; } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_id)) { avail_multiplexed++; -- 2.27.0 [-- Attachment #2: Type: text/html, Size: 5605 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx 2024-05-01 1:50 ` Xueming Li @ 2024-05-07 1:56 ` Chaoyong He 2024-05-07 2:05 ` Xueming Li 0 siblings, 1 reply; 5+ messages in thread From: Chaoyong He @ 2024-05-07 1:56 UTC (permalink / raw) To: Xueming Li, stable; +Cc: oss-drivers, Long Wu, Nole Zhang [-- Attachment #1: Type: text/plain, Size: 3620 bytes --] Hi Xueming, After checking the logic carefully, we found this patch need not backport, because this bug is imported by another patch series which is not exist in DPDK 23.11 release version. Really sorry about this. From: Xueming Li <xuemingl@nvidia.com> Sent: Wednesday, May 1, 2024 9:51 AM To: Chaoyong He <chaoyong.he@corigine.com>; stable@dpdk.org Cc: oss-drivers <oss-drivers@corigine.com>; Long Wu <Long.Wu@nephogine.com>; Nole Zhang <peng.zhang@corigine.com> Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Some people who received this message don't often get email from xuemingl@nvidia.com<mailto:xuemingl@nvidia.com>. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> I got following compilation error: ../../auto/swgwork/xuemingl/workspace/dpdk/drivers/net/nfp/nfp_rxtx.c:763:14: error: no member named 'flags' in 'struct nfp_meta_parsed' Could you please address ASAP? make sure it tested. Thanks, ________________________________ From: Xueming Li <xuemingl@nvidia.com<mailto:xuemingl@nvidia.com>> Sent: Wednesday, May 1, 2024 9:19 AM To: Chaoyong He <chaoyong.he@corigine.com<mailto:chaoyong.he@corigine.com>>; stable@dpdk.org<mailto:stable@dpdk.org> <stable@dpdk.org<mailto:stable@dpdk.org>> Cc: oss-drivers@corigine.com<mailto:oss-drivers@corigine.com> <oss-drivers@corigine.com<mailto:oss-drivers@corigine.com>>; Long Wu <long.wu@corigine.com<mailto:long.wu@corigine.com>>; Peng Zhang <peng.zhang@corigine.com<mailto:peng.zhang@corigine.com>> Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Hi Chaoyong, Thanks for your help, patch added into release queue. ________________________________ From: Chaoyong He <chaoyong.he@corigine.com<mailto:chaoyong.he@corigine.com>> Sent: Monday, April 15, 2024 10:40 AM To: stable@dpdk.org<mailto:stable@dpdk.org> <stable@dpdk.org<mailto:stable@dpdk.org>> Cc: oss-drivers@corigine.com<mailto:oss-drivers@corigine.com> <oss-drivers@corigine.com<mailto:oss-drivers@corigine.com>>; Long Wu <long.wu@corigine.com<mailto:long.wu@corigine.com>>; Chaoyong He <chaoyong.he@corigine.com<mailto:chaoyong.he@corigine.com>>; Peng Zhang <peng.zhang@corigine.com<mailto:peng.zhang@corigine.com>> Subject: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx From: Long Wu <long.wu@corigine.com<mailto:long.wu@corigine.com>> [ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ] Meta data parsing should be controlled by meta data flag. So use flag to determine if receive function can use 'port_id' meta data. Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor") Signed-off-by: Long Wu <long.wu@corigine.com<mailto:long.wu@corigine.com>> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com<mailto:chaoyong.he@corigine.com>> Reviewed-by: Peng Zhang <peng.zhang@corigine.com<mailto:peng.zhang@corigine.com>> --- drivers/net/nfp/nfp_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 8ca651ba55..5033d659d3 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue, if (unlikely(rxq->rd_p == rxq->rx_count)) /* Wrapping */ rxq->rd_p = 0; - if (meta.port_id == 0) { + if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) == 0) { rx_pkts[avail++] = mb; } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_id)) { avail_multiplexed++; -- 2.27.0 [-- Attachment #2: Type: text/html, Size: 10342 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx 2024-05-07 1:56 ` Chaoyong He @ 2024-05-07 2:05 ` Xueming Li 0 siblings, 0 replies; 5+ messages in thread From: Xueming Li @ 2024-05-07 2:05 UTC (permalink / raw) To: Chaoyong He, stable; +Cc: oss-drivers, Long Wu, Nole Zhang [-- Attachment #1: Type: text/plain, Size: 4130 bytes --] Ok, thanks for letting me know. 获取Outlook for Android<https://aka.ms/AAb9ysg> ________________________________ From: Chaoyong He <chaoyong.he@corigine.com> Sent: Tuesday, May 7, 2024 9:56:31 AM To: Xueming Li <xuemingl@nvidia.com>; stable@dpdk.org <stable@dpdk.org> Cc: oss-drivers <oss-drivers@corigine.com>; Long Wu <Long.Wu@nephogine.com>; Nole Zhang <peng.zhang@corigine.com> Subject: RE: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Hi Xueming, After checking the logic carefully, we found this patch need not backport, because this bug is imported by another patch series which is not exist in DPDK 23.11 release version. Really sorry about this. From: Xueming Li <xuemingl@nvidia.com> Sent: Wednesday, May 1, 2024 9:51 AM To: Chaoyong He <chaoyong.he@corigine.com>; stable@dpdk.org Cc: oss-drivers <oss-drivers@corigine.com>; Long Wu <Long.Wu@nephogine.com>; Nole Zhang <peng.zhang@corigine.com> Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Some people who received this message don't often get email from xuemingl@nvidia.com<mailto:xuemingl@nvidia.com>. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> I got following compilation error: ../../auto/swgwork/xuemingl/workspace/dpdk/drivers/net/nfp/nfp_rxtx.c:763:14: error: no member named 'flags' in 'struct nfp_meta_parsed' Could you please address ASAP? make sure it tested. Thanks, ________________________________ From: Xueming Li <xuemingl@nvidia.com<mailto:xuemingl@nvidia.com>> Sent: Wednesday, May 1, 2024 9:19 AM To: Chaoyong He <chaoyong.he@corigine.com<mailto:chaoyong.he@corigine.com>>; stable@dpdk.org<mailto:stable@dpdk.org> <stable@dpdk.org<mailto:stable@dpdk.org>> Cc: oss-drivers@corigine.com<mailto:oss-drivers@corigine.com> <oss-drivers@corigine.com<mailto:oss-drivers@corigine.com>>; Long Wu <long.wu@corigine.com<mailto:long.wu@corigine.com>>; Peng Zhang <peng.zhang@corigine.com<mailto:peng.zhang@corigine.com>> Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Hi Chaoyong, Thanks for your help, patch added into release queue. ________________________________ From: Chaoyong He <chaoyong.he@corigine.com<mailto:chaoyong.he@corigine.com>> Sent: Monday, April 15, 2024 10:40 AM To: stable@dpdk.org<mailto:stable@dpdk.org> <stable@dpdk.org<mailto:stable@dpdk.org>> Cc: oss-drivers@corigine.com<mailto:oss-drivers@corigine.com> <oss-drivers@corigine.com<mailto:oss-drivers@corigine.com>>; Long Wu <long.wu@corigine.com<mailto:long.wu@corigine.com>>; Chaoyong He <chaoyong.he@corigine.com<mailto:chaoyong.he@corigine.com>>; Peng Zhang <peng.zhang@corigine.com<mailto:peng.zhang@corigine.com>> Subject: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx From: Long Wu <long.wu@corigine.com<mailto:long.wu@corigine.com>> [ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ] Meta data parsing should be controlled by meta data flag. So use flag to determine if receive function can use 'port_id' meta data. Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor") Signed-off-by: Long Wu <long.wu@corigine.com<mailto:long.wu@corigine.com>> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com<mailto:chaoyong.he@corigine.com>> Reviewed-by: Peng Zhang <peng.zhang@corigine.com<mailto:peng.zhang@corigine.com>> --- drivers/net/nfp/nfp_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 8ca651ba55..5033d659d3 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue, if (unlikely(rxq->rd_p == rxq->rx_count)) /* Wrapping */ rxq->rd_p = 0; - if (meta.port_id == 0) { + if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) == 0) { rx_pkts[avail++] = mb; } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_id)) { avail_multiplexed++; -- 2.27.0 [-- Attachment #2: Type: text/html, Size: 9734 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-07 2:05 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-04-15 2:40 [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Chaoyong He 2024-05-01 1:19 ` Xueming Li 2024-05-01 1:50 ` Xueming Li 2024-05-07 1:56 ` Chaoyong He 2024-05-07 2:05 ` Xueming Li
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).