From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C37AD45B0C for ; Fri, 11 Oct 2024 04:31:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AFD0402E0; Fri, 11 Oct 2024 04:31:08 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2094.outbound.protection.outlook.com [40.107.243.94]) by mails.dpdk.org (Postfix) with ESMTP id 5407A402E0; Fri, 11 Oct 2024 04:31:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LZdO62xWQFucPemsqs9gpk80YA1h71v7bs37ds+OtFLyUq3jUxuX54iCdVdldXo8N31WS0McIyGgqQ8sFB4hq1zTEXRB6l+gGPSHrWfRPKsS3R83zBjh5rUtoy7//UEsDkNEiaaeAS0lL8zXhw4GHxN7Gy+/HM/pX10NA2LTCZ4eJhrcTPHRPrfO47PMx5r2dnYNrvCukHIvrvrNxJJp3LTS+lltkCtXnVzCa7FSd90INSFySQd6VJo2y3ETESaVv5FHGutMPdA90Nhk17KIx9beFq9vmeJ0sCpzBkCgP1CdecioGiEz7f6yJFRk7qSsngMOV4V0Gib5xs1l5oxzSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9IdFWaeMyIF2vQFlbDqmMddkkidfBrD1hEGsi9QHU10=; b=GhOVoe7E0hvsKRRETXBHd5xd5I0MxRgRdHIhV6UTPoLXLJdY4QnH2VPXmb2cmlUo4AMChczVSqUr75W5CDkWEo8kJN7rhTwZLOCik+AXSIv6Jt5UKubmHb7FxqOEPpnY3CFSbgfcK0i50dGigj2ILDAO5wDmpbgO/vMRrPIXZI8+psgMyWituQQCBpx5Ome657sNei9IjhHcKAyqcX1lS+KN+bFPxo5f3DgtIdNcNuNGZU2UWVPp8H62ahGQRj/rxQK9yFy918Kg5OoZSwAqaVegBfOyzqNTtMcP4jlAcece2VvmROd4SZD7wLoXHVnJ6KJeuVop77bYTIYmexNqjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9IdFWaeMyIF2vQFlbDqmMddkkidfBrD1hEGsi9QHU10=; b=i11EOBMg22euCz9/Q+tWbfbXqn06g3oqicyZmh+vAItXzHLuYZz2YxXqYuRNPESxHQlgl3Jdmgbd9GR8tX8F34VNlr+16IA9M50GSqKz2W5PU099++hDke1u44K57Cl/DH5q0O9en1GE6R08MBS1z1a1TVnOQJakvARig+2NWEg= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB3731.namprd13.prod.outlook.com (2603:10b6:a03:219::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Fri, 11 Oct 2024 02:31:03 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%5]) with mapi id 15.20.8026.020; Fri, 11 Oct 2024 02:31:03 +0000 From: Chaoyong He To: Stephen Hemminger CC: "dev@dpdk.org" , oss-drivers , Nole Zhang , "stable@dpdk.org" , Long Wu Subject: RE: [PATCH 02/10] net/nfp: fix malloc name problem in secondary process Thread-Topic: [PATCH 02/10] net/nfp: fix malloc name problem in secondary process Thread-Index: AQHbGvVBnZcnV3wv1kq4uGcr6tt2orKAFmKAgAC9eAA= Date: Fri, 11 Oct 2024 02:31:03 +0000 Message-ID: References: <20241010091716.3631747-1-chaoyong.he@corigine.com> <20241010091716.3631747-3-chaoyong.he@corigine.com> <20241010080741.0840401f@hermes.local> In-Reply-To: <20241010080741.0840401f@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|BY5PR13MB3731:EE_ x-ms-office365-filtering-correlation-id: ce1e71e7-9440-4c27-8d2c-08dce99cc09a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?eeFu5yNjphwORZ64MecZQW51S7aaREgWlphSlb+XUFalbRNMy82NTHe51a6D?= =?us-ascii?Q?ua5Qs5/N11umbToYLPXxOB/R0CbOTYcWiZO1DAQuBqgqaB3BpAVMExLloD7+?= =?us-ascii?Q?XUwK3eCmWP5XCQWCcE8Oxu5Ibd5S8viGbtjgWHWDZOrnzlW0jlguj5nxEFdu?= =?us-ascii?Q?Frqzx5QwCdsU/aYjjcdAPgYciIxcki/cW6xq1kzCl4DSpRBAglK4e9sMwSRz?= =?us-ascii?Q?rP8W/CgXTlbQPxaIi37Cw77Ez2U44rPcWj5nCWFROBF7RAF0IzSr81zUe7iX?= =?us-ascii?Q?M2+OdeyuypMBGqy/GrkdM/EOAuorCjtWn7Z7j1PcU9x1G6zKMEYkE8n+d2TY?= =?us-ascii?Q?FqHLjMwmcLmo6hB1TFdZ6v3kp4vRuFZ3ZQiXdRojVlcYZyR6BuoNtwZervGa?= =?us-ascii?Q?iajx3/6knZbxSfdBHVe7/mheITRY4GiS3dKKHGiCnElA1peVApWQ6chfNw3u?= =?us-ascii?Q?qsufaKeaqJJskzKOfMHmSDcOvNFTXZRL3yrhJpepr06iVA0uG9egkqsI2A9q?= =?us-ascii?Q?nF5JR2IbKOujIhHZBmBrrWUdoZJpl1x3GYEdR/yfiuvLyIHMYhvvs65V7sL9?= =?us-ascii?Q?ZOtkM6k4HUa8tmCktqfLd3hMti+og77+KsAhLjoRS3+Sww/J3a+cxM3AUAzd?= =?us-ascii?Q?Mdza0f9E5CMu7S/BYo6jP6FSfXC/sv/kEIDkal4q0RxyuOc+2Bk+bJffkce4?= =?us-ascii?Q?tg//uYl8oz4PI4HZmVJGuTIvo3Whp+v82LV0/PFjrjtMLgD/kTkDePFa18fM?= =?us-ascii?Q?NV/TApS5wXW3KhyXRrBleU6mns0e/aWTCBj7776AXP0O2C1FPKKNu9blMQcO?= =?us-ascii?Q?1es0QGVk8xmWcptOO19BJbrkgB+lsYfKI69p32QbWL9Z9R4CgVoPB3f/C/8P?= =?us-ascii?Q?Izh+rafhKwRbd+VFNMavCWyAebfo6nIQ9vCbUnFA7lwx3oTB4CQQ4LLG+qR2?= =?us-ascii?Q?Vond0vftA9oFizUqxk6uQetH26F9rDGbWkIzKa+qivcwSiE/TAh8SbEBR39B?= =?us-ascii?Q?DZhWDag7sLVzUm7hRIIyXbIVdELr3p/fL//XF1gDV1RAS3z07qeuyCjs+uQv?= =?us-ascii?Q?ktIa7I46z/BqytXNXhcPbH2bsqGZ6SR54zKPvmWJnvoql4ZwOtukj238gTQW?= =?us-ascii?Q?A5DEmU7n9Flf3lg9PBEB9YdXDqb/GzD+krVqtu97uTWEBsuaQi8tGrJS3u8n?= =?us-ascii?Q?910mkJ7WKB1tY5GBO7Bq9LnTkOAUHEjW+vLRVE0D0+XwZFQuwvuKMWeMu+jB?= =?us-ascii?Q?QdPSPg8c6ZJxhsz0OsY8xoxvThMCgCAYwjebzsrqj2PusnPeayjv9iEb9Pkg?= =?us-ascii?Q?3MYENvhO76FDr/FnVLppISRpLcn61THIFg7EqcOc5mbi7g=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?poIFcTgDaU1buyfZDbn9s+2tlyP7EZFVT4ZLNQdF5ywdw9hHUZ/OnqS5jMW0?= =?us-ascii?Q?63RbUGkj8MjeRD7pGcE3o7gJKCeISrOqnju7H3aZZljrJ1BYfuFB1eL4wFT5?= =?us-ascii?Q?R60nG7/lM6t0Hj43X7lL2xArFL3zfvKG32Lszuf8m5JFCjSUI0ABnZ8Bo4gp?= =?us-ascii?Q?YVqlf3Z6RtWTM3osNGtup+Z7EUAFBuVqF2CJeuVKrAIJAHOanB2dYksUIhfT?= =?us-ascii?Q?GXlHehwF99E3rKEAS08l9xFyPDzJh7MFdJgHTAnFXo6xUEGVzKpD4JZu5NjZ?= =?us-ascii?Q?+RVY/w9rtQrdMs3wpnJi3eLxeVVoTJKGJZZL0oCXVwTCA//5b1JXAsAR2mFx?= =?us-ascii?Q?l7qHIrQnqncH7AUuJ8FgpNMpGruD5hf+htNbNlh6UxWxPR3hJ8ah5uqjOUZW?= =?us-ascii?Q?RF/5TI/kXsMxrVZf9Yc0kpKvp9xTSnDHjuF/NwOu81G1XQPvrJ4uo9h0y9wE?= =?us-ascii?Q?AszPV1oRBYK2UHtRJtGM52hFhas8Yl8vdZbuR9leBBu/BYlQguYhJBZXesxb?= =?us-ascii?Q?KixTKC3R3xFL9gprbyQXGmKnEQaggq/E9T8aK73FF6nXEBtviyc0pVyPCZ4l?= =?us-ascii?Q?yt4X0QqIKHCGSJCt3GJifawYj9WH5ri65psBNdjehw7CkFZFX5Wz+3HKgXuR?= =?us-ascii?Q?Gmkmnz7J1iPCUuidn5UzNI2gEdUTvwa1ihqA1FtqT49P4fEpMisrSnyK27o/?= =?us-ascii?Q?bWiPmhDDGXmsl7Ll5IsWOov/lJjxFGGZlt2S01Q0JL4T3TMGRNE69X3pVGwr?= =?us-ascii?Q?+W0ez9yvFm0ptJr4Ho6kI2R929MJHCBsiKcDpkH2eztN/ZPjndT+7el5Yao4?= =?us-ascii?Q?2/DhufU1YvN+qglT8kXiAnvIdnSPIKJHKLIbmxQpq7jEkDWJ4DYoQeXYR4vY?= =?us-ascii?Q?4lVGH3HwYskepNJPRcNortAaWq5hoVcBxUaOY0XtPxuGDHuOLmAfLCVGpqs4?= =?us-ascii?Q?LPfa9lcDPUt0L6cAIkoVIpMdp7S2x389/mAF9gbzmu1GIDPejQ+JHrUEDDZM?= =?us-ascii?Q?fH+YRJA4iUvJOax2c/xZ/Sb4QxLx6oWfzGXF4ephNnITUfjT+kscjpZ4QxDP?= =?us-ascii?Q?/mUnspvF4uh4iuOmG3rkC5bej6Zq6iZ2rrE5PQLIWkI0Y41z66qA8HN+LOpv?= =?us-ascii?Q?IUJVVki4AUALra16SN4yT2y3ek0b6lO7aBsEKkvkPI/8LNIFZoNCUbr0MXCB?= =?us-ascii?Q?pbi+X1+o5F4QxVfNBEnpk6KvzT0fHK5CLlXX4CYJEboPrUhlxzWEV7DTW47N?= =?us-ascii?Q?7Ed/Z2H5x8GRe58fTwRBpqgqBBmoA9C7f7HHdLloRB0fdFzlKof3gGDIiJ04?= =?us-ascii?Q?stayjs7+oXkDLMwz7jRQkLtZbmJ723fyK+OBXs9+I+0sP4i6tVjXBsqLjPKD?= =?us-ascii?Q?VtdaMtT1bbB72CH4BX77+NMkh6CHgxRrL/OP3eP5gT/li0+dB1YmmKXPbzvE?= =?us-ascii?Q?l6qC6Jyi9Y3KXqomS0kUFmKD2y9ogUSLTCWin9wsB++CJzo639RcXVxotgV9?= =?us-ascii?Q?vzXr6lOPrX7bv9CRAATljrBUERmJJkht3ADBlRbXPo6xkL00LD976kWv7WYx?= =?us-ascii?Q?TjEn6ktEnTeCiNuxfQsEvfvBdC7A9d6ilvY+JBfZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce1e71e7-9440-4c27-8d2c-08dce99cc09a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2024 02:31:03.4881 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mNSRVwavWVgOsX9r/ryXwsJwGX46PuvoMUC+hEGtNB+BFTrC61NYBx2ve660/DXouuNam8fe2qnuFrde9v8ZSEjPLscpZpexDZh0BNcsGcM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3731 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > On Thu, 10 Oct 2024 17:17:08 +0800 > Chaoyong He wrote: >=20 > > The original logic keeps using the same name parameter when malloc > > memory in secondary process, which may cause error when using multiple > > PF cards. > > > > Fixes: 3b00109d2b65 ("net/nfp: add PF ID used to format symbols") > > Cc: peng.zhang@corigine.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Chaoyong He > > Reviewed-by: Long Wu > > Reviewed-by: Peng Zhang >=20 > Huh? the name is ignored by rte_malloc(), it only shows up in tracing. > in fact you could just always pass NULL. Yeah, I have learned this from some patch thread. I will choose using 'NULL' in the newly added logic, treat this API as a 'w= hite box'. But for already exist logic like this one, I prefer to fix it, and treat it= as a 'black box'.=20