patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Yuanhan Liu <yliu@fridaylinux.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
Subject: Re: [dpdk-stable] [PATCH 17.11 5/5] net/qede: fix L2-handles used for RSS hash update
Date: Fri, 8 Jun 2018 23:10:04 +0000	[thread overview]
Message-ID: <SN1PR07MB40326B7E0858E77DEBE768F49F7B0@SN1PR07MB4032.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20180608144503.l7cwuoqsxzd7ulwg@yuanhanliu-NB0.tencent.com>

> From: Yuanhan Liu [mailto:yliu@fridaylinux.org]
> Sent: Friday, June 08, 2018 7:45 AM
> 
> On Thu, Jun 07, 2018 at 05:51:14PM -0700, Rasesh Mody wrote:
> > [ upstream commit 3a1a1f3f1344c8a3bc0b06cd23e97b3922a91a61 ]
> 
> Note that this commit is not from upstream, instead, it's from dpdk-next-net.
> 
> Another thing worth noting is the commit hash will likely change after it get
> applied to upstream, for, AFIAK, they do rebase for merging dpdk-next tress.
> That's the reason we don't directly pick commits from dpdk-next trees.
> 
> For this one, I will apply it without above commit info. I have also applied the
> others.

Thanks, we have additional fixes that are part of dpdk-next-net, but they are not part of upstream yet.
Can you pull in these to dpdk-17.11 stable?

https://dpdk.org/dev/patchwork/patch/40779/
https://dpdk.org/dev/patchwork/patch/40778/
https://dpdk.org/dev/patchwork/patch/40777/

> 
> Thanks.
> 
> 	--yliu
> 
> 
> >
> > Fix fast path array index which is used for passing L2 handles to RSS
> > indirection table, properly distribute rxq handles for indirection table.
> > Currently, it is using the local copy of indirection table. When the
> > RX queue configuration changes the local copy becomes invalid.
> >
> > Fixes: 69d7ba88f1a1 ("net/qede/base: use L2-handles for RSS
> > configuration")
> >
> > Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> > Reviewed-by: Kevin Traynor <ktraynor@redhat.com>
> > ---
> >  drivers/net/qede/qede_ethdev.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/qede/qede_ethdev.c
> > b/drivers/net/qede/qede_ethdev.c index d266fff..7462f1a 100644
> > --- a/drivers/net/qede/qede_ethdev.c
> > +++ b/drivers/net/qede/qede_ethdev.c
> > @@ -2084,7 +2084,7 @@ int qede_rss_hash_update(struct rte_eth_dev
> *eth_dev,
> >  	vport_update_params.vport_id = 0;
> >  	/* pass the L2 handles instead of qids */
> >  	for (i = 0 ; i < ECORE_RSS_IND_TABLE_SIZE ; i++) {
> > -		idx = qdev->rss_ind_table[i];
> > +		idx = i % QEDE_RSS_COUNT(qdev);
> >  		rss_params.rss_ind_table[i] = qdev->fp_array[idx].rxq-
> >handle;
> >  	}
> >  	vport_update_params.rss_params = &rss_params;
> > --
> > 1.7.10.3

  reply	other threads:[~2018-06-08 23:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08  0:51 [dpdk-stable] [PATCH 17.11 1/5] net/qede: fix VF port creation sequence Rasesh Mody
2018-06-08  0:51 ` [dpdk-stable] [PATCH 17.11 2/5] net/qede: fix device stop to remove primary MAC Rasesh Mody
2018-06-08  0:51 ` [dpdk-stable] [PATCH 17.11 3/5] net/qede: fix to prevent overwriting packet type Rasesh Mody
2018-06-08  0:51 ` [dpdk-stable] [PATCH 17.11 4/5] net/qede/base: fix to support OVLAN mode Rasesh Mody
2018-06-08  0:51 ` [dpdk-stable] [PATCH 17.11 5/5] net/qede: fix L2-handles used for RSS hash update Rasesh Mody
2018-06-08 14:45   ` Yuanhan Liu
2018-06-08 23:10     ` Mody, Rasesh [this message]
2018-06-15 14:33       ` Yuanhan Liu
2018-06-15 16:54         ` Mody, Rasesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN1PR07MB40326B7E0858E77DEBE768F49F7B0@SN1PR07MB4032.namprd07.prod.outlook.com \
    --to=rasesh.mody@cavium.com \
    --cc=Dept-EngDPDKDev@cavium.com \
    --cc=stable@dpdk.org \
    --cc=yliu@fridaylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).