From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0066.outbound.protection.outlook.com [104.47.37.66]) by dpdk.org (Postfix) with ESMTP id 4F5FA5F13 for ; Sat, 9 Jun 2018 01:10:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1rr262yTZSTulHp38fN3m5gahym26W4/5UAW24yhMeI=; b=ZVy4AMN8csHt7cWy4VcFo5dBOFENSrGKWccWDR23dh0haqCfx5B5IL9IbfxxR2jwAuEpNrcrKiJf1dMeGbQ7zUKNHVs5yodgATlAcVuTU68qoIbbidG0qnHqx8YyxjRFKQvEyxw0LqM1ri98i45W/6BAJUORetA6/SDf6H0gle0= Received: from SN1PR07MB4032.namprd07.prod.outlook.com (52.132.197.143) by SN1PR07MB1502.namprd07.prod.outlook.com (10.161.223.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.16; Fri, 8 Jun 2018 23:10:05 +0000 Received: from SN1PR07MB4032.namprd07.prod.outlook.com ([fe80::e14c:9ccc:e546:3f04]) by SN1PR07MB4032.namprd07.prod.outlook.com ([fe80::e14c:9ccc:e546:3f04%2]) with mapi id 15.20.0841.015; Fri, 8 Jun 2018 23:10:05 +0000 From: "Mody, Rasesh" To: Yuanhan Liu CC: "stable@dpdk.org" , Dept-Eng DPDK Dev Thread-Topic: [PATCH 17.11 5/5] net/qede: fix L2-handles used for RSS hash update Thread-Index: AQHT/sLYquO/kKjCIUazIl3bLGelh6RWcQuAgABLrbA= Date: Fri, 8 Jun 2018 23:10:04 +0000 Message-ID: References: <1528419074-18954-1-git-send-email-rasesh.mody@cavium.com> <1528419074-18954-5-git-send-email-rasesh.mody@cavium.com> <20180608144503.l7cwuoqsxzd7ulwg@yuanhanliu-NB0.tencent.com> In-Reply-To: <20180608144503.l7cwuoqsxzd7ulwg@yuanhanliu-NB0.tencent.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [173.186.134.106] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN1PR07MB1502; 7:un/SSK/G5voVVrjzBK0CJIa+MrkMThNhpHSSfdkQNPEe2ej8tyJvAOu8luo6HTga+T14WnxwMn8jpbvNyaF06+BgsVWnhMTk4cJmChFc/+zcNkGSz45GwevPbqTHRlp2pxxnjP/jbWRbIZn3SgnA9qIgJCxAopnVIEASBpDZ3vHyH9l56K4oriwfgLk9gH0qhVdfLYrkETilNS8H8q2pK6GpMah7Q7piMOg3Wk1BFDR2JPt5YNq55FgoxWFSXvUd x-ms-exchange-antispam-srfa-diagnostics: SOS; x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:SN1PR07MB1502; x-ms-traffictypediagnostic: SN1PR07MB1502: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231254)(944501410)(52105095)(10201501046)(93006095)(93001095)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:SN1PR07MB1502; BCL:0; PCL:0; RULEID:; SRVR:SN1PR07MB1502; x-forefront-prvs: 06973FFAD3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39840400004)(39380400002)(376002)(366004)(396003)(346002)(199004)(189003)(33656002)(446003)(305945005)(74316002)(186003)(105586002)(6916009)(6116002)(106356001)(11346002)(25786009)(2900100001)(3660700001)(107886003)(3280700002)(8676002)(6246003)(478600001)(53936002)(4326008)(26005)(97736004)(8936002)(9686003)(7736002)(486006)(81156014)(81166006)(6306002)(102836004)(476003)(7696005)(966005)(575784001)(99286004)(316002)(86362001)(55016002)(59450400001)(5250100002)(76176011)(72206003)(2906002)(6506007)(6436002)(14454004)(3846002)(66066001)(68736007)(229853002)(5660300001)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR07MB1502; H:SN1PR07MB4032.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 7Cf/zQ8tDBlo3wRozX2szCDM2hfZxrgSgghMxxn9Nw0qrciRG061Qej59A70fhP4hcHmjI8VYh5Dy3sl762MwhGpEFYT562UtJG+g1RS6qjEHD6q6sIMGbPAjov6dgLnj8RPp7o/E8riaTqH2IYz1ErulmYKnwfRtZ8lN8/obZdUU8uPgOmhAVgBIiLCivVF spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 7bd8268b-9fa9-46cd-f479-08d5cd94f886 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7bd8268b-9fa9-46cd-f479-08d5cd94f886 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2018 23:10:04.9389 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB1502 Subject: Re: [dpdk-stable] [PATCH 17.11 5/5] net/qede: fix L2-handles used for RSS hash update X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 23:10:11 -0000 > From: Yuanhan Liu [mailto:yliu@fridaylinux.org] > Sent: Friday, June 08, 2018 7:45 AM >=20 > On Thu, Jun 07, 2018 at 05:51:14PM -0700, Rasesh Mody wrote: > > [ upstream commit 3a1a1f3f1344c8a3bc0b06cd23e97b3922a91a61 ] >=20 > Note that this commit is not from upstream, instead, it's from dpdk-next-= net. >=20 > Another thing worth noting is the commit hash will likely change after it= get > applied to upstream, for, AFIAK, they do rebase for merging dpdk-next tre= ss. > That's the reason we don't directly pick commits from dpdk-next trees. >=20 > For this one, I will apply it without above commit info. I have also appl= ied the > others. Thanks, we have additional fixes that are part of dpdk-next-net, but they a= re not part of upstream yet. Can you pull in these to dpdk-17.11 stable? https://dpdk.org/dev/patchwork/patch/40779/ https://dpdk.org/dev/patchwork/patch/40778/ https://dpdk.org/dev/patchwork/patch/40777/ >=20 > Thanks. >=20 > --yliu >=20 >=20 > > > > Fix fast path array index which is used for passing L2 handles to RSS > > indirection table, properly distribute rxq handles for indirection tabl= e. > > Currently, it is using the local copy of indirection table. When the > > RX queue configuration changes the local copy becomes invalid. > > > > Fixes: 69d7ba88f1a1 ("net/qede/base: use L2-handles for RSS > > configuration") > > > > Signed-off-by: Rasesh Mody > > Reviewed-by: Kevin Traynor > > --- > > drivers/net/qede/qede_ethdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/qede/qede_ethdev.c > > b/drivers/net/qede/qede_ethdev.c index d266fff..7462f1a 100644 > > --- a/drivers/net/qede/qede_ethdev.c > > +++ b/drivers/net/qede/qede_ethdev.c > > @@ -2084,7 +2084,7 @@ int qede_rss_hash_update(struct rte_eth_dev > *eth_dev, > > vport_update_params.vport_id =3D 0; > > /* pass the L2 handles instead of qids */ > > for (i =3D 0 ; i < ECORE_RSS_IND_TABLE_SIZE ; i++) { > > - idx =3D qdev->rss_ind_table[i]; > > + idx =3D i % QEDE_RSS_COUNT(qdev); > > rss_params.rss_ind_table[i] =3D qdev->fp_array[idx].rxq- > >handle; > > } > > vport_update_params.rss_params =3D &rss_params; > > -- > > 1.7.10.3