From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690059.outbound.protection.outlook.com [40.107.69.59]) by dpdk.org (Postfix) with ESMTP id 9345F1C0B9 for ; Fri, 15 Jun 2018 18:54:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VuZceZiFBiozepAEqmHLn52pw/UUBrZOhyPiJePytb8=; b=Mx3aKQB/6/69HNZFNKVZJJuWcDy2LvgCj76neviSOGVEyywmT9nQPL1n8bQ74CsZ8Na/2wxLwCL3/EboIBpZECziAIrosn5wLBB0dhRHA0TNnAy6NSJ820NLwnky0XTnWl/9YPzjaH35Bb6KYllyif9izEw8NzDHRL6GGyEh1wc= Received: from SN1PR07MB4032.namprd07.prod.outlook.com (52.132.197.143) by SN1PR07MB1470.namprd07.prod.outlook.com (10.161.223.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.14; Fri, 15 Jun 2018 16:54:01 +0000 Received: from SN1PR07MB4032.namprd07.prod.outlook.com ([fe80::e14c:9ccc:e546:3f04]) by SN1PR07MB4032.namprd07.prod.outlook.com ([fe80::e14c:9ccc:e546:3f04%2]) with mapi id 15.20.0863.016; Fri, 15 Jun 2018 16:54:01 +0000 From: "Mody, Rasesh" To: Yuanhan Liu CC: "stable@dpdk.org" , Dept-Eng DPDK Dev Thread-Topic: [PATCH 17.11 5/5] net/qede: fix L2-handles used for RSS hash update Thread-Index: AQHT/sLYquO/kKjCIUazIl3bLGelh6RWcQuAgABLrbCACrGBgIAAJlvw Date: Fri, 15 Jun 2018 16:54:01 +0000 Message-ID: References: <1528419074-18954-1-git-send-email-rasesh.mody@cavium.com> <1528419074-18954-5-git-send-email-rasesh.mody@cavium.com> <20180608144503.l7cwuoqsxzd7ulwg@yuanhanliu-NB0.tencent.com> <20180615143349.hkv2puirrumi3edx@yuanhanliu-NB0.tencent.com> In-Reply-To: <20180615143349.hkv2puirrumi3edx@yuanhanliu-NB0.tencent.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [2601:646:8200:7290:28d8:a514:9ef3:28fd] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN1PR07MB1470; 7:fSPtcVXmsNBmL/sJu7kFB/8Sphlzpx7GjX4p8+sTu3jMCSM4RZVJiwyndx1GXEH/FVZI+yvnH2g28zi+FVWbGcHk+24AUGoPbyOKJtSnTPp6denEgnfYvxpAkts902z99z0xbemRV0lIr2OxKs1ISXiXxPoPtJMjxc6HNyW91fJOsRTb12wE6JjvzzoacD7Z/hZNEa3bN1RCvo67AbD+bcTPPD6ctSuSipZJS2k18vEXl3AQIGl5gfRxhETBD5tq x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: b293695c-e4e0-4c75-368f-08d5d2e0987d x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:SN1PR07MB1470; x-ms-traffictypediagnostic: SN1PR07MB1470: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(10201501046)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:SN1PR07MB1470; BCL:0; PCL:0; RULEID:; SRVR:SN1PR07MB1470; x-forefront-prvs: 0704670F76 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(39850400004)(366004)(396003)(376002)(346002)(39380400002)(199004)(189003)(8676002)(476003)(81156014)(305945005)(72206003)(5660300001)(107886003)(14454004)(2906002)(6506007)(7696005)(102836004)(966005)(7736002)(575784001)(54906003)(86362001)(68736007)(74316002)(33656002)(4326008)(81166006)(76176011)(8936002)(105586002)(97736004)(93886005)(106356001)(316002)(6246003)(5250100002)(59450400001)(9686003)(478600001)(53936002)(6916009)(3280700002)(186003)(229853002)(46003)(2900100001)(6116002)(6306002)(446003)(11346002)(486006)(6436002)(99286004)(25786009)(55016002)(3660700001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR07MB1470; H:SN1PR07MB4032.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: VbZ4pSISyXrlb2Hd9zSdvt80czfTo3PNDCpydU8+WIBz2nqP9mwhI9OD6EkRl/Aw4Apxho+MJSbLZY7dxMoRkkTcww7aF1UwSM9T5oqnx4UOTrBnynOLzn6MEwUUwHkJdDAUK7IJDeY2RN34cHnSVKUHB8mZXenNXA4DY5N+0BbjReoEH86msXdWkRLYa0tG spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: b293695c-e4e0-4c75-368f-08d5d2e0987d X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2018 16:54:01.3721 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB1470 Subject: Re: [dpdk-stable] [PATCH 17.11 5/5] net/qede: fix L2-handles used for RSS hash update X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 16:54:05 -0000 > From: Yuanhan Liu [mailto:yliu@fridaylinux.org] > Sent: Friday, June 15, 2018 7:34 AM >=20 > On Fri, Jun 08, 2018 at 11:10:04PM +0000, Mody, Rasesh wrote: > > > From: Yuanhan Liu [mailto:yliu@fridaylinux.org] > > > Sent: Friday, June 08, 2018 7:45 AM > > > > > > On Thu, Jun 07, 2018 at 05:51:14PM -0700, Rasesh Mody wrote: > > > > [ upstream commit 3a1a1f3f1344c8a3bc0b06cd23e97b3922a91a61 ] > > > > > > Note that this commit is not from upstream, instead, it's from dpdk-n= ext- > net. > > > > > > Another thing worth noting is the commit hash will likely change > > > after it get applied to upstream, for, AFIAK, they do rebase for merg= ing > dpdk-next tress. > > > That's the reason we don't directly pick commits from dpdk-next trees= . > > > > > > For this one, I will apply it without above commit info. I have also > > > applied the others. > > > > Thanks, we have additional fixes that are part of dpdk-next-net, but th= ey > are not part of upstream yet. > > Can you pull in these to dpdk-17.11 stable? >=20 > I suggest to not cross the line. We normally don't do that. Understood, thanks for taking care of the critical fix. >=20 > > https://dpdk.org/dev/patchwork/patch/40779/ > > https://dpdk.org/dev/patchwork/patch/40778/ >=20 > Thus, above 2 will not be applied. >=20 > > https://dpdk.org/dev/patchwork/patch/40777/ >=20 > And since you have mentioned (privately to me), that this one is critical= , I > have applied it to dpdk-stable/17.11. > > --yliu >=20 > > > > Fix fast path array index which is used for passing L2 handles to > > > > RSS indirection table, properly distribute rxq handles for indirect= ion > table. > > > > Currently, it is using the local copy of indirection table. When > > > > the RX queue configuration changes the local copy becomes invalid. > > > > > > > > Fixes: 69d7ba88f1a1 ("net/qede/base: use L2-handles for RSS > > > > configuration") > > > > > > > > Signed-off-by: Rasesh Mody > > > > Reviewed-by: Kevin Traynor > > > > --- > > > > drivers/net/qede/qede_ethdev.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/qede/qede_ethdev.c > > > > b/drivers/net/qede/qede_ethdev.c index d266fff..7462f1a 100644 > > > > --- a/drivers/net/qede/qede_ethdev.c > > > > +++ b/drivers/net/qede/qede_ethdev.c > > > > @@ -2084,7 +2084,7 @@ int qede_rss_hash_update(struct > rte_eth_dev > > > *eth_dev, > > > > vport_update_params.vport_id =3D 0; > > > > /* pass the L2 handles instead of qids */ > > > > for (i =3D 0 ; i < ECORE_RSS_IND_TABLE_SIZE ; i++) { > > > > - idx =3D qdev->rss_ind_table[i]; > > > > + idx =3D i % QEDE_RSS_COUNT(qdev); > > > > rss_params.rss_ind_table[i] =3D qdev->fp_array[idx].rxq- > > > >handle; > > > > } > > > > vport_update_params.rss_params =3D &rss_params; > > > > -- > > > > 1.7.10.3