From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A5AC42941 for ; Fri, 14 Apr 2023 15:22:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 001D941153; Fri, 14 Apr 2023 15:22:18 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 374C0400D5; Fri, 14 Apr 2023 15:22:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681478536; x=1713014536; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0RKD/anYTAV1fIhwu0P5rwk6ZU+0EpTspFHHuFzr664=; b=Rwx9qpqLHrQv1TwQ6SuGzSXcK/YnEIk6cjVEFDuKL5cDadxcickwlGOh PHFwL4fBwQ+9Bvvk8JwEAMJImutxaSDCmno/WXEjaQEDlF2HqnaGqHPu+ I37/Yhv95kwXcBECgAdFZ2KaafYsyNb85Cyw523VoVmjgpfNqs80HmuxH D4ZwRL9OqdkB4V/LtV19eRYdc9uO0LjFsAjqRR9vdoUvQgZLgPfo8MWGj SueGfYpC8KnObIBg9aYhqItDtBYbgVmpjM1KdAomsmDl74Plt7Zxpc6W7 MRFG4z3Lz1kwhQZbaWYoKqMWyIqxA/LRLFmYq3JF1NG9aFawI5jzTgfJF Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10679"; a="333235730" X-IronPort-AV: E=Sophos;i="5.99,195,1677571200"; d="scan'208";a="333235730" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2023 06:22:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10679"; a="722441767" X-IronPort-AV: E=Sophos;i="5.99,195,1677571200"; d="scan'208";a="722441767" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 14 Apr 2023 06:22:13 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 14 Apr 2023 06:22:13 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 14 Apr 2023 06:22:13 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 14 Apr 2023 06:22:13 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 14 Apr 2023 06:22:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LlnZg6XXpFDX6akWix2oJfVFvisOtvx9yltRVYKzU7DLwe8ERv8a1M32KdePRlzh48uvXfLvNUZqlIs0IhJzl26tNZ47nxeI7ca9blYU/DXRpeaT9rq4Y/FJsKnDoMneDhpjki0cwglWNnjDFI8NPRq//nb3Do9vaRmy8FBSF1QJkvTyHWB1rS2oIyOjkv9/Odqgyw56xIJ17FCaVS5eHGP4/9pL3n4Q1d5dTkTqn6Md9/U3GRym0FDDJgq7t4Qia+om3vyIMTzBOeUu88nAMJHvQnuQf+/1A2FQM032EIdSyA9tUDl++JbVYWiKoWEpJucaGIapjoemAdfLfLeEuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PaKoOwTMguY2JWiccGRk285MBsbCwWVsT4ekLszejaY=; b=Ma+qYb2R3VYyjFTWm19mD5SyGWGSDvTmUIe2yqIopqYlkz9uZFjwhToGIS+VsL0aej5oTFPEPESX+p/8ZM4O7hKKEzkP/9eMucNgKt2+V39hsqCt0x0aoQHjNiqN2LUMqPgAXtcljxd9uFNWMmpXvqx74Ptn8S4TDecHVibxoo9OWmzO59ctcBbpXq0wyGZe9P9+vAIBOKf1U0UWiwqpdxftqv9w4sIYCKXY+Fq+uoT9pl0obNvIg4e6GSQ6G0qWWDfocrPeHHsMvkUPLncscy2hL35Ix+7LaEN5Nd+2F+6qe5v/mR629b+PemyqPJ7REWNscQynZ6m5H0Kv8uXYGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by PH7PR11MB7513.namprd11.prod.outlook.com (2603:10b6:510:270::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 13:22:11 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::5b23:5882:d3f8:1085]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::5b23:5882:d3f8:1085%6]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 13:22:11 +0000 From: "Ji, Kai" To: "Power, Ciara" CC: "dev@dpdk.org" , "fanzhang.oss@gmail.com" , "stable@dpdk.org" Subject: RE: [PATCH] crypto/scheduler: fix last element for valid args Thread-Topic: [PATCH] crypto/scheduler: fix last element for valid args Thread-Index: AQHZbs1H+wlPIhoJ1Ei421u57iRrt68qyogQ Date: Fri, 14 Apr 2023 13:22:11 +0000 Message-ID: References: <20230414123306.575977-1-ciara.power@intel.com> In-Reply-To: <20230414123306.575977-1-ciara.power@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|PH7PR11MB7513:EE_ x-ms-office365-filtering-correlation-id: 8b357911-271f-4b17-1c6f-08db3ceb4135 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: COrAyXo2c5vTD4RVHrIbX7duZZcx0hMw9YHAo0xft/bv0+dSjpHIiMy0R+svUiRn5QhZEdKGfexiBcVUQjiple3w4/WQ07r+yCTADZH9IuoVJ34DU1CaCWwqRjj0KpKeJ+ca8oPqqhupIr7Q7Oe7kChP4w18n41jRaamy7w1Dg3cHqR1ZGVzU6N1bnTmvTMQ9G59ra+Pr/mCfmgDiLM18JbPIM5XgPtgTqCY0vQtV6n7poIvtBts1CrTlc0mv9q+5jxWrIHKV9ZW/yu9hF3NbffQfpzMpXNqZO0t0vUD1Iqk+PXzPPU3PiJsD84+5EGUvfOKU8Fx3lQAmUoNlUDkaZS8MJdzNSHO8OX0S2uRDCnCmrJkhFVi0vbO8kHVp8UScm7m7VDqbMwMmN2ZhAl5JR/+78m8Az4pwAJTc106ETv0iPoZj833f97ZZu6tM9FqFsyGRMgCCacBGNY0RrR1EmUVl39QgZieXMIv7hLPZpvyhdi496nIXsdnx+Hqk6/LPmcU86OMq9JSvqJxpLHedzzt+6SH9T1gSSfemtRvGu2x5X5qfY+1TyLncpDTFM6E3eZJ+2v2xtS4P0FHBf+OaaJbhl/nvmGuSseMx0qmMKL0ZUXOoTR7O9LT3AN9xu9i x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(136003)(376002)(39860400002)(346002)(396003)(451199021)(86362001)(54906003)(6636002)(316002)(82960400001)(478600001)(33656002)(41300700001)(8936002)(6862004)(38100700002)(122000001)(8676002)(52536014)(5660300002)(66476007)(64756008)(76116006)(55016003)(66446008)(66556008)(53546011)(6506007)(9686003)(38070700005)(26005)(186003)(66946007)(4326008)(83380400001)(71200400001)(2906002)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PClwJPeeN4709rsf9orqT++bOK1Jem77+kpjQd7m3sRJsBdL0e8CYwsX9JB9?= =?us-ascii?Q?bMr5uksEvb8sLcPvCJ8oA9qp534BxqYhd1vT2bE37i2HHfsSxzJLQ/BQo8xl?= =?us-ascii?Q?4zoSIo9Adsyb5TAKG0sASO8GVFONYeaB20uWPn+LLZ7ldG/VP1HAxdODkjVO?= =?us-ascii?Q?GTCr4X5w1c9TzJr0AEVzQav2cxV/5bet7TsiHXWsXe5Et9JvFsp4s521nI/3?= =?us-ascii?Q?Vq6JQoqnRJk5T7nuoe1bm5Ho3e4FlxLT9EwNdAyxEby0P9SLRtghqwH3y+1I?= =?us-ascii?Q?tkv1j9Qgu4nKJcI4qV20kOJ2PgkvpBdqTiI4NVkzYIjR1l3viFChdmduCKEl?= =?us-ascii?Q?VZXGzV6rYxQyDvjPM7So1ZJg1jInTx5OhH2ZecrKmmTBNCain7MlD2J/Xtb9?= =?us-ascii?Q?35iVg8/VonmMo3390iQpoOF/hWI45gy71A3DV1jylRqynuxNcAfxYfdChxQq?= =?us-ascii?Q?gVCqsRhReeNyIMDMCU+W/tRDe4MikcRJBNnXCP1E0V2ypdKQhAhkuEt6TJIZ?= =?us-ascii?Q?nKjAmr13x6mbppklgarK7RV0T1J4w/uU52PHgpglC4yFPFRyGOba9TLx9iNF?= =?us-ascii?Q?Af8zdln/L2YM7QH7L6Ev+VR93veX+2J1RYVIzNfVCbt+2SOB7tzI5+B1qVy0?= =?us-ascii?Q?pWUEsxn0/a2WwKkn51czRuGkrKEdedmLvit6HLEzUpLy/Cxr6miJfj5G+YH9?= =?us-ascii?Q?StedOAxRZgTiQtMyBhaYsd9Y57IDIN+6qCgSsa1tX2rzsRmgVK5ur346ciGG?= =?us-ascii?Q?d8hjhQ4HIIrB+d6jjvH2mBUzJOqaIugaVifMbB+Yaakt+OJs9uqcRrKYf1lU?= =?us-ascii?Q?vEJW3vXL2VKbJ/ECEOWgfJTQLAGc9yyQvhhhb8thRPzoZpsL/r7j+K0Xcgf7?= =?us-ascii?Q?UfgQpUmveyYma6VfK9/rOM03gWt42575MCMsDXZ8/9JyfZk+RYGFoB/MX+9H?= =?us-ascii?Q?dVQHWxmDTihICGaUuAiQUoR4ay5q/YVdciQhor9zFKArle66MlO1lHKfddvW?= =?us-ascii?Q?kYEY5S3hGAq8Jy3YCHydXPPs4A0rDnKHdi+udRMYKK9h3FYbb/JCge4/w8hj?= =?us-ascii?Q?irsIX3+1amYS4KlP7ZGh7fVH5sczxf+581xhSZHk6bPbcd7UxXTNggAAr+/x?= =?us-ascii?Q?tw1Ak6L4/jZ6zFM2bjls5b28t4XbGBwRN7uHbiu6ojIKokVlielwfFv6Ta4+?= =?us-ascii?Q?PBfzRCxsMQzWNe+mJXbbKwu8XeGf9tmGjPxRpYpO5eW6+F8fvtf1WYGVUeZX?= =?us-ascii?Q?PqW4nD4c2W93QM0Ll6p0rF+bd086OyD04mJ8h/HIy59wbYL85VV1Sm4StTWP?= =?us-ascii?Q?cBirpd+q4mmvD1lyj17M9IN9ooslSiyiJyArDBI7CqkQOUzIqRYpp+UITOPU?= =?us-ascii?Q?NjRWBF/xniyW6eCcTI1V3VB15EQrBYgKDBOlDqTfx0H4P6Kcw2kpaQhZhk9J?= =?us-ascii?Q?jhQioayxivrKIdhXZC13R/mPjMYaGDU/DHpuNNP0faNf97bep/lCEULi7uxt?= =?us-ascii?Q?Sfj4l8jpIHYve1H9TyNKH43o94Pezn08rsWjYiyFVZjv2Xb2+4SQP/lwTVX2?= =?us-ascii?Q?IgsUOFkWN6718kDQ/PI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b357911-271f-4b17-1c6f-08db3ceb4135 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2023 13:22:11.1920 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8Dp1MBMekA5VPU/VXYJ8LNQDKGMTAVVwwziWbMN42KnY//Inui198f2RR0vpVSaqP+sJz0Q/2KgpsS82sKwadA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7513 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Acked-by: Kai Ji > -----Original Message----- > From: Power, Ciara > Sent: Friday, April 14, 2023 1:33 PM > To: Ji, Kai > Cc: dev@dpdk.org; Power, Ciara ; > fanzhang.oss@gmail.com; stable@dpdk.org > Subject: [PATCH] crypto/scheduler: fix last element for valid args >=20 > The list of valid arguments for Scheduler PMD should be terminated with a > NULL entry, as expected by rte_kvargs_parse. >=20 > Without this, if an invalid key name was used, a global buffer overflow > occurred resulting in a segmentation fault. >=20 > Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver") > Cc: fanzhang.oss@gmail.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Ciara Power > --- > drivers/crypto/scheduler/scheduler_pmd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/crypto/scheduler/scheduler_pmd.c > b/drivers/crypto/scheduler/scheduler_pmd.c > index 9d1ce46622..4e8bbf0e09 100644 > --- a/drivers/crypto/scheduler/scheduler_pmd.c > +++ b/drivers/crypto/scheduler/scheduler_pmd.c > @@ -50,7 +50,8 @@ static const char * const scheduler_valid_params[] =3D = { > RTE_CRYPTODEV_VDEV_MAX_NB_QP_ARG, > RTE_CRYPTODEV_VDEV_SOCKET_ID, > RTE_CRYPTODEV_VDEV_COREMASK, > - RTE_CRYPTODEV_VDEV_CORELIST > + RTE_CRYPTODEV_VDEV_CORELIST, > + NULL > }; >=20 > struct scheduler_parse_map { > -- > 2.25.1