FW: [PATCH 21.11.1 v2] test/crypto: skip oop test for raw api

FW: [PATCH 21.11.1 v2] test/crypto: skip oop test for raw api

[Ji, Kai]

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]



> -----Original Message-----
> From: Ji, Kai
> Sent: Monday, July 25, 2022 12:44 PM
> To: ktraynor@redhat.com
> Cc: hemant.agrawal@nxp.com; Poczatek, Jakub
> <jakub.poczatek@intel.com>; Jiang, YuX <YuX.Jiang@intel.com>
> Subject: [PATCH 21.11.1 v2] test/crypto: skip oop test for raw api
> 
> Hi Kevin,
> 
> The attached patch fix a single failing oop test in raw api where it supposed to
> be skipped, and this test also failed in next-crypto 21.11 release.
> Because of major qat data-path refactor has been included in next-crypto
> 22.03 release,  this test is passing now as the OOP feature is supported by
> refactor.
> 
> So I didn't include upstream commit id in this patch as I'm not sure the fix will
> be needed for the next-crypto anymore.
> 
> Can you check to see if this patch is qualified to be merged into LTS 21.11.1 v2?
> 
> Regards
> 
> Kai
> 


[-- Attachment #2: v1-0001-test-crypto-skip-oop-test-for-raw-api.patch --]
[-- Type: application/octet-stream, Size: 1372 bytes --]

From f0046f0429098e668a4d2ffa5a80bce91f8c1635 Mon Sep 17 00:00:00 2001
From: Kai Ji <kai.ji@intel.com>
Date: Thu, 14 Apr 2022 01:59:43 +0800
Subject: [PATCH 21.11.1 v2 v1 1/1] test/crypto: skip oop test for raw api

Add in api test type check to skip unsupported aead OOP testcase
in raw API test.

Fixes: cd8166c28cd1 ("test/crypto: add raw API test for dpaax")
Cc: hemant.agrawal@nxp.com

Signed-off-by: Kai Ji <kai.ji@intel.com>
Tested-by: Poczatek, Jakub <jakub.poczatek@intel.com>
---
 app/test/test_cryptodev.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 41a8b10a90..b11be735d0 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -10547,9 +10547,11 @@ test_authenticated_encryption_oop(const struct aead_test_data *tdata)
 	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
 	uint64_t feat_flags = dev_info.feature_flags;

-	if ((global_api_test_type == CRYPTODEV_RAW_API_TEST) &&
-			(!(feat_flags & RTE_CRYPTODEV_FF_SYM_RAW_DP)))
+	if ((global_api_test_type == CRYPTODEV_RAW_API_TEST) ||
+			(!(feat_flags & RTE_CRYPTODEV_FF_SYM_RAW_DP))) {
+		printf("Device does not support RAW data-path APIs.\n");
 		return TEST_SKIPPED;
+	}

 	/* not supported with CPU crypto */
 	if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO)
--
2.17.1

Re: FW: [PATCH 21.11.1 v2] test/crypto: skip oop test for raw api

[Luca Boccassi]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

On Tue, 2022-08-16 at 14:43 +0000, Ji, Kai wrote:
> 
> > -----Original Message-----
> > From: Ji, Kai
> > Sent: Monday, July 25, 2022 12:44 PM
> > To: ktraynor@redhat.com
> > Cc: hemant.agrawal@nxp.com; Poczatek, Jakub
> > <jakub.poczatek@intel.com>; Jiang, YuX <YuX.Jiang@intel.com>
> > Subject: [PATCH 21.11.1 v2] test/crypto: skip oop test for raw api
> > 
> > Hi Kevin,
> > 
> > The attached patch fix a single failing oop test in raw api where it supposed to
> > be skipped, and this test also failed in next-crypto 21.11 release.
> > Because of major qat data-path refactor has been included in next-crypto
> > 22.03 release,  this test is passing now as the OOP feature is supported by
> > refactor.
> > 
> > So I didn't include upstream commit id in this patch as I'm not sure the fix will
> > be needed for the next-crypto anymore.
> > 
> > Can you check to see if this patch is qualified to be merged into LTS 21.11.1 v2?
> > 
> > Regards
> > 
> > Kai

Thanks, applied and pushed. Next time please send it directly to
stable@dpdk.org rather than to the maintainer privately.

-- 
Kind regards,
Luca Boccassi

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]