From: "Ji, Kai" <kai.ji@intel.com>
To: "Power, Ciara" <ciara.power@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] crypto/ipsec_mb: fix allocating mb_mgr in session
Date: Wed, 17 May 2023 16:46:35 +0000 [thread overview]
Message-ID: <SN6PR11MB3408431EA836E0FFF0A928B8817E9@SN6PR11MB3408.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230517151916.1048475-1-ciara.power@intel.com>
Acked-by: Kai Ji <kai.ji@intel.com>
> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Wednesday, May 17, 2023 4:19 PM
> To: Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; Power, Ciara <ciara.power@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] crypto/ipsec_mb: fix allocating mb_mgr in session
>
> When configuring the session, use the queue pair mb_mgr that was already
> allocated if possible. If this doesn't exist, then allocate a new mb_mgr.
>
> This reduces unnecessary cycles creating an mb_mgr for every session
> configured.
>
> Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
> v2: fixed indents
> ---
> drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> index 3e52f95674..30f919cd40 100644
> --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> @@ -434,15 +434,22 @@ ipsec_mb_sym_session_configure(
> struct ipsec_mb_dev_private *internals = dev->data->dev_private;
> struct ipsec_mb_internals *pmd_data =
> &ipsec_mb_pmds[internals->pmd_type];
> - IMB_MGR *mb_mgr = alloc_init_mb_mgr();
> + struct ipsec_mb_qp *qp = dev->data->queue_pairs[0];
> + IMB_MGR *mb_mgr;
> int ret = 0;
>
> + if (qp != NULL)
> + mb_mgr = qp->mb_mgr;
> + else
> + mb_mgr = alloc_init_mb_mgr();
> +
> if (!mb_mgr)
> return -ENOMEM;
>
> if (unlikely(sess == NULL)) {
> IPSEC_MB_LOG(ERR, "invalid session struct");
> - free_mb_mgr(mb_mgr);
> + if (qp == NULL)
> + free_mb_mgr(mb_mgr);
> return -EINVAL;
> }
>
> @@ -452,11 +459,13 @@ ipsec_mb_sym_session_configure(
> IPSEC_MB_LOG(ERR, "failed configure session parameters");
>
> /* Return session to mempool */
> - free_mb_mgr(mb_mgr);
> + if (qp == NULL)
> + free_mb_mgr(mb_mgr);
> return ret;
> }
>
> - free_mb_mgr(mb_mgr);
> + if (qp == NULL)
> + free_mb_mgr(mb_mgr);
> return 0;
> }
>
> --
> 2.25.1
next prev parent reply other threads:[~2023-05-17 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 15:13 [PATCH] " Ciara Power
2023-05-17 15:19 ` [PATCH v2] " Ciara Power
2023-05-17 16:46 ` Ji, Kai [this message]
2023-05-25 7:09 ` Akhil Goyal
2023-05-17 16:46 ` [PATCH] " Ji, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3408431EA836E0FFF0A928B8817E9@SN6PR11MB3408.namprd11.prod.outlook.com \
--to=kai.ji@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).