From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE04442B2C for ; Wed, 17 May 2023 18:46:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E96BB42BAC; Wed, 17 May 2023 18:46:40 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 56439406B7; Wed, 17 May 2023 18:46:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684341998; x=1715877998; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=EWNu95AgT35j2vr8/FD4XrjsoHu8hWE7B4R2g0a1QcI=; b=VJzJWBtx9Ah8F552+nYJ0FX23Y1NcckhSQlYAFNpcE96coKOzVMmuYD8 A5dsFHG+zlJD3k5pR8KLjQ8MQ97NiQCAOSO00edl54ZIyX2UGOiuYkos3 xSKz/YNOdae2hr+i7m0q6diwcCQo4E7HidfXJ8dV+yZwvcJAnqWnBax8R wPgvE6sSNtRDRGEGx34VNA1nfMB8iug4WtZeyw6Aq75KHxiFXWBeEb21a A1pCQZqOa4WVUmHy+c2ddTKGNJgxpUMEsSxI9M/t4YPIG5T6PjE3uDsiW W7LVipTVDXHtsuI2yw/p5pOp5T8l48vk+PZRoyk5aIh6a+W5Bm3bCeJJJ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="351833896" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="351833896" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 09:46:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="948338307" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="948338307" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 17 May 2023 09:46:37 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 17 May 2023 09:46:36 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 17 May 2023 09:46:36 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 17 May 2023 09:46:36 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 17 May 2023 09:46:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qs2hrs5YeLGqv9BPdB/deIkt3tRZlqAnXQyPaNkQzyKt9LnMSOo2yqbTiFsL/morAjbmDUUanjm5+AGzvamS29DrAy87xUQwQcQQiLjfUjK3I1rK5CWrQlXzcwonah37cvOyuPVY5jw14jbCJmgbbciigWyk4dfi5TX7n3iSHVY4TY0vthskgpHjVKNRi6fC5Mad7nxaIJBskKwPrkc9BvyESpsy6AQOwUDHAPnHyPxOfNSQmxm2Yopu8gts08HmuhtgwuXUtIRbLuhyGxVmW5wb2TTKnByKvtHvd3p9nm6cDto22Wmshj26cr9r4foJYE3R9YeHxHP9s0lY17285g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6ApGB03ZHKrMIeUDpIdg0VwrwESRsI9qaReDGwe4lqI=; b=Ka30XajaDh/nI6bsfdqx8gFl4oX5jpXPGKjPAWAygqezxBsn109iBit/PYgs78WgyYP5L2kCmQmOG5pjHw5ULIkl3D24DC+rmx1mtl0XN4eSoV1xoHHuVpr3VgA8D3eSXhyjg33TJ3/f6FY2WsQ4E+ZH1M42OsPpnQONjB3wAPr81Rsip2doyt6At8EyAiX9RufbJpH+u7oFUQYos51M3WlhuGFdkD4xnp8OPZnNLCqH0wjdNkHI7b8VnxucFJDesC4BxtX9Ja0P62bh1YGHPyfiS6b/NFlTko3ECBf9fUglnr6Yc0qpSrwivA/TuarOthAHnImzKW5svNtfUOXZSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by SA0PR11MB4734.namprd11.prod.outlook.com (2603:10b6:806:99::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Wed, 17 May 2023 16:46:35 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::7bfe:acda:6bdb:84c2]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::7bfe:acda:6bdb:84c2%5]) with mapi id 15.20.6387.030; Wed, 17 May 2023 16:46:35 +0000 From: "Ji, Kai" To: "Power, Ciara" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2] crypto/ipsec_mb: fix allocating mb_mgr in session Thread-Topic: [PATCH v2] crypto/ipsec_mb: fix allocating mb_mgr in session Thread-Index: AQHZiNL7mKVg4XNZ90y/efzpLFXurq9erJwQ Date: Wed, 17 May 2023 16:46:35 +0000 Message-ID: References: <20230517151339.1047237-1-ciara.power@intel.com> <20230517151916.1048475-1-ciara.power@intel.com> In-Reply-To: <20230517151916.1048475-1-ciara.power@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|SA0PR11MB4734:EE_ x-ms-office365-filtering-correlation-id: b905b62a-79a6-4899-1136-08db56f646c7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KB/QmsWrd1x00hgJIxxc/jX21HM5hksF95HqvjEtb63ZLCKJCsZaR1P/cq8fH1EYLJV7paZtbluNyILUcXOLBWnloH5CR5T+MGWzINMTP5LTfzHdtZiX/pQdrAk5oz96hx037qzsJT2l1+2+q+f4JoVoEB6SxTpcyeEmqZaUsstm8W/xr/3evacgAvUAzC30JjvtJsH/E83cu9GteoGZ799Q7pTYzkFu3YRjACNNyQP/tZwM+4lpxgeEwSOuUxRYjtn1l12cGSwNcEXfoNhNMQDAJiR22pi+5vj8o4AYarbQNsTYPAWCxlPYHRHTOA7QZbNFoG86YjzVL4n7hbVG5zoATAjRvhj7iK2UtLdqkkSA4zJFPRpyEJP7Oavnd5vXUlxfueQ8Md+MOfrQ8fpwBeoTqR3bqLvfJdUVnVvCjTNRXvnetiaa/Je0v0+5pXLw+SQOBvkKK0Osnr62srD/XP9HvZ9kQpyFO+xXRMMyToMKkFjvMN59Z693JcO+5Nft/yhlZ+stEGun87TxeZYJD+ZYcCOz0KqJLdAfUiZWCVlNKDZKOKQ3R0HkSjzf9ez7MfufT6jhZ4WlArdoWzOEO12fbIUP7ovZOkKKi7h6drAY2CPz0qpq0Zef4XO/FtRX x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199021)(7696005)(478600001)(71200400001)(38100700002)(33656002)(82960400001)(55016003)(86362001)(38070700005)(83380400001)(186003)(26005)(6506007)(53546011)(9686003)(316002)(122000001)(52536014)(8936002)(2906002)(8676002)(41300700001)(5660300002)(450100002)(54906003)(110136005)(66476007)(64756008)(66446008)(4326008)(76116006)(6636002)(66946007)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Zuwqo0j2mM6D1dtv/IUy62RN2hNzm7K9knCGBI1j5BMPoHjRiRPHvdb8JLtX?= =?us-ascii?Q?YW37Hc/R/f8dCSbSNKh9lQ2YHP9p//hMq2DPCSMworW6k9SaShn1LokF1NgE?= =?us-ascii?Q?udEYyGbybIfaY7bWVYr1sYRUclPHyUjJWKqP/9haR6pZpSPHMMPERXpDusiC?= =?us-ascii?Q?APx9BhVaLhRbEIz2GyG2XWJihStfDyz8Pc3jHoHW/O8uPJLOwVNFEiYF+W+S?= =?us-ascii?Q?tnWlIs3+BbLMlYEsQXm/q/gejaRePArgDNOZ8SzzFw6cBickU1FvQa8XuiFb?= =?us-ascii?Q?ip1jica1Jypr34dLdopMyaJnuJf5DBVRSKop5Db44QpqZncsjxl0eF0NYwQ1?= =?us-ascii?Q?WVl8DtIrKInWykx6DJyOyDk1vH8tHj2sVRjg8pJDDogEuiM95nEaHiXmGeuL?= =?us-ascii?Q?Km3mCWDb27a5KywNpazvOZH5s4PDxRNzuBGfO+Y9eMvvk4pH3DeBULcl9rQA?= =?us-ascii?Q?ocCqs/NMgU5sTwRTi1XK/chgj2a+Da6VMvcNNZ4cBsuSA2KBzvN7m/RLLbdj?= =?us-ascii?Q?TNAWClMFxAnMLkNdjZVyZBsO/wPFep3iZQ8HCu/kL8OmyvIl85+ObWCF9212?= =?us-ascii?Q?ID05yj9OXEYcT+OMKoJJLpfb61pmt70PIDS8tDYObvtyRuOa65W4scpIlu+B?= =?us-ascii?Q?+dTkn5noEmRt7gXUBj79SdFs7bLR90s+k34lMDJLSZz+ItRKrhQRZdDrifmz?= =?us-ascii?Q?dfCL7A6njnwM11i4qnvp4sEaY8MzGMl1o+rb4VwyDwuBmDYI8WWKn/D+ky6/?= =?us-ascii?Q?NIiJXgAaljEQdttqEJM9CV7hlZhR5oc+htawRSw04m1bfPGAybHQfk3gKDcp?= =?us-ascii?Q?N+eEBE18YHgxktmG/blerJ9O2wP43ez8VFkotDqih571AG/tMgOOtQ6R9d2M?= =?us-ascii?Q?9KrrT87/z+OdIkGKyls5VI4vhDsHt5lpmy8FQYdRo73YYfTQlNNYFoAjCbo3?= =?us-ascii?Q?TeV6of9ScjIkrCm0M+Smw9eeBBN3giQ07DOIP1FkadX6R7gnBUff9CAExttd?= =?us-ascii?Q?MFcto88qnBSaVLdeJd1VQKMNn4R/rWBkIaO5P/5BK6qCN1HC4672zshvYVMZ?= =?us-ascii?Q?FmIaLOTmlExSqjcDGutzEkW+HiQ4mavTsVj69UL1l/xqbtEd2MjHJR5UX+tG?= =?us-ascii?Q?0TCSo/r3PqVhJj/BYuFXPdz8g8iDgHXGjuFNmPOeLquKAC8rD3WZl/vdOWvx?= =?us-ascii?Q?YplXNYjl53G8YV44WBhCiZW4zc+C19r9W4aVIIkfuB1MhI/19uncE4MR4sPo?= =?us-ascii?Q?TB0OuKvcK65qtNwM6r4pqZccvghhkpFqWLh6SZFz+mxP6ZA5wx/bu5N4OWYP?= =?us-ascii?Q?jrhYlloSD7RMqpD+pCxxyt4ZJUEhcEtgpa9lrtVe9+ZMm6/9B1QWcGvuQtgq?= =?us-ascii?Q?iRQoItd5TtovXh7UY4R9ZB114Ov+GUhqYaD1lpupdzdF698u+8Y6l35oxOOf?= =?us-ascii?Q?YQG5oAygBHcuiRC5MwI05Ho5qshaVqS3+W4c7vrg2/ilBdaJYAdmVh2Wlw6f?= =?us-ascii?Q?rWquGlIgaV4n2Cwtw5bQ5s7kPjJh65qiAjkoGvEEOkq131xM4vwOM44/nCrE?= =?us-ascii?Q?vR/YtB3ra1RdL9Mo2Q0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b905b62a-79a6-4899-1136-08db56f646c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2023 16:46:35.2110 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Agbh8WBJsyJMnvK3Yl2VfhtZlIoBPlzK39bip7gmn198QzzYWwzTKgUfkNsfaah8L6Vd7uKjk8sdgMao0ani/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4734 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Acked-by: Kai Ji > -----Original Message----- > From: Power, Ciara > Sent: Wednesday, May 17, 2023 4:19 PM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Power, Ciara ; stable@dpdk.org > Subject: [PATCH v2] crypto/ipsec_mb: fix allocating mb_mgr in session >=20 > When configuring the session, use the queue pair mb_mgr that was already > allocated if possible. If this doesn't exist, then allocate a new mb_mgr. >=20 > This reduces unnecessary cycles creating an mb_mgr for every session > configured. >=20 > Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework") > Cc: stable@dpdk.org >=20 > Signed-off-by: Pablo de Lara > Signed-off-by: Ciara Power > --- > v2: fixed indents > --- > drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > index 3e52f95674..30f919cd40 100644 > --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > @@ -434,15 +434,22 @@ ipsec_mb_sym_session_configure( > struct ipsec_mb_dev_private *internals =3D dev->data->dev_private; > struct ipsec_mb_internals *pmd_data =3D > &ipsec_mb_pmds[internals->pmd_type]; > - IMB_MGR *mb_mgr =3D alloc_init_mb_mgr(); > + struct ipsec_mb_qp *qp =3D dev->data->queue_pairs[0]; > + IMB_MGR *mb_mgr; > int ret =3D 0; >=20 > + if (qp !=3D NULL) > + mb_mgr =3D qp->mb_mgr; > + else > + mb_mgr =3D alloc_init_mb_mgr(); > + > if (!mb_mgr) > return -ENOMEM; >=20 > if (unlikely(sess =3D=3D NULL)) { > IPSEC_MB_LOG(ERR, "invalid session struct"); > - free_mb_mgr(mb_mgr); > + if (qp =3D=3D NULL) > + free_mb_mgr(mb_mgr); > return -EINVAL; > } >=20 > @@ -452,11 +459,13 @@ ipsec_mb_sym_session_configure( > IPSEC_MB_LOG(ERR, "failed configure session parameters"); >=20 > /* Return session to mempool */ > - free_mb_mgr(mb_mgr); > + if (qp =3D=3D NULL) > + free_mb_mgr(mb_mgr); > return ret; > } >=20 > - free_mb_mgr(mb_mgr); > + if (qp =3D=3D NULL) > + free_mb_mgr(mb_mgr); > return 0; > } >=20 > -- > 2.25.1