From: "Ji, Kai" <kai.ji@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"gakhil@marvell.com" <gakhil@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] crypto/qat: fix build
Date: Wed, 18 Jan 2023 14:17:41 +0000 [thread overview]
Message-ID: <SN6PR11MB34085CD4356B9333A9332C6F81C79@SN6PR11MB3408.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230118110558.1136485-1-pablo.de.lara.guarch@intel.com>
Acked-by: Kai Ji <kai.ji@intel.com>
> -----Original Message-----
> From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Sent: Wednesday, January 18, 2023 11:06 AM
> To: gakhil@marvell.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org; Ji, Kai <kai.ji@intel.com>
> Subject: [PATCH v2] crypto/qat: fix build
>
> When building QAT PMD, the following issue comes up:
>
> intel-ipsec-mb.h:333: error: "AES_BLOCK_SIZE" redefined
> 333 | #define AES_BLOCK_SIZE IMB_AES_BLOCK_SIZE
> In file included from drivers/crypto/qat/qat_sym_session.c:8:
> /usr/include/openssl/aes.h:26: previous definition
> 26 | # define AES_BLOCK_SIZE 16
>
> By defining NO_COMPAT_IMB_API_053, it prevents legacy macros like
> AES_BLOCK_SIZE from being defined from IPSec MB library, avoiding the
> redefinition.
>
> Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash
> and AES")
> Cc: stable@dpdk.org
> Cc: kai.ji@intel.com
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> v2: reworded the commit message
> ---
>
> drivers/crypto/qat/qat_sym_session.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/qat/qat_sym_session.c
> b/drivers/crypto/qat/qat_sym_session.c
> index 978ee49dce..7f18e9875d 100644
> --- a/drivers/crypto/qat/qat_sym_session.c
> +++ b/drivers/crypto/qat/qat_sym_session.c
> @@ -10,6 +10,7 @@
> #include <openssl/evp.h> /* Needed for bpi runt block processing */
>
> #ifdef RTE_QAT_LIBIPSECMB
> +#define NO_COMPAT_IMB_API_053
> #if defined(RTE_ARCH_ARM)
> #include <ipsec-mb.h>
> #else
> --
> 2.34.1
next prev parent reply other threads:[~2023-01-18 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 19:30 [PATCH] " Pablo de Lara
2023-01-12 20:39 ` Thomas Monjalon
2023-01-17 8:22 ` [EXT] " Akhil Goyal
2023-01-18 9:51 ` De Lara Guarch, Pablo
2023-01-18 11:05 ` [PATCH v2] " Pablo de Lara
2023-01-18 14:17 ` Ji, Kai [this message]
2023-01-19 9:35 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB34085CD4356B9333A9332C6F81C79@SN6PR11MB3408.namprd11.prod.outlook.com \
--to=kai.ji@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).