From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41A4F42814 for ; Tue, 28 Mar 2023 05:14:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B33542686; Tue, 28 Mar 2023 05:14:32 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 8BB5540A87; Tue, 28 Mar 2023 05:14:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679973269; x=1711509269; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6BpaqyX7nm0hkDlpPqVNb9wYVuY3p5aQW4vpRtDE7jE=; b=T7E6Dh3FCUZtHT+0VQohAbS3ESRqvxSgkM290eTGWK7QcIMBWk88pt0/ vnHzhGOROIfdGwb5072AbsWh9kS6DJYvH8Jcz5B3XXgE16zL0mZiTsrY/ NQp2E6+8WWPH98vMgsl1wRMGdlnqpVKhTwWthRG0PrXaUyDRqEJVqiqs+ qHLDlXFw7ox9Pqut7aTRz1Zb6/h9d3XjxKdutjSkaZGlTlaq6doaT+JOL BrmFZ7XQ/Q+XBir9niF+uRMkeps9OdYm31CfxuuGlzkVsP2z0rl2ReIAL uEIyh4zXBu+XnZrfOVBZWDHlhrAKILfwLWHw9iAjfb0SdOx2DN0RNeO9F w==; X-IronPort-AV: E=McAfee;i="6600,9927,10662"; a="426721190" X-IronPort-AV: E=Sophos;i="5.98,296,1673942400"; d="scan'208";a="426721190" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2023 20:14:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10662"; a="827301933" X-IronPort-AV: E=Sophos;i="5.98,296,1673942400"; d="scan'208";a="827301933" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 27 Mar 2023 20:14:25 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 27 Mar 2023 20:14:25 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 27 Mar 2023 20:14:25 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Mon, 27 Mar 2023 20:14:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OFRRkICMJvTEyAKdAjblK/opwXFdHdXhmsfhutKDN0V8YM8Q4KpPagsnaq5/AEwBekvX+hqDyMc0kC/tGeag2MDhD7M6VBd0G0UEx6pevH1Js/I5CqCqF9C/dQeLkren53z56VufNUG9uQQqvWqLQcCyp0NXH/u7Y7h7eKmP3bws4QTopF1zzVB7y74X9JjivzNtKNWCI8/RJBxU9CDIP6TyPVwZcfYJnZAuIC3FVB349wwDG5UHynyYPjArh02xxJd7FX6ryQrrtqRgjZ+Sz5t/wjM+bR69WK+BjhikOyU3/Cr5Ag2uLpaSKb1o/ywFoKNsm6AGYZdvGbvtRzs2ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o0EQgM8CKoMmZvvt0LCWmm8LMiHeHM5HEUm9BWQR56Q=; b=ApEWPKMJn9vjafGku9upZCFGzF8BxJQMwA8m6VE2nWN9vMAvbuPqmiWzlbxlmR6aCx0KIT+xpyhHqRFwyXgjMzbvVgd9K+pVRoq6+6BaH22tXrwzdmQE0uYEXGQYsBfxbEbSyr1Ortd7L+SHD7kXNh7lQoIQcTl40mkQV8nqu1/EfsBFeFtY1AIl7OO/nOPRJMAvDc0XvZ5onWCgq4ZQ6GpEYfFa9sYg5FKNUPWcOdcDUAvY2u1e+aZp5gRDJiFSD20JhVYgVVNcvGn7fibZMilzpB8nVUXEgzxK216Lr8tTiZRbHbmQpsqFlqbLoVy39fnQH856NxUlhsvseCUoBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SJ1PR11MB6297.namprd11.prod.outlook.com (2603:10b6:a03:458::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.41; Tue, 28 Mar 2023 03:14:17 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::da2e:7612:2153:7978]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::da2e:7612:2153:7978%7]) with mapi id 15.20.6222.030; Tue, 28 Mar 2023 03:14:17 +0000 From: "Xia, Chenbo" To: Boleslav Stankevich , "dev@dpdk.org" CC: "stable@dpdk.org" , Andrew Rybchenko , Maxime Coquelin , David Marchand , Hyong Youb Kim , Harman Kalra Subject: RE: [PATCH 1/2] net/virtio: propagate return value of called function Thread-Topic: [PATCH 1/2] net/virtio: propagate return value of called function Thread-Index: AQHZXKhm/vlkQVJ+TUupv9xhur4kYa8PijdQ Date: Tue, 28 Mar 2023 03:14:17 +0000 Message-ID: References: <20230322102325.1739053-1-boleslav.stankevich@oktetlabs.ru> In-Reply-To: <20230322102325.1739053-1-boleslav.stankevich@oktetlabs.ru> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|SJ1PR11MB6297:EE_ x-ms-office365-filtering-correlation-id: 8a115c8e-9829-4b77-abf0-08db2f3a842c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d+s0rmMyiPMEG+xm7J8tApC7KZx38JoxtQj5T+5/DYN738CIl+6XspCeUTEGsfXhN5tAxZG5nHoVKwTkMzcjZyHNb0MWlDiJHGh84WeHCsizRITHGmK6YCOgSqJPxlX2NhZQ1Fxxb6NMzGbGKHALp5T5USXVSj9HGdvCPOT4Oo/83BxZcW6FyifZBz7QslpS8PUjxPxEdJXTQX9zKvLKctmomxS/9wxY+LD6KM8hbwF4KkWsGPqhR0XXmr3Br6hqDdeGDZFY2E3OfWinu6YIVDd5W/hawkMRTP/X3jL59c1RL/5VygTnA/GLDeetT0dJpVtqEG1GSrl5KR/zpLIoV3LkrvV5GFfN/dWKa+A+oDzQ0IJQVUWp5iC72MnDkdjLtaJAAeEQUFGcw4Rzt6X834ffF9DvgOCGhcNAjsh1EM/KEpU2du7tC2jvshISn6RslhhyvkGDl2K+IRvoeyMcAwbrJuXqTgTSCTYBYKPpyuwAayOd7cGWGRnQrHpAsVyXLLMgcj9XdSgLuEb24MBWmhEZ9LXze2XpMT69DuZLo/LWW77lqzosVgrbKPubxMaY8wuEuFcg/Wsr9k8hzaoHamYzKhdLrVYDX666IjjDX2ap3EBX0vpazOFrxFGAfGqT x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(396003)(39860400002)(346002)(366004)(136003)(451199021)(83380400001)(53546011)(41300700001)(33656002)(26005)(6506007)(110136005)(54906003)(66446008)(66556008)(66476007)(8676002)(55016003)(64756008)(66946007)(76116006)(86362001)(4326008)(5660300002)(52536014)(8936002)(7696005)(38100700002)(71200400001)(2906002)(186003)(9686003)(478600001)(122000001)(316002)(82960400001)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?77Qbo6LRR/Gj6ZWmx8YboCjWxBx5luXl1oVxgB9eM32+0SLLZFJ961irpxQF?= =?us-ascii?Q?84UTFdU17n0xh1eN9QVk0lnPWxUooNFBJ1wjiX7R1on/IXf1v9yfFvEOQe2S?= =?us-ascii?Q?TvVI9rJS9SM3rQKJWE8n3RpWxbg6At/OIdOK6b6JdxIGdEl5Pk+znIO53u9X?= =?us-ascii?Q?iPPDPlvT+EnVXgaMnrmBoxo980waOoJsGqv6ozSLVSH3mqbTsr0fTQ3eX3sT?= =?us-ascii?Q?uUDMINId0cMG3lah22+ciFdIylK5jy/oeasGEeVXj+sE1cMlfqsWM1+G042Q?= =?us-ascii?Q?zOIwC7eL+CeS0vjLofOj3F/9wNpI/EWvwj816jN9m2OpjKUE0St1tDpy+/4T?= =?us-ascii?Q?awKYrzvQsc+S4LSM+cXs4CuupStNpA++pV88cJEaCJjYBnGZ2ILc4Lpn03mz?= =?us-ascii?Q?RN361PbXb3F+1B1NIn8bLX9/2pAb9FduziJ/JriqX43lzxuxxIZp8FQpP7od?= =?us-ascii?Q?22HcbND9Mo7SNOnYifEtVPvt7b3f1uR9yNWdkxD69vc9kp4JQzNvxz33pY8d?= =?us-ascii?Q?z8UPVt9WODb066rgWs7ZxB8CIIj7lgAUZbhaub0XO0fpXbbwF2igxy1cha1y?= =?us-ascii?Q?xo2XJDry5nVUEwnFq57ZF29AOJDv6+9MT5aalTQ50fU9XDhAcDHcwqaXm90T?= =?us-ascii?Q?7Ft100CPU3txA8UeT/ZxhaCT5Nos9UG3LKLulK8VVjCMAvASrwkhGGBeVTAT?= =?us-ascii?Q?9hOyKQLDDweQMJtx3rKBkJlpgdB2VGSjM+CHt8X10iwLNE+Pr+fHInlACuXF?= =?us-ascii?Q?4V1bwePfGCmx6XP1TGIs3IxZYXBN1602afOB743fvaKZQEetvl11zL8Syk20?= =?us-ascii?Q?PZDeE7x6iOD6iz0dgUfcQ4aDavAg4Ck0nu2txM/yy/OQial3CNt5GES1gb68?= =?us-ascii?Q?Qi16EAnWPSUHx1xD2f2KJoGDVqxD8HE07Ij3UxyP3pnDvWufBLhcsenAvmyd?= =?us-ascii?Q?YR25/igx9VfAhiUJMuCWtJDWqZYNruViZGZLDZoh332GGx1kPd3OkdZOAMRW?= =?us-ascii?Q?uLVz12fQ67A4Fov4h8hyztoDmSTl7+zumIARFleMiOdVXGi8pP+Zofa12IQe?= =?us-ascii?Q?aruvZIbGVxrrnNKhJS+RiIaO4BFmgb7M55UoPBigi6VNzrqXIAIlHse5m+iu?= =?us-ascii?Q?r2hZcC38yTkcW0iytryJ61r2gefoFgmc246HmCh8CfoqUGPHeR/aiVP9Kwcm?= =?us-ascii?Q?AT4D1GKBlCIeFDsKJdFAdnDMXvgl/QBernnd6NH/sBU/A8tqHqQaYH7LUNJY?= =?us-ascii?Q?9v2kjs5rmV6i0nwZ7YrorV1uzlnkRl2m0rMSAn8saVZ9PsRppmgZSDyLzDta?= =?us-ascii?Q?a9Eb3qqzTT4gfDoLLMrRE9DhA9/AqAp4Qeo3V4LY05OXJTLVWRFKQsv8lvE1?= =?us-ascii?Q?qOJyunjzJeGXym8HP5ttrueQ/KtMBkac1D1NR5v44tlqkjgpbT5uN7sYzZdX?= =?us-ascii?Q?ME9aLIfb2pqCKyb8b8X4XwvHA251l2tajPwNr03W0ahPOGv3bBSGPmKQbYvp?= =?us-ascii?Q?hMBrVPoxX2QjNJL+78gikAoSc8y6Xc3ARrNP+ETw6/nVvdgk1k+SDaRL02aC?= =?us-ascii?Q?37QMcE6+T4HfpvnzrrSpkF7I9uCi112W2KxO2Edf?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a115c8e-9829-4b77-abf0-08db2f3a842c X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2023 03:14:17.5133 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DXiDt6f5r7bnPZNqHPrGNyNJyMosbIpucWPngIgEiTXBWBVnqtPlrCm5bqeUyaAZ1BIjRNOumAcAd4hnb5VXnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6297 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Boleslav Stankevich > Sent: Wednesday, March 22, 2023 6:23 PM > To: dev@dpdk.org > Cc: Boleslav Stankevich ; > stable@dpdk.org; Andrew Rybchenko ; Maxime > Coquelin ; Xia, Chenbo = ; > David Marchand ; Hyong Youb Kim > ; Harman Kalra > Subject: [PATCH 1/2] net/virtio: propagate return value of called functio= n >=20 > rte_intr_vec_list_alloc() may fail because of different reasons which > are indicated by different negative errno values. >=20 > Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") > Cc: stable@dpdk.org >=20 > Signed-off-by: Boleslav Stankevich > Signed-off-by: Andrew Rybchenko I see Boleslav's email is updated in mailmap file but patchwork is still co= mplaining about it. @Adrew & Maxime, Do you know why? Thanks, Chenbo > --- > drivers/net/virtio/virtio_ethdev.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index ae84d313be..5c8b7b95e9 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1390,6 +1390,7 @@ static int > virtio_configure_intr(struct rte_eth_dev *dev) > { > struct virtio_hw *hw =3D dev->data->dev_private; > + int ret; >=20 > if (!rte_intr_cap_multiple(dev->intr_handle)) { > PMD_INIT_LOG(ERR, "Multiple intr vector not supported"); > @@ -1401,11 +1402,12 @@ virtio_configure_intr(struct rte_eth_dev *dev) > return -1; > } >=20 > - if (rte_intr_vec_list_alloc(dev->intr_handle, "intr_vec", > - hw->max_queue_pairs)) { > + ret =3D rte_intr_vec_list_alloc(dev->intr_handle, "intr_vec", > + hw->max_queue_pairs); > + if (ret < 0) { > PMD_INIT_LOG(ERR, "Failed to allocate %u rxq vectors", > hw->max_queue_pairs); > - return -ENOMEM; > + return ret; > } >=20 > if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) { > -- > 2.30.2