From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B4D9A0554 for ; Wed, 29 Jun 2022 15:28:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32E6B410D5; Wed, 29 Jun 2022 15:28:30 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 6646840042; Wed, 29 Jun 2022 15:28:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656509307; x=1688045307; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uVlJDpoTt6Yp+uG+KD5az9xyXRYAK2UzHF7n/pEqOzI=; b=iw+TR5geeC1D5udCM0I1c0R0Nfbu9DJIzWV652IbF+cTrE/+BRUspaM9 X50vKFexeYAe/PNf2PnsshgXjtSSZWOvwjPGfXuKkleoMl56HPiduoNS+ hVUmi+potG+kKpdXFnqZUwatBWMtVDZNWEDqpBlaAIZ6UBqYv27sbrq+a rPV0ae+PWIZ4MygVkLLbZxLnEJhIkegZbtJiaInGO7c2A5slHTqjIvQYr Hxd7Tbo6nMHIhwHwUufwt2h1c6eOb6S+pyMN7tnJdqI4UweAaQ7Y4Ydw3 hzLmGx10pfPseCvX8A5jpNxtwj8D+COtMNPRFq8df3B3qi5yTAFv6OAJJ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10392"; a="270793372" X-IronPort-AV: E=Sophos;i="5.92,231,1650956400"; d="scan'208";a="270793372" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2022 06:28:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,231,1650956400"; d="scan'208";a="767584926" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 29 Jun 2022 06:28:26 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 29 Jun 2022 06:28:26 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 29 Jun 2022 06:28:25 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 29 Jun 2022 06:28:25 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 29 Jun 2022 06:28:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FkE9W+FXQfpMD54IWAMtGBfGIvbG/1g3R0lHGVVfj/6JFsW7phlb3p6bEmsh3Xey3w7DpxonOFwvkVxMarVXFnN4wHalKWpBtXzo0RWB98YfiKDcdpn36+uNnTbAui0x+Y7M7OfBp4sgdyPlDgOpx/KBcYNk4K3n+N/gzj9JT20YHAW+764c/ToIHoTKDaWS7gcKaHe66SmcgkW0GC0H4VL7KjcET1wq28UwrfIEHIve4mDjzKBtDA6uZZWVBsKQZn3OJZevTwa2vL6SaDUYfdzIdyulPmzmYqVBl876MqXRP5NiM+gm9pu6wwR3sfltrAga5aat9VvaNUs5tpB7QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F7HwTouSAk96pvFUp56Qf2fAA1rUDmDi9YkY+EVQtHI=; b=oMmHGBVulJZhJklRYzqj7IVwLdYLhMCXD+VdFLmCNfgxOJkKnR6no3lll6apxcE/ye3DR/pfIqFwNp6NC6VRCUK4X+LBKHm94ewloz/HRQUBIv1SnW9wzcKSDVbs7/ZmLUSpXZj5LKxgr37QbaGEy8nfOPOB8jJXVUXwFxJFQfNBbeEtmguoEczHpJd4hFB1V4KhBnQ/dhhrWqpV8vJGXVeLZGsvrZi/a6SHeJQTty9TjN+YDg+7JbT4EylwAXHznUdwD7Dc0Dy95yyDLmwBYmDvDfOF0HJhtZFiYMpw+HCRqH8hAN0yweievmBt89OGwUAcZ8lk9pBPIUXto+S9gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by DM4PR11MB6501.namprd11.prod.outlook.com (2603:10b6:8:88::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Wed, 29 Jun 2022 13:28:23 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9%7]) with mapi id 15.20.5373.018; Wed, 29 Jun 2022 13:28:23 +0000 From: "Xia, Chenbo" To: David Marchand , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "stable@dpdk.org" , Yuanhan Liu , Jens Freimann Subject: RE: [PATCH 1/4] vhost: add some trailing newline in log messages Thread-Topic: [PATCH 1/4] vhost: add some trailing newline in log messages Thread-Index: AQHYigguj+5BANsA10OAzBYuL0x2e61mY+rA Date: Wed, 29 Jun 2022 13:28:23 +0000 Message-ID: References: <20220627092728.78214-1-david.marchand@redhat.com> <20220627092728.78214-2-david.marchand@redhat.com> In-Reply-To: <20220627092728.78214-2-david.marchand@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7c606710-fd26-4fff-980a-08da59d33dd3 x-ms-traffictypediagnostic: DM4PR11MB6501:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E6ZbA7lNDa7z71wuhQSYT/c2aTzvpxKCkShYFnktuikvs4lvpzu4QyvAWMeEBSrCjk1qsH7cl8kC3yNODj7g48hiRGkP2dJGGmUvwbajF7VgFufyCrWrvG3dJkyg9hDk2wAHCt39uHG7238SaKfL3aK2Hvg/6bqScOgePlH0VczkYj9fz6Kejm4Qtp+p/bTAZ6WKeESh4KerSkXZekyZCZ4qyZZtNYc5cTEz4coalNd34cCC8u9YzSXYGGXFcdAKjNg8D0SZrVrhf/JxijotKISnX83dfslton8/O9htJv74EWuXUEnREMkgHqMgPETYYwAGStng0KFEHjfY4RYa/a2407qu5Tz42X0F+qWceeIL1EViwtgGv3ntaRhBSdQJ1xItQkE0PgnLBfLdv1FZr6Tc+YEe5Kjjp84Xvbc4eEdQfVZqCrsxLp+t5yA2Qh073LkUivp4eNe8rgxDhHnoAYZU8corbwH3IejNMtY0k7lkU21Hc4t9qX2kq/Jv61yhpeWp9dejEAiDnKdmxJdwNFc/Z45NQYriwa9rt07a2NubpF5ntSoY2zwg10ELcrxmNeo/FkrlMS9fAJe2Uokj68xMluTJdkbsxO7b+pZ2thOvlkx6WaArz3YvSvtWmInHyMaX6PdjxibBIz+iqNg9NUKoHstLMUfJxz/QdDxTmDU/iCGXOnaz/Gya/nUbplVNfHKGkCUuSDnfppNE0Gd4pLcvvCxg54UOIAOiRrQMfs9AbsK+7kzjWK2Ll9Z82KLvug3XoY1VzpPzkxelve2YPPy32BaSmFnynC0HgTjBQDM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(346002)(366004)(376002)(136003)(39860400002)(52536014)(316002)(66476007)(41300700001)(33656002)(122000001)(76116006)(55016003)(9686003)(66946007)(53546011)(54906003)(8676002)(26005)(83380400001)(6506007)(2906002)(66446008)(478600001)(82960400001)(110136005)(5660300002)(8936002)(64756008)(71200400001)(15650500001)(7696005)(4326008)(86362001)(186003)(38070700005)(66556008)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KBNhfeUtWFWnsLjz83LHeBliYSZacUvdiT5nd3fh0lqjp0QriOMjVg3SoKWW?= =?us-ascii?Q?khK14TnDfw3PZCMLnH4zRhlT3Rdvyfyd2E0GI4GfholOox/jkC/zoL07+78c?= =?us-ascii?Q?LOWpKGOqDwLEZ6CPdtZ3t5ye3OHWeTDLhYmw8GeRDKZYaHllk8O4dkSSOeXk?= =?us-ascii?Q?pFoHeCh6d/DWTWviTg1sKSOMimiBczGsX+9eQamrZv5eR+OY/Oh7NIsgftjH?= =?us-ascii?Q?PBgJ0Jl6OsVc768IhUAUxmH7i7+afvtBztHnrplvT4mimuF7ypHUwef82OII?= =?us-ascii?Q?FX6k+BVape6cNJ36HLVrPa45MYylQjUXRopcfHIWFG6cshExloahc5qtVCLk?= =?us-ascii?Q?GADgQSOp51oTKltc+lUBeVtk4rsQ0r70Xaq5cQplSzliAAMuGmVBlnq78tXu?= =?us-ascii?Q?riACXeAe74HBIBZB7Ziedg4xjhhEZSSiWRBWutiGWhTDnNT9e4hXFe5N0F/K?= =?us-ascii?Q?d/hOUCxEqyBQhUdd6FDwI253BoaXfj1ANsKYsXOzyCKE1/7gNBZoTVO3wH+m?= =?us-ascii?Q?Y1IynAcoxVk8gkiNjWkar8c1FZxjSXclNwMaXHUo113qWt4wtuN6il9XzA1U?= =?us-ascii?Q?ol5yLrQyxOdw8BQFUNh6EegcQunVraQ5dRkmfUQT15kBqoIcRAhFKaFP/8hB?= =?us-ascii?Q?c2VdGUXfxSN8mp+piTcTNZyuorF4oiiF4hSxhiED3r8zNS1hihFvdHErt9Uh?= =?us-ascii?Q?+Cbire0a+rRN+XsL3PBaoSRkYujmHXMkUkDO32wJobM9bF/NWqL2NSMnIykQ?= =?us-ascii?Q?gzdarqwp5XnuYFEc+LnRpee2KlCC16kfoOEgNOSAP/q3HF17aHG+LOjh0391?= =?us-ascii?Q?z782uhnQLTg3r8sbwNZ5LxCFfLciXJXJ6B6MOPbFeXhbsh6CR6im3cOEL9Az?= =?us-ascii?Q?4E+UU7k+E1qdXXcd9hdWesejfb+XZlUKe9JcFXQfveYOI5ccoYw+3bWfdzMv?= =?us-ascii?Q?s85DK5DrHvdiCw4mi4h50gA5ntu3R67UR6m5xkn9p7A6X2//uGMZIJvl6PDO?= =?us-ascii?Q?HutPjvWdxxcaNe/Y0jJ4dc84q3tk6VbKrR+VXFTGmmra0M06+K0J2+H+D5AI?= =?us-ascii?Q?Oy0uKj2JQ+xS7EkCTF44YVT3T1JXn85418PA9lPArHaJL7DSr1ChuHYMLavY?= =?us-ascii?Q?6YQgJHejNGuArd0lXs+cb4cEb++HmxFcu1WnEAhtL572k7uKI3Rw/42KHRmN?= =?us-ascii?Q?EkgWx+AdzgwPpE89eS2RKy+O3TLiHDveHqnemN2xmUT5JrLcnsTzE1UGSyWn?= =?us-ascii?Q?F3tQi2gqw5ee9FCHtm4Ubl7vPXGdaAC8UuowU4whGqjOM4bY+5dDsKwt/f8H?= =?us-ascii?Q?/hl6ikeS01X4MgUwKkZ05jtesZYeyYK6TYIBr07CJheCT6MFQVEg+DTdliyq?= =?us-ascii?Q?d8pcvzAz9MnxruCjN3PX4HzuYEeQ9s/epp5LAXFT6ADduiFhcoSBNBoP5gN4?= =?us-ascii?Q?8yq8QCdS0hHsi4dpweHL+MgVJ/ZAsfNvD7pzrdPWPLmPi+6H3tdwEuV1Lf1+?= =?us-ascii?Q?Ja5fCG2GbXOMCSrHQvg93UKfdCh50II6wnCvVtJZocZQC9RDPUAg6A+uSDBo?= =?us-ascii?Q?LPt06qGbusEFFgfvfCN82B8C3eJznHUzRB2jbDS+?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c606710-fd26-4fff-980a-08da59d33dd3 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2022 13:28:23.6282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8L4sP6MA86VMocvvxBkQfgy6wK6BThQhQCnBOvQW5xzUUq0mobGd+llkaXuWNFF62DR19gJzXUDutG0KywAq+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6501 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Monday, June 27, 2022 5:27 PM > To: dev@dpdk.org > Cc: maxime.coquelin@redhat.com; Xia, Chenbo ; > stable@dpdk.org; Yuanhan Liu ; Jens Freimann > > Subject: [PATCH 1/4] vhost: add some trailing newline in log messages >=20 > VHOST_LOG_* macros don't append a newline. > Add missing ones. >=20 > Fixes: e623e0c6d8a5 ("vhost: add reconnect ability") > Fixes: af1475918124 ("vhost: introduce API to start a specific driver") > Fixes: 2dfeebe26546 ("vhost: check return of mutex initialization") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > lib/vhost/socket.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c > index 7a0f63af14..24d60ca149 100644 > --- a/lib/vhost/socket.c > +++ b/lib/vhost/socket.c > @@ -499,7 +499,7 @@ vhost_user_reconnect_init(void) >=20 > ret =3D pthread_mutex_init(&reconn_list.mutex, NULL); > if (ret < 0) { > - VHOST_LOG_CONFIG(ERR, "%s: failed to initialize mutex", > __func__); > + VHOST_LOG_CONFIG(ERR, "%s: failed to initialize mutex\n", > __func__); > return ret; > } > TAILQ_INIT(&reconn_list.head); > @@ -507,9 +507,9 @@ vhost_user_reconnect_init(void) > ret =3D rte_ctrl_thread_create(&reconn_tid, "vhost_reconn", NULL, > vhost_user_client_reconnect, NULL); > if (ret !=3D 0) { > - VHOST_LOG_CONFIG(ERR, "failed to create reconnect thread"); > + VHOST_LOG_CONFIG(ERR, "failed to create reconnect thread\n"); > if (pthread_mutex_destroy(&reconn_list.mutex)) > - VHOST_LOG_CONFIG(ERR, "%s: failed to destroy reconnect > mutex", __func__); > + VHOST_LOG_CONFIG(ERR, "%s: failed to destroy reconnect > mutex\n", __func__); > } >=20 > return ret; > @@ -1170,8 +1170,8 @@ rte_vhost_driver_start(const char *path) > "vhost-events", NULL, fdset_event_dispatch, > &vhost_user.fdset); > if (ret !=3D 0) { > - VHOST_LOG_CONFIG(ERR, "(%s) failed to create fdset > handling thread", path); > - > + VHOST_LOG_CONFIG(ERR, "(%s) failed to create fdset > handling thread\n", > + path); > fdset_pipe_uninit(&vhost_user.fdset); > return -1; > } > -- > 2.36.1 Reviewed-by: Chenbo Xia