From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A1CD429D0 for ; Mon, 24 Apr 2023 04:58:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43C7542D0C; Mon, 24 Apr 2023 04:58:45 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id CC120427EE; Mon, 24 Apr 2023 04:58:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682305122; x=1713841122; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AJIm+3THFJGN/Gz0L4EAgTOcBKyO+1ImszrHwBRSalA=; b=eVdhI992oJIFgxkxhZPQZNB48S1u57bQGqK9G41YC5dGkr7caVar/Jiv G15zp/Vxiq6LN582ClWA1mskvVhGS6jDFGGaW2LTS2agmeIHOXq6rS3Qf bt+Rp9+DCmX7Ic9+dLN9y75NdihVHPNNkIrieiIPtWvPD7z+KaIXDc4Gk Rh70JOfgIUyo8mGYnUxyf5/N8toaHenK2YQTZk2xrrG/pxK2yR92J+ahR bnczaypwyUvf4zXjBxNj7xy45ZgBc5/FMW4fLc5FeHER4niaa12Yopv4O RBh82Ok+l9CHnZfzeMLlLxof7QPpqftDoIVBOYdHP52jm1tIBU17caQet A==; X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="348255945" X-IronPort-AV: E=Sophos;i="5.99,221,1677571200"; d="scan'208";a="348255945" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2023 19:58:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="782242295" X-IronPort-AV: E=Sophos;i="5.99,221,1677571200"; d="scan'208";a="782242295" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 23 Apr 2023 19:58:40 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 23 Apr 2023 19:58:40 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 23 Apr 2023 19:58:40 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 23 Apr 2023 19:58:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VIaS5sN0iU1CxIZujkR+oj4JGZ+sQ/qLvJ93yDZL21rs/kmjurgMUXlF526R1VB9cW3J4HJKaiXumwgSRfmT14Fng6V/ochBbzp2PPYv0tYl0SuV4C/aZ02HAMCu/TFIJWo6Kvg8pvvZc/8d7sSMiGY/lIhCg8CxREJ4+IM77M7BKmG8iDeC8Camx7xt43Kn0s0yFK97Ehq2h7/MrWk5G6zOEgW73E9kTTHjK+fZS+Dyorg5SVRtU8ovIPkunvqRu+D51TytlHM46eiOTf83RzTlKgmeHV87rP4zRe8oEEt0vV7p2aFLnKUKgUfig8nFwNR3BTx0cpDBVXiqzF+2BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nCdh47hAzjHuA+UVhe+y5CcMa+GAM5DjzFIivXOQg3s=; b=KimaUsr38gmkoKfkrula9hWfTstNNzurCCggCGhpQb8dOvcqXUg+xTTfFuCazhlfY06NXsIldTuKNLUQYyktUiNqCOq0YgYukAXF9E85dBSmvfLxHSsjso57FVvdmGurKd9c3FTSs1pk+/5HbP/VBZlb/BNVY/w8SysGeRx0fPmjs5W+Pe8vYDUFJnvLf+SKCg8ZGOobvzqkq7GchkAl9W25s2RMlOUmHB4drH6Rwe55C7G9gIkzfIC7JR5wqVi255CC8ntLfavF8rkZ6FBA/cxSaI9c9PRHulwXqsQmlcXmR8gGnokZDW6bzyO/rIpgUI0Oy3ZhqeOY1t9gzeyNoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by PH0PR11MB5143.namprd11.prod.outlook.com (2603:10b6:510:3f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.32; Mon, 24 Apr 2023 02:58:38 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::2d7a:a878:7bed:bb11]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::2d7a:a878:7bed:bb11%4]) with mapi id 15.20.6319.032; Mon, 24 Apr 2023 02:58:38 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "david.marchand@redhat.com" , "mkp@redhat.com" , "fbl@redhat.com" , "jasowang@redhat.com" , "Liang, Cunming" , "Xie, Yongji" , "echaudro@redhat.com" , "eperezma@redhat.com" , "amorenoz@redhat.com" CC: "stable@dpdk.org" Subject: RE: [RFC 03/27] vhost: fix IOTLB entries overlap check with previous entry Thread-Topic: [RFC 03/27] vhost: fix IOTLB entries overlap check with previous entry Thread-Index: AQHZY+ePNFR5AOaMTUenZo4I4EPzqa856XoQ Date: Mon, 24 Apr 2023 02:58:38 +0000 Message-ID: References: <20230331154259.1447831-1-maxime.coquelin@redhat.com> <20230331154259.1447831-4-maxime.coquelin@redhat.com> In-Reply-To: <20230331154259.1447831-4-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|PH0PR11MB5143:EE_ x-ms-office365-filtering-correlation-id: 9fe1dff5-433f-403a-752b-08db446fcd5d x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kkNkgMj/YtxDFQFSasC3Lc0HUgEovOy23MRlsD6pjMznQxDLBSjo3+fAcWJfaCu3n1/8HRzzERw5dZIg62+wAJkIfxlPdJ4mebzb7hd+8f/5dsPqrhLlOtv6oMcYPZqUOE0Ppib/gueJmVJ6PNB6lI1m62XG+n5wX7H1zFHW0cjCJlMClUVPqK4au3LN26vitoJuN5FikVSw5im/xTLvbuwdqzGVKKXg5W6CA2D+unm94MmXX2vGCsoJRcdC9kVHmfXn/cHLTgUIlHoFq+312nYO6pp3G66Q0qv4b5kEzj6EJnIXXM9oX2G/SHh4OprJHSe57AMsbJfBId6D0NTCs8uJiv3j2056n/yzL35r0R10bzmgslYrtj6mzlm3CwA2p0tiNxoBN26D7m3ESswgYIfYV/xHM8Cur9Jf2nJixVV5grawAP6a3UHBrjxAJqya4ueKR7tQciAGv30WhGCkRvOOdjU9qbv4x4FzBOFDJ/ZeUfaOZZfwoDFJfVyDPJaRui1lepWaxTP6BSJJkNIDHwGdC7e0IiCN9t2guPEeD2qR9pn05Jva6hAp13ar0oBi10pICm/+EJq2g82YwxgvWVt2rX1xUQLNj7E5mAsIbdzPGTYvJPTlisbkAaTR42X4bMAK2FdytmZ1ZrI2BFeSTw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(366004)(39860400002)(136003)(396003)(451199021)(38100700002)(122000001)(921005)(82960400001)(9686003)(53546011)(83380400001)(6506007)(26005)(55016003)(186003)(33656002)(7416002)(2906002)(8676002)(8936002)(52536014)(5660300002)(7696005)(478600001)(71200400001)(38070700005)(110136005)(316002)(4326008)(66446008)(66556008)(76116006)(64756008)(41300700001)(66946007)(86362001)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FxaR9kyGabBdsXSart/nfmYrKOhjoebWMU7KdwMS6aHr2ECgprzeE39lAvQT?= =?us-ascii?Q?IDp3APwFSAC4czvD2ZTEcU3I5UqO5sL1ayvZsP8TGMgPUOeeb+s7SvFfLMfZ?= =?us-ascii?Q?vBdHiD2dtr/OJGKrkn3TZJ5FFsa687fttOTGFWSIWFMOqlLwhwtTUJJyM5Ot?= =?us-ascii?Q?bEls1Ya1svF2asF3jKmUR5Zxx2xrsOssMTAIuMHPpH0XsM0yJR5p1s5XazT3?= =?us-ascii?Q?Yptki4PyDfIIL1qPJ1TRGAI2LGPp/yebuFoeX/wsllbpcRwMxVbNO1jdCG55?= =?us-ascii?Q?g3ndJ84YPgoSe/VyMfGnsevQUTckmDkBqWDQDF4k2mdfHkLRWN4y8zUUTx+F?= =?us-ascii?Q?HolrjybJV26M+79T2Xx17p3zBTDwvrqB4xxK8/v0sxtWGfP7cVbUm+w0q+dy?= =?us-ascii?Q?trDtt6IJ0GvW2LpCmBH9IGD5eQZGem/6BQCEiOgZmloFVHAs/AHB+QC7gzMB?= =?us-ascii?Q?XR9wigxb5GRdPbkmQL1JOzBI2D1SG65zXE6JwuJH3P1CvImLKzCS8Z6+h3aA?= =?us-ascii?Q?Qb8H6hR3s4hNEEN73NRjAMaDTvAJR8bjByaWPQkM6PwqiNrx0PzyzRHIyrZZ?= =?us-ascii?Q?WdIONUUNbzyhXsY8StHqXY2xHEDUGGFSgMGqzbpd/F07cwMFrTr772NbZbgJ?= =?us-ascii?Q?Wb4GKsvThZAx8ue011xwJ7hMI2kxcXlvVyGfWZtEnSKsRjU3YW+VfvB9y68D?= =?us-ascii?Q?PO1Wq1eJEgq8P8f14GyuoVmgfWIW/vlvL/Siz8I/7z0oyUtTaF3oDYxrutx7?= =?us-ascii?Q?Exo0Ka9j/M3x4MGov7k87TkGyj4OZAIikWBa7ImJe3p2YbsJcjkzTEiGcmTD?= =?us-ascii?Q?FPjE1j3vrcFOQhUwwxj92UVaO0V/NW4+fYSS2AwcxYmsP37+4SATMxKtWDXi?= =?us-ascii?Q?23WtHVDBhC/+IqZaSv4T3sLA3n6Lct1KPI4B02siK5ZTLyiYaEkmmJp0bS0C?= =?us-ascii?Q?d5paOrInYYNx8i3u+J4AMjXcuCRZ4IEp40Okl2BaF9W//pJ8mC3qbiocSid6?= =?us-ascii?Q?VDs4CQDX6UpY0pxFK/cqkhxM7mU3Lt0qXNNTtLtcctOOqEFmD5eV+cA0wVS4?= =?us-ascii?Q?4xUPxuYYIqMKuR0mplqsLW7PaC492vuU3+GSRRpwgyIMjt8AVrCVQrWzim/m?= =?us-ascii?Q?TefLJ5P4UwscR0EtnComvsvx5Yxx3WJppMp59nPURwXWTvtvoIky21htbYNY?= =?us-ascii?Q?Jo6VMfChhDiQv1Go4h9XhgIsjVC9321yVhFZ6Cz2dzICotHwqOiug5hoKIk9?= =?us-ascii?Q?NqjD12/L3FUWv2upDEAP+0mzB7d/6uNtzXEsmT2CknZd4M+XbRpvwQxtv902?= =?us-ascii?Q?fdj8w/H2EjEntpoKKMdJMRPQL25yXPV+1V+T9rqpACNmyCQHOKnbxks9tlSl?= =?us-ascii?Q?+36RshsivGsKCyJZu1P70jv/aSTPIEJz1xW2lxmROpY+Rt8Kh3VSNZlZDm9b?= =?us-ascii?Q?JDzE4m9+SQCNceqE/1/RSw6af5p8MwKA+EZNQ0pXhkpcfz8yjSIjyqbEVRDe?= =?us-ascii?Q?5yv0j19L3arfHnv8toUJppFzI0vB57FV2HNnUWAoGi4+KekpY9Aa3cQ/eDez?= =?us-ascii?Q?XLRItWOSCsR414ko53f7lxSO1wGrOQ8bLS2h6PVO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fe1dff5-433f-403a-752b-08db446fcd5d X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2023 02:58:38.0468 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5J9jHrpYKEB8roIyxhBbqIR59JYf3l7CWP5qVfDPqnGSYLQSJtJvRqbIByFelCcimVFh8wN8czLad4B2rcsMSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5143 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Friday, March 31, 2023 11:43 PM > To: dev@dpdk.org; david.marchand@redhat.com; Xia, Chenbo > ; mkp@redhat.com; fbl@redhat.com; > jasowang@redhat.com; Liang, Cunming ; Xie, Yongj= i > ; echaudro@redhat.com; eperezma@redhat.com; > amorenoz@redhat.com > Cc: Maxime Coquelin ; stable@dpdk.org > Subject: [RFC 03/27] vhost: fix IOTLB entries overlap check with previous > entry >=20 > Commit 22b6d0ac691a ("vhost: fix madvise IOTLB entries pages overlap > check") > fixed the check to ensure the entry to be removed does not > overlap with the next one in the IOTLB cache before marking > it as DONTDUMP with madvise(). This is not enough, because > the same issue is present when comparing with the previous > entry in the cache, where the end address of the previous > entry should be used, not the start one. >=20 > Fixes: dea092d0addb ("vhost: fix madvise arguments alignment") > Cc: stable@dpdk.org >=20 > Signed-off-by: Maxime Coquelin > --- > lib/vhost/iotlb.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c > index 3f45bc6061..870c8acb88 100644 > --- a/lib/vhost/iotlb.c > +++ b/lib/vhost/iotlb.c > @@ -178,8 +178,8 @@ vhost_user_iotlb_cache_random_evict(struct virtio_net > *dev, struct vhost_virtque > mask =3D ~(alignment - 1); >=20 > /* Don't disable coredump if the previous node is in the > same page */ > - if (prev_node =3D=3D NULL || > - (node->uaddr & mask) !=3D (prev_node->uaddr & > mask)) { > + if (prev_node =3D=3D NULL || (node->uaddr & mask) !=3D > + ((prev_node->uaddr + prev_node->size - 1) & > mask)) { > next_node =3D RTE_TAILQ_NEXT(node, next); > /* Don't disable coredump if the next node is in > the same page */ > if (next_node =3D=3D NULL || ((node->uaddr + node- > >size - 1) & mask) !=3D > @@ -283,8 +283,8 @@ vhost_user_iotlb_cache_remove(struct virtio_net *dev, > struct vhost_virtqueue *vq > mask =3D ~(alignment-1); >=20 > /* Don't disable coredump if the previous node is in the > same page */ > - if (prev_node =3D=3D NULL || > - (node->uaddr & mask) !=3D (prev_node->uaddr & > mask)) { > + if (prev_node =3D=3D NULL || (node->uaddr & mask) !=3D > + ((prev_node->uaddr + prev_node->size - 1) & > mask)) { > next_node =3D RTE_TAILQ_NEXT(node, next); > /* Don't disable coredump if the next node is in > the same page */ > if (next_node =3D=3D NULL || ((node->uaddr + node- > >size - 1) & mask) !=3D > -- > 2.39.2 Reviewed-by: Chenbo Xia