patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: "Ding, Xuan" <xuan.ding@intel.com>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v3] doc: fix vhost multi-queue reconnection
Date: Fri, 6 May 2022 08:40:55 +0000	[thread overview]
Message-ID: <SN6PR11MB3504FA8C563C3E892573387B9CC59@SN6PR11MB3504.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220415020801.37612-1-xuan.ding@intel.com>

> -----Original Message-----
> From: Ding, Xuan <xuan.ding@intel.com>
> Sent: Friday, April 15, 2022 10:08 AM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Ding, Xuan
> <xuan.ding@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] doc: fix vhost multi-queue reconnection
> 
> From: Xuan Ding <xuan.ding@intel.com>
> 
> Since QEMU 5.2.0 fixes the vhost split ring multi-queue reconnection
> issue in commit f66337bdbfda ("vhost-user: save features of multiqueues
> if chardev is closed"), this patch updates known issue to indicate
> the range of affeacted QEMU versions.
> 
> Fixes: b37e95507e1b ("doc: add vhost multi-queue reconnection issue")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> v3:
> * Updated affected QEMU versions.
> 
> v2:
> * Add fixes in commit title and log.
> ---
>  doc/guides/rel_notes/known_issues.rst | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/known_issues.rst
> b/doc/guides/rel_notes/known_issues.rst
> index 187d9c942e..bd89d58d24 100644
> --- a/doc/guides/rel_notes/known_issues.rst
> +++ b/doc/guides/rel_notes/known_issues.rst
> @@ -885,14 +885,15 @@ Unsuitable IOVA mode may be picked as the default
>  **Driver/Module**:
>     ALL.
> 
> -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0
> -----------------------------------------------------------------
> +Vhost multi-queue reconnection failed with QEMU version 4.2.0 to 5.1.0-
> rc3

So 5.1.0 fixes the problem or not? As 5.1.0 is later than 5.1.0-rc3 but you said
from 5.2.0 it's fixed. And I think we should just mention formal release, not any
rc, qemu users should not use any rc for formal usage.

Thanks,
Chenbo

> +-------------------------------------------------------------------------
> -
> 
>  **Description**
>     It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves
>     acked features for one vhost-net when vhost quits. When vhost
> reconnects
>     to virtio-net/virtio-pmd in multi-queue situations, the features been
> -   set multiple times are not consistent.
> +   set multiple times are not consistent. QEMU-5.2.0 fixes this issue in
> commit
> +   f66337bdbfda ("vhost-user: save features of multiqueues if chardev is
> closed").
> 
>  **Implication**
>     Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
> --
> 2.17.1


  reply	other threads:[~2022-05-06  8:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220221072743.88049-1-xuan.ding@intel.com>
2022-02-24  6:28 ` [PATCH v2] " xuan.ding
2022-03-29 12:46   ` Maxime Coquelin
2022-03-29 13:15     ` Ding, Xuan
2022-04-15  2:08 ` [PATCH v3] " xuan.ding
2022-05-06  8:40   ` Xia, Chenbo [this message]
2022-05-09  3:07     ` Ding, Xuan
2022-05-09  4:11 ` [PATCH v4] " xuan.ding
2022-05-16 12:44   ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB3504FA8C563C3E892573387B9CC59@SN6PR11MB3504.namprd11.prod.outlook.com \
    --to=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=xuan.ding@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).