From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF0A841E63 for ; Thu, 11 May 2023 10:21:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D67A942D8B; Thu, 11 May 2023 10:21:48 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 1718B42D5D; Thu, 11 May 2023 10:21:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683793306; x=1715329306; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=SBJXNjntGTLDpx/fUQndO5F7E1LD/WvzyhOt5WFIwww=; b=VSSyExtNZob7oc73WAIJnmBLPhQhJ1xzMUAnZnpBpoU30GHrRLuHhdO7 txn+pRNYTPF7sj2keaL2B3r5yL8yGsOMdYHRxd1HxvSpoR1Skw4wVs8PF K953lqJ0EkxasK3+Mi070oLwp+0KYYpV20avbk+3xQejROATHJgdevget ph13kIqeK035gw+CiK1NB2jtQ9KrDXXiEeJU8NgdzFPRrvVgru4naEgVB MTBKnhH62jfF8FvlctifJnBxxvR4XLotIWCAUdCLl4iakScFAI02RuTpf xh8rckTKzL1165squLtxrEWL5WqYHot5d9fcjmyxtmLDNbfqmRadqPolm Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10706"; a="378555394" X-IronPort-AV: E=Sophos;i="5.99,266,1677571200"; d="scan'208";a="378555394" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2023 01:21:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10706"; a="811496700" X-IronPort-AV: E=Sophos;i="5.99,266,1677571200"; d="scan'208";a="811496700" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 11 May 2023 01:21:44 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 11 May 2023 01:21:44 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 11 May 2023 01:21:44 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 11 May 2023 01:21:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Na9rKDh3L2eEzGlgMfJWGwN9iv82+1Ltjky9mMKOl0Rg/5L7BrrjxXHFW6XS64wumVAliMc+SYXbaPNcGEKGRLldw63m5fyrbeBxL6glvvcCeKSNfaS8oGc5d3NANwZLggeMxyahePmNiMC5/TIPFgj7ERHC6GEC2QhtwG/PZ/hCyd2DRl8ElUYpWPuYwcFnNEuXifl6F22xI6M+AVVJ50f6n4U9kAJbsy/BRRPXuWc9jZ2L1VJHdz8Le/6mmTyXHxM2wzuDH6CKxdqJbi3JxkixfDaYHsuSddmxF46UfrctY/KYkBN04gdGlRdHTHvbrUS+Uo1feaPetp6qu2hyJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KiiWzQxFSSzFpVEAJ2hSStN6IA6mSxnYYYFALPLoNgc=; b=DmISczC2Cu87bUPBfocscbebzzvkDxhLdCJyyt/+pme77y3mnU6tw7xYANJygzf5VwDIxXCUm5zdgERIoYEQt9OTd7AN/a2HNn8Gflbflau2yKLnQ9NqyQEc/4fBSZ0p1n3ObK67kROwsni98R9mfgRZ/l+0zRN+DGYyluWy4Rg4OJOdb2XadFeLK/bODB/M1lgGxfxDRh3IO40djpc+mUKDaFIV/MJIoR9+w5CJOm/S/8xM395mVWnJezXa1LS342B/AMxc9YLajpCOgmdMG69UjnxbxSyWFRirlxotS7a/UugfspOmR//pt2oou8Vqo1hEKI55DIXaAx3leiSFzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by IA1PR11MB7890.namprd11.prod.outlook.com (2603:10b6:208:3ff::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.18; Thu, 11 May 2023 08:19:51 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::e427:f0a6:8472:d0f6]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::e427:f0a6:8472:d0f6%6]) with mapi id 15.20.6387.019; Thu, 11 May 2023 08:19:51 +0000 From: "Xia, Chenbo" To: Boleslav Stankevich , "dev@dpdk.org" CC: "stable@dpdk.org" , Andrew Rybchenko , Maxime Coquelin , David Marchand , Hyong Youb Kim , Harman Kalra Subject: RE: [PATCH 1/2] net/virtio: propagate return value of called function Thread-Topic: [PATCH 1/2] net/virtio: propagate return value of called function Thread-Index: AQHZXKhm/vlkQVJ+TUupv9xhur4kYa9VCTHg Date: Thu, 11 May 2023 08:19:50 +0000 Message-ID: References: <20230322102325.1739053-1-boleslav.stankevich@oktetlabs.ru> In-Reply-To: <20230322102325.1739053-1-boleslav.stankevich@oktetlabs.ru> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|IA1PR11MB7890:EE_ x-ms-office365-filtering-correlation-id: 7c83ab54-8bc8-487e-a48d-08db51f87dd3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8n2qaFKd4Pzm4zduhwpN8qAV+4MNmGZQBN5VdTOmhUEWhlM638nWq+JpiOEezA+bsQC/qqnL4VoYXWefVwrNI0160lpRJu2Vm3S1bj4zje1Xmbl/+inup2GlHctKviEmKKKn/Fm9Qrh3RsNCLfZh8QQRDUAy5+Hcgcr1KICk0A65L/BtHIqe4wnFIHh/qLO1WEFaM0d5/jTwe+oTj5c4/74kxAvomImzKsTIdCex4tvctWvSlzdUJcBK5IHhDIGrqb6jTnHkZGfbslLf6H2RVuaG5dSjviO7YdwJZxzK52KOZHJkSWT/Ke+ZnA8a/VtCFidVnnnCskd686gCPFKNAGP37HBLI1cYjvd6DFioDTvFs+94e//Jl/Ta/A3ERvezZIope2uSBDGC8KmHhz1mINRUi6yNhUQ/PAU3iTX6q3kfSO+/hC+JWVMwFicB2+7koMK+AL65GehmBfLNGtyTYU24P//AIFUzbZHia3p9C+ukVURg8em0jhnDEcw/ynFtEyHuJbGj5AB3nWdxotlXzw+pLx97nIHvaB09f/OnrX10z+jJQDExyGkrwxLmytSI/oQF3EPL8+HY9P7242a6jL2H5SnSONJKa2SF5Dx5IOKVSTMhpRFgWJDS3OrBWQuL x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(346002)(396003)(376002)(39860400002)(366004)(451199021)(7696005)(26005)(53546011)(86362001)(38100700002)(41300700001)(55016003)(71200400001)(33656002)(82960400001)(186003)(9686003)(6506007)(83380400001)(122000001)(64756008)(66476007)(66446008)(66946007)(66556008)(76116006)(54906003)(110136005)(478600001)(38070700005)(4326008)(52536014)(8936002)(316002)(8676002)(5660300002)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S8k07SeMB3mTna0CrMLQ3hgVaF1OL1oluJNp6j4sX71Rl5u2NftgtRR49caY?= =?us-ascii?Q?VauU0HjP2o/WswV/W7XpRmXiv7vtO8iz4Gii97OTC/+L7CCA++SHWbUFu1to?= =?us-ascii?Q?thHKuygneLfhHB63iixe3+HfT+BOWP8V3SiudzPtIVCgKU9FTU5V8AmzkOQ6?= =?us-ascii?Q?qU7QttkImtfAGE2l9vcCFv7jrDTZSUM7dFD6PFsUp6UiQ9SDdecoP/3oAT1s?= =?us-ascii?Q?X+fbCfJT3IdvJ7mu+hNy32/rkoguuASn3m4P9R7ebi7kvvOkpU4b/p02r1VX?= =?us-ascii?Q?9LdIyCYT13BORGXDSMNzxlLU0jPTt7HKAPb41jyQjgK2s0h+W2P+8wRtSbfm?= =?us-ascii?Q?uj3OAWEijIru8MwLGSlVeWBUoWka5yVP3/TkL8IxbHOYEQMLw+m3G5+We8SC?= =?us-ascii?Q?Cshl6bFQVvaTWYamirfT7JyjQ33i2IXf0ccU+q6lf+6pTYzeeAfqjm9gG7mr?= =?us-ascii?Q?dHAzu679InWgdHDh2U1hXQZGQ7c0G+FX/fXG4fdjuGwOyfVi0rpT/jAlCUqP?= =?us-ascii?Q?RMgK+zO5L4P3C7KD0zKNjxqOGOeR94XZbkn5t0ynIY9TCUlyxTsNrv8tj3c5?= =?us-ascii?Q?jnlcMtP1DVqQhcPkRPSzBUYnyFdtH9QiPmNCiCW2n1gSQzNe4ZAiFZ1Ca15x?= =?us-ascii?Q?7zqzGASqUvsQEx7sF3lwXD8Qpwa4P+hyv8lGyiWJFiaE4a/Bncy+YWcSgOKU?= =?us-ascii?Q?7WZQJyz/NeopzgXIuPe6PnbaH/Nj6DzIjyqSQLXf0fVE3czcwsWrg9X+O6Mg?= =?us-ascii?Q?tGQqMWK9qpmU8zx6IZHBfvmPuL2D1+OMrOfyaIPDn/M9GUJcAYtb8DiTVwdR?= =?us-ascii?Q?dkAMUxMAx3B50lOBYBbsiG4C2qNBwmMS5StOuzbqncJJV+Z2SB4xBx5uwVZT?= =?us-ascii?Q?JvONb/Xv4z6tuQttk6qku5QA5N/8kezjXPNzFvzUdOToDdvtAS1Jde8qdUyk?= =?us-ascii?Q?t1L3DzkmFpGIM1QYixvHw3+UlxiVRkN5oQLas14R+YF1Y1uC/sIKhl8o7nIi?= =?us-ascii?Q?ox78PUmC2KM85Jvw4aF29667EZKxaA56YH6NBytNocsWCnfyXUnGtydnrBhm?= =?us-ascii?Q?k7xxqzvS0yNxz9suiR8ofPPl9PCE1kb2zY3Icz+za/8U2fsBzVRXTFpH10A+?= =?us-ascii?Q?iPFLVl7DftxxKdijBalOZ0J9KM7PZQ+eVIAM0oCEDQX4tgXc71E4twHeBxH4?= =?us-ascii?Q?NseW/kIwpr1l5UCQSTt1ExNFKvA/6DaD5M7K3Hl54ETPEYYJmOgtwyCf+A6I?= =?us-ascii?Q?pmpmasViMiQQCqOwSAET94IsbzAoYtqrXeWwg9D8DHsniMnmQ7yMtLVPd4Gd?= =?us-ascii?Q?LOHcuf1OoCUIHKS43v0n2xcrS156kTIyXLnjwzj48vtAFvg49qdCcAG77C2k?= =?us-ascii?Q?nF6SrGsenHrUWUprPrBciN9JMuCOTGlsvF3DaXKmVxDu+JLQFADVyfYQTQf7?= =?us-ascii?Q?mPa+um/fQh/xD/SmSvbvqlDlrIGnziWJtxwbK8+Eu40NmYQ22nN1CmUZAmm2?= =?us-ascii?Q?AatlN7d+P5mgeu2NZYn9Mc3qA4IJ7Dtg3jxQqc4xREgD21JpYi5cKZ27iphx?= =?us-ascii?Q?OLPfbsyHkjFUImheANEwQU5Ez7LPNBxNPzkUEU4t?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c83ab54-8bc8-487e-a48d-08db51f87dd3 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2023 08:19:50.7372 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h68A+ung5avbdFO4HLrnylhkZ2yCtjztzgDFKsmlCP3DK5LgaaFd8ug5vNSDgNByN7GWsr6jIbYSTNQ2PmpY4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7890 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Boleslav Stankevich > Sent: Wednesday, March 22, 2023 6:23 PM > To: dev@dpdk.org > Cc: Boleslav Stankevich ; > stable@dpdk.org; Andrew Rybchenko ; Maxime > Coquelin ; Xia, Chenbo = ; > David Marchand ; Hyong Youb Kim > ; Harman Kalra > Subject: [PATCH 1/2] net/virtio: propagate return value of called functio= n >=20 > rte_intr_vec_list_alloc() may fail because of different reasons which > are indicated by different negative errno values. >=20 > Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") > Cc: stable@dpdk.org >=20 > Signed-off-by: Boleslav Stankevich > Signed-off-by: Andrew Rybchenko > --- > drivers/net/virtio/virtio_ethdev.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index ae84d313be..5c8b7b95e9 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1390,6 +1390,7 @@ static int > virtio_configure_intr(struct rte_eth_dev *dev) > { > struct virtio_hw *hw =3D dev->data->dev_private; > + int ret; >=20 > if (!rte_intr_cap_multiple(dev->intr_handle)) { > PMD_INIT_LOG(ERR, "Multiple intr vector not supported"); > @@ -1401,11 +1402,12 @@ virtio_configure_intr(struct rte_eth_dev *dev) > return -1; > } >=20 > - if (rte_intr_vec_list_alloc(dev->intr_handle, "intr_vec", > - hw->max_queue_pairs)) { > + ret =3D rte_intr_vec_list_alloc(dev->intr_handle, "intr_vec", > + hw->max_queue_pairs); > + if (ret < 0) { > PMD_INIT_LOG(ERR, "Failed to allocate %u rxq vectors", > hw->max_queue_pairs); > - return -ENOMEM; > + return ret; > } >=20 > if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) { > -- > 2.30.2 I assume the mailmap warning should be fixed when merging. So: Reviewed-by: Chenbo Xia =20