From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1386A054A for ; Wed, 15 Jun 2022 03:57:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB73941145; Wed, 15 Jun 2022 03:57:01 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 7315A40220; Wed, 15 Jun 2022 03:56:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655258218; x=1686794218; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/1VE1fCpPSs0HNnYvEZc/IraqHRIdG30aGVw8cHjw+c=; b=gq0nSlGv8+wIrVyQunTabtzfgXR+v5O3mwGxcvGj3ZYY6aDqaaV+kneQ vAvcHEc029ysZwLkwiNTQmS2WYPkjBeiHF2CehEsXjqe+0tZ/HEputxOQ m8sz2kTFTnXXDp66Qq/e3q4ZYkFaZJagrrLDi9qYXREoYxRfKaBzMy/vI Tdt6oDXzfQlEE5UXkpd/Q3MVGHmzwzBV2vdK9i5+Xun4BV7hN5rQ5YWZC QKrRHE+6jpqgMaFut+pDGOQOgHZ/zOyFnv4C2okGZVbMO0Rhs+kWEgT2+ Ih8Ql2ij0IHL2KpYF5kMbVLeEFeiyRheKuByAEPxMjP2hfr9+x/0KBto4 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10378"; a="365146348" X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="365146348" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 18:56:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="762232963" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 14 Jun 2022 18:56:56 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 14 Jun 2022 18:56:55 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 14 Jun 2022 18:56:55 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 14 Jun 2022 18:56:55 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 14 Jun 2022 18:56:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h3iyflim71QBWvhcpL3yiyC6lKKe7goS2oA8QMOY2en3zx0TXIoDNSMTwRbTSwu8ELqxO/U1EA1+vmKu0rJYw0XKyCkt6feuImIRTUo7h0xJPD7FjdB6YsvAQwIu7R3SWMREx3b3bXgYQCHwcZU4oEeTmLrxm/mDC+ARiI2qG4uqL2hgfiRs8cOXwG6rpTLbrfFUsjNoCylC+Vlso0UxZRy4F9ZU8XZqFTFrQe6zBPDhCXrgzoFfI97NpFoIOl4xawNjAUFfDHk/hVfO/O39EuHyPY2nUt73vE4b1HjalEzl4E40V30uaQihAzTg83TMZLfo+nBDzv/nYBwWbHHVbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uSOXxjJUdsw9IVFD+SJ+FXxxJvTwzXCAwIVdUu+q8dE=; b=jtmziwGJCPZRrLG4GPoIffJNLNgYgSJqog9IxFDC/Iao4P+RFFzmPWwtYMiwUSv9JCdGKw3Kk9Ager5UGjxHkQDQzs6UNlDyIkyl2kZdYw3SvrnDkyOEOxSzfnaP2jAmO3pflNYCY8jpzOu0UgDXlaWS5n+IDFL+1ByBoOEyfDcmIBlCc3ci3XHAwzAmQ7kKjI2gBM35o1ZRLRarYZpPeSOL8S97dtlTzrHEWrv3jx4HF5ZjcfO7ynahdCN/4JzyOySQSkvJ2gt6rSCEtmJfHgMBuHLyc+NGAEMxiWN6TG1Jya6xIoSHjD1zcP9UgtAYU/fkOhxBaaVSU94/nzbBlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by DM6PR11MB2970.namprd11.prod.outlook.com (2603:10b6:5:65::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.14; Wed, 15 Jun 2022 01:56:53 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9%7]) with mapi id 15.20.5332.020; Wed, 15 Jun 2022 01:56:53 +0000 From: "Xia, Chenbo" To: "Lipiec, Herakliusz" , "maxime.coquelin@redhat.com" CC: "Mcnamara, John" , "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] doc: fix readability in lib vhost prog guide Thread-Topic: [PATCH] doc: fix readability in lib vhost prog guide Thread-Index: AQHYce7pAv5wkbLH7EyrNt8v6Gbpa61P0MZg Date: Wed, 15 Jun 2022 01:56:53 +0000 Message-ID: References: <20220527173120.30050-1-herakliusz.lipiec@intel.com> In-Reply-To: <20220527173120.30050-1-herakliusz.lipiec@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b099d6ff-528d-4774-de92-08da4e7251bb x-ms-traffictypediagnostic: DM6PR11MB2970:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CVL6vZ7UDsJ3yarrwy4xCgIPfbktZRy9zEi/7H5Zi7V5/+vTaHvKB/mtCApkrpvkd0pSLqdX0H6LjQU6DXs8klJaBuY23MNpcHVUN7JGUvMXUdh82Lt8T5puqopZfEY+IuCmP0MKPfW9UwgIXDt9E2MXvR7524SagdWioO2KoAf6eMeNb8WLOLziwErxeHXgm6qm7suoSpuvUUSG32fiBIKBgjxjF+MGxVPXW2xXcgtx6NEFcW9AG5Wkwksbqx54pqexkzjTtNFMNJh8uFPl6NUZ4vzsh6KRfdNeXlJG70UAyHdsqeWR/Mrwa1yIkwf5EFgAUhWJH14S6S82BCtiVDVYOjynsNK1pPI1E/FU2ubgmn8zgd5p1cjjodswNYeovE1trW4JmLXhGxaW1nkPXatqS1GxDg8L4sYTWSotnxTjhQIyOR/OPElIYvrU0e5+aZEiC3IVyswJdyA8tRL8DtFGsejdltlKc/YgTit+nG9S38P62RoRLUsZEfm0kECt6vjGXoz2TBtxP/Z//bfR+vi8RQt1e9+zjCmw2lpebVLfbznygwKdA+S3Ngd7AVNNAdmiT8MTQrWzS8liLrkCJAnBG44lvMIJiuhdnfAUZGO3dSOM5584RJqD2fomwFqBbQvOYz2TbcULucz048NwlORsXRuOcg5WKE3/E8lK+NoeanfSf4hMQAN5h8bUxOtnFF27IVAu31ifPns1E+6V2g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(38100700002)(86362001)(52536014)(8936002)(5660300002)(508600001)(110136005)(38070700005)(122000001)(82960400001)(54906003)(76116006)(4326008)(71200400001)(66946007)(66446008)(8676002)(66476007)(316002)(66556008)(64756008)(53546011)(33656002)(2906002)(55016003)(83380400001)(186003)(9686003)(6506007)(26005)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d+9jllmCRgEbTFnJtkUcBRGYh6UL8N/H3nlYO+9S4Ubbc9IQxsL6PK2kfKGU?= =?us-ascii?Q?WhoO98HqQC575xDmLSXvxOGQBqv3PbyrHOzqTrRUbj5shy1jie1JGvFem6u7?= =?us-ascii?Q?TeWbK0MqDobM4suhQPKm4UvV4YDMvAyy0+eiSXD3kqA5D3UhdRdZyRc1PK5K?= =?us-ascii?Q?jbdb71FwO3jj+pgFqqS10VZxmqtkRddAO1YlPqesNtLcHsXeLkFXqisnutOo?= =?us-ascii?Q?GwRoXpBHFlrDe0tP+PxncbybzHeVt+Kf7tllpPY/4OhABc3Y8F7/0Urj9/vf?= =?us-ascii?Q?eK0qGlHii0gduu2Gt+Od1fhkX5IeRoouMl31POaJWq8LJt4ZqY9oIojQ0r69?= =?us-ascii?Q?gS3pikLyTRl+nlH7CJmbtvvem3/FLqqoxpNMUZgs0wQBDMhJ3aFPoWFIPf99?= =?us-ascii?Q?YbSDgDo/6ShFYw1eQLCXB+RsHQXfa+Iq3IzKhKraW5jA/EdBXbx903YcjbPJ?= =?us-ascii?Q?yu1kSfklm4TlQjFZim91nPnzLFpCGqYnOL/7efmU6g3PIws/JlM57q4x/T6e?= =?us-ascii?Q?P9Uj2dbH5VybuyYlpTssiwQLhAE80Olev2LUwWjO2+SXWw9mtPJGFukfMA6E?= =?us-ascii?Q?tj6fdT/y1yX361M4jl/XELT8QbdXcFRa6AYfXgxum0UqVt1hrSrzQlEBtuZk?= =?us-ascii?Q?Az1wp1/BWp9QL5dVYst/vUFo80Lc5Z2XlxPOFOMLlXXIKNkpbacSlSYyU8BH?= =?us-ascii?Q?haNuoPcS4reSPhtDNPXcvqCwz4tnFOpocC/cwYDfqBhrTSxAzyqVx4GunqOg?= =?us-ascii?Q?olszW4iq0wuFlvqxltG99JPI7uwWxxNbmLlBXzOBRoSx2izpckkN+2M0iodT?= =?us-ascii?Q?KH2SOHQm76JQPACi1jscWC82k+CFe8Ll4OnoV4SW/ReoTO8zv+CsM8qsCQr8?= =?us-ascii?Q?NtB+dQmaFnRdnrhjaPtfJBXFqHM42XNsqcSwH2TKCeaq4MOQG9Now3ye4e0I?= =?us-ascii?Q?LKMojQpG2nID6JIwwSwOHXJeqTis2XKkkJTdGl4Mn2BjsJaAH2zu1EpBC/RK?= =?us-ascii?Q?b0ChnBzWPO+ghystMJeFo37FG7mumwuB2TldjIqb9Zdr/js22N/qtHpfoog7?= =?us-ascii?Q?RrJ2TJiI1wiGkLMmBREVd8UDTnXgOdWEgKmi8hqTVfXu/9r/B+0GOG0RFTzs?= =?us-ascii?Q?dsRmJ7mYi/6vTGGP7qTEu2GStH2sNmh/ut4X8TGBKmWsbCyhB4B5dIS1W6sq?= =?us-ascii?Q?7Co6fJ2WtQwZbEjRcdHK+9cnKQMYlMt7DvhGNfVLZyMR8+o07UTG7kzy3gy1?= =?us-ascii?Q?GkaGm/cuKiUeu9TC6kIVc0EkW/HzLqaRPhicvVeiYmN4miY/2uSGS8yfR4YE?= =?us-ascii?Q?kgDSYZgTvh0+uGGYCxOklKtNOzZ0SjgvOwJOzepAZmqe9yC5uilfaE656P8n?= =?us-ascii?Q?x1HMSZfKrvZ4lpTsAZ9WuJNH5EgCiq9at5UVphUjh+THpQst/G60LxfG+9lw?= =?us-ascii?Q?sv9Ccr8ZLnpioJ+yHG+wmhvq0SOfwle3qNXD3vdd8HrZrUPzTt7329V/KDeh?= =?us-ascii?Q?kC9ErCjAeecO3E5CN8CLen5QrenWo7UQn3UJdz1/J/0lvXtjdkmEV5zmNnKk?= =?us-ascii?Q?MTfRfWOxLEOUs5pYcZ01kQnkG3gE0IL4Xecs1Hh0Rdnp/IsyE53E5Y1pWRiA?= =?us-ascii?Q?qsmdzeUaA6Jufbi+PChy2+hbwqaQ8lS8h7zSC3espBc6I9RFT6j1YqDz0kfv?= =?us-ascii?Q?IEqYdFLih8U+tHSGmH+IR42XvEoaJob/nhRbpRKuNyTjid19UjmiZxhMtMpP?= =?us-ascii?Q?XP0hqyUuAQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b099d6ff-528d-4774-de92-08da4e7251bb X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2022 01:56:53.0382 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OzuiPq33XuMxX7ZNgfGvcMh+LyttYPXY/WzL74/bLmYyxzK1dYsaWL07FX/MMmXX5QSo10+5Q28LuSg15ggiGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2970 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Herakliusz, Thanks for the fix! See comments inline. > -----Original Message----- > From: Lipiec, Herakliusz > Sent: Saturday, May 28, 2022 1:31 AM > To: maxime.coquelin@redhat.com; Xia, Chenbo > Cc: Mcnamara, John ; dev@dpdk.org; Lipiec, > Herakliusz ; stable@dpdk.org > Subject: [PATCH] doc: fix readability in lib vhost prog guide I suggest to use this title: doc/prog_guide: fix readability in vhost guide >=20 > fix grammar issues and readbility in vhost library programmer guide >=20 > Fixes: 768274ebbd5e ("vhost: avoid populate guest memory") > Signed-off-by: Herakliusz Lipiec > Cc: stable@dpdk.org Should be: Fixes: 768274ebbd5e ("vhost: avoid populate guest memory") Cc: stable@dpdk.org Signed-off-by: Herakliusz Lipiec > --- > doc/guides/prog_guide/vhost_lib.rst | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/doc/guides/prog_guide/vhost_lib.rst > b/doc/guides/prog_guide/vhost_lib.rst > index f287b76ebf..70a0683d5b 100644 > --- a/doc/guides/prog_guide/vhost_lib.rst > +++ b/doc/guides/prog_guide/vhost_lib.rst > @@ -310,7 +310,7 @@ vhost-user implementation has two options: >=20 > * The vhost supported features must be exactly the same before and > after the restart. For example, if TSO is disabled and then > enabled, > - nothing will work and issues undefined might happen. > + nothing will work and undefined issues might happen. >=20 > No matter which mode is used, once a connection is established, DPDK > vhost-user will start receiving and processing vhost messages from QEMU. > @@ -341,21 +341,21 @@ Guest memory requirement >=20 > * Memory pre-allocation >=20 > - For non-async data path, guest memory pre-allocation is not a > - must. This can help save of memory. If users really want the guest > memory > - to be pre-allocated (e.g., for performance reason), we can add option > - ``-mem-prealloc`` when starting QEMU. Or, we can lock all memory at > vhost > - side which will force memory to be allocated when mmap at vhost side; > - option --mlockall in ovs-dpdk is an example in hand. > + For non-async data path guest memory pre-allocation is not a > + must but can help save memory. To do this we can we can add option Double 'we can' Also notice there's a coding style issue reported in patchwork. Thanks, Chenbo > + ``-mem-prealloc`` when starting QEMU, or we can lock all memory at > vhost > + side which will force memory to be allocated when it calls mmap > + (option --mlockall in ovs-dpdk is an example in hand). >=20 > + > For async data path, we force the VM memory to be pre-allocated at > vhost > lib when mapping the guest memory; and also we need to lock the memory > to > prevent pages being swapped out to disk. >=20 > * Memory sharing >=20 > - Make sure ``share=3Don`` QEMU option is given. vhost-user will not wor= k > with > - a QEMU version without shared memory mapping. > + Make sure ``share=3Don`` QEMU option is given. The vhost-user will not > work with > + a QEMU instance without shared memory mapping. >=20 > Vhost supported vSwitch reference > --------------------------------- > -- > 2.17.2