RE: [PATCH v6] doc: add PMD known issue

["Ye, MingjinX" <mingjinx.ye@intel.com>]

> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: 2022年12月13日 9:41
> To: Ye, MingjinX <mingjinx.ye@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; stable@dpdk.org; Zhou, YidingX
> <yidingx.zhou@intel.com>; Jie Zhou <jizh@microsoft.com>; Menon, Ranjit
> <ranjit.menon@intel.com>; Ferruh Yigit <ferruh.yigit@intel.com>; Kadam,
> Pallavi <pallavi.kadam@intel.com>
> Subject: RE: [PATCH v6] doc: add PMD known issue
> 
> 
> 
> > -----Original Message-----
> > From: Ye, MingjinX <mingjinx.ye@intel.com>
> > Sent: Monday, November 21, 2022 10:55 AM
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; stable@dpdk.org; Zhou,
> > YidingX <yidingx.zhou@intel.com>; Ye, MingjinX
> > <mingjinx.ye@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Jie Zhou
> > <jizh@microsoft.com>; Menon, Ranjit <ranjit.menon@intel.com>; Ferruh
> > Yigit <ferruh.yigit@intel.com>; Kadam, Pallavi
> > <pallavi.kadam@intel.com>
> > Subject: [PATCH v6] doc: add PMD known issue
> >
> > Add a known issue: Rx path dynamic routing is not supported for PMD.
> >
> > Fixes: de853a3bb151 ("net/ice: disable DDP package on Windows")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> > ---
> >  doc/guides/nics/ice.rst | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >
> > diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index
> > ce075e067c..60fd7834ed 100644
> > --- a/doc/guides/nics/ice.rst
> > +++ b/doc/guides/nics/ice.rst
> > @@ -395,3 +395,20 @@ file is used by both the kernel driver and the
> > DPDK PMD.
> >
> >        Windows support: The DDP package is not supported on Windows so,
> >        loading of the package is disabled on Windows.
> > +
> > +ice: Rx path is not supported after PF or DCF add vlan offload
> >
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~
> > ~
> > +
> > +If pmd does not enable Vlan offload during initialization, it will
> > +automatically select Rx paths that do not support offload. Even if
> > +Vlan offload is subsequently enabled through the API, Vlan offload
> > +will not work because the selected Rx path does not support Vlan offload.
> > +
> > +Rx path dynamic routing is not supported. When the offload features
> > +is switched, the queue needs to be reconfigured, then takes effect.
> > +It would take additional workload for the network card to deal with.
> 
> If offload features is switched, we need to re-configure the queue, this does
> not looks like a limitation.

Lihuisong<lihuisong@huawei.com>  thinks this is a limitation, and Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> agrees.


> Better to describe this from APIs calls

I will add a description.
> 
> > +
> > +When applying VLAN offload on the PF or DCF, it must be configured
> > +firstly by the startup parameters.
> 
> Better to explain what is the startup parameter precisely.

I will add a description of the startup parameters.
> 
> > +
> > --
> > 2.34.1