From: "Roberts, Lee A." <lee.roberts@hpe.com>
To: Luca Boccassi <bluca@debian.org>,
"john.griffin@intel.com" <john.griffin@intel.com>,
"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
"depak.k.jain@intel.com" <depak.k.jain@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] assign QAT cryptodev to correct NUMA node
Date: Mon, 26 Mar 2018 04:54:10 +0000 [thread overview]
Message-ID: <TU4PR8401MB054339BF93EC3A500AFF15E8E5AD0@TU4PR8401MB0543.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <1521886145.14111.84.camel@debian.org>
> -----Original Message-----
> From: Luca Boccassi [mailto:bluca@debian.org]
> Sent: Saturday, March 24, 2018 4:09 AM
> To: Roberts, Lee A. <lee.roberts@hpe.com>; john.griffin@intel.com; fiona.trahe@intel.com;
> depak.k.jain@intel.com
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] assign QAT cryptodev to correct NUMA node
>
> On Fri, 2018-03-23 at 09:59 -0600, Lee Roberts wrote:
> > rte_cryptodev_pmd_init_params should use NUMA node of the QAT device
> > for its socket_id rather than the socket_id of the initializing
> > process.
> >
> > Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
> > ---
> > drivers/crypto/qat/rte_qat_cryptodev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c
> > b/drivers/crypto/qat/rte_qat_cryptodev.c
> > index 4f8e4bf..6197820 100644
> > --- a/drivers/crypto/qat/rte_qat_cryptodev.c
> > +++ b/drivers/crypto/qat/rte_qat_cryptodev.c
> > @@ -159,7 +159,7 @@ static int crypto_qat_pci_probe(struct
> > rte_pci_driver *pci_drv __rte_unused,
> > {
> > struct rte_cryptodev_pmd_init_params init_params = {
> > .name = "",
> > - .socket_id = rte_socket_id(),
> > + .socket_id = pci_dev->device.numa_node,
> > .private_data_size = sizeof(struct qat_pmd_private),
> > .max_nb_sessions = RTE_QAT_PMD_MAX_NB_SESSIONS
> > };
>
> Hi,
>
> has this, or a variant of this, been merged into mainline?
>
> --
> Kind regards,
> Luca Boccassi
See patch https://dpdk.org/dev/patchwork/patch/35879/ for dpdk-dev.
- Lee Roberts
prev parent reply other threads:[~2018-03-26 4:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 15:59 Lee Roberts
2018-03-24 10:09 ` Luca Boccassi
2018-03-26 4:54 ` Roberts, Lee A. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TU4PR8401MB054339BF93EC3A500AFF15E8E5AD0@TU4PR8401MB0543.NAMPRD84.PROD.OUTLOOK.COM \
--to=lee.roberts@hpe.com \
--cc=bluca@debian.org \
--cc=depak.k.jain@intel.com \
--cc=fiona.trahe@intel.com \
--cc=john.griffin@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).