* [dpdk-stable] [PATCH] assign QAT cryptodev to correct NUMA node
@ 2018-03-23 15:59 Lee Roberts
2018-03-24 10:09 ` Luca Boccassi
0 siblings, 1 reply; 3+ messages in thread
From: Lee Roberts @ 2018-03-23 15:59 UTC (permalink / raw)
To: john.griffin, fiona.trahe, depak.k.jain; +Cc: stable, Lee Roberts
rte_cryptodev_pmd_init_params should use NUMA node of the QAT device
for its socket_id rather than the socket_id of the initializing process.
Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
---
drivers/crypto/qat/rte_qat_cryptodev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c
index 4f8e4bf..6197820 100644
--- a/drivers/crypto/qat/rte_qat_cryptodev.c
+++ b/drivers/crypto/qat/rte_qat_cryptodev.c
@@ -159,7 +159,7 @@ static int crypto_qat_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
{
struct rte_cryptodev_pmd_init_params init_params = {
.name = "",
- .socket_id = rte_socket_id(),
+ .socket_id = pci_dev->device.numa_node,
.private_data_size = sizeof(struct qat_pmd_private),
.max_nb_sessions = RTE_QAT_PMD_MAX_NB_SESSIONS
};
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH] assign QAT cryptodev to correct NUMA node
2018-03-23 15:59 [dpdk-stable] [PATCH] assign QAT cryptodev to correct NUMA node Lee Roberts
@ 2018-03-24 10:09 ` Luca Boccassi
2018-03-26 4:54 ` Roberts, Lee A.
0 siblings, 1 reply; 3+ messages in thread
From: Luca Boccassi @ 2018-03-24 10:09 UTC (permalink / raw)
To: Lee Roberts, john.griffin, fiona.trahe, depak.k.jain; +Cc: stable
On Fri, 2018-03-23 at 09:59 -0600, Lee Roberts wrote:
> rte_cryptodev_pmd_init_params should use NUMA node of the QAT device
> for its socket_id rather than the socket_id of the initializing
> process.
>
> Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
> ---
> drivers/crypto/qat/rte_qat_cryptodev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c
> b/drivers/crypto/qat/rte_qat_cryptodev.c
> index 4f8e4bf..6197820 100644
> --- a/drivers/crypto/qat/rte_qat_cryptodev.c
> +++ b/drivers/crypto/qat/rte_qat_cryptodev.c
> @@ -159,7 +159,7 @@ static int crypto_qat_pci_probe(struct
> rte_pci_driver *pci_drv __rte_unused,
> {
> struct rte_cryptodev_pmd_init_params init_params = {
> .name = "",
> - .socket_id = rte_socket_id(),
> + .socket_id = pci_dev->device.numa_node,
> .private_data_size = sizeof(struct qat_pmd_private),
> .max_nb_sessions = RTE_QAT_PMD_MAX_NB_SESSIONS
> };
Hi,
has this, or a variant of this, been merged into mainline?
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH] assign QAT cryptodev to correct NUMA node
2018-03-24 10:09 ` Luca Boccassi
@ 2018-03-26 4:54 ` Roberts, Lee A.
0 siblings, 0 replies; 3+ messages in thread
From: Roberts, Lee A. @ 2018-03-26 4:54 UTC (permalink / raw)
To: Luca Boccassi, john.griffin, fiona.trahe, depak.k.jain; +Cc: stable
> -----Original Message-----
> From: Luca Boccassi [mailto:bluca@debian.org]
> Sent: Saturday, March 24, 2018 4:09 AM
> To: Roberts, Lee A. <lee.roberts@hpe.com>; john.griffin@intel.com; fiona.trahe@intel.com;
> depak.k.jain@intel.com
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] assign QAT cryptodev to correct NUMA node
>
> On Fri, 2018-03-23 at 09:59 -0600, Lee Roberts wrote:
> > rte_cryptodev_pmd_init_params should use NUMA node of the QAT device
> > for its socket_id rather than the socket_id of the initializing
> > process.
> >
> > Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
> > ---
> > drivers/crypto/qat/rte_qat_cryptodev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c
> > b/drivers/crypto/qat/rte_qat_cryptodev.c
> > index 4f8e4bf..6197820 100644
> > --- a/drivers/crypto/qat/rte_qat_cryptodev.c
> > +++ b/drivers/crypto/qat/rte_qat_cryptodev.c
> > @@ -159,7 +159,7 @@ static int crypto_qat_pci_probe(struct
> > rte_pci_driver *pci_drv __rte_unused,
> > {
> > struct rte_cryptodev_pmd_init_params init_params = {
> > .name = "",
> > - .socket_id = rte_socket_id(),
> > + .socket_id = pci_dev->device.numa_node,
> > .private_data_size = sizeof(struct qat_pmd_private),
> > .max_nb_sessions = RTE_QAT_PMD_MAX_NB_SESSIONS
> > };
>
> Hi,
>
> has this, or a variant of this, been merged into mainline?
>
> --
> Kind regards,
> Luca Boccassi
See patch https://dpdk.org/dev/patchwork/patch/35879/ for dpdk-dev.
- Lee Roberts
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-26 4:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-23 15:59 [dpdk-stable] [PATCH] assign QAT cryptodev to correct NUMA node Lee Roberts
2018-03-24 10:09 ` Luca Boccassi
2018-03-26 4:54 ` Roberts, Lee A.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).