patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] examples/fips_validation: fix null pointer dereferences
@ 2019-09-25  6:31 Chaitanya Babu Talluri
  2019-09-30 20:21 ` [dpdk-stable] [dpdk-dev] " Akhil Goyal
  0 siblings, 1 reply; 2+ messages in thread
From: Chaitanya Babu Talluri @ 2019-09-25  6:31 UTC (permalink / raw)
  To: dev
  Cc: reshma.pattan, jananeex.m.parthasarathy, marko.kovacevic,
	Chaitanya Babu Talluri, stable

One issue caught by Coverity 343408
*deref_parm: Directly dereferencing parameter val->val.

In writeback_tdes_hex_str(), tmp_val is initialised to null.
tmp_val.val is updated only if keys are found.
If keys are not found,it doesn't fails but continues
to invoke writeback_hex_str(),where val->val is accessed
without null check.

The fix is to return the error,
if keys are not found in writeback_tdes_hex_str().

Coverity issue: 343408
Fixes: 527cbf3d5e ("examples/fips_validation: support TDES parsing")
Cc: stable@dpdk.org

Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
---
 examples/fips_validation/fips_validation_tdes.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/examples/fips_validation/fips_validation_tdes.c b/examples/fips_validation/fips_validation_tdes.c
index 15ee434e1..2b262c9a0 100644
--- a/examples/fips_validation/fips_validation_tdes.c
+++ b/examples/fips_validation/fips_validation_tdes.c
@@ -212,6 +212,8 @@ writeback_tdes_hex_str(const char *key, char *dst, struct fips_val *val)
 		tmp_val.val = val->val + 8;
 	else if (strstr(key, KEY3_STR))
 		tmp_val.val = val->val + 16;
+	else
+		return -EINVAL;
 
 	return writeback_hex_str(key, dst, &tmp_val);
 }
-- 
2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/fips_validation: fix null pointer dereferences
  2019-09-25  6:31 [dpdk-stable] [PATCH] examples/fips_validation: fix null pointer dereferences Chaitanya Babu Talluri
@ 2019-09-30 20:21 ` " Akhil Goyal
  0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2019-09-30 20:21 UTC (permalink / raw)
  To: Chaitanya Babu Talluri, dev
  Cc: reshma.pattan, jananeex.m.parthasarathy, marko.kovacevic, stable



> 
> One issue caught by Coverity 343408
> *deref_parm: Directly dereferencing parameter val->val.
> 
> In writeback_tdes_hex_str(), tmp_val is initialised to null.
> tmp_val.val is updated only if keys are found.
> If keys are not found,it doesn't fails but continues
> to invoke writeback_hex_str(),where val->val is accessed
> without null check.
> 
> The fix is to return the error,
> if keys are not found in writeback_tdes_hex_str().
> 
> Coverity issue: 343408
> Fixes: 527cbf3d5e ("examples/fips_validation: support TDES parsing")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-25  6:31 [dpdk-stable] [PATCH] examples/fips_validation: fix null pointer dereferences Chaitanya Babu Talluri
2019-09-30 20:21 ` [dpdk-stable] [dpdk-dev] " Akhil Goyal

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox