From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 373D1A2EFC for ; Mon, 16 Sep 2019 11:48:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 066DD1C02C; Mon, 16 Sep 2019 11:48:52 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40047.outbound.protection.outlook.com [40.107.4.47]) by dpdk.org (Postfix) with ESMTP id F1AE81C02C for ; Mon, 16 Sep 2019 11:48:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XxebGcgd93E3U330fXxmrm8w6aomZbWzQt1H4DJ2EfbrUDI3Nm5yWNFnf84hZZKhqqDk2kSSVjZ4erbckBgj2h3OwT4C899t9GUt+SwocT27pQF3ZggSkM+8sr/vd0lIv0QOGHO6NRBkUJB0I2sCrlshOO0GEG7jMOOuQ8Z3kJnAk17krcNCSravRffHdoZNGCwVAedE+gVKwppVET4xJz9YmrgqPOSO9XOzjHh+1JUBAJMNhI18X6JhtkVAuhtZdqdkRpEGMkFkbFpUI8u9doS4rJx6igaC0nvvsb5TD7eYrUNKAp6go1RhfsIP4MY3JF0TrMIgiN2RmXvCCrMcFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PnRvmRJt1onV9jlFaFyiowP6hRAxHEBYnNwCzjI1VZU=; b=EcJCDvwUZNevbIIgVHmj+r7HicukezX8/O9lIHs1o820A9K/rdJUKFIcxqryr9uZyN8ogbXgLfmbPivjUJDT/eHi3ts1KSMaPL0DZCgktgK8JD2V3QKHFpo5ssp6ftMLewCIntHlE0ZCVaab7cNTivLYVAMUrM2ViNbosL3KV0Zf/rWsuIRWnv8RjHmwyMNgYUqgaipaOuIwVDhuE7sqZKp8EDcNAANYuL1V/7qNq28KkBHx7KwcybmB/5BibqFtr6TV6Akiz8CENc8uYa4p+0m8MclfZWsuuMlU5J0+imXrwwuBrUzTI9VX2Kb1inSPr1E615mSHFuYbJN54VjH4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PnRvmRJt1onV9jlFaFyiowP6hRAxHEBYnNwCzjI1VZU=; b=o1In+9rc26BVaEjArjRB1ANwbg8cxvV/8J1Ro0lbV/RGVtAHkBth5YtConM+A4KcRDRmwNBGgERY2WBZTZN2ekP59yVoQPlAF2re6QKNe0ccVDluDcgEkKMawW1WUHF4Xq2xREW0flS1W9W1DoqMiC7felEuA0VPj6sXDaoB85s= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6656.eurprd04.prod.outlook.com (20.179.235.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.26; Mon, 16 Sep 2019 09:48:50 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::7092:d719:df0b:2b70]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::7092:d719:df0b:2b70%7]) with mapi id 15.20.2263.023; Mon, 16 Sep 2019 09:48:50 +0000 From: Akhil Goyal To: "michaelsh@marvell.com" CC: "marko.kovacevic@intel.com" , "stable@dpdk.org" , "lironh@marvell.com" Thread-Topic: [PATCH] examples/fips_validation: fix bad return value Thread-Index: AQHVbHOaUDHZ8/ZmikKtWbHQotU/xqcuDp5A Date: Mon, 16 Sep 2019 09:48:48 +0000 Message-ID: References: <20190916100442.12140-1-michaelsh@marvell.com> In-Reply-To: <20190916100442.12140-1-michaelsh@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.0.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e98f1a9a-6e00-4ab8-518c-08d73a8b139d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VE1PR04MB6656; x-ms-traffictypediagnostic: VE1PR04MB6656: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:98; x-forefront-prvs: 0162ACCC24 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(189003)(199004)(305945005)(54906003)(71190400001)(6306002)(55016002)(6916009)(316002)(5640700003)(8936002)(81156014)(476003)(229853002)(33656002)(9686003)(53936002)(64756008)(76116006)(2351001)(6436002)(3846002)(6116002)(446003)(11346002)(52536014)(186003)(7696005)(99286004)(66556008)(6506007)(66446008)(7736002)(66476007)(74316002)(26005)(76176011)(102836004)(66946007)(86362001)(66066001)(81166006)(1730700003)(6246003)(8676002)(2501003)(14454004)(25786009)(44832011)(966005)(486006)(478600001)(4326008)(71200400001)(5660300002)(256004)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6656; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 8FL1LFo5Lmhf7Jui86adMbIwN/+abOIG9qD/cI/XPI8QxFpR8NfxDRJiigCYlTnI9vA0sdDNlcoVIXYq6+ztk2i6tEl+kdrdKftD6oA5u9TI2DXlNjIaJD8xvz8AgON0Lpnd3s6IwEFGsL3b0Ax6NJX2L8pDvwSENP9XO+i4u8KOIrl+DxoclL/EkNBqZ8C8vWe4f/5ACTNnjJD1LiyQlGGvNOwXA74eP4FvKwZTR7GColyeUKNJq7t+W3tsHTTGDrm8219zyaz5BagUju2+g1V66X1t7peyTbNyWgIdtb+h0e6lL4WzMGw506iCqEY5IRSkRl7ieubDc4Iq8ISm9jSTvl0iOTbQhFREOGUNz2/83sLP2IZYKtuYtNXJwmrRTS+iT7lMSgzcbya8aKSivNuOpJLqLIcb6s0CNDr5cSU= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e98f1a9a-6e00-4ab8-518c-08d73a8b139d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2019 09:48:49.1301 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OmnE3bM/do80IurD/0L+IJO/CMqgGiqTLS+cX/5QgBRnqTKqZGzzqXklm/BOKqmRxL17dGt8fxml/rVWOM7Nxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6656 Subject: Re: [dpdk-stable] [PATCH] examples/fips_validation: fix bad return value X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" >=20 > From: Michael Shamis >=20 > Returning correct error value by fips_test_parse_header() > allows graceful exit of fips application. >=20 Please add a fixes line here about which commit it is fixing. Please take http://patches.dpdk.org/patch/59101/ as reference. > Signed-off-by: Michael Shamis > --- > examples/fips_validation/fips_validation.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/examples/fips_validation/fips_validation.c > b/examples/fips_validation/fips_validation.c > index 80fd482a1..eaa7349d6 100644 > --- a/examples/fips_validation/fips_validation.c > +++ b/examples/fips_validation/fips_validation.c > @@ -125,13 +125,13 @@ fips_test_parse_header(void) > info.algo =3D FIPS_TEST_ALGO_AES_CMAC; > ret =3D parse_test_cmac_init(); > if (ret < 0) > - return 0; > + return ret; > } else if (strstr(info.vec[i], "CCM")) { > algo_parsed =3D 1; > info.algo =3D FIPS_TEST_ALGO_AES_CCM; > ret =3D parse_test_ccm_init(); > if (ret < 0) > - return 0; > + return ret; > } else if (strstr(info.vec[i], "HMAC")) { > algo_parsed =3D 1; > info.algo =3D FIPS_TEST_ALGO_HMAC; > @@ -143,7 +143,7 @@ fips_test_parse_header(void) > info.algo =3D FIPS_TEST_ALGO_TDES; > ret =3D parse_test_tdes_init(); > if (ret < 0) > - return 0; > + return ret; > } else if (strstr(info.vec[i], "SHA-")) { > if (info.algo !=3D FIPS_TEST_ALGO_HMAC) { > algo_parsed =3D 1; > -- > 2.23.0