patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] crypto/ccp: fix queue alignment
@ 2020-02-07 14:06 David Marchand
  2020-02-12 13:14 ` Akhil Goyal
  0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2020-02-07 14:06 UTC (permalink / raw)
  To: dev; +Cc: akhil.goyal, stable, Ravi Kumar

Caught by compiling with -fno-common.
A ____cacheline_aligned symbol can be found in the crypto/ccp driver
object files.

Looking at this driver source, the ____cacheline_aligned (kernel?)
alignment macro is undefined.
The compiler treats this as a symbol definition and generates a global
symbol.

Fixes: ef4b04f87fa6 ("crypto/ccp: support device init")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/crypto/ccp/ccp_dev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/ccp/ccp_dev.h b/drivers/crypto/ccp/ccp_dev.h
index f4ad9eafd..37e04218c 100644
--- a/drivers/crypto/ccp/ccp_dev.h
+++ b/drivers/crypto/ccp/ccp_dev.h
@@ -220,7 +220,7 @@ struct ccp_queue {
 	/**< lsb assigned for sha ctx */
 	uint32_t sb_hmac;
 	/**< lsb assigned for hmac ctx */
-} ____cacheline_aligned;
+} __rte_cache_aligned;
 
 /**
  * A structure describing a CCP device.
-- 
2.23.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [PATCH] crypto/ccp: fix queue alignment
  2020-02-07 14:06 [dpdk-stable] [PATCH] crypto/ccp: fix queue alignment David Marchand
@ 2020-02-12 13:14 ` Akhil Goyal
  0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2020-02-12 13:14 UTC (permalink / raw)
  To: David Marchand, dev; +Cc: stable, Ravi Kumar

> 
> Caught by compiling with -fno-common.
> A ____cacheline_aligned symbol can be found in the crypto/ccp driver
> object files.
> 
> Looking at this driver source, the ____cacheline_aligned (kernel?)
> alignment macro is undefined.
> The compiler treats this as a symbol definition and generates a global
> symbol.
> 
> Fixes: ef4b04f87fa6 ("crypto/ccp: support device init")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-07 14:06 [dpdk-stable] [PATCH] crypto/ccp: fix queue alignment David Marchand
2020-02-12 13:14 ` Akhil Goyal

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox