patches for DPDK stable branches
 help / color / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "jerinj@marvell.com" <jerinj@marvell.com>,
	"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: nd <nd@arm.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2
Date: Thu, 12 Sep 2019 14:42:41 +0000
Message-ID: <VE1PR08MB51491E714E9BE01F4E6D712098B00@VE1PR08MB5149.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <BYAPR18MB242413A71E73CCD56D5C13C4C8B10@BYAPR18MB2424.namprd18.prod.outlook.com>

<snip>

> > Subject: [EXT] [PATCH v2 1/3] test/rcu: fix the compiling error for
> > armv8.2
> >
> > With "-march=armv8.2-a" specified, a compiling error generated:
> > app/test/test_rcu_qsbr.c:234:10: error: comparison of integer
> > expressions of different signedness: ‘unsigned int’ and ‘int’
> > [-Werror=sign-compare]
> >
> > Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Steve Capper <steve.capper@arm.com>
> 
> 
> Reviewed-by: Jerin Jacob <jerinj@marvell.com>
This should be fixed already due to commit 104dbec2081.
Gavin, can you please verify? If yes, we can skip this patch.

> 
> 
> > ---
> >  app/test/test_rcu_qsbr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index
> > 1d273e3..b008c9d 100644
> > --- a/app/test/test_rcu_qsbr.c
> > +++ b/app/test/test_rcu_qsbr.c
> > @@ -231,7 +231,7 @@ test_rcu_qsbr_thread_unregister(void)
> >  		/* Update quiescent state counter */
> >  		for (i = 0; i < num_threads[j]; i++) {
> >  			/* Skip one update */
> > -			if (i == (RTE_MAX_LCORE - 10))
> > +			if (i == (unsigned int)(RTE_MAX_LCORE - 10))
> >  				continue;
> >  			rte_rcu_qsbr_quiescent(t[0],
> >  				(j == 2) ? (RTE_MAX_LCORE - 1) : i);
> > --
> > 2.7.4


  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 10:38 Jerin Jacob Kollanukkaran
2019-09-12 14:42 ` Honnappa Nagarahalli [this message]
2019-09-13 15:28   ` Gavin Hu (Arm Technology China)
2019-09-13 15:36     ` Honnappa Nagarahalli
     [not found] <1564616902-13861-1-git-send-email-gavin.hu@arm.com>
2019-07-31 23:32 ` [dpdk-stable] [PATCH 1/2] " Gavin Hu
2019-07-31 23:48   ` [dpdk-stable] [PATCH v2 1/3] " Gavin Hu

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR08MB51491E714E9BE01F4E6D712098B00@VE1PR08MB5149.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=Gavin.Hu@arm.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    --cc=nd@arm.com \
    --cc=pbhagavatula@marvell.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox