From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Luca Boccassi <bluca@debian.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-stable] missing ring memory barrier in 17.11
Date: Tue, 1 Oct 2019 14:05:11 +0000 [thread overview]
Message-ID: <VE1PR08MB5149568F3E0100EA33D5D39E989D0@VE1PR08MB5149.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <c77d967af8a5c9c024581aa635c70807d2825b8c.camel@debian.org>
China team is on holiday. Yes, we should apply this patch to 17.11
> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Tuesday, October 1, 2019 3:48 AM
> To: thomas@monjalon.net; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>
> Cc: stable@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Nipun.gupta@nxp.com; Konstantin
> Ananyev <konstantin.ananyev@intel.com>
> Subject: Re: missing ring memory barrier in 17.11
>
> On Tue, 2019-10-01 at 09:41 +0200, Thomas Monjalon wrote:
> > Hi Luca, Gavin,
> >
> > It seems the fix 85cffb2eccd9 ("ring: enforce reading tail before
> > slots")
> > should be backported in 17.11.
> >
> > This patch is missing because the root cause is wrongly identified.
> > It is referenced as
> > Fixes: c9fb3c62896f ("ring: move code in a new header file") in
> > 18.02, but in reality it is from 17.05:
> > Fixes: 0dfc98c507b1 ("ring: separate out head index
> > manipulation")
> >
> > Do you agree?
>
> Hi,
>
> Makes sense to me, and it applies cleanly (after accounting for the source file
> name change). I'll queue it up for 17.11.8.
>
> --
> Kind regards,
> Luca Boccassi
next prev parent reply other threads:[~2019-10-01 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 7:41 Thomas Monjalon
2019-10-01 8:48 ` Luca Boccassi
2019-10-01 14:05 ` Honnappa Nagarahalli [this message]
2019-10-08 6:41 ` Gavin Hu (Arm Technology China)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB5149568F3E0100EA33D5D39E989D0@VE1PR08MB5149.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=bluca@debian.org \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=nipun.gupta@nxp.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).